All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Justin Stitt <justinstitt@google.com>
Cc: linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	geert@linux-m68k.org, gregkh@linuxfoundation.org,
	workflows@vger.kernel.org, mario.limonciello@amd.com
Subject: Re: [PATCH v2 0/2] get_maintainer: add patch-only keyword matching
Date: Wed, 27 Sep 2023 23:09:31 -0700	[thread overview]
Message-ID: <137a309b313cc8a295f3affc704f0da049f233aa.camel@perches.com> (raw)
In-Reply-To: <CAFhGd8rtnvipRVAKRQAEcyGqCknVmx+bd2NMT7mCuTZjhrqULA@mail.gmail.com>

On Thu, 2023-09-28 at 14:31 +0900, Justin Stitt wrote:
> On Thu, Sep 28, 2023 at 2:01 PM Joe Perches <joe@perches.com> wrote:
> > 
> > On Thu, 2023-09-28 at 04:23 +0000, Justin Stitt wrote:
> > > Changes in v2:
> > > - remove formatting pass (thanks Joe) (but seriously the formatting is
> > >   bad, is there opportunity to get a formatting pass in here at some
> > >   point?)
> > 
> > Why?  What is it that makes you believe the formatting is bad?
> > 
> 
> Investigating further, it looked especially bad in my editor. There is
> a mixture of
> tabs and spaces and my vim tabstop is set to 4 for pl files. Setting this to
> 8 is a whole lot better. But I still see some weird spacing
> 

Yes, it's a bit odd indentation.
It's emacs default perl format.
4 space indent with 8 space tabs, maximal tab fill.


  reply	other threads:[~2023-09-28  6:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-28  4:23 [PATCH v2 0/2] get_maintainer: add patch-only keyword matching Justin Stitt
2023-09-28  4:23 ` [PATCH v2 1/2] get_maintainer: add patch-only keyword-matching Justin Stitt
2023-09-28  4:46   ` Joe Perches
2023-09-28  5:03     ` Justin Stitt
2023-09-28  5:08       ` Joe Perches
2023-09-28 19:12         ` Konstantin Ryabitsev
2023-09-28  4:23 ` [PATCH v2 2/2] MAINTAINERS: migrate some K to D Justin Stitt
2023-09-28  4:49   ` Joe Perches
2023-09-28  5:01 ` [PATCH v2 0/2] get_maintainer: add patch-only keyword matching Joe Perches
2023-09-28  5:31   ` Justin Stitt
2023-09-28  6:09     ` Joe Perches [this message]
2023-09-28 15:52       ` Nick Desaulniers
2023-09-29  2:07         ` Justin Stitt
2023-09-29  2:50           ` Joe Perches
2023-09-29  3:07             ` Justin Stitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=137a309b313cc8a295f3affc704f0da049f233aa.camel@perches.com \
    --to=joe@perches.com \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=justinstitt@google.com \
    --cc=keescook@chromium.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.