From: Tim Chen <tim.c.chen@linux.intel.com> To: Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@linux-foundation.org> Cc: Andrea Arcangeli <aarcange@redhat.com>, Alex Shi <alex.shi@linaro.org>, Andi Kleen <andi@firstfloor.org>, Michel Lespinasse <walken@google.com>, Davidlohr Bueso <davidlohr.bueso@hp.com>, Matthew R Wilcox <matthew.r.wilcox@intel.com>, Dave Hansen <dave.hansen@intel.com>, Peter Zijlstra <a.p.zijlstra@chello.nl>, Rik van Riel <riel@redhat.com>, Peter Hurley <peter@hurleysoftware.com>, Tim Chen <tim.c.chen@linux.intel.com>, linux-kernel@vger.kernel.org, linux-mm <linux-mm@kvack.org> Subject: [PATCH v5 2/6] rwsem: remove 'out' label in do_wake Date: Tue, 24 Sep 2013 15:22:30 -0700 [thread overview] Message-ID: <1380061350.3467.51.camel@schen9-DESK> (raw) In-Reply-To: <cover.1380057198.git.tim.c.chen@linux.intel.com> That make code simple and more readable. Signed-off-by: Alex Shi <alex.shi@intel.com> --- lib/rwsem.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/rwsem.c b/lib/rwsem.c index 19c5fa9..42f1b1a 100644 --- a/lib/rwsem.c +++ b/lib/rwsem.c @@ -75,7 +75,7 @@ __rwsem_do_wake(struct rw_semaphore *sem, enum rwsem_wake_type wake_type) * will block as they will notice the queued writer. */ wake_up_process(waiter->task); - goto out; + return sem; } /* Writers might steal the lock before we grant it to the next reader. @@ -91,7 +91,7 @@ __rwsem_do_wake(struct rw_semaphore *sem, enum rwsem_wake_type wake_type) /* A writer stole the lock. Undo our reader grant. */ if (rwsem_atomic_update(-adjustment, sem) & RWSEM_ACTIVE_MASK) - goto out; + return sem; /* Last active locker left. Retry waking readers. */ goto try_reader_grant; } @@ -136,7 +136,6 @@ __rwsem_do_wake(struct rw_semaphore *sem, enum rwsem_wake_type wake_type) sem->wait_list.next = next; next->prev = &sem->wait_list; - out: return sem; } -- 1.7.4.4
WARNING: multiple messages have this Message-ID (diff)
From: Tim Chen <tim.c.chen@linux.intel.com> To: Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@linux-foundation.org> Cc: Andrea Arcangeli <aarcange@redhat.com>, Alex Shi <alex.shi@linaro.org>, Andi Kleen <andi@firstfloor.org>, Michel Lespinasse <walken@google.com>, Davidlohr Bueso <davidlohr.bueso@hp.com>, Matthew R Wilcox <matthew.r.wilcox@intel.com>, Dave Hansen <dave.hansen@intel.com>, Peter Zijlstra <a.p.zijlstra@chello.nl>, Rik van Riel <riel@redhat.com>, Peter Hurley <peter@hurleysoftware.com>, Tim Chen <tim.c.chen@linux.intel.com>, linux-kernel@vger.kernel.org, linux-mm <linux-mm@kvack.org> Subject: [PATCH v5 2/6] rwsem: remove 'out' label in do_wake Date: Tue, 24 Sep 2013 15:22:30 -0700 [thread overview] Message-ID: <1380061350.3467.51.camel@schen9-DESK> (raw) In-Reply-To: <cover.1380057198.git.tim.c.chen@linux.intel.com> That make code simple and more readable. Signed-off-by: Alex Shi <alex.shi@intel.com> --- lib/rwsem.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/rwsem.c b/lib/rwsem.c index 19c5fa9..42f1b1a 100644 --- a/lib/rwsem.c +++ b/lib/rwsem.c @@ -75,7 +75,7 @@ __rwsem_do_wake(struct rw_semaphore *sem, enum rwsem_wake_type wake_type) * will block as they will notice the queued writer. */ wake_up_process(waiter->task); - goto out; + return sem; } /* Writers might steal the lock before we grant it to the next reader. @@ -91,7 +91,7 @@ __rwsem_do_wake(struct rw_semaphore *sem, enum rwsem_wake_type wake_type) /* A writer stole the lock. Undo our reader grant. */ if (rwsem_atomic_update(-adjustment, sem) & RWSEM_ACTIVE_MASK) - goto out; + return sem; /* Last active locker left. Retry waking readers. */ goto try_reader_grant; } @@ -136,7 +136,6 @@ __rwsem_do_wake(struct rw_semaphore *sem, enum rwsem_wake_type wake_type) sem->wait_list.next = next; next->prev = &sem->wait_list; - out: return sem; } -- 1.7.4.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-09-24 22:22 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <cover.1380057198.git.tim.c.chen@linux.intel.com> 2013-09-24 22:22 ` [PATCH v5 0/6] rwsem: performance optimizations Tim Chen 2013-09-24 22:22 ` Tim Chen 2013-09-25 3:32 ` Davidlohr Bueso 2013-09-25 3:32 ` Davidlohr Bueso 2013-09-24 22:22 ` [PATCH v5 1/6] rwsem: check the lock before cpmxchg in down_write_trylock Tim Chen 2013-09-24 22:22 ` Tim Chen 2013-09-24 23:22 ` Jason Low 2013-09-24 23:22 ` Jason Low 2013-09-24 23:30 ` Tim Chen 2013-09-24 23:30 ` Tim Chen 2013-09-24 22:22 ` Tim Chen [this message] 2013-09-24 22:22 ` [PATCH v5 2/6] rwsem: remove 'out' label in do_wake Tim Chen 2013-09-24 22:22 ` [PATCH v5 3/6] rwsem: remove try_reader_grant label do_wake Tim Chen 2013-09-24 22:22 ` Tim Chen 2013-09-24 22:22 ` [PATCH v5 4/6] rwsem/wake: check lock before do atomic update Tim Chen 2013-09-24 22:22 ` Tim Chen 2013-09-24 22:22 ` [PATCH v5 5/6] MCS Lock: Restructure the MCS lock defines and locking code into its own file Tim Chen 2013-09-24 22:22 ` Tim Chen 2013-09-25 5:55 ` Peter Zijlstra 2013-09-25 5:55 ` Peter Zijlstra 2013-09-25 15:58 ` Tim Chen 2013-09-25 15:58 ` Tim Chen 2013-09-24 22:22 ` [PATCH v5 6/6] rwsem: do optimistic spinning for writer lock acquisition Tim Chen 2013-09-24 22:22 ` Tim Chen 2013-09-25 6:52 ` Ingo Molnar 2013-09-25 6:52 ` Ingo Molnar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1380061350.3467.51.camel@schen9-DESK \ --to=tim.c.chen@linux.intel.com \ --cc=a.p.zijlstra@chello.nl \ --cc=aarcange@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=alex.shi@linaro.org \ --cc=andi@firstfloor.org \ --cc=dave.hansen@intel.com \ --cc=davidlohr.bueso@hp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=matthew.r.wilcox@intel.com \ --cc=mingo@elte.hu \ --cc=peter@hurleysoftware.com \ --cc=riel@redhat.com \ --cc=walken@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.