* [PATCH v2 1/2] rt2x00: rt2800lib: remove TXMIXER_GAIN entries from the extended EEPROM map
@ 2013-10-03 12:07 Gabor Juhos
2013-10-03 12:07 ` [PATCH v2 2/2] rt2x00: rt2800lib: remove TXPOWER_DELTA entry from " Gabor Juhos
2013-10-04 14:06 ` [rt2x00-users] [PATCH v2 1/2] rt2x00: rt2800lib: remove TXMIXER_GAIN entries from the " Stanislaw Gruszka
0 siblings, 2 replies; 4+ messages in thread
From: Gabor Juhos @ 2013-10-03 12:07 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless, users, Paul Menzel, Gabor Juhos
The comments are indicating that the TXMIXER_GAIN_BG
and TXMIXED_GAIN_A entries are overlapping with the
RSSI_BG2 and RSSI_A2 entries in the extended EEPROM
map. This is not correct, because the upper byte of
the RSSI_BG2 and RSSI_A2 entries are reserved. There
are no TX mixer gain values are stored at all in the
extended EEPROM.
Remove the initialization of these entries from the
extended EEPROM map to reflect this.
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
Changes since v1:
- improve commit message and fix a typo
- add Paul's Acked-by tag
---
drivers/net/wireless/rt2x00/rt2800lib.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
index c706ddc..c979bb7 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -280,10 +280,8 @@ static const unsigned int rt2800_eeprom_map_ext[EEPROM_WORD_COUNT] = {
[EEPROM_RSSI_BG] = 0x0028,
[EEPROM_TXPOWER_DELTA] = 0x0028, /* Overlaps with RSSI_BG */
[EEPROM_RSSI_BG2] = 0x0029,
- [EEPROM_TXMIXER_GAIN_BG] = 0x0029, /* Overlaps with RSSI_BG2 */
[EEPROM_RSSI_A] = 0x002a,
[EEPROM_RSSI_A2] = 0x002b,
- [EEPROM_TXMIXER_GAIN_A] = 0x002b, /* Overlaps with RSSI_A2 */
[EEPROM_TXPOWER_BG1] = 0x0030,
[EEPROM_TXPOWER_BG2] = 0x0037,
[EEPROM_EXT_TXPOWER_BG3] = 0x003e,
--
1.7.10
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 2/2] rt2x00: rt2800lib: remove TXPOWER_DELTA entry from extended EEPROM map
2013-10-03 12:07 [PATCH v2 1/2] rt2x00: rt2800lib: remove TXMIXER_GAIN entries from the extended EEPROM map Gabor Juhos
@ 2013-10-03 12:07 ` Gabor Juhos
2013-10-04 14:07 ` [rt2x00-users] " Stanislaw Gruszka
2013-10-04 14:06 ` [rt2x00-users] [PATCH v2 1/2] rt2x00: rt2800lib: remove TXMIXER_GAIN entries from the " Stanislaw Gruszka
1 sibling, 1 reply; 4+ messages in thread
From: Gabor Juhos @ 2013-10-03 12:07 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless, users, Paul Menzel, Gabor Juhos
The TXPOWER_DELTA field of the regular EEPROM
stores the TX power compensation value for HT40.
The extended EEPROM has no such field, it stores
separate TX power values for HT20 and for HT40.
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
Changes since v1:
- add Paul's Acked-by tag
---
drivers/net/wireless/rt2x00/rt2800lib.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
index c979bb7..315f4af 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -278,7 +278,6 @@ static const unsigned int rt2800_eeprom_map_ext[EEPROM_WORD_COUNT] = {
[EEPROM_LNA] = 0x0026,
[EEPROM_EXT_LNA2] = 0x0027,
[EEPROM_RSSI_BG] = 0x0028,
- [EEPROM_TXPOWER_DELTA] = 0x0028, /* Overlaps with RSSI_BG */
[EEPROM_RSSI_BG2] = 0x0029,
[EEPROM_RSSI_A] = 0x002a,
[EEPROM_RSSI_A2] = 0x002b,
--
1.7.10
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [rt2x00-users] [PATCH v2 1/2] rt2x00: rt2800lib: remove TXMIXER_GAIN entries from the extended EEPROM map
2013-10-03 12:07 [PATCH v2 1/2] rt2x00: rt2800lib: remove TXMIXER_GAIN entries from the extended EEPROM map Gabor Juhos
2013-10-03 12:07 ` [PATCH v2 2/2] rt2x00: rt2800lib: remove TXPOWER_DELTA entry from " Gabor Juhos
@ 2013-10-04 14:06 ` Stanislaw Gruszka
1 sibling, 0 replies; 4+ messages in thread
From: Stanislaw Gruszka @ 2013-10-04 14:06 UTC (permalink / raw)
To: Gabor Juhos; +Cc: John Linville, linux-wireless, users, Paul Menzel
On Thu, Oct 03, 2013 at 02:07:01PM +0200, Gabor Juhos wrote:
> The comments are indicating that the TXMIXER_GAIN_BG
> and TXMIXED_GAIN_A entries are overlapping with the
> RSSI_BG2 and RSSI_A2 entries in the extended EEPROM
> map. This is not correct, because the upper byte of
> the RSSI_BG2 and RSSI_A2 entries are reserved. There
> are no TX mixer gain values are stored at all in the
> extended EEPROM.
>
> Remove the initialization of these entries from the
> extended EEPROM map to reflect this.
>
> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
> Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [rt2x00-users] [PATCH v2 2/2] rt2x00: rt2800lib: remove TXPOWER_DELTA entry from extended EEPROM map
2013-10-03 12:07 ` [PATCH v2 2/2] rt2x00: rt2800lib: remove TXPOWER_DELTA entry from " Gabor Juhos
@ 2013-10-04 14:07 ` Stanislaw Gruszka
0 siblings, 0 replies; 4+ messages in thread
From: Stanislaw Gruszka @ 2013-10-04 14:07 UTC (permalink / raw)
To: Gabor Juhos; +Cc: John Linville, linux-wireless, users, Paul Menzel
On Thu, Oct 03, 2013 at 02:07:02PM +0200, Gabor Juhos wrote:
> The TXPOWER_DELTA field of the regular EEPROM
> stores the TX power compensation value for HT40.
> The extended EEPROM has no such field, it stores
> separate TX power values for HT20 and for HT40.
>
> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
> Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-04 14:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-03 12:07 [PATCH v2 1/2] rt2x00: rt2800lib: remove TXMIXER_GAIN entries from the extended EEPROM map Gabor Juhos
2013-10-03 12:07 ` [PATCH v2 2/2] rt2x00: rt2800lib: remove TXPOWER_DELTA entry from " Gabor Juhos
2013-10-04 14:07 ` [rt2x00-users] " Stanislaw Gruszka
2013-10-04 14:06 ` [rt2x00-users] [PATCH v2 1/2] rt2x00: rt2800lib: remove TXMIXER_GAIN entries from the " Stanislaw Gruszka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.