All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] media: rcar_vin: Add preliminary r8a7790 support
@ 2013-10-04 14:20 ` Valentine Barshak
  0 siblings, 0 replies; 4+ messages in thread
From: Valentine Barshak @ 2013-10-04 14:20 UTC (permalink / raw)
  To: linux-media, Hans Verkuil
  Cc: Simon Horman, Magnus Damm, Laurent Pinchart,
	Mauro Carvalho Chehab, Guennadi Liakhovetski, linux-sh

Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
---
 drivers/media/platform/soc_camera/rcar_vin.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
index d02a7e0..b21f777 100644
--- a/drivers/media/platform/soc_camera/rcar_vin.c
+++ b/drivers/media/platform/soc_camera/rcar_vin.c
@@ -105,6 +105,7 @@
 #define VIN_MAX_HEIGHT		2048
 
 enum chip_id {
+	RCAR_H2,
 	RCAR_H1,
 	RCAR_M1,
 	RCAR_E1,
@@ -300,7 +301,8 @@ static int rcar_vin_setup(struct rcar_vin_priv *priv)
 		dmr = 0;
 		break;
 	case V4L2_PIX_FMT_RGB32:
-		if (priv->chip = RCAR_H1 || priv->chip = RCAR_E1) {
+		if (priv->chip = RCAR_H2 || priv->chip = RCAR_H1 ||
+		    priv->chip = RCAR_E1) {
 			dmr = VNDMR_EXRGB;
 			break;
 		}
@@ -1381,6 +1383,7 @@ static struct soc_camera_host_ops rcar_vin_host_ops = {
 };
 
 static struct platform_device_id rcar_vin_id_table[] = {
+	{ "r8a7790-vin",  RCAR_H2 },
 	{ "r8a7779-vin",  RCAR_H1 },
 	{ "r8a7778-vin",  RCAR_M1 },
 	{ "uPD35004-vin", RCAR_E1 },
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] media: rcar_vin: Add preliminary r8a7790 support
@ 2013-10-04 14:20 ` Valentine Barshak
  0 siblings, 0 replies; 4+ messages in thread
From: Valentine Barshak @ 2013-10-04 14:20 UTC (permalink / raw)
  To: linux-media, Hans Verkuil
  Cc: Simon Horman, Magnus Damm, Laurent Pinchart,
	Mauro Carvalho Chehab, Guennadi Liakhovetski, linux-sh

Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
---
 drivers/media/platform/soc_camera/rcar_vin.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
index d02a7e0..b21f777 100644
--- a/drivers/media/platform/soc_camera/rcar_vin.c
+++ b/drivers/media/platform/soc_camera/rcar_vin.c
@@ -105,6 +105,7 @@
 #define VIN_MAX_HEIGHT		2048
 
 enum chip_id {
+	RCAR_H2,
 	RCAR_H1,
 	RCAR_M1,
 	RCAR_E1,
@@ -300,7 +301,8 @@ static int rcar_vin_setup(struct rcar_vin_priv *priv)
 		dmr = 0;
 		break;
 	case V4L2_PIX_FMT_RGB32:
-		if (priv->chip == RCAR_H1 || priv->chip == RCAR_E1) {
+		if (priv->chip == RCAR_H2 || priv->chip == RCAR_H1 ||
+		    priv->chip == RCAR_E1) {
 			dmr = VNDMR_EXRGB;
 			break;
 		}
@@ -1381,6 +1383,7 @@ static struct soc_camera_host_ops rcar_vin_host_ops = {
 };
 
 static struct platform_device_id rcar_vin_id_table[] = {
+	{ "r8a7790-vin",  RCAR_H2 },
 	{ "r8a7779-vin",  RCAR_H1 },
 	{ "r8a7778-vin",  RCAR_M1 },
 	{ "uPD35004-vin", RCAR_E1 },
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] media: rcar_vin: Add preliminary r8a7790 support
  2013-10-04 14:20 ` Valentine Barshak
@ 2013-10-29  5:06   ` Simon Horman
  -1 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2013-10-29  5:06 UTC (permalink / raw)
  To: Valentine Barshak
  Cc: linux-media, Hans Verkuil, Magnus Damm, Laurent Pinchart,
	Mauro Carvalho Chehab, Guennadi Liakhovetski, linux-sh

On Fri, Oct 04, 2013 at 06:20:52PM +0400, Valentine Barshak wrote:
> Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>

This looks entirely sane to me.

Acked-by: Simon Horman <horms+renesas@verge.net.au>

Mauro, would you consider taking this?

> ---
>  drivers/media/platform/soc_camera/rcar_vin.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
> index d02a7e0..b21f777 100644
> --- a/drivers/media/platform/soc_camera/rcar_vin.c
> +++ b/drivers/media/platform/soc_camera/rcar_vin.c
> @@ -105,6 +105,7 @@
>  #define VIN_MAX_HEIGHT		2048
>  
>  enum chip_id {
> +	RCAR_H2,
>  	RCAR_H1,
>  	RCAR_M1,
>  	RCAR_E1,
> @@ -300,7 +301,8 @@ static int rcar_vin_setup(struct rcar_vin_priv *priv)
>  		dmr = 0;
>  		break;
>  	case V4L2_PIX_FMT_RGB32:
> -		if (priv->chip = RCAR_H1 || priv->chip = RCAR_E1) {
> +		if (priv->chip = RCAR_H2 || priv->chip = RCAR_H1 ||
> +		    priv->chip = RCAR_E1) {
>  			dmr = VNDMR_EXRGB;
>  			break;
>  		}
> @@ -1381,6 +1383,7 @@ static struct soc_camera_host_ops rcar_vin_host_ops = {
>  };
>  
>  static struct platform_device_id rcar_vin_id_table[] = {
> +	{ "r8a7790-vin",  RCAR_H2 },
>  	{ "r8a7779-vin",  RCAR_H1 },
>  	{ "r8a7778-vin",  RCAR_M1 },
>  	{ "uPD35004-vin", RCAR_E1 },
> -- 
> 1.8.3.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] media: rcar_vin: Add preliminary r8a7790 support
@ 2013-10-29  5:06   ` Simon Horman
  0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2013-10-29  5:06 UTC (permalink / raw)
  To: Valentine Barshak
  Cc: linux-media, Hans Verkuil, Magnus Damm, Laurent Pinchart,
	Mauro Carvalho Chehab, Guennadi Liakhovetski, linux-sh

On Fri, Oct 04, 2013 at 06:20:52PM +0400, Valentine Barshak wrote:
> Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>

This looks entirely sane to me.

Acked-by: Simon Horman <horms+renesas@verge.net.au>

Mauro, would you consider taking this?

> ---
>  drivers/media/platform/soc_camera/rcar_vin.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
> index d02a7e0..b21f777 100644
> --- a/drivers/media/platform/soc_camera/rcar_vin.c
> +++ b/drivers/media/platform/soc_camera/rcar_vin.c
> @@ -105,6 +105,7 @@
>  #define VIN_MAX_HEIGHT		2048
>  
>  enum chip_id {
> +	RCAR_H2,
>  	RCAR_H1,
>  	RCAR_M1,
>  	RCAR_E1,
> @@ -300,7 +301,8 @@ static int rcar_vin_setup(struct rcar_vin_priv *priv)
>  		dmr = 0;
>  		break;
>  	case V4L2_PIX_FMT_RGB32:
> -		if (priv->chip == RCAR_H1 || priv->chip == RCAR_E1) {
> +		if (priv->chip == RCAR_H2 || priv->chip == RCAR_H1 ||
> +		    priv->chip == RCAR_E1) {
>  			dmr = VNDMR_EXRGB;
>  			break;
>  		}
> @@ -1381,6 +1383,7 @@ static struct soc_camera_host_ops rcar_vin_host_ops = {
>  };
>  
>  static struct platform_device_id rcar_vin_id_table[] = {
> +	{ "r8a7790-vin",  RCAR_H2 },
>  	{ "r8a7779-vin",  RCAR_H1 },
>  	{ "r8a7778-vin",  RCAR_M1 },
>  	{ "uPD35004-vin", RCAR_E1 },
> -- 
> 1.8.3.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-29  5:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-04 14:20 [PATCH] media: rcar_vin: Add preliminary r8a7790 support Valentine Barshak
2013-10-04 14:20 ` Valentine Barshak
2013-10-29  5:06 ` Simon Horman
2013-10-29  5:06   ` Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.