All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/3] ARM: dts: omap3-igep: improvements for v3.13
@ 2013-10-07  9:55 Javier Martinez Canillas
  2013-10-07  9:55 ` [PATCH v2 1/3] ARM: dts: omap3-igep: Add USB OTG support Javier Martinez Canillas
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2013-10-07  9:55 UTC (permalink / raw)
  To: bcousson; +Cc: Tony Lindgren, Enric Balletbo i Serra, Roger Quadros, linux-omap

Hi Benoit,

This series are some enhancements and cleanups for IGEP boards
that it would be great if can make it for v3.13.

This is a second version of the patch-set that addresses some issues
raised by Roger Quadros and is composed of the following patches:

[PATCH v2 1/3] ARM: dts: omap3-igep: Add USB OTG support
[PATCH v2 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support
[PATCH v2 3/3] ARM: dts: omap3-igep0020: use standard constant for IRQ

Patch 1 and 2 adds USB OTG and Host support respectively and patch 3
is a small cleanup to get rid of a magic number and use the proper
constant for IRQ edge/level type flags.

Thanks a lot and best regards,
Javier

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH v2 1/3] ARM: dts: omap3-igep: Add USB OTG support
  2013-10-07  9:55 [PATCH v2 0/3] ARM: dts: omap3-igep: improvements for v3.13 Javier Martinez Canillas
@ 2013-10-07  9:55 ` Javier Martinez Canillas
  2013-10-07  9:55 ` [PATCH v2 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support Javier Martinez Canillas
  2013-10-07  9:55 ` [PATCH v2 3/3] ARM: dts: omap3-igep0020: use standard constant for IRQ flags Javier Martinez Canillas
  2 siblings, 0 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2013-10-07  9:55 UTC (permalink / raw)
  To: bcousson
  Cc: Tony Lindgren, Enric Balletbo i Serra, Roger Quadros, linux-omap,
	Javier Martinez Canillas

Commit ad871c10b ("ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards")
added USB OTG support for most OMAP boards but some OMAP3 boards
such as IGEP boards were not updated. This patch adds an USB OTG
device node to these board.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Tested-by: Enric Balletbo i Serra <eballetbo@gmail.com>
---

Changes since v1:
 - Add USB OTG support for both IGEPv2 and IGEP COM and not only to IGEPv2

 arch/arm/boot/dts/omap3-igep.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi
index 0f92224..4e2eda2 100644
--- a/arch/arm/boot/dts/omap3-igep.dtsi
+++ b/arch/arm/boot/dts/omap3-igep.dtsi
@@ -143,3 +143,10 @@
 &twl_gpio {
 	ti,use-leds;
 };
+
+&usb_otg_hs {
+	interface-type = <0>;
+	usb-phy = <&usb2_phy>;
+	mode = <3>;
+	power = <50>;
+};
-- 
1.8.4.rc3


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH v2 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support
  2013-10-07  9:55 [PATCH v2 0/3] ARM: dts: omap3-igep: improvements for v3.13 Javier Martinez Canillas
  2013-10-07  9:55 ` [PATCH v2 1/3] ARM: dts: omap3-igep: Add USB OTG support Javier Martinez Canillas
@ 2013-10-07  9:55 ` Javier Martinez Canillas
  2013-10-07 10:18   ` Roger Quadros
  2013-10-07  9:55 ` [PATCH v2 3/3] ARM: dts: omap3-igep0020: use standard constant for IRQ flags Javier Martinez Canillas
  2 siblings, 1 reply; 5+ messages in thread
From: Javier Martinez Canillas @ 2013-10-07  9:55 UTC (permalink / raw)
  To: bcousson
  Cc: Tony Lindgren, Enric Balletbo i Serra, Roger Quadros, linux-omap,
	Javier Martinez Canillas

Add device nodes for the HS USB Host port 1, USB PHY and its
required regulator and also pin mux setup for HS USB1 pins.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Tested-by: Enric Balletbo i Serra <eballetbo@gmail.com>
---

Changes since v1:
 - Add HST USB port 1 pinmux setup in omap3-igep0020 instead of
   omap3-igep.dtsi since is not used by IGEP COM; suggested by Roger Quadros

 arch/arm/boot/dts/omap3-igep0020.dts | 49 ++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts
index eedf0d8..35346f2 100644
--- a/arch/arm/boot/dts/omap3-igep0020.dts
+++ b/arch/arm/boot/dts/omap3-igep0020.dts
@@ -55,6 +55,47 @@
 		regulator-name = "vdd33a";
 		regulator-always-on;
 	};
+
+       /* HS USB Port 1 Power */
+       hsusb1_power: hsusb1_power_reg {
+               compatible = "regulator-fixed";
+               regulator-name = "hsusb1_vbus";
+               regulator-min-microvolt = <3300000>;
+               regulator-max-microvolt = <3300000>;
+               gpio = <&twl_gpio 18 GPIO_ACTIVE_LOW>;	/* GPIO LEDA */
+               startup-delay-us = <70000>;
+       };
+
+	/* HS USB Host PHY on PORT 1 */
+	hsusb1_phy: hsusb1_phy {
+		compatible = "usb-nop-xceiv";
+		reset-gpios = <&gpio1 24 GPIO_ACTIVE_LOW>; /* gpio_24 */
+		vcc-supply = <&hsusb1_power>;
+	};
+};
+
+&omap3_pmx_core {
+	pinctrl-names = "default";
+	pinctrl-0 = <
+		&hsusbb1_pins
+	>;
+
+	hsusbb1_pins: pinmux_hsusbb1_pins {
+		pinctrl-single,pins = <
+			0x5aa (PIN_OUTPUT | MUX_MODE3)		/* etk_ctl.hsusb1_clk */
+			0x5a8 (PIN_OUTPUT | MUX_MODE3)		/* etk_clk.hsusb1_stp */
+			0x5bc (PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d8.hsusb1_dir */
+			0x5be (PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d9.hsusb1_nxt */
+			0x5ac (PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d0.hsusb1_data0 */
+			0x5ae (PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d1.hsusb1_data1 */
+			0x5b0 (PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d2.hsusb1_data2 */
+			0x5b2 (PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d3.hsusb1_data7 */
+			0x5b4 (PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d4.hsusb1_data4 */
+			0x5b6 (PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d5.hsusb1_data5 */
+			0x5b8 (PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d6.hsusb1_data6 */
+			0x5ba (PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d7.hsusb1_data3 */
+		>;
+	};
 };
 
 &leds_pins {
@@ -166,3 +207,11 @@
 		smsc,save-mac-address;
 	};
 };
+
+&usbhshost {
+	port1-mode = "ehci-phy";
+};
+
+&usbhsehci {
+	phys = <&hsusb1_phy>;
+};
-- 
1.8.4.rc3


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH v2 3/3] ARM: dts: omap3-igep0020: use standard constant for IRQ flags
  2013-10-07  9:55 [PATCH v2 0/3] ARM: dts: omap3-igep: improvements for v3.13 Javier Martinez Canillas
  2013-10-07  9:55 ` [PATCH v2 1/3] ARM: dts: omap3-igep: Add USB OTG support Javier Martinez Canillas
  2013-10-07  9:55 ` [PATCH v2 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support Javier Martinez Canillas
@ 2013-10-07  9:55 ` Javier Martinez Canillas
  2 siblings, 0 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2013-10-07  9:55 UTC (permalink / raw)
  To: bcousson
  Cc: Tony Lindgren, Enric Balletbo i Serra, Roger Quadros, linux-omap,
	Javier Martinez Canillas

Commit 840ef8b7 ("ARM: dt: add header to define IRQ flags") added
constants for IRQ edge/level triggered types so use it instead of
a magic number to enhance the DT readability.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---

Changes since v1:
 - None

 arch/arm/boot/dts/omap3-igep0020.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts
index 35346f2..750ce84 100644
--- a/arch/arm/boot/dts/omap3-igep0020.dts
+++ b/arch/arm/boot/dts/omap3-igep0020.dts
@@ -199,7 +199,7 @@
 		gpmc,cycle2cycle-diffcsen;
 
 		interrupt-parent = <&gpio6>;
-		interrupts = <16 8>;
+		interrupts = <16 IRQ_TYPE_LEVEL_LOW>;
 		vmmc-supply = <&vddvario>;
 		vmmc_aux-supply = <&vdd33a>;
 		reg-io-width = <4>;
-- 
1.8.4.rc3


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support
  2013-10-07  9:55 ` [PATCH v2 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support Javier Martinez Canillas
@ 2013-10-07 10:18   ` Roger Quadros
  0 siblings, 0 replies; 5+ messages in thread
From: Roger Quadros @ 2013-10-07 10:18 UTC (permalink / raw)
  To: Javier Martinez Canillas, bcousson
  Cc: Tony Lindgren, Enric Balletbo i Serra, linux-omap

On 10/07/2013 12:55 PM, Javier Martinez Canillas wrote:
> Add device nodes for the HS USB Host port 1, USB PHY and its
> required regulator and also pin mux setup for HS USB1 pins.
> 
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Tested-by: Enric Balletbo i Serra <eballetbo@gmail.com>

Acked-by: Roger Quadros <rogerq@ti.com>

> ---
> 
> Changes since v1:
>  - Add HST USB port 1 pinmux setup in omap3-igep0020 instead of
>    omap3-igep.dtsi since is not used by IGEP COM; suggested by Roger Quadros
> 
>  arch/arm/boot/dts/omap3-igep0020.dts | 49 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 49 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts
> index eedf0d8..35346f2 100644
> --- a/arch/arm/boot/dts/omap3-igep0020.dts
> +++ b/arch/arm/boot/dts/omap3-igep0020.dts
> @@ -55,6 +55,47 @@
>  		regulator-name = "vdd33a";
>  		regulator-always-on;
>  	};
> +
> +       /* HS USB Port 1 Power */
> +       hsusb1_power: hsusb1_power_reg {
> +               compatible = "regulator-fixed";
> +               regulator-name = "hsusb1_vbus";
> +               regulator-min-microvolt = <3300000>;
> +               regulator-max-microvolt = <3300000>;
> +               gpio = <&twl_gpio 18 GPIO_ACTIVE_LOW>;	/* GPIO LEDA */
> +               startup-delay-us = <70000>;
> +       };
> +
> +	/* HS USB Host PHY on PORT 1 */
> +	hsusb1_phy: hsusb1_phy {
> +		compatible = "usb-nop-xceiv";
> +		reset-gpios = <&gpio1 24 GPIO_ACTIVE_LOW>; /* gpio_24 */
> +		vcc-supply = <&hsusb1_power>;
> +	};
> +};
> +
> +&omap3_pmx_core {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <
> +		&hsusbb1_pins
> +	>;
> +
> +	hsusbb1_pins: pinmux_hsusbb1_pins {
> +		pinctrl-single,pins = <
> +			0x5aa (PIN_OUTPUT | MUX_MODE3)		/* etk_ctl.hsusb1_clk */
> +			0x5a8 (PIN_OUTPUT | MUX_MODE3)		/* etk_clk.hsusb1_stp */
> +			0x5bc (PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d8.hsusb1_dir */
> +			0x5be (PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d9.hsusb1_nxt */
> +			0x5ac (PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d0.hsusb1_data0 */
> +			0x5ae (PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d1.hsusb1_data1 */
> +			0x5b0 (PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d2.hsusb1_data2 */
> +			0x5b2 (PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d3.hsusb1_data7 */
> +			0x5b4 (PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d4.hsusb1_data4 */
> +			0x5b6 (PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d5.hsusb1_data5 */
> +			0x5b8 (PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d6.hsusb1_data6 */
> +			0x5ba (PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d7.hsusb1_data3 */
> +		>;
> +	};
>  };
>  
>  &leds_pins {
> @@ -166,3 +207,11 @@
>  		smsc,save-mac-address;
>  	};
>  };
> +
> +&usbhshost {
> +	port1-mode = "ehci-phy";
> +};
> +
> +&usbhsehci {
> +	phys = <&hsusb1_phy>;
> +};
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-10-07 10:18 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-07  9:55 [PATCH v2 0/3] ARM: dts: omap3-igep: improvements for v3.13 Javier Martinez Canillas
2013-10-07  9:55 ` [PATCH v2 1/3] ARM: dts: omap3-igep: Add USB OTG support Javier Martinez Canillas
2013-10-07  9:55 ` [PATCH v2 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support Javier Martinez Canillas
2013-10-07 10:18   ` Roger Quadros
2013-10-07  9:55 ` [PATCH v2 3/3] ARM: dts: omap3-igep0020: use standard constant for IRQ flags Javier Martinez Canillas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.