* [PATCH net v2] be2net: Warn users of possible broken functionality on BE2 cards with very old FW versions with latest driver
@ 2013-10-03 10:04 Somnath Kotur
2013-10-07 16:31 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Somnath Kotur @ 2013-10-03 10:04 UTC (permalink / raw)
To: netdev; +Cc: davem, Somnath Kotur
On very old FW versions < 4.0, the mailbox command to set interrupts
on the card succeeds even though it is not supported and should have
failed, leading to a scenario where interrupts do not work.
Hence warn users to upgrade to a suitable FW version to avoid seeing
broken functionality.
Signed-off-by: Somnath Kotur <somnath.kotur@emulex.com>
---
v2: Replaced all occurences of 'F/W' with 'FW' or 'Firmware' as suggested by
Sathya
drivers/net/ethernet/emulex/benet/be_main.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index 2c38cc4..9563ced 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -3247,6 +3247,11 @@ static int be_setup(struct be_adapter *adapter)
be_cmd_get_fw_ver(adapter, adapter->fw_ver, adapter->fw_on_flash);
+ if (BE2_chip(adapter) && memcmp(adapter->fw_ver, "4.", 2) < 0) {
+ dev_err(dev, "Firmware version is too old.IRQs may not work\n");
+ dev_err(dev, "Pls upgrade firmware to version >= 4.0\n");
+ }
+
if (adapter->vlans_added)
be_vid_config(adapter);
--
1.6.0.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net v2] be2net: Warn users of possible broken functionality on BE2 cards with very old FW versions with latest driver
2013-10-03 10:04 [PATCH net v2] be2net: Warn users of possible broken functionality on BE2 cards with very old FW versions with latest driver Somnath Kotur
@ 2013-10-07 16:31 ` David Miller
2013-10-07 16:44 ` Joe Perches
2013-10-16 14:59 ` Ivan Vecera
0 siblings, 2 replies; 5+ messages in thread
From: David Miller @ 2013-10-07 16:31 UTC (permalink / raw)
To: somnath.kotur; +Cc: netdev
From: Somnath Kotur <somnath.kotur@emulex.com>
Date: Thu, 3 Oct 2013 15:34:29 +0530
> + if (BE2_chip(adapter) && memcmp(adapter->fw_ver, "4.", 2) < 0) {
> + dev_err(dev, "Firmware version is too old.IRQs may not work\n");
So many grammatical mistakes in one line.
First sentence got a period, second one did not.
Missing space between period and second sentence.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net v2] be2net: Warn users of possible broken functionality on BE2 cards with very old FW versions with latest driver
2013-10-07 16:31 ` David Miller
@ 2013-10-07 16:44 ` Joe Perches
2013-10-16 14:59 ` Ivan Vecera
1 sibling, 0 replies; 5+ messages in thread
From: Joe Perches @ 2013-10-07 16:44 UTC (permalink / raw)
To: David Miller; +Cc: somnath.kotur, netdev
On Mon, 2013-10-07 at 12:31 -0400, David Miller wrote:
> From: Somnath Kotur <somnath.kotur@emulex.com>
> Date: Thu, 3 Oct 2013 15:34:29 +0530
> > + if (BE2_chip(adapter) && memcmp(adapter->fw_ver, "4.", 2) < 0) {
> > + dev_err(dev, "Firmware version is too old.IRQs may not work\n");
>
> So many grammatical mistakes in one line.
>
> First sentence got a period, second one did not.
>
> Missing space between period and second sentence.
Periods are unnecessary here.
Just use a comma or a dash.
Also, it might be nicer to show the current firmware version too.
Maybe:
dev_err(dev, "Firmware version is '%s' - Version 5 or higher is required for properly functional IRQs\n",
adapter->fw_ver);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net v2] be2net: Warn users of possible broken functionality on BE2 cards with very old FW versions with latest driver
2013-10-07 16:31 ` David Miller
2013-10-07 16:44 ` Joe Perches
@ 2013-10-16 14:59 ` Ivan Vecera
2013-10-17 5:41 ` Somnath Kotur
1 sibling, 1 reply; 5+ messages in thread
From: Ivan Vecera @ 2013-10-16 14:59 UTC (permalink / raw)
To: somnath.kotur; +Cc: David Miller, netdev
On 10/07/2013 06:31 PM, David Miller wrote:
> From: Somnath Kotur <somnath.kotur@emulex.com>
> Date: Thu, 3 Oct 2013 15:34:29 +0530
>
>> + if (BE2_chip(adapter) && memcmp(adapter->fw_ver, "4.", 2) < 0) {
>> + dev_err(dev, "Firmware version is too old.IRQs may not work\n");
>
> So many grammatical mistakes in one line.
>
> First sentence got a period, second one did not.
>
> Missing space between period and second sentence.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Som, any plan to send v3?
Ivan
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH net v2] be2net: Warn users of possible broken functionality on BE2 cards with very old FW versions with latest driver
2013-10-16 14:59 ` Ivan Vecera
@ 2013-10-17 5:41 ` Somnath Kotur
0 siblings, 0 replies; 5+ messages in thread
From: Somnath Kotur @ 2013-10-17 5:41 UTC (permalink / raw)
To: Ivan Vecera; +Cc: David Miller, netdev
> -----Original Message-----
> From: Ivan Vecera [mailto:ivecera@redhat.com]
> Sent: Wednesday, October 16, 2013 8:30 PM
> To: Somnath Kotur
> Cc: David Miller; netdev@vger.kernel.org
> Subject: Re: [PATCH net v2] be2net: Warn users of possible broken
> functionality on BE2 cards with very old FW versions with latest driver
>
> On 10/07/2013 06:31 PM, David Miller wrote:
> > From: Somnath Kotur <somnath.kotur@emulex.com>
> > Date: Thu, 3 Oct 2013 15:34:29 +0530
> >
> >> + if (BE2_chip(adapter) && memcmp(adapter->fw_ver, "4.", 2) < 0) {
> >> + dev_err(dev, "Firmware version is too old.IRQs may not
> work\n");
> >
> > So many grammatical mistakes in one line.
> >
> > First sentence got a period, second one did not.
> >
> > Missing space between period and second sentence.
> > --
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to majordomo@vger.kernel.org More majordomo
> info
> > at http://vger.kernel.org/majordomo-info.html
> >
> Som, any plan to send v3?
>
> Ivan
HI Ivan,
Yes , the problem was I was trying to stick within the 80 chars line limit , the missing space above would have pushed it over
needlessly warranting an extra line to accommodate a character.
Will rework the sentence using Joe Perches's suggestions as well as address Ben Hutching's concerns.
Stay tuned.
Thanks
Som
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-10-17 5:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-03 10:04 [PATCH net v2] be2net: Warn users of possible broken functionality on BE2 cards with very old FW versions with latest driver Somnath Kotur
2013-10-07 16:31 ` David Miller
2013-10-07 16:44 ` Joe Perches
2013-10-16 14:59 ` Ivan Vecera
2013-10-17 5:41 ` Somnath Kotur
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.