From: Scott Wood <scottwood@freescale.com>
To: Claudiu Manoil <claudiu.manoil@freescale.com>
Cc: <netdev@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>,
<linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 2/3] gianfar: Use mpc85xx support for errata detection
Date: Wed, 9 Oct 2013 15:14:13 -0500 [thread overview]
Message-ID: <1381349653.7979.366.camel@snotra.buserror.net> (raw)
In-Reply-To: <1381339242-32030-2-git-send-email-claudiu.manoil@freescale.com>
On Wed, 2013-10-09 at 20:20 +0300, Claudiu Manoil wrote:
> +static void gfar_detect_errata(struct gfar_private *priv)
> +{
> + struct device *dev = &priv->ofdev->dev;
> +
> + /* no plans to fix */
> + priv->errata |= GFAR_ERRATA_A002;
> +
> + if (pvr_version_is(PVR_VER_E500V1) || pvr_version_is(PVR_VER_E500V2))
> + __gfar_detect_errata_85xx(priv);
> + else /* non-mpc85xx parts, i.e. e300 core based */
> + __gfar_detect_errata_83xx(priv);
It would be better to use CONFIG_E500 here (note that we do not support
building e500 and 83xx/86xx in the same kernel), on the off chance that
we put a gianfar in a chip with a newer e500 derivative. I suppose it's
harmless as long as the 83xx version checks the full PVR, until such a
chip exists and has an erratum workaround (other than A002) added for
it.
What about 86xx? Are there any gianfar errata there besides A002?
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Claudiu Manoil <claudiu.manoil@freescale.com>
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 2/3] gianfar: Use mpc85xx support for errata detection
Date: Wed, 9 Oct 2013 15:14:13 -0500 [thread overview]
Message-ID: <1381349653.7979.366.camel@snotra.buserror.net> (raw)
In-Reply-To: <1381339242-32030-2-git-send-email-claudiu.manoil@freescale.com>
On Wed, 2013-10-09 at 20:20 +0300, Claudiu Manoil wrote:
> +static void gfar_detect_errata(struct gfar_private *priv)
> +{
> + struct device *dev = &priv->ofdev->dev;
> +
> + /* no plans to fix */
> + priv->errata |= GFAR_ERRATA_A002;
> +
> + if (pvr_version_is(PVR_VER_E500V1) || pvr_version_is(PVR_VER_E500V2))
> + __gfar_detect_errata_85xx(priv);
> + else /* non-mpc85xx parts, i.e. e300 core based */
> + __gfar_detect_errata_83xx(priv);
It would be better to use CONFIG_E500 here (note that we do not support
building e500 and 83xx/86xx in the same kernel), on the off chance that
we put a gianfar in a chip with a newer e500 derivative. I suppose it's
harmless as long as the 83xx version checks the full PVR, until such a
chip exists and has an erratum workaround (other than A002) added for
it.
What about 86xx? Are there any gianfar errata there besides A002?
-Scott
next prev parent reply other threads:[~2013-10-09 20:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 17:20 [PATCH 1/3] gianfar: Enable eTSEC-A002 erratum w/a for all parts Claudiu Manoil
2013-10-09 17:20 ` Claudiu Manoil
2013-10-09 17:20 ` [PATCH 2/3] gianfar: Use mpc85xx support for errata detection Claudiu Manoil
2013-10-09 17:20 ` Claudiu Manoil
2013-10-09 18:02 ` David Miller
2013-10-09 20:14 ` Scott Wood [this message]
2013-10-09 20:14 ` Scott Wood
2013-10-09 17:20 ` [PATCH 3/3] gianfar: Enable eTSEC-20 erratum w/a for P2020 Rev1 Claudiu Manoil
2013-10-09 18:02 ` David Miller
2013-10-09 18:02 ` [PATCH 1/3] gianfar: Enable eTSEC-A002 erratum w/a for all parts David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381349653.7979.366.camel@snotra.buserror.net \
--to=scottwood@freescale.com \
--cc=claudiu.manoil@freescale.com \
--cc=davem@davemloft.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.