* [Buildroot] [PATCH 1/1] Added jack2 as a package. Due to alignment errors on ARM platform, git sources are used.
@ 2013-10-24 23:42 ` Wojciech M. Zabolotny
2013-10-24 23:48 ` Wojciech Zabolotny
2013-10-25 23:36 ` [Buildroot] [PATCH 1/1] jack2: new package Wojciech M. Zabolotny
0 siblings, 2 replies; 28+ messages in thread
From: Wojciech M. Zabolotny @ 2013-10-24 23:42 UTC (permalink / raw)
To: buildroot
Signed-off-by: Wojciech M. Zabolotny <wzab01@gmail.com>
---
package/Config.in | 1 +
package/jack2/Config.in | 13 +++++++++++++
package/jack2/jack2.mk | 31 +++++++++++++++++++++++++++++++
3 files changed, 45 insertions(+)
create mode 100644 package/jack2/Config.in
create mode 100644 package/jack2/jack2.mk
diff --git a/package/Config.in b/package/Config.in
index 0e6f86c..a74ba5f 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -423,6 +423,7 @@ source "package/alsa-lib/Config.in"
source "package/audiofile/Config.in"
source "package/celt051/Config.in"
source "package/fdk-aac/Config.in"
+source "package/jack2/Config.in"
source "package/libao/Config.in"
source "package/libcdaudio/Config.in"
source "package/libcue/Config.in"
diff --git a/package/jack2/Config.in b/package/jack2/Config.in
new file mode 100644
index 0000000..c82bc15
--- /dev/null
+++ b/package/jack2/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_JACK2
+ bool "jack2"
+ select BR2_PACKAGE_LIBSAMPLERATE
+ select BR2_PACKAGE_LIBSNDFILE
+ help
+ JACK Audio Connection Kit (server and example clients)
+ http://jackaudio.org/
+
+ JACK is a low-latency sound server, allowing multiple applications to
+ connect to one audio device, and to share audio between themselves.
+
+ This package contains the daemon jackd as well as some example clients.
+
diff --git a/package/jack2/jack2.mk b/package/jack2/jack2.mk
new file mode 100644
index 0000000..785df16
--- /dev/null
+++ b/package/jack2/jack2.mk
@@ -0,0 +1,31 @@
+################################################################################
+#
+# jack2
+#
+################################################################################
+
+JACK2_VERSION = 37976441044d69b91d61d8f6278949a39cf1b7b7
+JACK2_SITE = git://github.com/jackaudio/jack2
+JACK2_LICENSE = LGPLv2.1+
+JACK2_DEPENDENCIES = \
+ libsamplerate \
+ libsndfile
+
+define JACK2_CONFIGURE_CMDS
+ (cd $(@D); \
+ $(TARGET_CONFIGURE_OPTS) \
+ ./waf configure \
+ --prefix=/usr \
+ --alsa \
+ )
+endef
+
+define JACK2_BUILD_CMDS
+ (cd $(@D); ./waf build -j $(PARALLEL_JOBS))
+endef
+
+define JACK2_INSTALL_TARGET_CMDS
+ (cd $(@D); ./waf --destdir=$(TARGET_DIR) install)
+endef
+
+$(eval $(generic-package))
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 1/1] Added jack2 as a package. Due to alignment errors on ARM platform, git sources are used.
2013-10-24 23:42 ` [Buildroot] [PATCH 1/1] Added jack2 as a package. Due to alignment errors on ARM platform, git sources are used Wojciech M. Zabolotny
@ 2013-10-24 23:48 ` Wojciech Zabolotny
2013-10-25 23:36 ` [Buildroot] [PATCH 1/1] jack2: new package Wojciech M. Zabolotny
1 sibling, 0 replies; 28+ messages in thread
From: Wojciech Zabolotny @ 2013-10-24 23:48 UTC (permalink / raw)
To: buildroot
Hi,
Today I have successfully compiled jack2 as a Buldroot package. I
hope, that this may be also useful for others.
Due to the fact, that released varsion generates alignment error on
ARM platform (
https://groups.google.com/d/msg/comp.sys.raspberry-pi/EgQAQ0DNwN4/2pTvdLy4r7UJ
), I have used the development version from git.
I'm not sure if I have correctly handled all necessary dependencies
(some necessary packages could be
selected by other packages before I selected jack2).
Regards,
Wojtek
On Fri, Oct 25, 2013 at 1:42 AM, Wojciech M. Zabolotny <wzab01@gmail.com> wrote:
> Signed-off-by: Wojciech M. Zabolotny <wzab01@gmail.com>
> ---
> package/Config.in | 1 +
> package/jack2/Config.in | 13 +++++++++++++
> package/jack2/jack2.mk | 31 +++++++++++++++++++++++++++++++
> 3 files changed, 45 insertions(+)
> create mode 100644 package/jack2/Config.in
> create mode 100644 package/jack2/jack2.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 0e6f86c..a74ba5f 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -423,6 +423,7 @@ source "package/alsa-lib/Config.in"
> source "package/audiofile/Config.in"
> source "package/celt051/Config.in"
> source "package/fdk-aac/Config.in"
> +source "package/jack2/Config.in"
> source "package/libao/Config.in"
> source "package/libcdaudio/Config.in"
> source "package/libcue/Config.in"
> diff --git a/package/jack2/Config.in b/package/jack2/Config.in
> new file mode 100644
> index 0000000..c82bc15
> --- /dev/null
> +++ b/package/jack2/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_JACK2
> + bool "jack2"
> + select BR2_PACKAGE_LIBSAMPLERATE
> + select BR2_PACKAGE_LIBSNDFILE
> + help
> + JACK Audio Connection Kit (server and example clients)
> + http://jackaudio.org/
> +
> + JACK is a low-latency sound server, allowing multiple applications to
> + connect to one audio device, and to share audio between themselves.
> +
> + This package contains the daemon jackd as well as some example clients.
> +
> diff --git a/package/jack2/jack2.mk b/package/jack2/jack2.mk
> new file mode 100644
> index 0000000..785df16
> --- /dev/null
> +++ b/package/jack2/jack2.mk
> @@ -0,0 +1,31 @@
> +################################################################################
> +#
> +# jack2
> +#
> +################################################################################
> +
> +JACK2_VERSION = 37976441044d69b91d61d8f6278949a39cf1b7b7
> +JACK2_SITE = git://github.com/jackaudio/jack2
> +JACK2_LICENSE = LGPLv2.1+
> +JACK2_DEPENDENCIES = \
> + libsamplerate \
> + libsndfile
> +
> +define JACK2_CONFIGURE_CMDS
> + (cd $(@D); \
> + $(TARGET_CONFIGURE_OPTS) \
> + ./waf configure \
> + --prefix=/usr \
> + --alsa \
> + )
> +endef
> +
> +define JACK2_BUILD_CMDS
> + (cd $(@D); ./waf build -j $(PARALLEL_JOBS))
> +endef
> +
> +define JACK2_INSTALL_TARGET_CMDS
> + (cd $(@D); ./waf --destdir=$(TARGET_DIR) install)
> +endef
> +
> +$(eval $(generic-package))
> --
> 1.8.4.rc3
>
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 1/1] Added pyusb as a package
@ 2013-10-25 12:54 Wojciech M. Zabolotny
2013-10-25 15:26 ` Ryan Barnett
2013-10-25 16:50 ` Thomas De Schampheleire
0 siblings, 2 replies; 28+ messages in thread
From: Wojciech M. Zabolotny @ 2013-10-25 12:54 UTC (permalink / raw)
To: buildroot
Signed-off-by: Wojciech M. Zabolotny <wzab01@gmail.com>
---
package/Config.in | 1 +
package/pyusb/Config.in | 10 ++++++++++
package/pyusb/pyusb.mk | 22 ++++++++++++++++++++++
3 files changed, 33 insertions(+)
create mode 100644 package/pyusb/Config.in
create mode 100644 package/pyusb/pyusb.mk
diff --git a/package/Config.in b/package/Config.in
index 0e6f86c..591cc04 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -404,6 +404,7 @@ source "package/python-pyzmq/Config.in"
source "package/python-serial/Config.in"
source "package/python-setuptools/Config.in"
source "package/python-thrift/Config.in"
+source "package/pyusb/Config.in"
endmenu
endif
source "package/python3/Config.in"
diff --git a/package/pyusb/Config.in b/package/pyusb/Config.in
new file mode 100644
index 0000000..b0c714a
--- /dev/null
+++ b/package/pyusb/Config.in
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_PYUSB
+ bool "pyusb"
+ depends on BR2_PACKAGE_PYTHON
+ select BR2_PACKAGE_LIBUSB
+ help
+ The PyUSB module provides for Python easy access to the host
+ machine's Universal Serial Bus (USB) system.
+
+ http://sourceforge.net/apps/trac/pyusb/
+
diff --git a/package/pyusb/pyusb.mk b/package/pyusb/pyusb.mk
new file mode 100644
index 0000000..fde10c9
--- /dev/null
+++ b/package/pyusb/pyusb.mk
@@ -0,0 +1,22 @@
+################################################################################
+#
+# pyusb
+#
+################################################################################
+
+PYUSB_VERSION = 0546cad8980783c39f96db717005a550059b730f
+PYUSB_SITE = git://github.com/walac/pyusb/
+PYUSB_LICENSE_FILES = LICENSE
+
+PYUSB_DEPENDENCIES = python libusb
+
+define PYUSB_INSTALL_TARGET_CMDS
+ (cd $(@D); $(HOST_DIR)/usr/bin/python setup.py install \
+ --prefix=$(TARGET_DIR)/usr)
+endef
+
+define PYUSB_UNINSTALL_TARGET_CMDS
+ rm -rf $(TARGET_DIR)/usr/lib/python*/site-packages/pyusb*
+endef
+
+$(eval $(generic-package))
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 1/1] Added pyusb as a package
2013-10-25 12:54 [Buildroot] [PATCH 1/1] Added pyusb as a package Wojciech M. Zabolotny
@ 2013-10-25 15:26 ` Ryan Barnett
2013-10-25 16:50 ` Thomas De Schampheleire
1 sibling, 0 replies; 28+ messages in thread
From: Ryan Barnett @ 2013-10-25 15:26 UTC (permalink / raw)
To: buildroot
Wojciech,
Please see some comments I have on this package below.
"Wojciech M. Zabolotny" <wzab01@gmail.com> wrote on 10/25/2013 07:54:06
AM:
Your commit message title should be this:
python-pyusb: new package
To follow on with this, the folder name for this package
should be "python-pyusb" instead of "pyusb" since all
python packages have "python-" added to their name.
> Signed-off-by: Wojciech M. Zabolotny <wzab01@gmail.com>
> ---
> package/Config.in | 1 +
> package/pyusb/Config.in | 10 ++++++++++
> package/pyusb/pyusb.mk | 22 ++++++++++++++++++++++
> 3 files changed, 33 insertions(+)
> create mode 100644 package/pyusb/Config.in
> create mode 100644 package/pyusb/pyusb.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 0e6f86c..591cc04 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -404,6 +404,7 @@ source "package/python-pyzmq/Config.in"
> source "package/python-serial/Config.in"
> source "package/python-setuptools/Config.in"
> source "package/python-thrift/Config.in"
> +source "package/pyusb/Config.in"
> endmenu
> endif
> source "package/python3/Config.in"
> diff --git a/package/pyusb/Config.in b/package/pyusb/Config.in
> new file mode 100644
> index 0000000..b0c714a
> --- /dev/null
> +++ b/package/pyusb/Config.in
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_PYUSB
> + bool "pyusb"
> + depends on BR2_PACKAGE_PYTHON
> + select BR2_PACKAGE_LIBUSB
> + help
> + The PyUSB module provides for Python easy access to the host
> + machine's Universal Serial Bus (USB) system.
> +
> + http://sourceforge.net/apps/trac/pyusb/
The formatting for the website URL is not correct. It should
be a "tab" plus "two spaces".
> +
> diff --git a/package/pyusb/pyusb.mk b/package/pyusb/pyusb.mk
> new file mode 100644
> index 0000000..fde10c9
> --- /dev/null
> +++ b/package/pyusb/pyusb.mk
> @@ -0,0 +1,22 @@
As noted earlier, the package name should be python-pyusb. So all
references of pyusb should either be "python-pyusb" or "PYTHON_PYUSB"
>
+################################################################################
> +#
> +# pyusb
> +#
>
+################################################################################
> +
> +PYUSB_VERSION = 0546cad8980783c39f96db717005a550059b730f
> +PYUSB_SITE = git://github.com/walac/pyusb/
You should also define what the license type is for this package.
Taking a quick glance at the license for this package it appears
that it is a BSD-style license with 3-clauses. Thus you should
add the following:
PYTHON_PYUSB_LICENSE = BSD-3c
Please see the buildroot manual for more information on this:
http://buildroot.uclibc.org/downloads/manual/manual.html#legal-info
> +PYUSB_LICENSE_FILES = LICENSE
> +
> +PYUSB_DEPENDENCIES = python libusb
> +
For building and installing, I would like to see that you
follow the standard way that we compile python packages for
cross-compiling. Though it appears that this package is
just .py files, by following this way it makes sure that
if ever in the future they. Please see the "python-pyparsing"
package makefile for how we like to have python packages.
http://git.buildroot.net/buildroot/tree/package/python-pyparsing/python-pyparsing.mk
> +define PYUSB_INSTALL_TARGET_CMDS
> + (cd $(@D); $(HOST_DIR)/usr/bin/python setup.py install \
> + --prefix=$(TARGET_DIR)/usr)
> +endef
> +
There is no need for the uninstall commands any more. So please
remove.
> +define PYUSB_UNINSTALL_TARGET_CMDS
> + rm -rf $(TARGET_DIR)/usr/lib/python*/site-packages/pyusb*
> +endef
> +
> +$(eval $(generic-package))
> --
> 1.8.4.rc3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 1/1] Added pyusb as a package
2013-10-25 12:54 [Buildroot] [PATCH 1/1] Added pyusb as a package Wojciech M. Zabolotny
2013-10-25 15:26 ` Ryan Barnett
@ 2013-10-25 16:50 ` Thomas De Schampheleire
2013-10-24 23:42 ` [Buildroot] [PATCH 1/1] Added jack2 as a package. Due to alignment errors on ARM platform, git sources are used Wojciech M. Zabolotny
2013-10-25 23:15 ` [Buildroot] [PATCH 1/1] python-pyusb: " Wojciech M. Zabolotny
1 sibling, 2 replies; 28+ messages in thread
From: Thomas De Schampheleire @ 2013-10-25 16:50 UTC (permalink / raw)
To: buildroot
"Wojciech M. Zabolotny" <wzab01@gmail.com> wrote:
>Signed-off-by: Wojciech M. Zabolotny <wzab01@gmail.com>
>---
> package/Config.in | 1 +
> package/pyusb/Config.in | 10 ++++++++++
> package/pyusb/pyusb.mk | 22 ++++++++++++++++++++++
> 3 files changed, 33 insertions(+)
> create mode 100644 package/pyusb/Config.in
> create mode 100644 package/pyusb/pyusb.mk
>
>diff --git a/package/Config.in b/package/Config.in
>index 0e6f86c..591cc04 100644
>--- a/package/Config.in
>+++ b/package/Config.in
>@@ -404,6 +404,7 @@ source "package/python-pyzmq/Config.in"
> source "package/python-serial/Config.in"
> source "package/python-setuptools/Config.in"
> source "package/python-thrift/Config.in"
>+source "package/pyusb/Config.in"
> endmenu
> endif
> source "package/python3/Config.in"
>diff --git a/package/pyusb/Config.in b/package/pyusb/Config.in
>new file mode 100644
>index 0000000..b0c714a
>--- /dev/null
>+++ b/package/pyusb/Config.in
>@@ -0,0 +1,10 @@
>+config BR2_PACKAGE_PYUSB
>+ bool "pyusb"
>+ depends on BR2_PACKAGE_PYTHON
>+ select BR2_PACKAGE_LIBUSB
>+ help
>+ The PyUSB module provides for Python easy access to the host
>+ machine's Universal Serial Bus (USB) system.
>+
>+ http://sourceforge.net/apps/trac/pyusb/
>+
>diff --git a/package/pyusb/pyusb.mk b/package/pyusb/pyusb.mk
>new file mode 100644
>index 0000000..fde10c9
>--- /dev/null
>+++ b/package/pyusb/pyusb.mk
>@@ -0,0 +1,22 @@
>+################################################################################
>+#
>+# pyusb
>+#
>+################################################################################
>+
>+PYUSB_VERSION = 0546cad8980783c39f96db717005a550059b730f
>+PYUSB_SITE = git://github.com/walac/pyusb/
Packages that come from github can be downloaded directly as a tarball. This has the advantage of not needing git. Please refer to the buildroot manual for instructions on this.
Best regards,
Thomas
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 1/1] Package python-pyusb added.
@ 2013-10-25 23:05 Wojciech M. Zabolotny
2013-10-25 23:09 ` Wojciech Zabolotny
0 siblings, 1 reply; 28+ messages in thread
From: Wojciech M. Zabolotny @ 2013-10-25 23:05 UTC (permalink / raw)
To: buildroot
Signed-off-by: Wojciech M. Zabolotny <wzab01@gmail.com>
---
package/Config.in | 1 +
package/python-pyusb/Config.in | 10 ++++++++++
package/python-pyusb/python-pyusb.mk | 37 ++++++++++++++++++++++++++++++++++++
3 files changed, 48 insertions(+)
create mode 100644 package/python-pyusb/Config.in
create mode 100644 package/python-pyusb/python-pyusb.mk
diff --git a/package/Config.in b/package/Config.in
index 0e6f86c..40dba0c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -400,6 +400,7 @@ source "package/python-protobuf/Config.in"
source "package/python-pygame/Config.in"
source "package/python-pyparsing/Config.in"
source "package/python-pyro/Config.in"
+source "package/python-pyusb/Config.in"
source "package/python-pyzmq/Config.in"
source "package/python-serial/Config.in"
source "package/python-setuptools/Config.in"
diff --git a/package/python-pyusb/Config.in b/package/python-pyusb/Config.in
new file mode 100644
index 0000000..3a1242a
--- /dev/null
+++ b/package/python-pyusb/Config.in
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_PYTHON_PYUSB
+ bool "python-pyusb"
+ depends on BR2_PACKAGE_PYTHON
+ select BR2_PACKAGE_LIBUSB
+ help
+ The PyUSB module provides for Python easy access to the host
+ machine's Universal Serial Bus (USB) system.
+
+ http://sourceforge.net/apps/trac/pyusb/
+
diff --git a/package/python-pyusb/python-pyusb.mk b/package/python-pyusb/python-pyusb.mk
new file mode 100644
index 0000000..80609af
--- /dev/null
+++ b/package/python-pyusb/python-pyusb.mk
@@ -0,0 +1,37 @@
+################################################################################
+#
+# python-pyusb
+#
+################################################################################
+
+PYTHON_PYUSB_VERSION = 0546cad8980783c39f96db717005a550059b730f
+PYTHON_PYUSB_SITE = http://github.com/walac/pyusb/tarball/$(PYTHON_PYUSB_VERSION)
+PYTHON_PYUSB_LICENSE = BSD-3c
+PYTHON_PYUSB_LICENSE_FILES = LICENSE
+
+PYTHON_PYUSB_DEPENDENCIES = python libusb
+
+# Copied from python-pyparsing, based on python-pygame
+define PYTHON_PYUSB_BUILD_CMDS
+ (cd $(@D); \
+ CC="$(TARGET_CC)" \
+ CFLAGS="$(TARGET_CFLAGS)" \
+ LDSHARED="$(TARGET_CROSS)gcc -shared" \
+ CROSS_COMPILING=yes \
+ _python_sysroot=$(STAGING_DIR) \
+ _python_srcdir=$(BUILD_DIR)/python$(PYTHON_VERSION) \
+ _python_prefix=/usr \
+ _python_exec_prefix=/usr \
+ $(HOST_DIR)/usr/bin/python setup.py build \
+ )
+endef
+
+# Copied from python-pyparsing, based on python-pygame
+define PYTHON_PYUSB_INSTALL_TARGET_CMDS
+ (cd $(@D); \
+ $(HOST_DIR)/usr/bin/python setup.py install \
+ --prefix=$(TARGET_DIR)/usr \
+ )
+endef
+
+$(eval $(generic-package))
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 1/1] Package python-pyusb added.
2013-10-25 23:05 [Buildroot] [PATCH 1/1] Package python-pyusb added Wojciech M. Zabolotny
@ 2013-10-25 23:09 ` Wojciech Zabolotny
0 siblings, 0 replies; 28+ messages in thread
From: Wojciech Zabolotny @ 2013-10-25 23:09 UTC (permalink / raw)
To: buildroot
Ooops, sorry, I have sent not-edited version...
On Sat, Oct 26, 2013 at 1:05 AM, Wojciech M. Zabolotny <wzab01@gmail.com> wrote:
> Signed-off-by: Wojciech M. Zabolotny <wzab01@gmail.com>
> ---
> package/Config.in | 1 +
> package/python-pyusb/Config.in | 10 ++++++++++
> package/python-pyusb/python-pyusb.mk | 37 ++++++++++++++++++++++++++++++++++++
> 3 files changed, 48 insertions(+)
> create mode 100644 package/python-pyusb/Config.in
> create mode 100644 package/python-pyusb/python-pyusb.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 0e6f86c..40dba0c 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -400,6 +400,7 @@ source "package/python-protobuf/Config.in"
> source "package/python-pygame/Config.in"
> source "package/python-pyparsing/Config.in"
> source "package/python-pyro/Config.in"
> +source "package/python-pyusb/Config.in"
> source "package/python-pyzmq/Config.in"
> source "package/python-serial/Config.in"
> source "package/python-setuptools/Config.in"
> diff --git a/package/python-pyusb/Config.in b/package/python-pyusb/Config.in
> new file mode 100644
> index 0000000..3a1242a
> --- /dev/null
> +++ b/package/python-pyusb/Config.in
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_PYTHON_PYUSB
> + bool "python-pyusb"
> + depends on BR2_PACKAGE_PYTHON
> + select BR2_PACKAGE_LIBUSB
> + help
> + The PyUSB module provides for Python easy access to the host
> + machine's Universal Serial Bus (USB) system.
> +
> + http://sourceforge.net/apps/trac/pyusb/
> +
> diff --git a/package/python-pyusb/python-pyusb.mk b/package/python-pyusb/python-pyusb.mk
> new file mode 100644
> index 0000000..80609af
> --- /dev/null
> +++ b/package/python-pyusb/python-pyusb.mk
> @@ -0,0 +1,37 @@
> +################################################################################
> +#
> +# python-pyusb
> +#
> +################################################################################
> +
> +PYTHON_PYUSB_VERSION = 0546cad8980783c39f96db717005a550059b730f
> +PYTHON_PYUSB_SITE = http://github.com/walac/pyusb/tarball/$(PYTHON_PYUSB_VERSION)
> +PYTHON_PYUSB_LICENSE = BSD-3c
> +PYTHON_PYUSB_LICENSE_FILES = LICENSE
> +
> +PYTHON_PYUSB_DEPENDENCIES = python libusb
> +
> +# Copied from python-pyparsing, based on python-pygame
> +define PYTHON_PYUSB_BUILD_CMDS
> + (cd $(@D); \
> + CC="$(TARGET_CC)" \
> + CFLAGS="$(TARGET_CFLAGS)" \
> + LDSHARED="$(TARGET_CROSS)gcc -shared" \
> + CROSS_COMPILING=yes \
> + _python_sysroot=$(STAGING_DIR) \
> + _python_srcdir=$(BUILD_DIR)/python$(PYTHON_VERSION) \
> + _python_prefix=/usr \
> + _python_exec_prefix=/usr \
> + $(HOST_DIR)/usr/bin/python setup.py build \
> + )
> +endef
> +
> +# Copied from python-pyparsing, based on python-pygame
> +define PYTHON_PYUSB_INSTALL_TARGET_CMDS
> + (cd $(@D); \
> + $(HOST_DIR)/usr/bin/python setup.py install \
> + --prefix=$(TARGET_DIR)/usr \
> + )
> +endef
> +
> +$(eval $(generic-package))
> --
> 1.8.4.rc3
>
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 1/1] python-pyusb: new package
2013-10-25 16:50 ` Thomas De Schampheleire
2013-10-24 23:42 ` [Buildroot] [PATCH 1/1] Added jack2 as a package. Due to alignment errors on ARM platform, git sources are used Wojciech M. Zabolotny
@ 2013-10-25 23:15 ` Wojciech M. Zabolotny
2013-10-25 23:41 ` Arnout Vandecappelle
1 sibling, 1 reply; 28+ messages in thread
From: Wojciech M. Zabolotny @ 2013-10-25 23:15 UTC (permalink / raw)
To: buildroot
I have considered remarks provided by Ryan Barnett and Thomas De Schampheleire.
I hope that now the package definition is correct.
Signed-off-by: Wojciech M. Zabolotny <wzab01@gmail.com>
---
package/Config.in | 1 +
package/python-pyusb/Config.in | 10 ++++++++++
package/python-pyusb/python-pyusb.mk | 37 ++++++++++++++++++++++++++++++++++++
3 files changed, 48 insertions(+)
create mode 100644 package/python-pyusb/Config.in
create mode 100644 package/python-pyusb/python-pyusb.mk
diff --git a/package/Config.in b/package/Config.in
index 0e6f86c..40dba0c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -400,6 +400,7 @@ source "package/python-protobuf/Config.in"
source "package/python-pygame/Config.in"
source "package/python-pyparsing/Config.in"
source "package/python-pyro/Config.in"
+source "package/python-pyusb/Config.in"
source "package/python-pyzmq/Config.in"
source "package/python-serial/Config.in"
source "package/python-setuptools/Config.in"
diff --git a/package/python-pyusb/Config.in b/package/python-pyusb/Config.in
new file mode 100644
index 0000000..3a1242a
--- /dev/null
+++ b/package/python-pyusb/Config.in
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_PYTHON_PYUSB
+ bool "python-pyusb"
+ depends on BR2_PACKAGE_PYTHON
+ select BR2_PACKAGE_LIBUSB
+ help
+ The PyUSB module provides for Python easy access to the host
+ machine's Universal Serial Bus (USB) system.
+
+ http://sourceforge.net/apps/trac/pyusb/
+
diff --git a/package/python-pyusb/python-pyusb.mk b/package/python-pyusb/python-pyusb.mk
new file mode 100644
index 0000000..80609af
--- /dev/null
+++ b/package/python-pyusb/python-pyusb.mk
@@ -0,0 +1,37 @@
+################################################################################
+#
+# python-pyusb
+#
+################################################################################
+
+PYTHON_PYUSB_VERSION = 0546cad8980783c39f96db717005a550059b730f
+PYTHON_PYUSB_SITE = http://github.com/walac/pyusb/tarball/$(PYTHON_PYUSB_VERSION)
+PYTHON_PYUSB_LICENSE = BSD-3c
+PYTHON_PYUSB_LICENSE_FILES = LICENSE
+
+PYTHON_PYUSB_DEPENDENCIES = python libusb
+
+# Copied from python-pyparsing, based on python-pygame
+define PYTHON_PYUSB_BUILD_CMDS
+ (cd $(@D); \
+ CC="$(TARGET_CC)" \
+ CFLAGS="$(TARGET_CFLAGS)" \
+ LDSHARED="$(TARGET_CROSS)gcc -shared" \
+ CROSS_COMPILING=yes \
+ _python_sysroot=$(STAGING_DIR) \
+ _python_srcdir=$(BUILD_DIR)/python$(PYTHON_VERSION) \
+ _python_prefix=/usr \
+ _python_exec_prefix=/usr \
+ $(HOST_DIR)/usr/bin/python setup.py build \
+ )
+endef
+
+# Copied from python-pyparsing, based on python-pygame
+define PYTHON_PYUSB_INSTALL_TARGET_CMDS
+ (cd $(@D); \
+ $(HOST_DIR)/usr/bin/python setup.py install \
+ --prefix=$(TARGET_DIR)/usr \
+ )
+endef
+
+$(eval $(generic-package))
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 1/1] jack2: new package
2013-10-24 23:42 ` [Buildroot] [PATCH 1/1] Added jack2 as a package. Due to alignment errors on ARM platform, git sources are used Wojciech M. Zabolotny
2013-10-24 23:48 ` Wojciech Zabolotny
@ 2013-10-25 23:36 ` Wojciech M. Zabolotny
2013-10-27 17:10 ` Thomas Petazzoni
1 sibling, 1 reply; 28+ messages in thread
From: Wojciech M. Zabolotny @ 2013-10-25 23:36 UTC (permalink / raw)
To: buildroot
I corrected downloading of sources from the github, according to
suggestion received from Thomas De Schampheleire.
Signed-off-by: Wojciech M. Zabolotny <wzab01@gmail.com>
---
package/Config.in | 1 +
package/jack2/Config.in | 13 +++++++++++++
package/jack2/jack2.mk | 31 +++++++++++++++++++++++++++++++
3 files changed, 45 insertions(+)
create mode 100644 package/jack2/Config.in
create mode 100644 package/jack2/jack2.mk
diff --git a/package/Config.in b/package/Config.in
index 0e6f86c..9f7e118 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -11,6 +11,7 @@ source "package/ffmpeg/Config.in"
source "package/flac/Config.in"
source "package/gstreamer/Config.in"
source "package/gstreamer1/Config.in"
+source "package/jack2/Config.in"
source "package/lame/Config.in"
source "package/libvpx/Config.in"
source "package/madplay/Config.in"
diff --git a/package/jack2/Config.in b/package/jack2/Config.in
new file mode 100644
index 0000000..c82bc15
--- /dev/null
+++ b/package/jack2/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_JACK2
+ bool "jack2"
+ select BR2_PACKAGE_LIBSAMPLERATE
+ select BR2_PACKAGE_LIBSNDFILE
+ help
+ JACK Audio Connection Kit (server and example clients)
+ http://jackaudio.org/
+
+ JACK is a low-latency sound server, allowing multiple applications to
+ connect to one audio device, and to share audio between themselves.
+
+ This package contains the daemon jackd as well as some example clients.
+
diff --git a/package/jack2/jack2.mk b/package/jack2/jack2.mk
new file mode 100644
index 0000000..5ab751f
--- /dev/null
+++ b/package/jack2/jack2.mk
@@ -0,0 +1,31 @@
+################################################################################
+#
+# jack2
+#
+################################################################################
+
+JACK2_VERSION = 37976441044d69b91d61d8f6278949a39cf1b7b7
+JACK2_SITE = http://github.com/jackaudio/jack2/tarball/$(JACK2_VERSION)
+JACK2_LICENSE = LGPLv2.1+
+JACK2_DEPENDENCIES = \
+ libsamplerate \
+ libsndfile
+
+define JACK2_CONFIGURE_CMDS
+ (cd $(@D); \
+ $(TARGET_CONFIGURE_OPTS) \
+ ./waf configure \
+ --prefix=/usr \
+ --alsa \
+ )
+endef
+
+define JACK2_BUILD_CMDS
+ (cd $(@D); ./waf build -j $(PARALLEL_JOBS))
+endef
+
+define JACK2_INSTALL_TARGET_CMDS
+ (cd $(@D); ./waf --destdir=$(TARGET_DIR) install)
+endef
+
+$(eval $(generic-package))
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 1/1] python-pyusb: new package
2013-10-25 23:15 ` [Buildroot] [PATCH 1/1] python-pyusb: " Wojciech M. Zabolotny
@ 2013-10-25 23:41 ` Arnout Vandecappelle
2013-10-26 7:25 ` Wojciech M. Zabolotny
2013-10-26 7:33 ` [Buildroot] [PATCH " Wojciech Zabolotny
0 siblings, 2 replies; 28+ messages in thread
From: Arnout Vandecappelle @ 2013-10-25 23:41 UTC (permalink / raw)
To: buildroot
Hi Wojciech,
A few minor nits and one major issue.
On 26/10/13 01:15, Wojciech M. Zabolotny wrote:
> I have considered remarks provided by Ryan Barnett and Thomas De Schampheleire.
> I hope that now the package definition is correct.
Comments like this should not appear in the git history. You can do
that by putting them below the Signed-off-by line, separated with --- on
a line on its own. The part below the --- line is removed when the patch
is committed with git am.
Also, when sending an update, it is customary to add v2 to the subject
so people can see which version is the latest one. You can do that by
calling
git send-email -v2 # Since git 1.8.x
or
git send-email --subject-prefix='PATCH v2'
>
> Signed-off-by: Wojciech M. Zabolotny <wzab01@gmail.com>
> ---
> package/Config.in | 1 +
> package/python-pyusb/Config.in | 10 ++++++++++
> package/python-pyusb/python-pyusb.mk | 37 ++++++++++++++++++++++++++++++++++++
> 3 files changed, 48 insertions(+)
> create mode 100644 package/python-pyusb/Config.in
> create mode 100644 package/python-pyusb/python-pyusb.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 0e6f86c..40dba0c 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -400,6 +400,7 @@ source "package/python-protobuf/Config.in"
> source "package/python-pygame/Config.in"
> source "package/python-pyparsing/Config.in"
> source "package/python-pyro/Config.in"
> +source "package/python-pyusb/Config.in"
> source "package/python-pyzmq/Config.in"
> source "package/python-serial/Config.in"
> source "package/python-setuptools/Config.in"
> diff --git a/package/python-pyusb/Config.in b/package/python-pyusb/Config.in
> new file mode 100644
> index 0000000..3a1242a
> --- /dev/null
> +++ b/package/python-pyusb/Config.in
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_PYTHON_PYUSB
> + bool "python-pyusb"
> + depends on BR2_PACKAGE_PYTHON
> + select BR2_PACKAGE_LIBUSB
libusb depends on threads so you should have
depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
and
comment "python-pyusb needs a toolchain w/ threads"
depends on BR2_PACKAGE_PYTHON
depends on !BR2_TOOLCHAIN_HAS_THREADS
> + help
> + The PyUSB module provides for Python easy access to the host
> + machine's Universal Serial Bus (USB) system.
> +
Empty lines should be really empty, not contain spaces.
> + http://sourceforge.net/apps/trac/pyusb/
> +
Spurious empty line.
> diff --git a/package/python-pyusb/python-pyusb.mk b/package/python-pyusb/python-pyusb.mk
> new file mode 100644
> index 0000000..80609af
> --- /dev/null
> +++ b/package/python-pyusb/python-pyusb.mk
> @@ -0,0 +1,37 @@
> +################################################################################
> +#
> +# python-pyusb
> +#
> +################################################################################
> +
> +PYTHON_PYUSB_VERSION = 0546cad8980783c39f96db717005a550059b730f
> +PYTHON_PYUSB_SITE = http://github.com/walac/pyusb/tarball/$(PYTHON_PYUSB_VERSION)
> +PYTHON_PYUSB_LICENSE = BSD-3c
> +PYTHON_PYUSB_LICENSE_FILES = LICENSE
> +
> +PYTHON_PYUSB_DEPENDENCIES = python libusb
libusb is only a runtime dependency, so it doesn't need to be added to
the dependencies list.
Otherwise, looks good :-)
Regards,
Arnout
> +
> +# Copied from python-pyparsing, based on python-pygame
> +define PYTHON_PYUSB_BUILD_CMDS
> + (cd $(@D); \
> + CC="$(TARGET_CC)" \
> + CFLAGS="$(TARGET_CFLAGS)" \
> + LDSHARED="$(TARGET_CROSS)gcc -shared" \
> + CROSS_COMPILING=yes \
> + _python_sysroot=$(STAGING_DIR) \
> + _python_srcdir=$(BUILD_DIR)/python$(PYTHON_VERSION) \
> + _python_prefix=/usr \
> + _python_exec_prefix=/usr \
> + $(HOST_DIR)/usr/bin/python setup.py build \
> + )
> +endef
> +
> +# Copied from python-pyparsing, based on python-pygame
> +define PYTHON_PYUSB_INSTALL_TARGET_CMDS
> + (cd $(@D); \
> + $(HOST_DIR)/usr/bin/python setup.py install \
> + --prefix=$(TARGET_DIR)/usr \
> + )
> +endef
> +
> +$(eval $(generic-package))
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 1/1] python-pyusb: new package
2013-10-25 23:41 ` Arnout Vandecappelle
@ 2013-10-26 7:25 ` Wojciech M. Zabolotny
2013-10-26 7:35 ` [Buildroot] [PATCH v2 " Wojciech M. Zabolotny
2013-10-26 7:33 ` [Buildroot] [PATCH " Wojciech Zabolotny
1 sibling, 1 reply; 28+ messages in thread
From: Wojciech M. Zabolotny @ 2013-10-26 7:25 UTC (permalink / raw)
To: buildroot
Signed-off-by: Wojciech M. Zabolotny <wzab01@gmail.com>
---
package/Config.in | 1 +
package/python-pyusb/Config.in | 14 ++++++++++++++
package/python-pyusb/python-pyusb.mk | 37 ++++++++++++++++++++++++++++++++++++
3 files changed, 52 insertions(+)
create mode 100644 package/python-pyusb/Config.in
create mode 100644 package/python-pyusb/python-pyusb.mk
diff --git a/package/Config.in b/package/Config.in
index 0e6f86c..40dba0c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -400,6 +400,7 @@ source "package/python-protobuf/Config.in"
source "package/python-pygame/Config.in"
source "package/python-pyparsing/Config.in"
source "package/python-pyro/Config.in"
+source "package/python-pyusb/Config.in"
source "package/python-pyzmq/Config.in"
source "package/python-serial/Config.in"
source "package/python-setuptools/Config.in"
diff --git a/package/python-pyusb/Config.in b/package/python-pyusb/Config.in
new file mode 100644
index 0000000..3337b7e
--- /dev/null
+++ b/package/python-pyusb/Config.in
@@ -0,0 +1,14 @@
+config BR2_PACKAGE_PYTHON_PYUSB
+ bool "python-pyusb"
+ depends on BR2_PACKAGE_PYTHON
+ depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
+ select BR2_PACKAGE_LIBUSB
+ help
+ The PyUSB module provides for Python easy access to the host
+ machine's Universal Serial Bus (USB) system.
+
+ http://sourceforge.net/apps/trac/pyusb/
+comment "python-pyusb needs a toolchain w/ threads"
+ depends on BR2_PACKAGE_PYTHON
+ depends on !BR2_TOOLCHAIN_HAS_THREADS
+
diff --git a/package/python-pyusb/python-pyusb.mk b/package/python-pyusb/python-pyusb.mk
new file mode 100644
index 0000000..e4d17be
--- /dev/null
+++ b/package/python-pyusb/python-pyusb.mk
@@ -0,0 +1,37 @@
+################################################################################
+#
+# python-pyusb
+#
+################################################################################
+
+PYTHON_PYUSB_VERSION = 0546cad8980783c39f96db717005a550059b730f
+PYTHON_PYUSB_SITE = http://github.com/walac/pyusb/tarball/$(PYTHON_PYUSB_VERSION)
+PYTHON_PYUSB_LICENSE = BSD-3c
+PYTHON_PYUSB_LICENSE_FILES = LICENSE
+
+PYTHON_PYUSB_DEPENDENCIES = python
+
+# Copied from python-pyparsing, based on python-pygame
+define PYTHON_PYUSB_BUILD_CMDS
+ (cd $(@D); \
+ CC="$(TARGET_CC)" \
+ CFLAGS="$(TARGET_CFLAGS)" \
+ LDSHARED="$(TARGET_CROSS)gcc -shared" \
+ CROSS_COMPILING=yes \
+ _python_sysroot=$(STAGING_DIR) \
+ _python_srcdir=$(BUILD_DIR)/python$(PYTHON_VERSION) \
+ _python_prefix=/usr \
+ _python_exec_prefix=/usr \
+ $(HOST_DIR)/usr/bin/python setup.py build \
+ )
+endef
+
+# Copied from python-pyparsing, based on python-pygame
+define PYTHON_PYUSB_INSTALL_TARGET_CMDS
+ (cd $(@D); \
+ $(HOST_DIR)/usr/bin/python setup.py install \
+ --prefix=$(TARGET_DIR)/usr \
+ )
+endef
+
+$(eval $(generic-package))
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 1/1] python-pyusb: new package
2013-10-25 23:41 ` Arnout Vandecappelle
2013-10-26 7:25 ` Wojciech M. Zabolotny
@ 2013-10-26 7:33 ` Wojciech Zabolotny
2013-10-28 7:12 ` Arnout Vandecappelle
1 sibling, 1 reply; 28+ messages in thread
From: Wojciech Zabolotny @ 2013-10-26 7:33 UTC (permalink / raw)
To: buildroot
On Sat, Oct 26, 2013 at 1:41 AM, Arnout Vandecappelle <arnout@mind.be> wrote:
> Also, when sending an update, it is customary to add v2 to the subject so
> people can see which version is the latest one. You can do that by calling
> git send-email -v2 # Since git 1.8.x
> or
> git send-email --subject-prefix='PATCH v2'
>
It seems, that the above should be applied to git format-patch, not
git send-email?
--
Regards,
Wojtek
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH v2 1/1] python-pyusb: new package
2013-10-26 7:25 ` Wojciech M. Zabolotny
@ 2013-10-26 7:35 ` Wojciech M. Zabolotny
0 siblings, 0 replies; 28+ messages in thread
From: Wojciech M. Zabolotny @ 2013-10-26 7:35 UTC (permalink / raw)
To: buildroot
Signed-off-by: Wojciech M. Zabolotny <wzab01@gmail.com>
---
package/Config.in | 1 +
package/python-pyusb/Config.in | 14 ++++++++++++++
package/python-pyusb/python-pyusb.mk | 37 ++++++++++++++++++++++++++++++++++++
3 files changed, 52 insertions(+)
create mode 100644 package/python-pyusb/Config.in
create mode 100644 package/python-pyusb/python-pyusb.mk
diff --git a/package/Config.in b/package/Config.in
index 0e6f86c..40dba0c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -400,6 +400,7 @@ source "package/python-protobuf/Config.in"
source "package/python-pygame/Config.in"
source "package/python-pyparsing/Config.in"
source "package/python-pyro/Config.in"
+source "package/python-pyusb/Config.in"
source "package/python-pyzmq/Config.in"
source "package/python-serial/Config.in"
source "package/python-setuptools/Config.in"
diff --git a/package/python-pyusb/Config.in b/package/python-pyusb/Config.in
new file mode 100644
index 0000000..3337b7e
--- /dev/null
+++ b/package/python-pyusb/Config.in
@@ -0,0 +1,14 @@
+config BR2_PACKAGE_PYTHON_PYUSB
+ bool "python-pyusb"
+ depends on BR2_PACKAGE_PYTHON
+ depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
+ select BR2_PACKAGE_LIBUSB
+ help
+ The PyUSB module provides for Python easy access to the host
+ machine's Universal Serial Bus (USB) system.
+
+ http://sourceforge.net/apps/trac/pyusb/
+comment "python-pyusb needs a toolchain w/ threads"
+ depends on BR2_PACKAGE_PYTHON
+ depends on !BR2_TOOLCHAIN_HAS_THREADS
+
diff --git a/package/python-pyusb/python-pyusb.mk b/package/python-pyusb/python-pyusb.mk
new file mode 100644
index 0000000..e4d17be
--- /dev/null
+++ b/package/python-pyusb/python-pyusb.mk
@@ -0,0 +1,37 @@
+################################################################################
+#
+# python-pyusb
+#
+################################################################################
+
+PYTHON_PYUSB_VERSION = 0546cad8980783c39f96db717005a550059b730f
+PYTHON_PYUSB_SITE = http://github.com/walac/pyusb/tarball/$(PYTHON_PYUSB_VERSION)
+PYTHON_PYUSB_LICENSE = BSD-3c
+PYTHON_PYUSB_LICENSE_FILES = LICENSE
+
+PYTHON_PYUSB_DEPENDENCIES = python
+
+# Copied from python-pyparsing, based on python-pygame
+define PYTHON_PYUSB_BUILD_CMDS
+ (cd $(@D); \
+ CC="$(TARGET_CC)" \
+ CFLAGS="$(TARGET_CFLAGS)" \
+ LDSHARED="$(TARGET_CROSS)gcc -shared" \
+ CROSS_COMPILING=yes \
+ _python_sysroot=$(STAGING_DIR) \
+ _python_srcdir=$(BUILD_DIR)/python$(PYTHON_VERSION) \
+ _python_prefix=/usr \
+ _python_exec_prefix=/usr \
+ $(HOST_DIR)/usr/bin/python setup.py build \
+ )
+endef
+
+# Copied from python-pyparsing, based on python-pygame
+define PYTHON_PYUSB_INSTALL_TARGET_CMDS
+ (cd $(@D); \
+ $(HOST_DIR)/usr/bin/python setup.py install \
+ --prefix=$(TARGET_DIR)/usr \
+ )
+endef
+
+$(eval $(generic-package))
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 1/1] jack2: new package
2013-10-25 23:36 ` [Buildroot] [PATCH 1/1] jack2: new package Wojciech M. Zabolotny
@ 2013-10-27 17:10 ` Thomas Petazzoni
2013-10-27 19:50 ` [Buildroot] [PATCH v2 " Wojciech M. Zabolotny
0 siblings, 1 reply; 28+ messages in thread
From: Thomas Petazzoni @ 2013-10-27 17:10 UTC (permalink / raw)
To: buildroot
Dear Wojciech M. Zabolotny,
On Sat, 26 Oct 2013 01:36:08 +0200, Wojciech M. Zabolotny wrote:
> I corrected downloading of sources from the github, according to
> suggestion received from Thomas De Schampheleire.
This shouldn't be part of the commit log, but of the changelog. See
http://buildroot.org/downloads/manual/manual.html#_patch_revision_changelog.
> diff --git a/package/jack2/Config.in b/package/jack2/Config.in
> new file mode 100644
> index 0000000..c82bc15
> --- /dev/null
> +++ b/package/jack2/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_JACK2
> + bool "jack2"
> + select BR2_PACKAGE_LIBSAMPLERATE
> + select BR2_PACKAGE_LIBSNDFILE
libsndfile depends on largefile, so you should propagate this
dependency here.
> + help
> + JACK Audio Connection Kit (server and example clients)
> + http://jackaudio.org/
> +
> + JACK is a low-latency sound server, allowing multiple applications to
> + connect to one audio device, and to share audio between themselves.
> +
> + This package contains the daemon jackd as well as some example clients.
Indentation is wrong for the help text. It should be one tab + two
spaces. And the upstream URL should be at the end. See
http://buildroot.org/downloads/manual/manual.html#writing-rules-config-in.
> diff --git a/package/jack2/jack2.mk b/package/jack2/jack2.mk
> new file mode 100644
> index 0000000..5ab751f
> --- /dev/null
> +++ b/package/jack2/jack2.mk
> @@ -0,0 +1,31 @@
> +################################################################################
> +#
> +# jack2
> +#
> +################################################################################
> +
> +JACK2_VERSION = 37976441044d69b91d61d8f6278949a39cf1b7b7
> +JACK2_SITE = http://github.com/jackaudio/jack2/tarball/$(JACK2_VERSION)
> +JACK2_LICENSE = LGPLv2.1+
> +JACK2_DEPENDENCIES = \
> + libsamplerate \
> + libsndfile
> +
> +define JACK2_CONFIGURE_CMDS
> + (cd $(@D); \
> + $(TARGET_CONFIGURE_OPTS) \
> + ./waf configure \
> + --prefix=/usr \
> + --alsa \
From this --alsa option, I seem to understand that it is using ALSA.
Are you sure it shouldn't depend on alsa-lib as well?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH v2 1/1] jack2: new package
2013-10-27 17:10 ` Thomas Petazzoni
@ 2013-10-27 19:50 ` Wojciech M. Zabolotny
2013-10-28 19:27 ` Thomas Petazzoni
0 siblings, 1 reply; 28+ messages in thread
From: Wojciech M. Zabolotny @ 2013-10-27 19:50 UTC (permalink / raw)
To: buildroot
Signed-off-by: Wojciech M. Zabolotny <wzab01@gmail.com>
---
I have modified patch introducing the new "jack2" package, according
to suggestions received from Thomas De Schampheleire and Thomas Petazzoni
(corrections of formatting, dependencies and downloading of source form git).
---
package/Config.in | 1 +
package/jack2/Config.in | 23 +++++++++++++++++++++++
package/jack2/jack2.mk | 31 +++++++++++++++++++++++++++++++
3 files changed, 55 insertions(+)
create mode 100644 package/jack2/Config.in
create mode 100644 package/jack2/jack2.mk
diff --git a/package/Config.in b/package/Config.in
index 4c4da51..bf297a8 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -11,6 +11,7 @@ source "package/ffmpeg/Config.in"
source "package/flac/Config.in"
source "package/gstreamer/Config.in"
source "package/gstreamer1/Config.in"
+source "package/jack2/Config.in"
source "package/lame/Config.in"
source "package/libvpx/Config.in"
source "package/madplay/Config.in"
diff --git a/package/jack2/Config.in b/package/jack2/Config.in
new file mode 100644
index 0000000..0fb6ca2
--- /dev/null
+++ b/package/jack2/Config.in
@@ -0,0 +1,23 @@
+config BR2_PACKAGE_JACK2
+ bool "jack2"
+ depends on BR2_LARGEFILE
+ depends on BR2_TOOLCHAIN_HAS_THREADS
+ select BR2_PACKAGE_LIBSAMPLERATE
+ select BR2_PACKAGE_LIBSNDFILE
+ select BR2_PACKAGE_ALSA_LIB
+ help
+ JACK Audio Connection Kit (server and example clients)
+ JACK is a low-latency sound server, allowing multiple applications to
+ connect to one audio device, and to share audio between themselves.
+ This package contains the daemon jackd as well as some example clients.
+
+ http://jackaudio.org/
+
+comment "jack2 uses libsndfile which requires a toolchain with LARGEFILE support"
+ depends on !BR2_LARGEFILE
+
+comment "jack2 uses alsa-lib which requires a toolchain with threads support"
+ depends on !BR2_TOOLCHAIN_HAS_THREADS
+
+
+
diff --git a/package/jack2/jack2.mk b/package/jack2/jack2.mk
new file mode 100644
index 0000000..5ab751f
--- /dev/null
+++ b/package/jack2/jack2.mk
@@ -0,0 +1,31 @@
+################################################################################
+#
+# jack2
+#
+################################################################################
+
+JACK2_VERSION = 37976441044d69b91d61d8f6278949a39cf1b7b7
+JACK2_SITE = http://github.com/jackaudio/jack2/tarball/$(JACK2_VERSION)
+JACK2_LICENSE = LGPLv2.1+
+JACK2_DEPENDENCIES = \
+ libsamplerate \
+ libsndfile
+
+define JACK2_CONFIGURE_CMDS
+ (cd $(@D); \
+ $(TARGET_CONFIGURE_OPTS) \
+ ./waf configure \
+ --prefix=/usr \
+ --alsa \
+ )
+endef
+
+define JACK2_BUILD_CMDS
+ (cd $(@D); ./waf build -j $(PARALLEL_JOBS))
+endef
+
+define JACK2_INSTALL_TARGET_CMDS
+ (cd $(@D); ./waf --destdir=$(TARGET_DIR) install)
+endef
+
+$(eval $(generic-package))
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 1/1] python-pyusb: new package
2013-10-26 7:33 ` [Buildroot] [PATCH " Wojciech Zabolotny
@ 2013-10-28 7:12 ` Arnout Vandecappelle
2013-10-28 8:10 ` Baruch Siach
0 siblings, 1 reply; 28+ messages in thread
From: Arnout Vandecappelle @ 2013-10-28 7:12 UTC (permalink / raw)
To: buildroot
On 26/10/13 09:33, Wojciech Zabolotny wrote:
> On Sat, Oct 26, 2013 at 1:41 AM, Arnout Vandecappelle <arnout@mind.be> wrote:
>
>> Also, when sending an update, it is customary to add v2 to the subject so
>> people can see which version is the latest one. You can do that by calling
>> git send-email -v2 # Since git 1.8.x
>> or
>> git send-email --subject-prefix='PATCH v2'
>>
>
> It seems, that the above should be applied to git format-patch, not
> git send-email?
You're right, but git send-email takes (almost) all of the options of
git format-patch if you let it generate patches directly (e.g. with 'git
send-email -1). Normally I don't bother with generating the patches
separately and just mail them immediately - and I assumed that the rest
of the world does the same :-).
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 1/1] python-pyusb: new package
2013-10-28 7:12 ` Arnout Vandecappelle
@ 2013-10-28 8:10 ` Baruch Siach
2013-10-28 8:24 ` Arnout Vandecappelle
0 siblings, 1 reply; 28+ messages in thread
From: Baruch Siach @ 2013-10-28 8:10 UTC (permalink / raw)
To: buildroot
Hi Arnout,
On Mon, Oct 28, 2013 at 08:12:21AM +0100, Arnout Vandecappelle wrote:
> On 26/10/13 09:33, Wojciech Zabolotny wrote:
> >On Sat, Oct 26, 2013 at 1:41 AM, Arnout Vandecappelle <arnout@mind.be> wrote:
> >> Also, when sending an update, it is customary to add v2 to the subject
> >> so
> >>people can see which version is the latest one. You can do that by calling
> >>git send-email -v2 # Since git 1.8.x
> >>or
> >>git send-email --subject-prefix='PATCH v2'
> >
> >It seems, that the above should be applied to git format-patch, not
> >git send-email?
>
> You're right, but git send-email takes (almost) all of the options
> of git format-patch if you let it generate patches directly (e.g.
> with 'git send-email -1). Normally I don't bother with generating
> the patches separately and just mail them immediately - and I
> assumed that the rest of the world does the same :-).
How do you add patch version changelog then?
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 1/1] python-pyusb: new package
2013-10-28 8:10 ` Baruch Siach
@ 2013-10-28 8:24 ` Arnout Vandecappelle
2013-10-28 8:40 ` Baruch Siach
0 siblings, 1 reply; 28+ messages in thread
From: Arnout Vandecappelle @ 2013-10-28 8:24 UTC (permalink / raw)
To: buildroot
On 28/10/13 09:10, Baruch Siach wrote:
> Hi Arnout,
>
> On Mon, Oct 28, 2013 at 08:12:21AM +0100, Arnout Vandecappelle wrote:
>> On 26/10/13 09:33, Wojciech Zabolotny wrote:
>>> On Sat, Oct 26, 2013 at 1:41 AM, Arnout Vandecappelle <arnout@mind.be> wrote:
>>>> Also, when sending an update, it is customary to add v2 to the subject
>>>> so
>>>> people can see which version is the latest one. You can do that by calling
>>>> git send-email -v2 # Since git 1.8.x
>>>> or
>>>> git send-email --subject-prefix='PATCH v2'
>>>
>>> It seems, that the above should be applied to git format-patch, not
>>> git send-email?
>>
>> You're right, but git send-email takes (almost) all of the options
>> of git format-patch if you let it generate patches directly (e.g.
>> with 'git send-email -1). Normally I don't bother with generating
>> the patches separately and just mail them immediately - and I
>> assumed that the rest of the world does the same :-).
>
> How do you add patch version changelog then?
Manually with git commit --amend.
There is no way AFAIK to ensure consistency between the patch changelog
and the -v option you pass to send-email/format-patch. There are a few
tools like topgit and guilt that are supposed to make it easier to manage
a patch with changelog, but I found them difficult to use.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 1/1] python-pyusb: new package
2013-10-28 8:24 ` Arnout Vandecappelle
@ 2013-10-28 8:40 ` Baruch Siach
2013-10-28 8:47 ` Arnout Vandecappelle
0 siblings, 1 reply; 28+ messages in thread
From: Baruch Siach @ 2013-10-28 8:40 UTC (permalink / raw)
To: buildroot
Hi Arnout,
On Mon, Oct 28, 2013 at 09:24:59AM +0100, Arnout Vandecappelle wrote:
> On 28/10/13 09:10, Baruch Siach wrote:
> >On Mon, Oct 28, 2013 at 08:12:21AM +0100, Arnout Vandecappelle wrote:
> >>On 26/10/13 09:33, Wojciech Zabolotny wrote:
> >>>On Sat, Oct 26, 2013 at 1:41 AM, Arnout Vandecappelle <arnout@mind.be> wrote:
> >>>> Also, when sending an update, it is customary to add v2 to the subject
> >>>> so
> >>>>people can see which version is the latest one. You can do that by calling
> >>>>git send-email -v2 # Since git 1.8.x
> >>>>or
> >>>>git send-email --subject-prefix='PATCH v2'
> >>>
> >>>It seems, that the above should be applied to git format-patch, not
> >>>git send-email?
> >>
> >> You're right, but git send-email takes (almost) all of the options
> >>of git format-patch if you let it generate patches directly (e.g.
> >>with 'git send-email -1). Normally I don't bother with generating
> >>the patches separately and just mail them immediately - and I
> >>assumed that the rest of the world does the same :-).
>
> >How do you add patch version changelog then?
>
> Manually with git commit --amend.
But with 'commit --amend' you can only edit the log message itself, not the
part below the '---' separator where patches changelog usually go.
baruch
> There is no way AFAIK to ensure consistency between the patch
> changelog and the -v option you pass to send-email/format-patch.
> There are a few tools like topgit and guilt that are supposed to
> make it easier to manage a patch with changelog, but I found them
> difficult to use.
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 1/1] python-pyusb: new package
2013-10-28 8:40 ` Baruch Siach
@ 2013-10-28 8:47 ` Arnout Vandecappelle
2013-10-28 9:03 ` Baruch Siach
0 siblings, 1 reply; 28+ messages in thread
From: Arnout Vandecappelle @ 2013-10-28 8:47 UTC (permalink / raw)
To: buildroot
On 28/10/13 09:40, Baruch Siach wrote:
> Hi Arnout,
>
> On Mon, Oct 28, 2013 at 09:24:59AM +0100, Arnout Vandecappelle wrote:
>> On 28/10/13 09:10, Baruch Siach wrote:
>>> On Mon, Oct 28, 2013 at 08:12:21AM +0100, Arnout Vandecappelle wrote:
>>>> On 26/10/13 09:33, Wojciech Zabolotny wrote:
>>>>> On Sat, Oct 26, 2013 at 1:41 AM, Arnout Vandecappelle <arnout@mind.be> wrote:
>>>>>> Also, when sending an update, it is customary to add v2 to the subject
>>>>>> so
>>>>>> people can see which version is the latest one. You can do that by calling
>>>>>> git send-email -v2 # Since git 1.8.x
>>>>>> or
>>>>>> git send-email --subject-prefix='PATCH v2'
>>>>>
>>>>> It seems, that the above should be applied to git format-patch, not
>>>>> git send-email?
>>>>
>>>> You're right, but git send-email takes (almost) all of the options
>>>> of git format-patch if you let it generate patches directly (e.g.
>>>> with 'git send-email -1). Normally I don't bother with generating
>>>> the patches separately and just mail them immediately - and I
>>>> assumed that the rest of the world does the same :-).
>>
>>> How do you add patch version changelog then?
>>
>> Manually with git commit --amend.
>
> But with 'commit --amend' you can only edit the log message itself, not the
> part below the '---' separator where patches changelog usually go.
Sure you can. The --- separator is only interpreted by git-am (well,
actually the plumbing tool that is called by git-am). So you can update
the things below the --- separator while doing git commit --amend or git
rebase -i.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 1/1] python-pyusb: new package
2013-10-28 8:47 ` Arnout Vandecappelle
@ 2013-10-28 9:03 ` Baruch Siach
0 siblings, 0 replies; 28+ messages in thread
From: Baruch Siach @ 2013-10-28 9:03 UTC (permalink / raw)
To: buildroot
Hi Arnout,
On Mon, Oct 28, 2013 at 09:47:17AM +0100, Arnout Vandecappelle wrote:
> On 28/10/13 09:40, Baruch Siach wrote:
> >On Mon, Oct 28, 2013 at 09:24:59AM +0100, Arnout Vandecappelle wrote:
> >>On 28/10/13 09:10, Baruch Siach wrote:
> >>>On Mon, Oct 28, 2013 at 08:12:21AM +0100, Arnout Vandecappelle wrote:
> >>>>On 26/10/13 09:33, Wojciech Zabolotny wrote:
> >>>>>On Sat, Oct 26, 2013 at 1:41 AM, Arnout Vandecappelle <arnout@mind.be> wrote:
> >>>>>> Also, when sending an update, it is customary to add v2 to the subject
> >>>>>> so
> >>>>>>people can see which version is the latest one. You can do that by calling
> >>>>>>git send-email -v2 # Since git 1.8.x
> >>>>>>or
> >>>>>>git send-email --subject-prefix='PATCH v2'
> >>>>>
> >>>>>It seems, that the above should be applied to git format-patch, not
> >>>>>git send-email?
> >>>>
> >>>> You're right, but git send-email takes (almost) all of the options
> >>>>of git format-patch if you let it generate patches directly (e.g.
> >>>>with 'git send-email -1). Normally I don't bother with generating
> >>>>the patches separately and just mail them immediately - and I
> >>>>assumed that the rest of the world does the same :-).
> >>
> >>>How do you add patch version changelog then?
> >>
> >> Manually with git commit --amend.
> >
> >But with 'commit --amend' you can only edit the log message itself, not the
> >part below the '---' separator where patches changelog usually go.
>
> Sure you can. The --- separator is only interpreted by git-am
> (well, actually the plumbing tool that is called by git-am). So you
> can update the things below the --- separator while doing git commit
> --amend or git rebase -i.
Nice trick. Should save me a lot of time. Thanks.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH v2 1/1] jack2: new package
2013-10-27 19:50 ` [Buildroot] [PATCH v2 " Wojciech M. Zabolotny
@ 2013-10-28 19:27 ` Thomas Petazzoni
2013-10-29 18:55 ` [Buildroot] [PATCH v3 " Wojciech M. Zabolotny
0 siblings, 1 reply; 28+ messages in thread
From: Thomas Petazzoni @ 2013-10-28 19:27 UTC (permalink / raw)
To: buildroot
Dear Wojciech M. Zabolotny,
On Sun, 27 Oct 2013 20:50:56 +0100, Wojciech M. Zabolotny wrote:
> Signed-off-by: Wojciech M. Zabolotny <wzab01@gmail.com>
> ---
> I have modified patch introducing the new "jack2" package, according
> to suggestions received from Thomas De Schampheleire and Thomas Petazzoni
> (corrections of formatting, dependencies and downloading of source form git).
Thanks for the followup patch. Some comments below.
> new file mode 100644
> index 0000000..0fb6ca2
> --- /dev/null
> +++ b/package/jack2/Config.in
> @@ -0,0 +1,23 @@
> +config BR2_PACKAGE_JACK2
> + bool "jack2"
> + depends on BR2_LARGEFILE
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> + select BR2_PACKAGE_LIBSAMPLERATE
> + select BR2_PACKAGE_LIBSNDFILE
> + select BR2_PACKAGE_ALSA_LIB
> + help
> + JACK Audio Connection Kit (server and example clients)
> + JACK is a low-latency sound server, allowing multiple applications to
> + connect to one audio device, and to share audio between themselves.
> + This package contains the daemon jackd as well as some example clients.
> +
> + http://jackaudio.org/
> +
> +comment "jack2 uses libsndfile which requires a toolchain with LARGEFILE support"
> + depends on !BR2_LARGEFILE
> +
> +comment "jack2 uses alsa-lib which requires a toolchain with threads support"
> + depends on !BR2_TOOLCHAIN_HAS_THREADS
These comments should be only one comment. See also the recent commit
c3a832a7fb26fed8fd7834e96f09e3565b637f69, which updated the manual to
explain how such comments should be written.
> +
> +
> +
These empty new lines are not needed.
> diff --git a/package/jack2/jack2.mk b/package/jack2/jack2.mk
> new file mode 100644
> index 0000000..5ab751f
> --- /dev/null
> +++ b/package/jack2/jack2.mk
> @@ -0,0 +1,31 @@
> +################################################################################
> +#
> +# jack2
> +#
> +################################################################################
> +
> +JACK2_VERSION = 37976441044d69b91d61d8f6278949a39cf1b7b7
> +JACK2_SITE = http://github.com/jackaudio/jack2/tarball/$(JACK2_VERSION)
> +JACK2_LICENSE = LGPLv2.1+
> +JACK2_DEPENDENCIES = \
> + libsamplerate \
> + libsndfile
You have selected BR2_PACKAGE_ALSA_LIB above, but you don't depend on
them. Unless alsa-lib is a runtime-only dependency, and not a
build-dependency, this is wrong.
Also, I believe that since the dependency list is not too long, putting
it on one line is ok:
JACK2_DEPENDENCIES = libsamplerate libsndfile alsa-lib
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH v3 1/1] jack2: new package
2013-10-28 19:27 ` Thomas Petazzoni
@ 2013-10-29 18:55 ` Wojciech M. Zabolotny
2013-10-29 19:34 ` Thomas Petazzoni
0 siblings, 1 reply; 28+ messages in thread
From: Wojciech M. Zabolotny @ 2013-10-29 18:55 UTC (permalink / raw)
To: buildroot
Signed-off-by: Wojciech M. Zabolotny <wzab01@gmail.com>
---
package/Config.in | 1 +
package/jack2/Config.in | 17 +++++++++++++++++
package/jack2/jack2.mk | 29 +++++++++++++++++++++++++++++
3 files changed, 47 insertions(+)
create mode 100644 package/jack2/Config.in
create mode 100644 package/jack2/jack2.mk
diff --git a/package/Config.in b/package/Config.in
index 4c4da51..bf297a8 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -11,6 +11,7 @@ source "package/ffmpeg/Config.in"
source "package/flac/Config.in"
source "package/gstreamer/Config.in"
source "package/gstreamer1/Config.in"
+source "package/jack2/Config.in"
source "package/lame/Config.in"
source "package/libvpx/Config.in"
source "package/madplay/Config.in"
diff --git a/package/jack2/Config.in b/package/jack2/Config.in
new file mode 100644
index 0000000..68cafd4
--- /dev/null
+++ b/package/jack2/Config.in
@@ -0,0 +1,17 @@
+config BR2_PACKAGE_JACK2
+ bool "jack2"
+ depends on BR2_LARGEFILE
+ depends on BR2_TOOLCHAIN_HAS_THREADS
+ select BR2_PACKAGE_LIBSAMPLERATE
+ select BR2_PACKAGE_LIBSNDFILE
+ select BR2_PACKAGE_ALSA_LIB
+ help
+ JACK Audio Connection Kit (server and example clients)
+ JACK is a low-latency sound server, allowing multiple applications to
+ connect to one audio device, and to share audio between themselves.
+ This package contains the daemon jackd as well as some example clients.
+
+ http://jackaudio.org/
+
+comment "jack2 needs a toolchain w/ largefile and threads"
+ depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/jack2/jack2.mk b/package/jack2/jack2.mk
new file mode 100644
index 0000000..1fed146
--- /dev/null
+++ b/package/jack2/jack2.mk
@@ -0,0 +1,29 @@
+################################################################################
+#
+# jack2
+#
+################################################################################
+
+JACK2_VERSION = 37976441044d69b91d61d8f6278949a39cf1b7b7
+JACK2_SITE = http://github.com/jackaudio/jack2/tarball/$(JACK2_VERSION)
+JACK2_LICENSE = LGPLv2.1+
+JACK2_DEPENDENCIES = libsamplerate libsndfile alsa-lib
+
+define JACK2_CONFIGURE_CMDS
+ (cd $(@D); \
+ $(TARGET_CONFIGURE_OPTS) \
+ ./waf configure \
+ --prefix=/usr \
+ --alsa \
+ )
+endef
+
+define JACK2_BUILD_CMDS
+ (cd $(@D); ./waf build -j $(PARALLEL_JOBS))
+endef
+
+define JACK2_INSTALL_TARGET_CMDS
+ (cd $(@D); ./waf --destdir=$(TARGET_DIR) install)
+endef
+
+$(eval $(generic-package))
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH v3 1/1] jack2: new package
2013-10-29 18:55 ` [Buildroot] [PATCH v3 " Wojciech M. Zabolotny
@ 2013-10-29 19:34 ` Thomas Petazzoni
2013-10-30 0:00 ` Wojciech Zabolotny
0 siblings, 1 reply; 28+ messages in thread
From: Thomas Petazzoni @ 2013-10-29 19:34 UTC (permalink / raw)
To: buildroot
Dear Wojciech M. Zabolotny,
On Tue, 29 Oct 2013 19:55:45 +0100, Wojciech M. Zabolotny wrote:
> +JACK2_LICENSE = LGPLv2.1+
I didn't notice until now, but this license specification doesn't seem
to be correct. For example,
https://github.com/jackaudio/jack2/blob/master/linux/alsa/JackAlsaAdapter.cpp
is under GPLv2+. Parts of jack2 seem to be under LGPL, some other parts
under GPL. It should be explained in the <pkg>_LICENSE specification,
with something just as (purely invented example, I haven't analyzed
jack2) :
FOO_LICENSE = GPLv2+ (this part and this part), LGPLv2.1+ (this other part)
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH v3 1/1] jack2: new package
2013-10-29 19:34 ` Thomas Petazzoni
@ 2013-10-30 0:00 ` Wojciech Zabolotny
2013-10-30 0:14 ` Thomas Petazzoni
0 siblings, 1 reply; 28+ messages in thread
From: Wojciech Zabolotny @ 2013-10-30 0:00 UTC (permalink / raw)
To: buildroot
Dear Thomas,
Yes, you are right. Unfortunately there is no single file with
licensing information in jack sources themselves.
Checking of individual files seems to be very inefficient.
Can we rely on information published on this website:
http://jackaudio.org/files/docs/html/index.html ?
Quoting from there:
License
Copyright (C) 2001-2011 by Paul Davis, Stephane Letz, Jack O'Quinn,
Torben Hohn and others.
JACK is free software; you can redistribute it and/or modify it under
the terms of the GNU GPL and LGPL licenses as published by the Free
Software Foundation, <http://www.gnu.org>. The JACK server uses the
GPL, as noted in the source file headers. However, the JACK library is
licensed under the LGPL, allowing proprietary programs to link with it
and use JACK services. You should have received a copy of these
Licenses along with the program; if not, write to the Free Software
Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307,
USA.
This program is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
General Public License for more details.
So finally I'd propose:
JACK2_LICENSE = LGPLv2.1+ (jack library), GPLv2+ (other components)
is it possible to specify
JACK2_LICENSE_SITE = http://jackaudio.org/files/docs/html/index.html
instead of JACK2_LICENSE_FILE (as such file doesn't seem to exist in sources).
Regards,
Wojtek
On Tue, Oct 29, 2013 at 8:34 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Wojciech M. Zabolotny,
>
> On Tue, 29 Oct 2013 19:55:45 +0100, Wojciech M. Zabolotny wrote:
>
>> +JACK2_LICENSE = LGPLv2.1+
>
> I didn't notice until now, but this license specification doesn't seem
> to be correct. For example,
> https://github.com/jackaudio/jack2/blob/master/linux/alsa/JackAlsaAdapter.cpp
> is under GPLv2+. Parts of jack2 seem to be under LGPL, some other parts
> under GPL. It should be explained in the <pkg>_LICENSE specification,
> with something just as (purely invented example, I haven't analyzed
> jack2) :
>
> FOO_LICENSE = GPLv2+ (this part and this part), LGPLv2.1+ (this other part)
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
--
Wojciech M. Zabo?otny
My GPG/PGP keys:
standard: B191 ACF0 7909 83FA 3F9B 450C 407E 3C4B 4569 D119
confidential: 2BF3 F90F 6EA8 7D35 59FD 5080 78ED 33DE 1312 D8F8
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH v3 1/1] jack2: new package
2013-10-30 0:00 ` Wojciech Zabolotny
@ 2013-10-30 0:14 ` Thomas Petazzoni
2013-10-30 15:46 ` [Buildroot] [PATCH v4 " Wojciech M. Zabolotny
0 siblings, 1 reply; 28+ messages in thread
From: Thomas Petazzoni @ 2013-10-30 0:14 UTC (permalink / raw)
To: buildroot
Dear Wojciech Zabolotny,
On Wed, 30 Oct 2013 01:00:11 +0100, Wojciech Zabolotny wrote:
> JACK is free software; you can redistribute it and/or modify it under
> the terms of the GNU GPL and LGPL licenses as published by the Free
> Software Foundation, <http://www.gnu.org>. The JACK server uses the
> GPL, as noted in the source file headers. However, the JACK library is
> licensed under the LGPL, allowing proprietary programs to link with it
> and use JACK services. You should have received a copy of these
> Licenses along with the program; if not, write to the Free Software
> Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307,
> USA.
I believe this information is enough, and I would encode it as below:
JACK2_LICENSE = GPLv2+ (jack server), LGPLv2.1+ (jack library)
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH v4 1/1] jack2: new package
2013-10-30 0:14 ` Thomas Petazzoni
@ 2013-10-30 15:46 ` Wojciech M. Zabolotny
2014-03-07 23:10 ` Thomas Petazzoni
0 siblings, 1 reply; 28+ messages in thread
From: Wojciech M. Zabolotny @ 2013-10-30 15:46 UTC (permalink / raw)
To: buildroot
Signed-off-by: Wojciech M. Zabolotny <wzab01@gmail.com>
---
package/Config.in | 1 +
package/jack2/Config.in | 17 +++++++++++++++++
package/jack2/jack2.mk | 29 +++++++++++++++++++++++++++++
3 files changed, 47 insertions(+)
create mode 100644 package/jack2/Config.in
create mode 100644 package/jack2/jack2.mk
diff --git a/package/Config.in b/package/Config.in
index 4c4da51..bf297a8 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -11,6 +11,7 @@ source "package/ffmpeg/Config.in"
source "package/flac/Config.in"
source "package/gstreamer/Config.in"
source "package/gstreamer1/Config.in"
+source "package/jack2/Config.in"
source "package/lame/Config.in"
source "package/libvpx/Config.in"
source "package/madplay/Config.in"
diff --git a/package/jack2/Config.in b/package/jack2/Config.in
new file mode 100644
index 0000000..2a57c1d
--- /dev/null
+++ b/package/jack2/Config.in
@@ -0,0 +1,17 @@
+config BR2_PACKAGE_JACK2
+ bool "jack2"
+ depends on BR2_LARGEFILE
+ depends on BR2_TOOLCHAIN_HAS_THREADS
+ select BR2_PACKAGE_LIBSAMPLERATE
+ select BR2_PACKAGE_LIBSNDFILE
+ select BR2_PACKAGE_ALSA_LIB
+ help
+ JACK Audio Connection Kit (server and example clients)
+ JACK is a low-latency sound server, allowing multiple applications to
+ connect to one audio device, and to share audio between themselves.
+ This package contains the daemon jackd as well as some example clients.
+
+ http://jackaudio.org/
+
+comment "jack2 needs a toolchain w/ largefile and threads"
+ depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
\ No newline at end of file
diff --git a/package/jack2/jack2.mk b/package/jack2/jack2.mk
new file mode 100644
index 0000000..e49ddef
--- /dev/null
+++ b/package/jack2/jack2.mk
@@ -0,0 +1,29 @@
+################################################################################
+#
+# jack2
+#
+################################################################################
+
+JACK2_VERSION = 37976441044d69b91d61d8f6278949a39cf1b7b7
+JACK2_SITE = http://github.com/jackaudio/jack2/tarball/$(JACK2_VERSION)
+JACK2_LICENSE = GPLv2+ (jack server), LGPLv2.1+ (jack library)
+JACK2_DEPENDENCIES = libsamplerate libsndfile alsa-lib
+
+define JACK2_CONFIGURE_CMDS
+ (cd $(@D); \
+ $(TARGET_CONFIGURE_OPTS) \
+ ./waf configure \
+ --prefix=/usr \
+ --alsa \
+ )
+endef
+
+define JACK2_BUILD_CMDS
+ (cd $(@D); ./waf build -j $(PARALLEL_JOBS))
+endef
+
+define JACK2_INSTALL_TARGET_CMDS
+ (cd $(@D); ./waf --destdir=$(TARGET_DIR) install)
+endef
+
+$(eval $(generic-package))
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH v4 1/1] jack2: new package
2013-10-30 15:46 ` [Buildroot] [PATCH v4 " Wojciech M. Zabolotny
@ 2014-03-07 23:10 ` Thomas Petazzoni
0 siblings, 0 replies; 28+ messages in thread
From: Thomas Petazzoni @ 2014-03-07 23:10 UTC (permalink / raw)
To: buildroot
Dear Wojciech M. Zabolotny,
On Wed, 30 Oct 2013 16:46:01 +0100, Wojciech M. Zabolotny wrote:
> Signed-off-by: Wojciech M. Zabolotny <wzab01@gmail.com>
> ---
> package/Config.in | 1 +
> package/jack2/Config.in | 17 +++++++++++++++++
> package/jack2/jack2.mk | 29 +++++++++++++++++++++++++++++
> 3 files changed, 47 insertions(+)
> create mode 100644 package/jack2/Config.in
> create mode 100644 package/jack2/jack2.mk
Applied, thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 28+ messages in thread
end of thread, other threads:[~2014-03-07 23:10 UTC | newest]
Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-25 12:54 [Buildroot] [PATCH 1/1] Added pyusb as a package Wojciech M. Zabolotny
2013-10-25 15:26 ` Ryan Barnett
2013-10-25 16:50 ` Thomas De Schampheleire
2013-10-24 23:42 ` [Buildroot] [PATCH 1/1] Added jack2 as a package. Due to alignment errors on ARM platform, git sources are used Wojciech M. Zabolotny
2013-10-24 23:48 ` Wojciech Zabolotny
2013-10-25 23:36 ` [Buildroot] [PATCH 1/1] jack2: new package Wojciech M. Zabolotny
2013-10-27 17:10 ` Thomas Petazzoni
2013-10-27 19:50 ` [Buildroot] [PATCH v2 " Wojciech M. Zabolotny
2013-10-28 19:27 ` Thomas Petazzoni
2013-10-29 18:55 ` [Buildroot] [PATCH v3 " Wojciech M. Zabolotny
2013-10-29 19:34 ` Thomas Petazzoni
2013-10-30 0:00 ` Wojciech Zabolotny
2013-10-30 0:14 ` Thomas Petazzoni
2013-10-30 15:46 ` [Buildroot] [PATCH v4 " Wojciech M. Zabolotny
2014-03-07 23:10 ` Thomas Petazzoni
2013-10-25 23:15 ` [Buildroot] [PATCH 1/1] python-pyusb: " Wojciech M. Zabolotny
2013-10-25 23:41 ` Arnout Vandecappelle
2013-10-26 7:25 ` Wojciech M. Zabolotny
2013-10-26 7:35 ` [Buildroot] [PATCH v2 " Wojciech M. Zabolotny
2013-10-26 7:33 ` [Buildroot] [PATCH " Wojciech Zabolotny
2013-10-28 7:12 ` Arnout Vandecappelle
2013-10-28 8:10 ` Baruch Siach
2013-10-28 8:24 ` Arnout Vandecappelle
2013-10-28 8:40 ` Baruch Siach
2013-10-28 8:47 ` Arnout Vandecappelle
2013-10-28 9:03 ` Baruch Siach
2013-10-25 23:05 [Buildroot] [PATCH 1/1] Package python-pyusb added Wojciech M. Zabolotny
2013-10-25 23:09 ` Wojciech Zabolotny
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.