All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] lib/drmtest: Scream harder when igt_exit isn't called for subtest tests
@ 2013-10-29 10:35 Daniel Vetter
  0 siblings, 0 replies; only message in thread
From: Daniel Vetter @ 2013-10-29 10:35 UTC (permalink / raw)
  To: Intel Graphics Development; +Cc: Daniel Vetter

We really need this since otherwise the magic return value handling
for running testcases with piglit (or on QA's validation
infrastructure) doesn't work properly.

We need to be careful though to only install this check on success.

See also the previous commits to sprinkle igt_exit() calls over all
the tests that missed it.

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 lib/drmtest.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/drmtest.c b/lib/drmtest.c
index 8164ef9..576b4ab 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -812,8 +812,6 @@ int igt_subtest_init_parse_opts(int argc, char **argv,
 		case 'l':
 			if (!run_single_subtest)
 				list_subtests = true;
-			else
-				igt_install_exit_handler(check_igt_exit);
 			break;
 		case 'r':
 			if (!list_subtests)
@@ -842,6 +840,8 @@ int igt_subtest_init_parse_opts(int argc, char **argv,
 		}
 	}
 
+	igt_install_exit_handler(check_igt_exit);
+
 out:
 	return ret;
 }
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2013-10-29 10:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-29 10:35 [PATCH] lib/drmtest: Scream harder when igt_exit isn't called for subtest tests Daniel Vetter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.