* [PATCH v2] mvneta: drop redundant mac address check
@ 2013-10-29 23:10 Luka Perkov
2013-10-30 2:53 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Luka Perkov @ 2013-10-29 23:10 UTC (permalink / raw)
To: netdev; +Cc: Luka Perkov, David Miller
Checking if MAC address is valid using is_valid_ether_addr() is already done in
of_get_mac_address().
Signed-off-by: Luka Perkov <luka@openwrt.org>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
CC: David Miller <davem@davemloft.net>
---
v1->v2:
* cosmetic commit message fix based on comment from David Miller
---
drivers/net/ethernet/marvell/mvneta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index e35bac7..7d99e695 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -2811,7 +2811,7 @@ static int mvneta_probe(struct platform_device *pdev)
}
dt_mac_addr = of_get_mac_address(dn);
- if (dt_mac_addr && is_valid_ether_addr(dt_mac_addr)) {
+ if (dt_mac_addr) {
mac_from = "device tree";
memcpy(dev->dev_addr, dt_mac_addr, ETH_ALEN);
} else {
--
1.8.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] mvneta: drop redundant mac address check
2013-10-29 23:10 [PATCH v2] mvneta: drop redundant mac address check Luka Perkov
@ 2013-10-30 2:53 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-10-30 2:53 UTC (permalink / raw)
To: luka; +Cc: netdev
From: Luka Perkov <luka@openwrt.org>
Date: Wed, 30 Oct 2013 00:10:01 +0100
> Checking if MAC address is valid using is_valid_ether_addr() is already done in
> of_get_mac_address().
>
> Signed-off-by: Luka Perkov <luka@openwrt.org>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-30 2:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-29 23:10 [PATCH v2] mvneta: drop redundant mac address check Luka Perkov
2013-10-30 2:53 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.