* [PATCH] ath10k: Add logging to better determine some VIF/STA creation failures.
@ 2013-11-04 17:19 greearb
2013-11-08 9:58 ` Kalle Valo
2013-11-12 17:43 ` Kalle Valo
0 siblings, 2 replies; 6+ messages in thread
From: greearb @ 2013-11-04 17:19 UTC (permalink / raw)
To: ath10k; +Cc: kvalo, Ben Greear
From: Ben Greear <greearb@candelatech.com>
---
drivers/net/wireless/ath/ath10k/mac.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index f45eca0..93e52c5 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -322,12 +322,16 @@ static int ath10k_peer_create(struct ath10k *ar, u32 vdev_id, const u8 *addr)
lockdep_assert_held(&ar->conf_mutex);
ret = ath10k_wmi_peer_create(ar, vdev_id, addr);
- if (ret)
+ if (ret) {
+ ath10k_dbg(ATH10K_DBG_WMI, "wmi_peer_create failed: %i\n", ret);
return ret;
+ }
ret = ath10k_wait_for_peer_created(ar, vdev_id, addr);
- if (ret)
+ if (ret) {
+ ath10k_dbg(ATH10K_DBG_WMI, "wmi_wait_for_peer_created failed: %i\n", ret);
return ret;
+ }
return 0;
}
@@ -2404,8 +2408,8 @@ static void ath10k_bss_info_changed(struct ieee80211_hw *hw,
ret = ath10k_peer_create(ar, arvif->vdev_id,
info->bssid);
if (ret)
- ath10k_warn("Failed to add peer: %pM for VDEV: %d\n",
- info->bssid, arvif->vdev_id);
+ ath10k_warn("Failed to add peer: %pM for VDEV: %d ret: %i\n",
+ info->bssid, arvif->vdev_id, ret);
if (vif->type == NL80211_IFTYPE_STATION) {
/*
@@ -2687,8 +2691,8 @@ static int ath10k_sta_state(struct ieee80211_hw *hw,
ret = ath10k_peer_create(ar, arvif->vdev_id, sta->addr);
if (ret)
- ath10k_warn("Failed to add peer: %pM for VDEV: %d\n",
- sta->addr, arvif->vdev_id);
+ ath10k_warn("Failed to add peer: %pM for VDEV: %d, ret: %i\n",
+ sta->addr, arvif->vdev_id, ret);
} else if ((old_state == IEEE80211_STA_NONE &&
new_state == IEEE80211_STA_NOTEXIST)) {
/*
--
1.7.11.7
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: Add logging to better determine some VIF/STA creation failures.
2013-11-04 17:19 [PATCH] ath10k: Add logging to better determine some VIF/STA creation failures greearb
@ 2013-11-08 9:58 ` Kalle Valo
2013-11-08 16:53 ` Ben Greear
2013-11-12 17:43 ` Kalle Valo
1 sibling, 1 reply; 6+ messages in thread
From: Kalle Valo @ 2013-11-08 9:58 UTC (permalink / raw)
To: greearb; +Cc: ath10k
greearb@candelatech.com writes:
> From: Ben Greear <greearb@candelatech.com>
>
I did some changes to this patch:
https://github.com/kvalo/ath/commit/20c062b93a1addc863d15334dd1eb5892a759f78
The patch is still on ath-next-test branch. Please take a look and if
it's ok for you, send you S-o-b tag so that I can apply it (it was
missing).
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: Add logging to better determine some VIF/STA creation failures.
2013-11-08 9:58 ` Kalle Valo
@ 2013-11-08 16:53 ` Ben Greear
2013-11-11 9:14 ` Kalle Valo
0 siblings, 1 reply; 6+ messages in thread
From: Ben Greear @ 2013-11-08 16:53 UTC (permalink / raw)
To: Kalle Valo; +Cc: ath10k
On 11/08/2013 01:58 AM, Kalle Valo wrote:
> greearb@candelatech.com writes:
>
>> From: Ben Greear <greearb@candelatech.com>
>>
>
> I did some changes to this patch:
>
> https://github.com/kvalo/ath/commit/20c062b93a1addc863d15334dd1eb5892a759f78
>
> The patch is still on ath-next-test branch. Please take a look and if
> it's ok for you, send you S-o-b tag so that I can apply it (it was
> missing).
This part has some grammar issues, it seems to say that the failure
is due to changed bssid. Maybe make it instead:
Failed to add peer %pM for vdev %d when changing bssid, error: %i
- ath10k_warn("Failed to add peer: %pM for VDEV: %d\n",
- info->bssid, arvif->vdev_id);
+ ath10k_warn("Failed to add peer %pM for vdev %d due to changed bssid: %i\n",
+ info->bssid, arvif->vdev_id, ret);
Either way, it's better than what was there before, so:
Signed-off-by: Ben Greear <greearb@candelatech.com>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: Add logging to better determine some VIF/STA creation failures.
2013-11-08 16:53 ` Ben Greear
@ 2013-11-11 9:14 ` Kalle Valo
2013-11-11 16:55 ` Ben Greear
0 siblings, 1 reply; 6+ messages in thread
From: Kalle Valo @ 2013-11-11 9:14 UTC (permalink / raw)
To: Ben Greear; +Cc: ath10k
Ben Greear <greearb@candelatech.com> writes:
> On 11/08/2013 01:58 AM, Kalle Valo wrote:
>> greearb@candelatech.com writes:
>>
>>> From: Ben Greear <greearb@candelatech.com>
>>>
>>
>> I did some changes to this patch:
>>
>> https://github.com/kvalo/ath/commit/20c062b93a1addc863d15334dd1eb5892a759f78
>>
>> The patch is still on ath-next-test branch. Please take a look and if
>> it's ok for you, send you S-o-b tag so that I can apply it (it was
>> missing).
>
> This part has some grammar issues, it seems to say that the failure
> is due to changed bssid. Maybe make it instead:
>
> Failed to add peer %pM for vdev %d when changing bssid, error: %i
>
> - ath10k_warn("Failed to add peer: %pM for VDEV: %d\n",
> - info->bssid, arvif->vdev_id);
> + ath10k_warn("Failed to add peer %pM for vdev %d due to changed bssid: %i\n",
> + info->bssid, arvif->vdev_id, ret);
>
> Either way, it's better than what was there before, so:
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
Good point, thanks. I just didn't use the word error as I thought that
wasn't necessary. New version which I'll apply soon:
https://github.com/kvalo/ath/commit/ee309046323f2af1d2cd6f5c1361a6ce8dae5f87
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: Add logging to better determine some VIF/STA creation failures.
2013-11-11 9:14 ` Kalle Valo
@ 2013-11-11 16:55 ` Ben Greear
0 siblings, 0 replies; 6+ messages in thread
From: Ben Greear @ 2013-11-11 16:55 UTC (permalink / raw)
To: Kalle Valo; +Cc: ath10k
On 11/11/2013 01:14 AM, Kalle Valo wrote:
> Ben Greear <greearb@candelatech.com> writes:
>
>> On 11/08/2013 01:58 AM, Kalle Valo wrote:
>>> greearb@candelatech.com writes:
>>>
>>>> From: Ben Greear <greearb@candelatech.com>
>>>>
>>>
>>> I did some changes to this patch:
>>>
>>> https://github.com/kvalo/ath/commit/20c062b93a1addc863d15334dd1eb5892a759f78
>>>
>>> The patch is still on ath-next-test branch. Please take a look and if
>>> it's ok for you, send you S-o-b tag so that I can apply it (it was
>>> missing).
>>
>> This part has some grammar issues, it seems to say that the failure
>> is due to changed bssid. Maybe make it instead:
>>
>> Failed to add peer %pM for vdev %d when changing bssid, error: %i
>>
>> - ath10k_warn("Failed to add peer: %pM for VDEV: %d\n",
>> - info->bssid, arvif->vdev_id);
>> + ath10k_warn("Failed to add peer %pM for vdev %d due to changed bssid: %i\n",
>> + info->bssid, arvif->vdev_id, ret);
>>
>> Either way, it's better than what was there before, so:
>>
>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>
> Good point, thanks. I just didn't use the word error as I thought that
> wasn't necessary. New version which I'll apply soon:
>
> https://github.com/kvalo/ath/commit/ee309046323f2af1d2cd6f5c1361a6ce8dae5f87
>
Looks good.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: Add logging to better determine some VIF/STA creation failures.
2013-11-04 17:19 [PATCH] ath10k: Add logging to better determine some VIF/STA creation failures greearb
2013-11-08 9:58 ` Kalle Valo
@ 2013-11-12 17:43 ` Kalle Valo
1 sibling, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2013-11-12 17:43 UTC (permalink / raw)
To: greearb; +Cc: ath10k
Thanks, applied with these changes:
commit 479398b07048342c7fdca89fd3a6cdb739e48a86
Author: Ben Greear <greearb@candelatech.com>
Date: Mon Nov 4 09:19:34 2013 -0800
ath10k: add logging to better determine some VIF/STA creation failures
Not all errors were properly notified, fix that.
kvalo: use ath10k_warn() for all messages, cosmetic changes to some of the messages
Signed-off-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-11-12 17:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-04 17:19 [PATCH] ath10k: Add logging to better determine some VIF/STA creation failures greearb
2013-11-08 9:58 ` Kalle Valo
2013-11-08 16:53 ` Ben Greear
2013-11-11 9:14 ` Kalle Valo
2013-11-11 16:55 ` Ben Greear
2013-11-12 17:43 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.