* [PATCH] Ceph: allocate non-zero page to fscache in readpage()
@ 2013-11-09 2:26 Li Wang
2013-11-09 15:19 ` Milosz Tanski
0 siblings, 1 reply; 3+ messages in thread
From: Li Wang @ 2013-11-09 2:26 UTC (permalink / raw)
To: ceph-devel
Cc: linux-cachefs, Sage Weil, Milosz Tanski, linux-fsdevel,
linux-kernel, Li Wang
ceph_osdc_readpages() returns number of bytes read, currently,
the code only allocate full-zero page into fscache, this patch
fixes this.
Signed-off-by: Li Wang <liwang@ubuntukylin.com>
---
fs/ceph/addr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index 6df8bd4..1e561c0 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -216,7 +216,7 @@ static int readpage_nounlock(struct file *filp, struct page *page)
}
SetPageUptodate(page);
- if (err == 0)
+ if (err >= 0)
ceph_readpage_to_fscache(inode, page);
out:
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Ceph: allocate non-zero page to fscache in readpage()
2013-11-09 2:26 [PATCH] Ceph: allocate non-zero page to fscache in readpage() Li Wang
@ 2013-11-09 15:19 ` Milosz Tanski
2013-11-09 21:52 ` Sage Weil
0 siblings, 1 reply; 3+ messages in thread
From: Milosz Tanski @ 2013-11-09 15:19 UTC (permalink / raw)
To: Li Wang; +Cc: ceph-devel, linux-cachefs, Sage Weil, linux-fsdevel, linux-kernel
Li, that's a good good catch.
On Fri, Nov 8, 2013 at 9:26 PM, Li Wang <liwang@ubuntukylin.com> wrote:
> ceph_osdc_readpages() returns number of bytes read, currently,
> the code only allocate full-zero page into fscache, this patch
> fixes this.
>
> Signed-off-by: Li Wang <liwang@ubuntukylin.com>
> ---
> fs/ceph/addr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> index 6df8bd4..1e561c0 100644
> --- a/fs/ceph/addr.c
> +++ b/fs/ceph/addr.c
> @@ -216,7 +216,7 @@ static int readpage_nounlock(struct file *filp, struct page *page)
> }
> SetPageUptodate(page);
>
> - if (err == 0)
> + if (err >= 0)
> ceph_readpage_to_fscache(inode, page);
>
> out:
> --
> 1.7.9.5
>
--
Milosz Tanski
CTO
10 East 53rd Street, 37th floor
New York, NY 10022
p: 646-253-9055
e: milosz@adfin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Ceph: allocate non-zero page to fscache in readpage()
2013-11-09 15:19 ` Milosz Tanski
@ 2013-11-09 21:52 ` Sage Weil
0 siblings, 0 replies; 3+ messages in thread
From: Sage Weil @ 2013-11-09 21:52 UTC (permalink / raw)
To: Milosz Tanski, Li Wang
Cc: linux-fsdevel, ceph-devel, linux-cachefs, Sage Weil, linux-kernel
Added to the testing branch.
Thanks!
Milosz Tanski <milosz@adfin.com> wrote:
>Li, that's a good good catch.
>
>
>On Fri, Nov 8, 2013 at 9:26 PM, Li Wang <liwang@ubuntukylin.com> wrote:
>> ceph_osdc_readpages() returns number of bytes read, currently,
>> the code only allocate full-zero page into fscache, this patch
>> fixes this.
>>
>> Signed-off-by: Li Wang <liwang@ubuntukylin.com>
>> ---
>> fs/ceph/addr.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
>> index 6df8bd4..1e561c0 100644
>> --- a/fs/ceph/addr.c
>> +++ b/fs/ceph/addr.c
>> @@ -216,7 +216,7 @@ static int readpage_nounlock(struct file *filp,
>struct page *page)
>> }
>> SetPageUptodate(page);
>>
>> - if (err == 0)
>> + if (err >= 0)
>> ceph_readpage_to_fscache(inode, page);
>>
>> out:
>> --
>> 1.7.9.5
>>
>
>
>
>--
>Milosz Tanski
>CTO
>10 East 53rd Street, 37th floor
>New York, NY 10022
>
>p: 646-253-9055
>e: milosz@adfin.com
>--
>To unsubscribe from this list: send the line "unsubscribe ceph-devel"
>in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-09 21:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-09 2:26 [PATCH] Ceph: allocate non-zero page to fscache in readpage() Li Wang
2013-11-09 15:19 ` Milosz Tanski
2013-11-09 21:52 ` Sage Weil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.