All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2 0/5] Add Microblaze internal toolchain
@ 2013-11-12 17:31 Spenser Gilliland
  2013-11-12 17:31 ` [Buildroot] [PATCH v2 1/5] binutils: add microblaze " Spenser Gilliland
                   ` (4 more replies)
  0 siblings, 5 replies; 10+ messages in thread
From: Spenser Gilliland @ 2013-11-12 17:31 UTC (permalink / raw)
  To: buildroot

This patch series adds a Microblaze internal toolchain from the sources at
http://github.com/Xilinx .

Spenser Gilliland (5):
  binutils: add microblaze internal toolchain
  gcc: add microblaze internal toolchain
  glibc: add microblaze internal toolchain
  gdb: add microblaze internal toolchain
  toolchain: enable microblaze toolchain

 package/binutils/Config.in.host                    |    2 +
 package/binutils/binutils.mk                       |    5 +
 package/gcc/4.9-microblaze/100-uclibc-conf.patch   |   15 ++
 .../4.9-microblaze/301-missing-execinfo_h.patch    |   13 ++
 package/gcc/4.9-microblaze/302-c99-snprintf.patch  |   13 ++
 .../305-libmudflap-susv3-legacy.patch              |   49 +++++++
 .../gcc/4.9-microblaze/disable_gc_sections.patch   |  145 ++++++++++++++++++++
 package/gcc/Config.in.host                         |   36 ++++--
 package/gcc/gcc.mk                                 |   12 ++-
 package/gdb/Config.in.host                         |    4 +
 package/gdb/gdb.mk                                 |    9 +-
 package/glibc/glibc.mk                             |   12 ++
 toolchain/Config.in                                |    2 +-
 toolchain/toolchain-buildroot/Config.in            |    4 +-
 14 files changed, 305 insertions(+), 16 deletions(-)
 create mode 100644 package/gcc/4.9-microblaze/100-uclibc-conf.patch
 create mode 100644 package/gcc/4.9-microblaze/301-missing-execinfo_h.patch
 create mode 100644 package/gcc/4.9-microblaze/302-c99-snprintf.patch
 create mode 100644 package/gcc/4.9-microblaze/305-libmudflap-susv3-legacy.patch
 create mode 100644 package/gcc/4.9-microblaze/disable_gc_sections.patch

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Buildroot] [PATCH v2 1/5] binutils: add microblaze internal toolchain
  2013-11-12 17:31 [Buildroot] [PATCH v2 0/5] Add Microblaze internal toolchain Spenser Gilliland
@ 2013-11-12 17:31 ` Spenser Gilliland
  2013-11-12 17:31 ` [Buildroot] [PATCH v2 2/5] gcc: " Spenser Gilliland
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 10+ messages in thread
From: Spenser Gilliland @ 2013-11-12 17:31 UTC (permalink / raw)
  To: buildroot


Signed-off-by: Spenser Gilliland <spenser@gillilanding.com>
---
 package/binutils/Config.in.host |    2 ++
 package/binutils/binutils.mk    |    5 +++++
 2 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/package/binutils/Config.in.host b/package/binutils/Config.in.host
index 8f19597..e43261b 100644
--- a/package/binutils/Config.in.host
+++ b/package/binutils/Config.in.host
@@ -3,6 +3,7 @@ comment "Binutils Options"
 choice
 	prompt "Binutils Version"
 	depends on !BR2_arc
+	depends on !BR2_microblaze
 	default BR2_BINUTILS_VERSION_2_21 if (BR2_mips || BR2_mipsel || BR2_sh)
 	default BR2_BINUTILS_VERSION_2_22
 	help
@@ -45,6 +46,7 @@ config BR2_BINUTILS_VERSION
 	string
 	default "2.18-avr32-1.0.1" if BR2_BINUTILS_VERSION_2_18_AVR32_1_0_1
 	default "2.23.2-arc"	if BR2_arc
+	default "2.24.51-microblaze" if BR2_microblaze
 	default "2.20.1"	if BR2_BINUTILS_VERSION_2_20_1
 	default "2.21"		if BR2_BINUTILS_VERSION_2_21
 	default "2.21.1"	if BR2_BINUTILS_VERSION_2_21_1
diff --git a/package/binutils/binutils.mk b/package/binutils/binutils.mk
index f1723b2..0d809c1 100644
--- a/package/binutils/binutils.mk
+++ b/package/binutils/binutils.mk
@@ -29,6 +29,11 @@ endif
 ifeq ($(BR2_arc),y)
 BINUTILS_SITE = $(BR2_ARC_SITE)
 endif
+ifeq ($(BR2_microblaze),y)
+BINUTILS_VERSION = 8351467c933d277ebea0c8d99ad2b65b5f7b6bc2
+BINUTILS_SITE = http://github.com/Xilinx/binutils/tarball/$(BINUTILS_VERSION)
+BINUTILS_SOURCE = binutils-$(BINUTILS_VERSION).tar.gz
+endif
 BINUTILS_EXTRA_CONFIG_OPTIONS = $(call qstrip,$(BR2_BINUTILS_EXTRA_CONFIG_OPTIONS))
 BINUTILS_INSTALL_STAGING = YES
 BINUTILS_DEPENDENCIES = $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext)
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [Buildroot] [PATCH v2 2/5] gcc: add microblaze internal toolchain
  2013-11-12 17:31 [Buildroot] [PATCH v2 0/5] Add Microblaze internal toolchain Spenser Gilliland
  2013-11-12 17:31 ` [Buildroot] [PATCH v2 1/5] binutils: add microblaze " Spenser Gilliland
@ 2013-11-12 17:31 ` Spenser Gilliland
  2013-11-12 21:07   ` Thomas Petazzoni
  2013-11-12 17:31 ` [Buildroot] [PATCH v2 3/5] glibc: " Spenser Gilliland
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 10+ messages in thread
From: Spenser Gilliland @ 2013-11-12 17:31 UTC (permalink / raw)
  To: buildroot


Signed-off-by: Spenser Gilliland <spenser@gillilanding.com>
---
 package/gcc/4.9-microblaze/100-uclibc-conf.patch   |   15 ++
 .../4.9-microblaze/301-missing-execinfo_h.patch    |   13 ++
 package/gcc/4.9-microblaze/302-c99-snprintf.patch  |   13 ++
 .../305-libmudflap-susv3-legacy.patch              |   49 +++++++
 .../gcc/4.9-microblaze/disable_gc_sections.patch   |  145 ++++++++++++++++++++
 package/gcc/Config.in.host                         |   36 ++++--
 package/gcc/gcc.mk                                 |   12 ++-
 7 files changed, 271 insertions(+), 12 deletions(-)
 create mode 100644 package/gcc/4.9-microblaze/100-uclibc-conf.patch
 create mode 100644 package/gcc/4.9-microblaze/301-missing-execinfo_h.patch
 create mode 100644 package/gcc/4.9-microblaze/302-c99-snprintf.patch
 create mode 100644 package/gcc/4.9-microblaze/305-libmudflap-susv3-legacy.patch
 create mode 100644 package/gcc/4.9-microblaze/disable_gc_sections.patch

diff --git a/package/gcc/4.9-microblaze/100-uclibc-conf.patch b/package/gcc/4.9-microblaze/100-uclibc-conf.patch
new file mode 100644
index 0000000..d56bf0a
--- /dev/null
+++ b/package/gcc/4.9-microblaze/100-uclibc-conf.patch
@@ -0,0 +1,15 @@
+Index: gcc-4.8.0/contrib/regression/objs-gcc.sh
+===================================================================
+--- gcc-4.8.0.orig/contrib/regression/objs-gcc.sh	2009-04-09 17:00:19.000000000 +0200
++++ gcc-4.8.0/contrib/regression/objs-gcc.sh	2013-03-23 17:39:04.000000000 +0100
+@@ -106,6 +106,10 @@
+  then
+   make all-gdb all-dejagnu all-ld || exit 1
+   make install-gdb install-dejagnu install-ld || exit 1
++elif [ $H_REAL_TARGET = $H_REAL_HOST -a $H_REAL_TARGET = i686-pc-linux-uclibc ]
++ then
++  make all-gdb all-dejagnu all-ld || exit 1
++  make install-gdb install-dejagnu install-ld || exit 1
+ elif [ $H_REAL_TARGET = $H_REAL_HOST ] ; then
+   make bootstrap || exit 1
+   make install || exit 1
diff --git a/package/gcc/4.9-microblaze/301-missing-execinfo_h.patch b/package/gcc/4.9-microblaze/301-missing-execinfo_h.patch
new file mode 100644
index 0000000..00efda2
--- /dev/null
+++ b/package/gcc/4.9-microblaze/301-missing-execinfo_h.patch
@@ -0,0 +1,13 @@
+Index: gcc-4.8.0/boehm-gc/include/gc.h
+===================================================================
+--- gcc-4.8.0.orig/boehm-gc/include/gc.h	2007-04-23 23:10:09.000000000 +0200
++++ gcc-4.8.0/boehm-gc/include/gc.h	2013-03-23 17:39:20.000000000 +0100
+@@ -503,7 +503,7 @@
+ #if defined(__linux__) || defined(__GLIBC__)
+ # include <features.h>
+ # if (__GLIBC__ == 2 && __GLIBC_MINOR__ >= 1 || __GLIBC__ > 2) \
+-     && !defined(__ia64__)
++     && !defined(__ia64__) && !defined(__UCLIBC__)
+ #   ifndef GC_HAVE_BUILTIN_BACKTRACE
+ #     define GC_HAVE_BUILTIN_BACKTRACE
+ #   endif
diff --git a/package/gcc/4.9-microblaze/302-c99-snprintf.patch b/package/gcc/4.9-microblaze/302-c99-snprintf.patch
new file mode 100644
index 0000000..cd4d2cc
--- /dev/null
+++ b/package/gcc/4.9-microblaze/302-c99-snprintf.patch
@@ -0,0 +1,13 @@
+Index: gcc-4.8.0/libstdc++-v3/include/c_global/cstdio
+===================================================================
+--- gcc-4.8.0.orig/libstdc++-v3/include/c_global/cstdio	2013-02-03 18:54:05.000000000 +0100
++++ gcc-4.8.0/libstdc++-v3/include/c_global/cstdio	2013-03-23 17:39:32.000000000 +0100
+@@ -138,7 +138,7 @@
+   using ::vsprintf;
+ } // namespace
+ 
+-#if _GLIBCXX_USE_C99
++#if _GLIBCXX_USE_C99 || defined __UCLIBC__
+ 
+ #undef snprintf
+ #undef vfscanf
diff --git a/package/gcc/4.9-microblaze/305-libmudflap-susv3-legacy.patch b/package/gcc/4.9-microblaze/305-libmudflap-susv3-legacy.patch
new file mode 100644
index 0000000..35d5f50
--- /dev/null
+++ b/package/gcc/4.9-microblaze/305-libmudflap-susv3-legacy.patch
@@ -0,0 +1,49 @@
+Index: gcc-4.8.0/libmudflap/mf-hooks2.c
+===================================================================
+--- gcc-4.8.0.orig/libmudflap/mf-hooks2.c	2013-02-03 18:48:05.000000000 +0100
++++ gcc-4.8.0/libmudflap/mf-hooks2.c	2013-03-23 17:39:43.000000000 +0100
+@@ -424,7 +424,7 @@
+ {
+   TRACE ("%s\n", __PRETTY_FUNCTION__);
+   MF_VALIDATE_EXTENT(s, n, __MF_CHECK_WRITE, "bzero region");
+-  bzero (s, n);
++  memset (s, 0, n);
+ }
+ 
+ 
+@@ -434,7 +434,7 @@
+   TRACE ("%s\n", __PRETTY_FUNCTION__);
+   MF_VALIDATE_EXTENT(src, n, __MF_CHECK_READ, "bcopy src");
+   MF_VALIDATE_EXTENT(dest, n, __MF_CHECK_WRITE, "bcopy dest");
+-  bcopy (src, dest, n);
++  memmove (dest, src, n);
+ }
+ 
+ 
+@@ -444,7 +444,7 @@
+   TRACE ("%s\n", __PRETTY_FUNCTION__);
+   MF_VALIDATE_EXTENT(s1, n, __MF_CHECK_READ, "bcmp 1st arg");
+   MF_VALIDATE_EXTENT(s2, n, __MF_CHECK_READ, "bcmp 2nd arg");
+-  return bcmp (s1, s2, n);
++  return n == 0 ? 0 : memcmp (s1, s2, n);
+ }
+ 
+ 
+@@ -453,7 +453,7 @@
+   size_t n = strlen (s);
+   TRACE ("%s\n", __PRETTY_FUNCTION__);
+   MF_VALIDATE_EXTENT(s, CLAMPADD(n, 1), __MF_CHECK_READ, "index region");
+-  return index (s, c);
++  return strchr (s, c);
+ }
+ 
+ 
+@@ -462,7 +462,7 @@
+   size_t n = strlen (s);
+   TRACE ("%s\n", __PRETTY_FUNCTION__);
+   MF_VALIDATE_EXTENT(s, CLAMPADD(n, 1), __MF_CHECK_READ, "rindex region");
+-  return rindex (s, c);
++  return strrchr (s, c);
+ }
+ 
+ /* XXX:  stpcpy, memccpy */
diff --git a/package/gcc/4.9-microblaze/disable_gc_sections.patch b/package/gcc/4.9-microblaze/disable_gc_sections.patch
new file mode 100644
index 0000000..46a3a26
--- /dev/null
+++ b/package/gcc/4.9-microblaze/disable_gc_sections.patch
@@ -0,0 +1,145 @@
+From be904b178fc0858ad41a3c2fbc13b388bd1ff465 Mon Sep 17 00:00:00 2001
+From: Mischa Jonker <mjonker@synopsys.com>
+Date: Mon, 15 Jul 2013 11:50:20 +0200
+Subject: [PATCH] libstdc++: Disable gc-sections to work around binutils bug
+
+This is to work around the following error message:
+BFD (GNU Binutils) 2.23.2 assertion fail elf32-arc.c:2140
+
+Signed-off-by: Mischa Jonker <mjonker@synopsys.com>
+---
+ libstdc++-v3/acinclude.m4 |    3 ---
+ libstdc++-v3/configure    |   33 ---------------------------------
+ 2 files changed, 36 deletions(-)
+
+diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4
+index e131214..aa2e375 100644
+--- a/libstdc++-v3/acinclude.m4
++++ b/libstdc++-v3/acinclude.m4
+@@ -296,9 +296,6 @@ AC_DEFUN([GLIBCXX_CHECK_LINKER_FEATURES], [
+       fi
+       rm -f conftest.c conftest.o conftest
+     fi
+-    if test "$ac_gcsections" = "yes"; then
+-      SECTION_LDFLAGS="-Wl,--gc-sections $SECTION_LDFLAGS"
+-    fi
+     AC_MSG_RESULT($ac_gcsections)
+ 
+     if test "$ac_test_CFLAGS" = set; then
+diff --git a/libstdc++-v3/configure b/libstdc++-v3/configure
+index ed049cf..d325e3e 100755
+--- a/libstdc++-v3/configure
++++ b/libstdc++-v3/configure
+@@ -20653,9 +20653,6 @@ rm -f core conftest.err conftest.$ac_objext \
+       fi
+       rm -f conftest.c conftest.o conftest
+     fi
+-    if test "$ac_gcsections" = "yes"; then
+-      SECTION_LDFLAGS="-Wl,--gc-sections $SECTION_LDFLAGS"
+-    fi
+     { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_gcsections" >&5
+ $as_echo "$ac_gcsections" >&6; }
+ 
+@@ -27688,9 +27685,6 @@ rm -f core conftest.err conftest.$ac_objext \
+       fi
+       rm -f conftest.c conftest.o conftest
+     fi
+-    if test "$ac_gcsections" = "yes"; then
+-      SECTION_LDFLAGS="-Wl,--gc-sections $SECTION_LDFLAGS"
+-    fi
+     { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_gcsections" >&5
+ $as_echo "$ac_gcsections" >&6; }
+ 
+@@ -33619,9 +33613,6 @@ rm -f core conftest.err conftest.$ac_objext \
+       fi
+       rm -f conftest.c conftest.o conftest
+     fi
+-    if test "$ac_gcsections" = "yes"; then
+-      SECTION_LDFLAGS="-Wl,--gc-sections $SECTION_LDFLAGS"
+-    fi
+     { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_gcsections" >&5
+ $as_echo "$ac_gcsections" >&6; }
+ 
+@@ -45496,9 +45487,6 @@ rm -f core conftest.err conftest.$ac_objext \
+       fi
+       rm -f conftest.c conftest.o conftest
+     fi
+-    if test "$ac_gcsections" = "yes"; then
+-      SECTION_LDFLAGS="-Wl,--gc-sections $SECTION_LDFLAGS"
+-    fi
+     { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_gcsections" >&5
+ $as_echo "$ac_gcsections" >&6; }
+ 
+@@ -45710,9 +45698,6 @@ rm -f core conftest.err conftest.$ac_objext \
+       fi
+       rm -f conftest.c conftest.o conftest
+     fi
+-    if test "$ac_gcsections" = "yes"; then
+-      SECTION_LDFLAGS="-Wl,--gc-sections $SECTION_LDFLAGS"
+-    fi
+     { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_gcsections" >&5
+ $as_echo "$ac_gcsections" >&6; }
+ 
+@@ -46185,9 +46170,6 @@ rm -f core conftest.err conftest.$ac_objext \
+       fi
+       rm -f conftest.c conftest.o conftest
+     fi
+-    if test "$ac_gcsections" = "yes"; then
+-      SECTION_LDFLAGS="-Wl,--gc-sections $SECTION_LDFLAGS"
+-    fi
+     { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_gcsections" >&5
+ $as_echo "$ac_gcsections" >&6; }
+ 
+@@ -52470,9 +52452,6 @@ rm -f core conftest.err conftest.$ac_objext \
+       fi
+       rm -f conftest.c conftest.o conftest
+     fi
+-    if test "$ac_gcsections" = "yes"; then
+-      SECTION_LDFLAGS="-Wl,--gc-sections $SECTION_LDFLAGS"
+-    fi
+     { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_gcsections" >&5
+ $as_echo "$ac_gcsections" >&6; }
+ 
+@@ -58386,9 +58365,6 @@ rm -f core conftest.err conftest.$ac_objext \
+       fi
+       rm -f conftest.c conftest.o conftest
+     fi
+-    if test "$ac_gcsections" = "yes"; then
+-      SECTION_LDFLAGS="-Wl,--gc-sections $SECTION_LDFLAGS"
+-    fi
+     { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_gcsections" >&5
+ $as_echo "$ac_gcsections" >&6; }
+ 
+@@ -58553,9 +58529,6 @@ rm -f core conftest.err conftest.$ac_objext \
+       fi
+       rm -f conftest.c conftest.o conftest
+     fi
+-    if test "$ac_gcsections" = "yes"; then
+-      SECTION_LDFLAGS="-Wl,--gc-sections $SECTION_LDFLAGS"
+-    fi
+     { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_gcsections" >&5
+ $as_echo "$ac_gcsections" >&6; }
+ 
+@@ -58781,9 +58754,6 @@ rm -f core conftest.err conftest.$ac_objext \
+       fi
+       rm -f conftest.c conftest.o conftest
+     fi
+-    if test "$ac_gcsections" = "yes"; then
+-      SECTION_LDFLAGS="-Wl,--gc-sections $SECTION_LDFLAGS"
+-    fi
+     { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_gcsections" >&5
+ $as_echo "$ac_gcsections" >&6; }
+ 
+@@ -64697,9 +64667,6 @@ rm -f core conftest.err conftest.$ac_objext \
+       fi
+       rm -f conftest.c conftest.o conftest
+     fi
+-    if test "$ac_gcsections" = "yes"; then
+-      SECTION_LDFLAGS="-Wl,--gc-sections $SECTION_LDFLAGS"
+-    fi
+     { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_gcsections" >&5
+ $as_echo "$ac_gcsections" >&6; }
+ 
+-- 
+1.7.9.5
+
diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host
index 41c1213..1c8beba 100644
--- a/package/gcc/Config.in.host
+++ b/package/gcc/Config.in.host
@@ -3,11 +3,18 @@ comment "GCC Options"
 config BR2_GCC_NEEDS_MPC
 	bool
 
+# Until gcc 4.7, a three stage build process was needed when using
+# NPTL. This hidden option tells whether gcc is a version that
+# requires this three stage build process.
+config BR2_GCC_VERSION_NEEDS_THREE_STAGE_BUILD
+	bool
+
 choice
 	prompt "GCC compiler Version"
 	default BR2_GCC_VERSION_4_4_X if BR2_sparc_sparchfleon || BR2_sparc_sparchfleonv8 || BR2_sparc_sparcsfleon || BR2_sparc_sparcsfleonv8
 	default BR2_GCC_VERSION_4_2_2_AVR32_2_1_5 if BR2_avr32
 	default BR2_GCC_VERSION_4_8_ARC if BR2_arc
+	default BR2_GCC_VERSION_4_9_MICROBLAZE if BR2_microblaze
 	default BR2_GCC_VERSION_4_5_X if BR2_bfin
 	default BR2_GCC_VERSION_4_7_X
 	help
@@ -16,39 +23,44 @@ choice
 	config BR2_GCC_VERSION_4_2_2_AVR32_2_1_5
 		depends on BR2_avr32
 		bool "gcc 4.2.2-avr32-2.1.5"
+		select BR2_GCC_VERSION_NEEDS_THREE_STAGE_BUILD
 
 	config BR2_GCC_VERSION_4_3_X
-		depends on !BR2_arc && !BR2_avr32 && !BR2_sparc_sparchfleon && !BR2_sparc_sparchfleonv8 && !BR2_sparc_sparcsfleon && !BR2_sparc_sparcsfleonv8 && !BR2_cortex_a5 && !BR2_cortex_a7 && !BR2_cortex_a8 && !BR2_cortex_a9 && !BR2_cortex_a15 && !BR2_x86_atom && !BR2_powerpc_e300c2 && !BR2_powerpc_e300c3 && !BR2_powerpc_e500mc && !BR2_powerpc_464 && !BR2_powerpc_464fp && !BR2_powerpc_476 && !BR2_powerpc_476fp && !BR2_fa526 && !BR2_pj4
+		depends on !BR2_microblaze && !BR2_arc && !BR2_avr32 && !BR2_sparc_sparchfleon && !BR2_sparc_sparchfleonv8 && !BR2_sparc_sparcsfleon && !BR2_sparc_sparcsfleonv8 && !BR2_cortex_a5 && !BR2_cortex_a7 && !BR2_cortex_a8 && !BR2_cortex_a9 && !BR2_cortex_a15 && !BR2_x86_atom && !BR2_powerpc_e300c2 && !BR2_powerpc_e300c3 && !BR2_powerpc_e500mc && !BR2_powerpc_464 && !BR2_powerpc_464fp && !BR2_powerpc_476 && !BR2_powerpc_476fp && !BR2_fa526 && !BR2_pj4
 		depends on !BR2_ARM_EABIHF
 		bool "gcc 4.3.x"
+		select BR2_GCC_VERSION_NEEDS_THREE_STAGE_BUILD
 
 	config BR2_GCC_VERSION_4_4_X
-		depends on !BR2_arc && !BR2_avr32 && !BR2_cortex_a5 && !BR2_cortex_a7 && !BR2_cortex_a15 && !BR2_x86_atom && !BR2_powerpc_476 && !BR2_powerpc_476fp && !BR2_fa526 && !BR2_pj4
+		depends on !BR2_microblaze && !BR2_arc && !BR2_avr32 && !BR2_cortex_a5 && !BR2_cortex_a7 && !BR2_cortex_a15 && !BR2_x86_atom && !BR2_powerpc_476 && !BR2_powerpc_476fp && !BR2_fa526 && !BR2_pj4
 		bool "gcc 4.4.x"
 		# ARM EABIhf support appeared in gcc 4.6
 		depends on !BR2_ARM_EABIHF
 		# VFPv4 support appeared in gcc 4.5
 		depends on !BR2_ARM_FPU_VFPV4 && !BR2_ARM_FPU_VFPV4D16
+		select BR2_GCC_VERSION_NEEDS_THREE_STAGE_BUILD
 
 	config BR2_GCC_VERSION_4_5_X
-		depends on !BR2_arc && !BR2_avr32 && !BR2_cortex_a7 && !BR2_cortex_a15 && !BR2_sparc_sparchfleon && !BR2_sparc_sparchfleonv8 && !BR2_sparc_sparcsfleon && !BR2_sparc_sparcsfleonv8 && !BR2_fa526 && !BR2_pj4
+		depends on !BR2_microblaze && !BR2_arc && !BR2_avr32 && !BR2_cortex_a7 && !BR2_cortex_a15 && !BR2_sparc_sparchfleon && !BR2_sparc_sparchfleonv8 && !BR2_sparc_sparcsfleon && !BR2_sparc_sparcsfleonv8 && !BR2_fa526 && !BR2_pj4
 		select BR2_GCC_NEEDS_MPC
 		# ARM EABIhf support appeared in gcc 4.6
 		depends on !BR2_ARM_EABIHF
 		bool "gcc 4.5.x"
+		select BR2_GCC_VERSION_NEEDS_THREE_STAGE_BUILD
 
 	config BR2_GCC_VERSION_4_6_X
-		depends on !BR2_arc && !BR2_avr32 && !BR2_bfin && !BR2_cortex_a7 && !BR2_sparc_sparchfleon && !BR2_sparc_sparchfleonv8 && !BR2_sparc_sparcsfleon && !BR2_sparc_sparcsfleonv8 && !BR2_pj4
+		depends on !BR2_microblaze && !BR2_arc && !BR2_avr32 && !BR2_bfin && !BR2_cortex_a7 && !BR2_sparc_sparchfleon && !BR2_sparc_sparchfleonv8 && !BR2_sparc_sparcsfleon && !BR2_sparc_sparcsfleonv8 && !BR2_pj4
 		select BR2_GCC_NEEDS_MPC
 		bool "gcc 4.6.x"
+		select BR2_GCC_VERSION_NEEDS_THREE_STAGE_BUILD
 
 	config BR2_GCC_VERSION_4_7_X
-		depends on !BR2_arc && !BR2_avr32 && !BR2_bfin && !BR2_sparc_sparchfleon && !BR2_sparc_sparchfleonv8 && !BR2_sparc_sparcsfleon && !BR2_sparc_sparcsfleonv8 && !BR2_pj4
+		depends on !BR2_microblaze && !BR2_arc && !BR2_avr32 && !BR2_bfin && !BR2_sparc_sparchfleon && !BR2_sparc_sparchfleonv8 && !BR2_sparc_sparcsfleon && !BR2_sparc_sparcsfleonv8 && !BR2_pj4
 		select BR2_GCC_NEEDS_MPC
 		bool "gcc 4.7.x"
 
 	config BR2_GCC_VERSION_4_8_X
-		depends on !BR2_arc && !BR2_avr32 && !BR2_bfin && !BR2_sparc_sparchfleon && !BR2_sparc_sparchfleonv8 && !BR2_sparc_sparcsfleon && !BR2_sparc_sparcsfleonv8
+		depends on !BR2_microblaze && !BR2_arc && !BR2_avr32 && !BR2_bfin && !BR2_sparc_sparchfleon && !BR2_sparc_sparchfleonv8 && !BR2_sparc_sparcsfleon && !BR2_sparc_sparcsfleonv8
 		select BR2_GCC_NEEDS_MPC
 		bool "gcc 4.8.x"
 
@@ -57,8 +69,13 @@ choice
 		select BR2_GCC_NEEDS_MPC
 		bool "gcc 4.8-arc"
 
+	config BR2_GCC_VERSION_4_9_MICROBLAZE
+		depends on BR2_microblaze
+		select BR2_GCC_NEEDS_MPC
+		bool "gcc 4.9-microblaze"
+
 	config BR2_GCC_VERSION_SNAP
-		depends on !BR2_arc && !BR2_avr32 && !BR2_sparc_sparchfleon && !BR2_sparc_sparchfleonv8 && !BR2_sparc_sparcsfleon && !BR2_sparc_sparcsfleonv8
+		depends on !BR2_microblaze && !BR2_arc && !BR2_avr32 && !BR2_sparc_sparchfleon && !BR2_sparc_sparchfleonv8 && !BR2_sparc_sparcsfleon && !BR2_sparc_sparcsfleonv8
 		select BR2_GCC_NEEDS_MPC
 		bool "gcc snapshot"
 endchoice
@@ -89,8 +106,9 @@ config BR2_GCC_VERSION
 	default "4.5.4"     if BR2_GCC_VERSION_4_5_X
 	default "4.6.4"     if BR2_GCC_VERSION_4_6_X
 	default "4.7.3"     if BR2_GCC_VERSION_4_7_X
-	default "4.8.2"     if BR2_GCC_VERSION_4_8_X
+	default "4.8.1"     if BR2_GCC_VERSION_4_8_X
 	default "4.8-arc"   if BR2_GCC_VERSION_4_8_ARC
+	default "4.9-microblaze" if BR2_GCC_VERSION_4_9_MICROBLAZE
 	default BR2_GCC_SNAP_DATE if BR2_GCC_VERSION_SNAP
 
 config BR2_EXTRA_GCC_CONFIG_OPTIONS
@@ -143,7 +161,7 @@ config BR2_GCC_ENABLE_TLS
 
 config BR2_GCC_ENABLE_OPENMP
 	bool "Enable compiler OpenMP support"
-	depends on !BR2_PTHREADS_NONE && !BR2_avr32 && !BR2_arc
+	depends on !BR2_PTHREADS_NONE && !BR2_avr32 && !BR2_arc && !BR2_microblaze
 	help
 	  Enable OpenMP support for the compiler
 
diff --git a/package/gcc/gcc.mk b/package/gcc/gcc.mk
index 41600ef..7414d6d 100644
--- a/package/gcc/gcc.mk
+++ b/package/gcc/gcc.mk
@@ -17,15 +17,21 @@ endif
 
 ifneq ($(GCC_SNAP_DATE),)
 GCC_SITE = ftp://gcc.gnu.org/pub/gcc/snapshots/$(GCC_SNAP_DATE)/
+GCC_SOURCE = gcc-$(GCC_VERSION).tar.bz2
 else ifeq ($(findstring avr32,$(GCC_VERSION)),avr32)
 GCC_SITE = ftp://www.at91.com/pub/buildroot/
+GCC_SOURCE = gcc-$(GCC_VERSION).tar.bz2
 else ifeq ($(findstring arc,$(GCC_VERSION)),arc)
 GCC_SITE = $(BR2_ARC_SITE)
+GCC_SOURCE = gcc-$(GCC_VERSION).tar.bz2
+else ifeq ($(findstring microblaze,$(GCC_VERSION)),microblaze)
+MBGCC_VERSION = b93bb009e021aba64dd4b8cdb0bbc5a176c55543
+GCC_SITE = http://github.com/Xilinx/gcc/tarball/$(MBGCC_VERSION)
+GCC_SOURCE = gcc-$(GCC_VERSION).tar.gz
 else
 GCC_SITE = $(BR2_GNU_MIRROR:/=)/gcc/gcc-$(GCC_VERSION)
-endif
-
 GCC_SOURCE = gcc-$(GCC_VERSION).tar.bz2
+endif
 
 #
 # Xtensa special hook
@@ -60,7 +66,7 @@ endef
 #
 
 define HOST_GCC_EXTRACT_CMDS
-	$(BZCAT) $(DL_DIR)/$(GCC_SOURCE) | \
+	$(call suitable-extractor,$(GCC_SOURCE),$(BZCAT)) $(DL_DIR)/$(GCC_SOURCE) | \
 		$(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $(@D) \
 		--exclude='libjava/*' \
 		--exclude='libgo/*' \
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [Buildroot] [PATCH v2 3/5] glibc: add microblaze internal toolchain
  2013-11-12 17:31 [Buildroot] [PATCH v2 0/5] Add Microblaze internal toolchain Spenser Gilliland
  2013-11-12 17:31 ` [Buildroot] [PATCH v2 1/5] binutils: add microblaze " Spenser Gilliland
  2013-11-12 17:31 ` [Buildroot] [PATCH v2 2/5] gcc: " Spenser Gilliland
@ 2013-11-12 17:31 ` Spenser Gilliland
  2013-11-12 17:31 ` [Buildroot] [PATCH v2 4/5] gdb: " Spenser Gilliland
  2013-11-12 17:31 ` [Buildroot] [PATCH v2 5/5] toolchain: enable microblaze toolchain Spenser Gilliland
  4 siblings, 0 replies; 10+ messages in thread
From: Spenser Gilliland @ 2013-11-12 17:31 UTC (permalink / raw)
  To: buildroot


Signed-off-by: Spenser Gilliland <spenser@gillilanding.com>
---
 package/glibc/glibc.mk |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/package/glibc/glibc.mk b/package/glibc/glibc.mk
index 2e7fe82..91ad29e 100644
--- a/package/glibc/glibc.mk
+++ b/package/glibc/glibc.mk
@@ -4,6 +4,17 @@
 #
 ################################################################################
 
+ifeq ($(BR2_microblaze),y)
+ifeq ($(BR2_TOOLCHAIN_BUILDROOT_EGLIBC),y)
+GLIBC_VERSION = 7f0bcce417c47aefad06ddfec7cd4ced3a4e10ff
+GLIBC_SITE = http://github.com/Xilinx/eglibc/tarball/$(GLIBC_VERSION)
+GLIBC_SRC_SUBDIR = .
+else
+GLIBC_VERSION = b86835ca92a1942ed08d8b5ee47498e711feaddb
+GLIBC_SITE = http://github.com/Xilinx/glibc/tarball/$(GLIBC_VERSION)
+GLIBC_SRC_SUBDIR = .
+endif
+else
 ifeq ($(BR2_TOOLCHAIN_BUILDROOT_EGLIBC),y)
 GLIBC_VERSION = 2.17-svnr22064
 GLIBC_SITE = http://downloads.yoctoproject.org/releases/eglibc/
@@ -15,6 +26,7 @@ GLIBC_SITE = $(BR2_GNU_MIRROR)/libc
 GLIBC_SOURCE = glibc-$(GLIBC_VERSION).tar.xz
 GLIBC_SRC_SUBDIR = .
 endif
+endif
 
 GLIBC_LICENSE = GPLv2+ (programs), LGPLv2.1+, BSD-3c, MIT (library)
 GLIBC_LICENSE_FILES = $(addprefix $(GLIBC_SRC_SUBDIR)/,COPYING COPYING.LIB LICENSES)
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [Buildroot] [PATCH v2 4/5] gdb: add microblaze internal toolchain
  2013-11-12 17:31 [Buildroot] [PATCH v2 0/5] Add Microblaze internal toolchain Spenser Gilliland
                   ` (2 preceding siblings ...)
  2013-11-12 17:31 ` [Buildroot] [PATCH v2 3/5] glibc: " Spenser Gilliland
@ 2013-11-12 17:31 ` Spenser Gilliland
  2013-11-12 17:31 ` [Buildroot] [PATCH v2 5/5] toolchain: enable microblaze toolchain Spenser Gilliland
  4 siblings, 0 replies; 10+ messages in thread
From: Spenser Gilliland @ 2013-11-12 17:31 UTC (permalink / raw)
  To: buildroot


Signed-off-by: Spenser Gilliland <spenser@gillilanding.com>
---
 package/gdb/Config.in.host |    4 ++++
 package/gdb/gdb.mk         |    9 ++++++++-
 2 files changed, 12 insertions(+), 1 deletions(-)

diff --git a/package/gdb/Config.in.host b/package/gdb/Config.in.host
index 128aed9..aae0109 100644
--- a/package/gdb/Config.in.host
+++ b/package/gdb/Config.in.host
@@ -18,6 +18,7 @@ choice
 	depends on !BR2_arc
 	default BR2_GDB_VERSION_6_6 if BR2_bfin
 	default BR2_GDB_VERSION_6_7_1_AVR32_2_1_5 if BR2_avr32
+	default BR2_GDB_VERSION_7_6_MICROBLAZE if BR2_microblaze
 	default BR2_GDB_VERSION_7_5
 	help
 	  Select the version of gdb you wish to use.
@@ -48,6 +49,8 @@ choice
 		bool "gdb 7.5.x"
 		depends on !BR2_bfin
 
+	config BR2_GDB_VERSION_7_6_MICROBLAZE
+		bool "gdb 7.6-microblaze"
 endchoice
 
 config BR2_GDB_VERSION
@@ -59,5 +62,6 @@ config BR2_GDB_VERSION
 	default "7.4.1"    if BR2_GDB_VERSION_7_4
 	default "7.5.1"    if BR2_GDB_VERSION_7_5
 	default "7.5.1-arc" if BR2_arc
+	default "7.6-microblaze" if BR2_microblaze
 
 endif
diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk
index 9cf90e3..65485da 100644
--- a/package/gdb/gdb.mk
+++ b/package/gdb/gdb.mk
@@ -21,15 +21,22 @@ GDB_VERSION = 7.5.1
 endif
 endif
 
+GDB_SOURCE = gdb-$(GDB_VERSION).tar.bz2
+
 ifeq ($(BR2_arc),y)
 GDB_SITE = $(BR2_ARC_SITE)
 endif
 
+ifeq ($(BR2_microblaze),y)
+GDB_VERSION = 6be65fb56ea6694a9260733a536a023a1e2d4d57
+GDB_SITE = http://github.com/Xilinx/gdb/tarball/$(GDB_VERSION)
+GDB_SOURCE = gdb-$(GDB_VERSION).tar.gz
+endif
+
 ifeq ($(GDB_VERSION),6.7.1-avr32-2.1.5)
 GDB_SITE = ftp://www.at91.com/pub/buildroot/
 endif
 
-GDB_SOURCE = gdb-$(GDB_VERSION).tar.bz2
 GDB_LICENSE = GPLv2+ LGPLv2+ GPLv3+ LGPLv3+
 GDB_LICENSE_FILES = COPYING COPYING.LIB COPYING3 COPYING3.LIB
 
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [Buildroot] [PATCH v2 5/5] toolchain: enable microblaze toolchain
  2013-11-12 17:31 [Buildroot] [PATCH v2 0/5] Add Microblaze internal toolchain Spenser Gilliland
                   ` (3 preceding siblings ...)
  2013-11-12 17:31 ` [Buildroot] [PATCH v2 4/5] gdb: " Spenser Gilliland
@ 2013-11-12 17:31 ` Spenser Gilliland
  4 siblings, 0 replies; 10+ messages in thread
From: Spenser Gilliland @ 2013-11-12 17:31 UTC (permalink / raw)
  To: buildroot


Signed-off-by: Spenser Gilliland <spenser@gillilanding.com>
---
 toolchain/Config.in                     |    2 +-
 toolchain/toolchain-buildroot/Config.in |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/toolchain/Config.in b/toolchain/Config.in
index 3980d79..bbfd367 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -35,7 +35,7 @@ choice
 
 config BR2_TOOLCHAIN_BUILDROOT
 	bool "Buildroot toolchain"
-	depends on !BR2_microblaze && !BR2_aarch64 && !BR2_nios2
+	depends on !BR2_aarch64 && !BR2_nios2
 	select BR2_TOOLCHAIN_HAS_SHADOW_PASSWORDS
 
 config BR2_TOOLCHAIN_EXTERNAL
diff --git a/toolchain/toolchain-buildroot/Config.in b/toolchain/toolchain-buildroot/Config.in
index 8b37127..1529004 100644
--- a/toolchain/toolchain-buildroot/Config.in
+++ b/toolchain/toolchain-buildroot/Config.in
@@ -21,7 +21,7 @@ config BR2_TOOLCHAIN_BUILDROOT_EGLIBC
 		   BR2_i386   || BR2_mips     || BR2_mipsel  || \
 		   BR2_mips64 || BR2_mips64el || BR2_powerpc || \
 		   BR2_sh     || BR2_sh64     || BR2_sparc   || \
-		   BR2_x86_64
+		   BR2_x86_64 || BR2_microblaze
 	depends on BR2_USE_MMU
 	depends on !BR2_PREFER_STATIC_LIB
 	select BR2_TOOLCHAIN_USES_GLIBC
@@ -42,7 +42,7 @@ config BR2_TOOLCHAIN_BUILDROOT_GLIBC
 		   BR2_i386   || BR2_mips     || BR2_mipsel  || \
 		   BR2_mips64 || BR2_mips64el || BR2_powerpc || \
 		   BR2_sh     || BR2_sh64     || BR2_sparc   || \
-		   BR2_x86_64
+		   BR2_x86_64 || BR2_microblaze
 	select BR2_TOOLCHAIN_USES_GLIBC
 	depends on !BR2_PREFER_STATIC_LIB
 	# our glibc.mk enables RPC support
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [Buildroot] [PATCH v2 2/5] gcc: add microblaze internal toolchain
  2013-11-12 17:31 ` [Buildroot] [PATCH v2 2/5] gcc: " Spenser Gilliland
@ 2013-11-12 21:07   ` Thomas Petazzoni
  2013-11-12 21:14     ` Mischa Jonker
                       ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Thomas Petazzoni @ 2013-11-12 21:07 UTC (permalink / raw)
  To: buildroot

Dear Spenser Gilliland,

On Tue, 12 Nov 2013 11:31:42 -0600, Spenser Gilliland wrote:

> +# Until gcc 4.7, a three stage build process was needed when using
> +# NPTL. This hidden option tells whether gcc is a version that
> +# requires this three stage build process.
> +config BR2_GCC_VERSION_NEEDS_THREE_STAGE_BUILD
> +	bool

Hum, is this really meant to be part of your patch? :-)


> @@ -16,39 +23,44 @@ choice
>  	config BR2_GCC_VERSION_4_2_2_AVR32_2_1_5
>  		depends on BR2_avr32
>  		bool "gcc 4.2.2-avr32-2.1.5"
> +		select BR2_GCC_VERSION_NEEDS_THREE_STAGE_BUILD

and this (and all the other occurrences).

> +GCC_SOURCE = gcc-$(GCC_VERSION).tar.bz2
> +else ifeq ($(findstring microblaze,$(GCC_VERSION)),microblaze)
> +MBGCC_VERSION = b93bb009e021aba64dd4b8cdb0bbc5a176c55543

MBGCC_VERSION ?

> +GCC_SITE = http://github.com/Xilinx/gcc/tarball/$(MBGCC_VERSION)
> +GCC_SOURCE = gcc-$(GCC_VERSION).tar.gz
>  else
>  GCC_SITE = $(BR2_GNU_MIRROR:/=)/gcc/gcc-$(GCC_VERSION)
> -endif
> -
>  GCC_SOURCE = gcc-$(GCC_VERSION).tar.bz2
> +endif
>  
>  #
>  # Xtensa special hook
> @@ -60,7 +66,7 @@ endef
>  #
>  
>  define HOST_GCC_EXTRACT_CMDS
> -	$(BZCAT) $(DL_DIR)/$(GCC_SOURCE) | \
> +	$(call suitable-extractor,$(GCC_SOURCE),$(BZCAT)) $(DL_DIR)/$(GCC_SOURCE) | \

The suitable-extractor macro doesn't take a second argument, so
the ,$(BZCAT) here is useless.

>  		$(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $(@D) \
>  		--exclude='libjava/*' \
>  		--exclude='libgo/*' \

Another issue is that this series is going to conflict quite badly with
the series posted by Mischa to add specific binutils/gcc/gdb/uClibc
versions for ARC.

It would probably be good if you could sync up on these two series.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Buildroot] [PATCH v2 2/5] gcc: add microblaze internal toolchain
  2013-11-12 21:07   ` Thomas Petazzoni
@ 2013-11-12 21:14     ` Mischa Jonker
  2013-11-12 21:22     ` Spenser Gilliland
  2013-11-12 21:40     ` Spenser Gilliland
  2 siblings, 0 replies; 10+ messages in thread
From: Mischa Jonker @ 2013-11-12 21:14 UTC (permalink / raw)
  To: buildroot

> >
> >  define HOST_GCC_EXTRACT_CMDS
> > -	$(BZCAT) $(DL_DIR)/$(GCC_SOURCE) | \
> > +	$(call suitable-extractor,$(GCC_SOURCE),$(BZCAT))
> > +$(DL_DIR)/$(GCC_SOURCE) | \
> 
> The suitable-extractor macro doesn't take a second argument, so the ,$(BZCAT)
> here is useless.
> 
> >  		$(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $(@D) \
> >  		--exclude='libjava/*' \
> >  		--exclude='libgo/*' \
> 
> Another issue is that this series is going to conflict quite badly with the
> series posted by Mischa to add specific binutils/gcc/gdb/uClibc versions for
> ARC.
> 
> It would probably be good if you could sync up on these two series.
> 

I wasn't aware of this suitable-extractor macro. If it supports .tar.gz, it should work fine for me (and I will update my patch accordingly, or better yet: leave it out of my patch completely). I will need to update my patch anyway with full commit ID's, and maybe I take a look at implementing this github helper too.

Mischa

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Buildroot] [PATCH v2 2/5] gcc: add microblaze internal toolchain
  2013-11-12 21:07   ` Thomas Petazzoni
  2013-11-12 21:14     ` Mischa Jonker
@ 2013-11-12 21:22     ` Spenser Gilliland
  2013-11-12 21:40     ` Spenser Gilliland
  2 siblings, 0 replies; 10+ messages in thread
From: Spenser Gilliland @ 2013-11-12 21:22 UTC (permalink / raw)
  To: buildroot

On Tue, 2013-11-12 at 22:07 +0100, Thomas Petazzoni wrote:
> Dear Spenser Gilliland,
> 
> On Tue, 12 Nov 2013 11:31:42 -0600, Spenser Gilliland wrote:
> 
> > +# Until gcc 4.7, a three stage build process was needed when using
> > +# NPTL. This hidden option tells whether gcc is a version that
> > +# requires this three stage build process.
> > +config BR2_GCC_VERSION_NEEDS_THREE_STAGE_BUILD
> > +	bool
> 
> Hum, is this really meant to be part of your patch? :-)
> 
> 
> > @@ -16,39 +23,44 @@ choice
> >  	config BR2_GCC_VERSION_4_2_2_AVR32_2_1_5
> >  		depends on BR2_avr32
> >  		bool "gcc 4.2.2-avr32-2.1.5"
> > +		select BR2_GCC_VERSION_NEEDS_THREE_STAGE_BUILD
> 
> and this (and all the other occurrences).
> 
> > +GCC_SOURCE = gcc-$(GCC_VERSION).tar.bz2
> > +else ifeq ($(findstring microblaze,$(GCC_VERSION)),microblaze)
> > +MBGCC_VERSION = b93bb009e021aba64dd4b8cdb0bbc5a176c55543
> 
> MBGCC_VERSION ?
> 
> > +GCC_SITE = http://github.com/Xilinx/gcc/tarball/$(MBGCC_VERSION)
> > +GCC_SOURCE = gcc-$(GCC_VERSION).tar.gz
> >  else
> >  GCC_SITE = $(BR2_GNU_MIRROR:/=)/gcc/gcc-$(GCC_VERSION)
> > -endif
> > -
> >  GCC_SOURCE = gcc-$(GCC_VERSION).tar.bz2
> > +endif
> >  
> >  #
> >  # Xtensa special hook
> > @@ -60,7 +66,7 @@ endef
> >  #
> >  
> >  define HOST_GCC_EXTRACT_CMDS
> > -	$(BZCAT) $(DL_DIR)/$(GCC_SOURCE) | \
> > +	$(call suitable-extractor,$(GCC_SOURCE),$(BZCAT)) $(DL_DIR)/$(GCC_SOURCE) | \
> 
> The suitable-extractor macro doesn't take a second argument, so
> the ,$(BZCAT) here is useless.
> 
> >  		$(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $(@D) \
> >  		--exclude='libjava/*' \
> >  		--exclude='libgo/*' \
> 
> Another issue is that this series is going to conflict quite badly with
> the series posted by Mischa to add specific binutils/gcc/gdb/uClibc
> versions for ARC.
> 
> It would probably be good if you could sync up on these two series.
> 
> Thanks!
> 
> Thomas

Thomas,

Thanks for the review.  I must have miss merged when rebasing onto
master.  I'll fix it up and resubmit.

I'll look into how to better sync my code into Mischa's.

Thanks,
Spenser
-- 
Spenser Gilliland
Computer Engineer
IIT ECASP Lab
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20131112/90743992/attachment.asc>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Buildroot] [PATCH v2 2/5] gcc: add microblaze internal toolchain
  2013-11-12 21:07   ` Thomas Petazzoni
  2013-11-12 21:14     ` Mischa Jonker
  2013-11-12 21:22     ` Spenser Gilliland
@ 2013-11-12 21:40     ` Spenser Gilliland
  2 siblings, 0 replies; 10+ messages in thread
From: Spenser Gilliland @ 2013-11-12 21:40 UTC (permalink / raw)
  To: buildroot

On Tue, 2013-11-12 at 22:07 +0100, Thomas Petazzoni wrote:
> Dear Spenser Gilliland,
> 
> On Tue, 12 Nov 2013 11:31:42 -0600, Spenser Gilliland wrote:

Oops, forgot to respond to the review comments. See inline.

> > +# Until gcc 4.7, a three stage build process was needed when using
> > +# NPTL. This hidden option tells whether gcc is a version that
> > +# requires this three stage build process.
> > +config BR2_GCC_VERSION_NEEDS_THREE_STAGE_BUILD
> > +	bool
> 
> Hum, is this really meant to be part of your patch? :-)

No, will fix.

> 
> > @@ -16,39 +23,44 @@ choice
> >  	config BR2_GCC_VERSION_4_2_2_AVR32_2_1_5
> >  		depends on BR2_avr32
> >  		bool "gcc 4.2.2-avr32-2.1.5"
> > +		select BR2_GCC_VERSION_NEEDS_THREE_STAGE_BUILD
> 
> and this (and all the other occurrences).

Same.

> > +GCC_SOURCE = gcc-$(GCC_VERSION).tar.bz2
> > +else ifeq ($(findstring microblaze,$(GCC_VERSION)),microblaze)
> > +MBGCC_VERSION = b93bb009e021aba64dd4b8cdb0bbc5a176c55543
> 
> MBGCC_VERSION ?

When initially doing this I felt that the git refs were to opaque.
However, I now realize that was a bad decision.

> 
> > +GCC_SITE = http://github.com/Xilinx/gcc/tarball/$(MBGCC_VERSION)
> > +GCC_SOURCE = gcc-$(GCC_VERSION).tar.gz
> >  else
> >  GCC_SITE = $(BR2_GNU_MIRROR:/=)/gcc/gcc-$(GCC_VERSION)
> > -endif
> > -
> >  GCC_SOURCE = gcc-$(GCC_VERSION).tar.bz2
> > +endif
> >  
> >  #
> >  # Xtensa special hook
> > @@ -60,7 +66,7 @@ endef
> >  #
> >  
> >  define HOST_GCC_EXTRACT_CMDS
> > -	$(BZCAT) $(DL_DIR)/$(GCC_SOURCE) | \
> > +	$(call suitable-extractor,$(GCC_SOURCE),$(BZCAT)) $(DL_DIR)/$(GCC_SOURCE) | \
> 
> The suitable-extractor macro doesn't take a second argument, so
> the ,$(BZCAT) here is useless.

Will fix.

> >  		$(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $(@D) \
> >  		--exclude='libjava/*' \
> >  		--exclude='libgo/*' \
> 
> Another issue is that this series is going to conflict quite badly with
> the series posted by Mischa to add specific binutils/gcc/gdb/uClibc
> versions for ARC.
> 
> It would probably be good if you could sync up on these two series.
> 
> Thanks!
> 
> Thomas


-- 
Spenser Gilliland
Computer Engineer
IIT ECASP Lab
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20131112/e80818fd/attachment.asc>

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2013-11-12 21:40 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-12 17:31 [Buildroot] [PATCH v2 0/5] Add Microblaze internal toolchain Spenser Gilliland
2013-11-12 17:31 ` [Buildroot] [PATCH v2 1/5] binutils: add microblaze " Spenser Gilliland
2013-11-12 17:31 ` [Buildroot] [PATCH v2 2/5] gcc: " Spenser Gilliland
2013-11-12 21:07   ` Thomas Petazzoni
2013-11-12 21:14     ` Mischa Jonker
2013-11-12 21:22     ` Spenser Gilliland
2013-11-12 21:40     ` Spenser Gilliland
2013-11-12 17:31 ` [Buildroot] [PATCH v2 3/5] glibc: " Spenser Gilliland
2013-11-12 17:31 ` [Buildroot] [PATCH v2 4/5] gdb: " Spenser Gilliland
2013-11-12 17:31 ` [Buildroot] [PATCH v2 5/5] toolchain: enable microblaze toolchain Spenser Gilliland

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.