All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] usbnet: fix status interrupt urb handling
@ 2013-11-12 15:34 Felix Fietkau
       [not found] ` <1384270481-30972-1-git-send-email-nbd-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
  0 siblings, 1 reply; 6+ messages in thread
From: Felix Fietkau @ 2013-11-12 15:34 UTC (permalink / raw)
  To: netdev-u79uwXL29TY76Z2rM5mHXA
  Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA, dcbw-H+wXaHxf7aLQT0dZR+AlfA

Since commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf
"sierra_net: keep status interrupt URB active", sierra_net triggers
status interrupt polling before the net_device is opened (in order to
properly receive the sync message response).

To be able to receive further interrupts, the interrupt urb needs to be
re-submitted, so this patch removes the bogus check for netif_running().

Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Signed-off-by: Felix Fietkau <nbd-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
---
 drivers/net/usb/usbnet.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 90a429b..8494bb5 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -204,9 +204,6 @@ static void intr_complete (struct urb *urb)
 		break;
 	}
 
-	if (!netif_running (dev->net))
-		return;

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] usbnet: fix status interrupt urb handling
       [not found] ` <1384270481-30972-1-git-send-email-nbd-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
@ 2013-11-12 17:37   ` Dan Williams
  2013-11-13  8:01   ` Oliver Neukum
  2013-11-14  7:33   ` David Miller
  2 siblings, 0 replies; 6+ messages in thread
From: Dan Williams @ 2013-11-12 17:37 UTC (permalink / raw)
  To: Felix Fietkau
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA

On Tue, 2013-11-12 at 16:34 +0100, Felix Fietkau wrote:
> Since commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf
> "sierra_net: keep status interrupt URB active", sierra_net triggers
> status interrupt polling before the net_device is opened (in order to
> properly receive the sync message response).
> 
> To be able to receive further interrupts, the interrupt urb needs to be
> re-submitted, so this patch removes the bogus check for netif_running().
> 
> Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Signed-off-by: Felix Fietkau <nbd-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>

Tested-by: Dan Williams <dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

> ---
>  drivers/net/usb/usbnet.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
> index 90a429b..8494bb5 100644
> --- a/drivers/net/usb/usbnet.c
> +++ b/drivers/net/usb/usbnet.c
> @@ -204,9 +204,6 @@ static void intr_complete (struct urb *urb)
>  		break;
>  	}
>  
> -	if (!netif_running (dev->net))
> -		return;
> -
>  	status = usb_submit_urb (urb, GFP_ATOMIC);
>  	if (status != 0)
>  		netif_err(dev, timer, dev->net,


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] usbnet: fix status interrupt urb handling
       [not found] ` <1384270481-30972-1-git-send-email-nbd-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
  2013-11-12 17:37   ` Dan Williams
@ 2013-11-13  8:01   ` Oliver Neukum
       [not found]     ` <1384329672.5724.6.camel-B2T3B9s34ElbnMAlSieJcQ@public.gmane.org>
  2013-11-14  7:33   ` David Miller
  2 siblings, 1 reply; 6+ messages in thread
From: Oliver Neukum @ 2013-11-13  8:01 UTC (permalink / raw)
  To: Felix Fietkau
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA,
	dcbw-H+wXaHxf7aLQT0dZR+AlfA

On Tue, 2013-11-12 at 16:34 +0100, Felix Fietkau wrote:
> Since commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf
> "sierra_net: keep status interrupt URB active", sierra_net triggers
> status interrupt polling before the net_device is opened (in order to
> properly receive the sync message response).
> 
> To be able to receive further interrupts, the interrupt urb needs to be
> re-submitted, so this patch removes the bogus check for netif_running().

And what about the other drivers for whom this patch means added
traffic? This fix is done with a sledge hammer and cares only about
some drivers.
I'd much prefer you introduced a driver flag for this.

	Regards
		Oliver


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] usbnet: fix status interrupt urb handling
       [not found]     ` <1384329672.5724.6.camel-B2T3B9s34ElbnMAlSieJcQ@public.gmane.org>
@ 2013-11-13  9:09       ` Bjørn Mork
       [not found]         ` <87r4akoefv.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
  0 siblings, 1 reply; 6+ messages in thread
From: Bjørn Mork @ 2013-11-13  9:09 UTC (permalink / raw)
  To: Oliver Neukum
  Cc: Felix Fietkau, netdev-u79uwXL29TY76Z2rM5mHXA,
	linux-usb-u79uwXL29TY76Z2rM5mHXA, dcbw-H+wXaHxf7aLQT0dZR+AlfA

Oliver Neukum <oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org> writes:

> On Tue, 2013-11-12 at 16:34 +0100, Felix Fietkau wrote:
>> Since commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf
>> "sierra_net: keep status interrupt URB active", sierra_net triggers
>> status interrupt polling before the net_device is opened (in order to
>> properly receive the sync message response).
>> 
>> To be able to receive further interrupts, the interrupt urb needs to be
>> re-submitted, so this patch removes the bogus check for netif_running().
>
> And what about the other drivers for whom this patch means added
> traffic? This fix is done with a sledge hammer and cares only about
> some drivers.

usbnet_stop calls usbnet_status_stop which kills the status URB, unless
the driver explicitly asked for it not to be killed.  And the callback
properly returns on status == -ENOENT, before the lines in question.

So I think Felix is right.   None of the other drivers will ever hit the
code he deletes. It only affects sierra_net, and that is unwanted.



Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] usbnet: fix status interrupt urb handling
       [not found]         ` <87r4akoefv.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
@ 2013-11-13  9:15           ` Oliver Neukum
  0 siblings, 0 replies; 6+ messages in thread
From: Oliver Neukum @ 2013-11-13  9:15 UTC (permalink / raw)
  To: Bjørn Mork
  Cc: Felix Fietkau, netdev-u79uwXL29TY76Z2rM5mHXA,
	linux-usb-u79uwXL29TY76Z2rM5mHXA, dcbw-H+wXaHxf7aLQT0dZR+AlfA

On Wed, 2013-11-13 at 10:09 +0100, Bjørn Mork wrote:
> Oliver Neukum <oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org> writes:
> 
> > On Tue, 2013-11-12 at 16:34 +0100, Felix Fietkau wrote:
> >> Since commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf
> >> "sierra_net: keep status interrupt URB active", sierra_net triggers
> >> status interrupt polling before the net_device is opened (in order to
> >> properly receive the sync message response).
> >> 
> >> To be able to receive further interrupts, the interrupt urb needs to be
> >> re-submitted, so this patch removes the bogus check for netif_running().
> >
> > And what about the other drivers for whom this patch means added
> > traffic? This fix is done with a sledge hammer and cares only about
> > some drivers.
> 
> usbnet_stop calls usbnet_status_stop which kills the status URB, unless
> the driver explicitly asked for it not to be killed.  And the callback
> properly returns on status == -ENOENT, before the lines in question.
> 
> So I think Felix is right.   None of the other drivers will ever hit the
> code he deletes. It only affects sierra_net, and that is unwanted.

True. I take back the objection.

	Regards
		Oliver


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] usbnet: fix status interrupt urb handling
       [not found] ` <1384270481-30972-1-git-send-email-nbd-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
  2013-11-12 17:37   ` Dan Williams
  2013-11-13  8:01   ` Oliver Neukum
@ 2013-11-14  7:33   ` David Miller
  2 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2013-11-14  7:33 UTC (permalink / raw)
  To: nbd-p3rKhJxN3npAfugRpC6u6w
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA,
	dcbw-H+wXaHxf7aLQT0dZR+AlfA

From: Felix Fietkau <nbd-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
Date: Tue, 12 Nov 2013 16:34:41 +0100

> Since commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf
> "sierra_net: keep status interrupt URB active", sierra_net triggers
> status interrupt polling before the net_device is opened (in order to
> properly receive the sync message response).
> 
> To be able to receive further interrupts, the interrupt urb needs to be
> re-submitted, so this patch removes the bogus check for netif_running().
> 
> Signed-off-by: Felix Fietkau <nbd-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-11-14  7:33 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-12 15:34 [PATCH] usbnet: fix status interrupt urb handling Felix Fietkau
     [not found] ` <1384270481-30972-1-git-send-email-nbd-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2013-11-12 17:37   ` Dan Williams
2013-11-13  8:01   ` Oliver Neukum
     [not found]     ` <1384329672.5724.6.camel-B2T3B9s34ElbnMAlSieJcQ@public.gmane.org>
2013-11-13  9:09       ` Bjørn Mork
     [not found]         ` <87r4akoefv.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
2013-11-13  9:15           ` Oliver Neukum
2013-11-14  7:33   ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.