All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86/early quirk: use gen6 stolen detection for VLV
@ 2013-11-12 18:17 Jesse Barnes
  2013-11-13 19:22   ` Ville Syrjälä
  0 siblings, 1 reply; 5+ messages in thread
From: Jesse Barnes @ 2013-11-12 18:17 UTC (permalink / raw)
  To: intel-gfx, linux-kernel; +Cc: hpa

We've always been able to use either method on VLV, but it appears more
recent BIOSes only support the gen6 method, so switch over to that.

References: https://bugs.freedesktop.org/show_bug.cgi?id=71370
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 arch/x86/kernel/early-quirks.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
index 96f958d..bc4a088 100644
--- a/arch/x86/kernel/early-quirks.c
+++ b/arch/x86/kernel/early-quirks.c
@@ -330,8 +330,8 @@ static struct pci_device_id intel_stolen_ids[] __initdata = {
 	INTEL_I915GM_IDS(gen3_stolen_size),
 	INTEL_I945G_IDS(gen3_stolen_size),
 	INTEL_I945GM_IDS(gen3_stolen_size),
-	INTEL_VLV_M_IDS(gen3_stolen_size),
-	INTEL_VLV_D_IDS(gen3_stolen_size),
+	INTEL_VLV_M_IDS(gen6_stolen_size),
+	INTEL_VLV_D_IDS(gen6_stolen_size),
 	INTEL_PINEVIEW_IDS(gen3_stolen_size),
 	INTEL_I965G_IDS(gen3_stolen_size),
 	INTEL_G33_IDS(gen3_stolen_size),
-- 
1.8.4.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Intel-gfx] [PATCH] x86/early quirk: use gen6 stolen detection for VLV
  2013-11-12 18:17 [PATCH] x86/early quirk: use gen6 stolen detection for VLV Jesse Barnes
@ 2013-11-13 19:22   ` Ville Syrjälä
  0 siblings, 0 replies; 5+ messages in thread
From: Ville Syrjälä @ 2013-11-13 19:22 UTC (permalink / raw)
  To: Jesse Barnes; +Cc: intel-gfx, linux-kernel, hpa

On Tue, Nov 12, 2013 at 10:17:39AM -0800, Jesse Barnes wrote:
> We've always been able to use either method on VLV, but it appears more
> recent BIOSes only support the gen6 method, so switch over to that.

I'm not sure what tha means since we've been using the gen6 method for
a long time now (except for the early quirk).

But anyways this matches the specs so:
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=71370
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
>  arch/x86/kernel/early-quirks.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index 96f958d..bc4a088 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -330,8 +330,8 @@ static struct pci_device_id intel_stolen_ids[] __initdata = {
>  	INTEL_I915GM_IDS(gen3_stolen_size),
>  	INTEL_I945G_IDS(gen3_stolen_size),
>  	INTEL_I945GM_IDS(gen3_stolen_size),
> -	INTEL_VLV_M_IDS(gen3_stolen_size),
> -	INTEL_VLV_D_IDS(gen3_stolen_size),
> +	INTEL_VLV_M_IDS(gen6_stolen_size),
> +	INTEL_VLV_D_IDS(gen6_stolen_size),
>  	INTEL_PINEVIEW_IDS(gen3_stolen_size),
>  	INTEL_I965G_IDS(gen3_stolen_size),
>  	INTEL_G33_IDS(gen3_stolen_size),
> -- 
> 1.8.4.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] x86/early quirk: use gen6 stolen detection for VLV
@ 2013-11-13 19:22   ` Ville Syrjälä
  0 siblings, 0 replies; 5+ messages in thread
From: Ville Syrjälä @ 2013-11-13 19:22 UTC (permalink / raw)
  To: Jesse Barnes; +Cc: intel-gfx, linux-kernel, hpa

On Tue, Nov 12, 2013 at 10:17:39AM -0800, Jesse Barnes wrote:
> We've always been able to use either method on VLV, but it appears more
> recent BIOSes only support the gen6 method, so switch over to that.

I'm not sure what tha means since we've been using the gen6 method for
a long time now (except for the early quirk).

But anyways this matches the specs so:
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=71370
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
>  arch/x86/kernel/early-quirks.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index 96f958d..bc4a088 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -330,8 +330,8 @@ static struct pci_device_id intel_stolen_ids[] __initdata = {
>  	INTEL_I915GM_IDS(gen3_stolen_size),
>  	INTEL_I945G_IDS(gen3_stolen_size),
>  	INTEL_I945GM_IDS(gen3_stolen_size),
> -	INTEL_VLV_M_IDS(gen3_stolen_size),
> -	INTEL_VLV_D_IDS(gen3_stolen_size),
> +	INTEL_VLV_M_IDS(gen6_stolen_size),
> +	INTEL_VLV_D_IDS(gen6_stolen_size),
>  	INTEL_PINEVIEW_IDS(gen3_stolen_size),
>  	INTEL_I965G_IDS(gen3_stolen_size),
>  	INTEL_G33_IDS(gen3_stolen_size),
> -- 
> 1.8.4.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Intel-gfx] [PATCH] x86/early quirk: use gen6 stolen detection for VLV
  2013-11-13 19:22   ` Ville Syrjälä
@ 2013-11-13 20:37     ` Daniel Vetter
  -1 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2013-11-13 20:37 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: Jesse Barnes, intel-gfx, linux-kernel, hpa

On Wed, Nov 13, 2013 at 09:22:59PM +0200, Ville Syrjälä wrote:
> On Tue, Nov 12, 2013 at 10:17:39AM -0800, Jesse Barnes wrote:
> > We've always been able to use either method on VLV, but it appears more
> > recent BIOSes only support the gen6 method, so switch over to that.
> 
> I'm not sure what tha means since we've been using the gen6 method for
> a long time now (except for the early quirk).

lalalala

> But anyways this matches the specs so:
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Picked up for -fixes, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] x86/early quirk: use gen6 stolen detection for VLV
@ 2013-11-13 20:37     ` Daniel Vetter
  0 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2013-11-13 20:37 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: intel-gfx, linux-kernel, hpa

On Wed, Nov 13, 2013 at 09:22:59PM +0200, Ville Syrjälä wrote:
> On Tue, Nov 12, 2013 at 10:17:39AM -0800, Jesse Barnes wrote:
> > We've always been able to use either method on VLV, but it appears more
> > recent BIOSes only support the gen6 method, so switch over to that.
> 
> I'm not sure what tha means since we've been using the gen6 method for
> a long time now (except for the early quirk).

lalalala

> But anyways this matches the specs so:
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Picked up for -fixes, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-11-13 20:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-12 18:17 [PATCH] x86/early quirk: use gen6 stolen detection for VLV Jesse Barnes
2013-11-13 19:22 ` [Intel-gfx] " Ville Syrjälä
2013-11-13 19:22   ` Ville Syrjälä
2013-11-13 20:37   ` [Intel-gfx] " Daniel Vetter
2013-11-13 20:37     ` Daniel Vetter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.