All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ath10k: clear tx status before submitting to mac80211
@ 2013-11-14  9:34 ` Michal Kazior
  0 siblings, 0 replies; 6+ messages in thread
From: Michal Kazior @ 2013-11-14  9:34 UTC (permalink / raw)
  To: ath10k; +Cc: linux-wireless, Michal Kazior

Garbage was reported in ieee80211_tx_info. This
led to a WARN_ON in cfg80211_calculate_bitrate().

This also fixes some random tx bitrate values
reported through `iw` command.

Reported-By: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
---
 drivers/net/wireless/ath/ath10k/txrx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/ath/ath10k/txrx.c b/drivers/net/wireless/ath/ath10k/txrx.c
index c511f91..3bc86f1 100644
--- a/drivers/net/wireless/ath/ath10k/txrx.c
+++ b/drivers/net/wireless/ath/ath10k/txrx.c
@@ -75,6 +75,7 @@ void ath10k_txrx_tx_unref(struct ath10k_htt *htt,
 	ath10k_report_offchan_tx(htt->ar, msdu);
 
 	info = IEEE80211_SKB_CB(msdu);
+	memset(info, 0, sizeof(*info));
 
 	if (tx_done->discard) {
 		ieee80211_free_txskb(htt->ar->hw, msdu);
-- 
1.8.4.rc3


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] ath10k: clear tx status before submitting to mac80211
@ 2013-11-14  9:34 ` Michal Kazior
  0 siblings, 0 replies; 6+ messages in thread
From: Michal Kazior @ 2013-11-14  9:34 UTC (permalink / raw)
  To: ath10k; +Cc: linux-wireless, Michal Kazior

Garbage was reported in ieee80211_tx_info. This
led to a WARN_ON in cfg80211_calculate_bitrate().

This also fixes some random tx bitrate values
reported through `iw` command.

Reported-By: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
---
 drivers/net/wireless/ath/ath10k/txrx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/ath/ath10k/txrx.c b/drivers/net/wireless/ath/ath10k/txrx.c
index c511f91..3bc86f1 100644
--- a/drivers/net/wireless/ath/ath10k/txrx.c
+++ b/drivers/net/wireless/ath/ath10k/txrx.c
@@ -75,6 +75,7 @@ void ath10k_txrx_tx_unref(struct ath10k_htt *htt,
 	ath10k_report_offchan_tx(htt->ar, msdu);
 
 	info = IEEE80211_SKB_CB(msdu);
+	memset(info, 0, sizeof(*info));
 
 	if (tx_done->discard) {
 		ieee80211_free_txskb(htt->ar->hw, msdu);
-- 
1.8.4.rc3


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: clear tx status before submitting to mac80211
  2013-11-14  9:34 ` Michal Kazior
@ 2013-11-15  9:06   ` Kalle Valo
  -1 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2013-11-15  9:06 UTC (permalink / raw)
  To: Michal Kazior; +Cc: ath10k, linux-wireless

Michal Kazior <michal.kazior@tieto.com> writes:

> Garbage was reported in ieee80211_tx_info. This
> led to a WARN_ON in cfg80211_calculate_bitrate().
>
> This also fixes some random tx bitrate values
> reported through `iw` command.
>
> Reported-By: Kalle Valo <kvalo@qca.qualcomm.com>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

Thanks, applied.

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: clear tx status before submitting to mac80211
@ 2013-11-15  9:06   ` Kalle Valo
  0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2013-11-15  9:06 UTC (permalink / raw)
  To: Michal Kazior; +Cc: linux-wireless, ath10k

Michal Kazior <michal.kazior@tieto.com> writes:

> Garbage was reported in ieee80211_tx_info. This
> led to a WARN_ON in cfg80211_calculate_bitrate().
>
> This also fixes some random tx bitrate values
> reported through `iw` command.
>
> Reported-By: Kalle Valo <kvalo@qca.qualcomm.com>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

Thanks, applied.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: Re: [PATCH] ath10k: clear tx status before submitting to mac80211
  2013-11-15  9:06   ` Kalle Valo
  (?)
@ 2013-11-20 21:38   ` Matti Laakso
  2013-11-21  7:21     ` Michal Kazior
  -1 siblings, 1 reply; 6+ messages in thread
From: Matti Laakso @ 2013-11-20 21:38 UTC (permalink / raw)
  To: ath10k

> Michal Kazior <michal.kazior at tieto.com <http://lists.infradead.org/mailman/listinfo/ath10k>> writes:
>
> >/ Garbage was reported in ieee80211_tx_info. This
> />/ led to a WARN_ON in cfg80211_calculate_bitrate().
> />/
> />/ This also fixes some random tx bitrate values
> />/ reported through `iw` command.
> />/
> />/ Reported-By: Kalle Valo <kvalo at qca.qualcomm.com <http://lists.infradead.org/mailman/listinfo/ath10k>>
> />/ Signed-off-by: Michal Kazior <michal.kazior at tieto.com <http://lists.infradead.org/mailman/listinfo/ath10k>>
> /
> Thanks, applied.
>
> -- 
> Kalle Valo

I'm running ath10k on a router, and cherry-picking this to current
OpenWrt (3.10.18 with backports from linux-next and some
OpenWrt-specific patches) prevents all stations from associating to the
access point. As far as I can see this patch doesn't depend on anything
else pushed in between?

Matti Laakso

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: Re: [PATCH] ath10k: clear tx status before submitting to mac80211
  2013-11-20 21:38   ` Matti Laakso
@ 2013-11-21  7:21     ` Michal Kazior
  0 siblings, 0 replies; 6+ messages in thread
From: Michal Kazior @ 2013-11-21  7:21 UTC (permalink / raw)
  To: Matti Laakso; +Cc: ath10k

On 20 November 2013 22:38, Matti Laakso <malaakso@elisanet.fi> wrote:
>> Michal Kazior <michal.kazior at tieto.com <http://lists.infradead.org/mailman/listinfo/ath10k>> writes:
>>
>> >/ Garbage was reported in ieee80211_tx_info. This
>> />/ led to a WARN_ON in cfg80211_calculate_bitrate().
>> />/
>> />/ This also fixes some random tx bitrate values
>> />/ reported through `iw` command.
>> />/
>> />/ Reported-By: Kalle Valo <kvalo at qca.qualcomm.com <http://lists.infradead.org/mailman/listinfo/ath10k>>
>> />/ Signed-off-by: Michal Kazior <michal.kazior at tieto.com <http://lists.infradead.org/mailman/listinfo/ath10k>>
>> /
>> Thanks, applied.
>>
>> --
>> Kalle Valo
>
> I'm running ath10k on a router, and cherry-picking this to current
> OpenWrt (3.10.18 with backports from linux-next and some
> OpenWrt-specific patches) prevents all stations from associating to the
> access point. As far as I can see this patch doesn't depend on anything
> else pushed in between?

Ah, my mistake. Thank you for testing and reporting back. I'll post a
fix for that.


Michał

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-11-21  7:21 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-14  9:34 [PATCH] ath10k: clear tx status before submitting to mac80211 Michal Kazior
2013-11-14  9:34 ` Michal Kazior
2013-11-15  9:06 ` Kalle Valo
2013-11-15  9:06   ` Kalle Valo
2013-11-20 21:38   ` Matti Laakso
2013-11-21  7:21     ` Michal Kazior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.