* [PATCH iptables] iptables/Makefile.am: fix more static linking issues
@ 2013-11-27 12:31 Gustavo Zacarias
2013-11-27 13:10 ` Florian Westphal
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo Zacarias @ 2013-11-27 12:31 UTC (permalink / raw)
To: netfilter-devel; +Cc: Gustavo Zacarias
On uClibc-based targets dlfcn.h isn't available when built for
static-only targets.
Add up -DNO_SHARED_LIBS when building static so as to guard off the
include.
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
iptables/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/iptables/Makefile.am b/iptables/Makefile.am
index a4246eb..1122d72 100644
--- a/iptables/Makefile.am
+++ b/iptables/Makefile.am
@@ -7,7 +7,7 @@ xtables_multi_SOURCES = xtables-multi.c iptables-xml.c
xtables_multi_CFLAGS = ${AM_CFLAGS}
xtables_multi_LDADD = ../extensions/libext.a
if ENABLE_STATIC
-xtables_multi_CFLAGS += -DALL_INCLUSIVE
+xtables_multi_CFLAGS += -DALL_INCLUSIVE -DNO_SHARED_LIBS
endif
if ENABLE_IPV4
xtables_multi_SOURCES += iptables-save.c iptables-restore.c \
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH iptables] iptables/Makefile.am: fix more static linking issues
2013-11-27 12:31 [PATCH iptables] iptables/Makefile.am: fix more static linking issues Gustavo Zacarias
@ 2013-11-27 13:10 ` Florian Westphal
2013-11-27 13:20 ` Gustavo Zacarias
0 siblings, 1 reply; 3+ messages in thread
From: Florian Westphal @ 2013-11-27 13:10 UTC (permalink / raw)
To: Gustavo Zacarias; +Cc: netfilter-devel
Gustavo Zacarias <gustavo@zacarias.com.ar> wrote:
> On uClibc-based targets dlfcn.h isn't available when built for
> static-only targets.
> Add up -DNO_SHARED_LIBS when building static so as to guard off the
> include.
Hmmm, it seems simpler to just kill #include <dlfcn.h>
from ip(6)tables-save.c -- I don't see why it would be needed there.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH iptables] iptables/Makefile.am: fix more static linking issues
2013-11-27 13:10 ` Florian Westphal
@ 2013-11-27 13:20 ` Gustavo Zacarias
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo Zacarias @ 2013-11-27 13:20 UTC (permalink / raw)
To: Florian Westphal; +Cc: netfilter-devel
On 11/27/2013 10:10 AM, Florian Westphal wrote:
> Hmmm, it seems simpler to just kill #include <dlfcn.h>
> from ip(6)tables-save.c -- I don't see why it would be needed there.
Fair enough, i'll send a revised patch.
Regards.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-27 13:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-27 12:31 [PATCH iptables] iptables/Makefile.am: fix more static linking issues Gustavo Zacarias
2013-11-27 13:10 ` Florian Westphal
2013-11-27 13:20 ` Gustavo Zacarias
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.