All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] apr: needs mmu
@ 2013-11-27 13:00 Gustavo Zacarias
  2013-11-28 13:44 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Gustavo Zacarias @ 2013-11-27 13:00 UTC (permalink / raw)
  To: buildroot

Uses fork() in apr_proc_fork() which is used by almost all the packages
that use apr (log4cxx, subversion).
apr-util doesn't use fork or apr_proc_fork but it's of no use alone.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/apr-util/Config.in   | 1 +
 package/apr/Config.in        | 1 +
 package/log4cxx/Config.in    | 1 +
 package/subversion/Config.in | 1 +
 4 files changed, 4 insertions(+)

diff --git a/package/apr-util/Config.in b/package/apr-util/Config.in
index 895dbb8..3d4ec23 100644
--- a/package/apr-util/Config.in
+++ b/package/apr-util/Config.in
@@ -7,6 +7,7 @@ config BR2_PACKAGE_APR_UTIL
 	select BR2_PACKAGE_ZLIB
 	# apr really needs shared library support
 	depends on !BR2_PREFER_STATIC_LIB
+	depends on BR2_USE_MMU # apr
 	help
 	  The utility library for the apache runtime project
 
diff --git a/package/apr/Config.in b/package/apr/Config.in
index ed319ed..e06d254 100644
--- a/package/apr/Config.in
+++ b/package/apr/Config.in
@@ -2,6 +2,7 @@ config BR2_PACKAGE_APR
 	bool "apr"
 	# apr really needs shared library support
 	depends on !BR2_PREFER_STATIC_LIB
+	depends on BR2_USE_MMU # fork() in apr_proc_fork()
 	help
 	  The mission of the Apache Portable Runtime (APR) project is to create
 	  and maintain software libraries that provide a predictable and
diff --git a/package/log4cxx/Config.in b/package/log4cxx/Config.in
index 8791b8c..616fb1f 100644
--- a/package/log4cxx/Config.in
+++ b/package/log4cxx/Config.in
@@ -6,6 +6,7 @@ config BR2_PACKAGE_LOG4CXX
 	depends on !BR2_PREFER_STATIC_LIB
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_USE_MMU # apr
 	help
 	  Apache log4cxx is a logging framework for C++ patterned
 	  after Apache log4j.
diff --git a/package/subversion/Config.in b/package/subversion/Config.in
index c1358fe..cc2549f 100644
--- a/package/subversion/Config.in
+++ b/package/subversion/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_SUBVERSION
 	select BR2_PACKAGE_APR_UTIL
 	# apr really needs shared library support
 	depends on !BR2_PREFER_STATIC_LIB
+	depends on BR2_USE_MMU # apr
 	select BR2_PACKAGE_NEON
 	select BR2_PACKAGE_NEON_XML
 	help
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] apr: needs mmu
  2013-11-27 13:00 [Buildroot] [PATCH] apr: needs mmu Gustavo Zacarias
@ 2013-11-28 13:44 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2013-11-28 13:44 UTC (permalink / raw)
  To: buildroot

>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

 > Uses fork() in apr_proc_fork() which is used by almost all the packages
 > that use apr (log4cxx, subversion).
 > apr-util doesn't use fork or apr_proc_fork but it's of no use alone.

 > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

 > +++ b/package/log4cxx/Config.in
 > @@ -6,6 +6,7 @@ config BR2_PACKAGE_LOG4CXX
 >  	depends on !BR2_PREFER_STATIC_LIB
 >  	depends on BR2_INSTALL_LIBSTDCPP
 >  	depends on BR2_TOOLCHAIN_HAS_THREADS
 > +	depends on BR2_USE_MMU # apr
 >  	help
 >  	  Apache log4cxx is a logging framework for C++ patterned
 >  	  after Apache log4j.

The log4cxx comment should also only be displayed when
BR2_USE_MMU. Fixed that and committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-11-28 13:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-27 13:00 [Buildroot] [PATCH] apr: needs mmu Gustavo Zacarias
2013-11-28 13:44 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.