All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] [RFC] drm/i915: Only use read-back pipe config
@ 2013-11-27 19:39 Daniel Vetter
  0 siblings, 0 replies; only message in thread
From: Daniel Vetter @ 2013-11-27 19:39 UTC (permalink / raw)
  To: Intel Graphics Development; +Cc: Daniel Vetter

This way we'll catch bugs in our code where we depend upon pipe config
state not (yet) read out much quicker, through a simple dpms on/off
cycle.

This will blow up all over the place for now, hence just a quick idea
to toss out there.

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/i915/intel_display.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 7ec8b488bb1d..342915f149b8 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -9287,6 +9287,9 @@ check_crtc_state(struct drm_device *dev)
 			intel_dump_pipe_config(crtc, &crtc->config,
 					       "[sw state]");
 		}
+
+		/* Make sure our code only depends upon stuff we read back. */
+		memcpy(&pipe_config, &crtc->config, sizeof(pipe_config));
 	}
 }
 
-- 
1.8.4.3

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2013-11-27 19:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-27 19:39 [PATCH] [RFC] drm/i915: Only use read-back pipe config Daniel Vetter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.