* [PATCH] ACPI / PCI / hotplug: Avoid warning when _ADR not present
@ 2013-11-27 20:33 Toshi Kani
2013-11-28 14:15 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Toshi Kani @ 2013-11-27 20:33 UTC (permalink / raw)
To: rjw, bhelgaas; +Cc: linux-acpi, linux-pci, linux-kernel, Toshi Kani
acpiphp_enumerate_slots() walks ACPI namenamespace under
a PCI host bridge with callback register_slot().
register_slot() evaluates _ADR for all the device objects
and emits a warning message for any error. Some platforms
have _HID device objects (such as HPET and IPMI), which
trigger unnecessary warning messages.
This patch avoids emitting a warning message when a target
device object does not have _ADR.
Signed-off-by: Toshi Kani <toshi.kani@hp.com>
---
Patch is based on Linus's tree (3.13-rc1).
---
drivers/pci/hotplug/acpiphp_glue.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c
index 1cf605f..438a4d0 100644
--- a/drivers/pci/hotplug/acpiphp_glue.c
+++ b/drivers/pci/hotplug/acpiphp_glue.c
@@ -279,7 +279,9 @@ static acpi_status register_slot(acpi_handle handle, u32 lvl, void *data,
status = acpi_evaluate_integer(handle, "_ADR", NULL, &adr);
if (ACPI_FAILURE(status)) {
- acpi_handle_warn(handle, "can't evaluate _ADR (%#x)\n", status);
+ if (status != AE_NOT_FOUND)
+ acpi_handle_warn(handle,
+ "can't evaluate _ADR (%#x)\n", status);
return AE_OK;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ACPI / PCI / hotplug: Avoid warning when _ADR not present
2013-11-27 20:33 [PATCH] ACPI / PCI / hotplug: Avoid warning when _ADR not present Toshi Kani
@ 2013-11-28 14:15 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2013-11-28 14:15 UTC (permalink / raw)
To: Toshi Kani; +Cc: bhelgaas, linux-acpi, linux-pci, linux-kernel
On Wednesday, November 27, 2013 01:33:09 PM Toshi Kani wrote:
> acpiphp_enumerate_slots() walks ACPI namenamespace under
> a PCI host bridge with callback register_slot().
> register_slot() evaluates _ADR for all the device objects
> and emits a warning message for any error. Some platforms
> have _HID device objects (such as HPET and IPMI), which
> trigger unnecessary warning messages.
>
> This patch avoids emitting a warning message when a target
> device object does not have _ADR.
>
> Signed-off-by: Toshi Kani <toshi.kani@hp.com>
> ---
> Patch is based on Linus's tree (3.13-rc1).
Queued up as a fix for 3.13, thanks!
> ---
> drivers/pci/hotplug/acpiphp_glue.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c
> index 1cf605f..438a4d0 100644
> --- a/drivers/pci/hotplug/acpiphp_glue.c
> +++ b/drivers/pci/hotplug/acpiphp_glue.c
> @@ -279,7 +279,9 @@ static acpi_status register_slot(acpi_handle handle, u32 lvl, void *data,
>
> status = acpi_evaluate_integer(handle, "_ADR", NULL, &adr);
> if (ACPI_FAILURE(status)) {
> - acpi_handle_warn(handle, "can't evaluate _ADR (%#x)\n", status);
> + if (status != AE_NOT_FOUND)
> + acpi_handle_warn(handle,
> + "can't evaluate _ADR (%#x)\n", status);
> return AE_OK;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-28 14:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-27 20:33 [PATCH] ACPI / PCI / hotplug: Avoid warning when _ADR not present Toshi Kani
2013-11-28 14:15 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.