[meta-fsl-arm-extra][PATCH v3 1/2] wandboard.inc: add file with common settings for wandboard boards

[meta-fsl-arm-extra][PATCH v3 1/2] wandboard.inc: add file with common settings for wandboard boards

[Mario Domenech Goulart]

Currently the following variables can be shared among all the
wandboard models: PREFERRED_PROVIDER_virtual/kernel, SERIAL_CONSOLE
and MACHINE_FEATURES.  Move them to a include file to avoid code
duplication.

Signed-off-by: Mario Domenech Goulart <mario@ossystems.com.br>
---
 conf/machine/include/wandboard.inc |   10 ++++++++++
 conf/machine/wandboard-dual.conf   |    9 ++-------
 conf/machine/wandboard-quad.conf   |    9 ++-------
 conf/machine/wandboard-solo.conf   |    9 +--------
 4 files changed, 15 insertions(+), 22 deletions(-)
 create mode 100644 conf/machine/include/wandboard.inc

diff --git a/conf/machine/include/wandboard.inc b/conf/machine/include/wandboard.inc
new file mode 100644
index 0000000..dc64d89
--- /dev/null
+++ b/conf/machine/include/wandboard.inc
@@ -0,0 +1,10 @@
+# Common settings for wandboard boards
+
+include conf/machine/include/imx-base.inc
+include conf/machine/include/tune-cortexa9.inc
+
+PREFERRED_PROVIDER_virtual/kernel ?= "linux-wandboard"
+
+SERIAL_CONSOLE = "115200 ttymxc0"
+
+MACHINE_FEATURES += "pci"
diff --git a/conf/machine/wandboard-dual.conf b/conf/machine/wandboard-dual.conf
index 3526790..bf2ba8d 100644
--- a/conf/machine/wandboard-dual.conf
+++ b/conf/machine/wandboard-dual.conf
@@ -3,19 +3,14 @@
 #@SOC: i.MX6DL
 #@DESCRIPTION: Machine configuration for i.MX6 Wandboard Duallite
 
-include conf/machine/include/imx-base.inc
-include conf/machine/include/tune-cortexa9.inc
+include include/wandboard.inc
 
 SOC_FAMILY = "mx6:mx6dl:wandboard"
 
-PREFERRED_PROVIDER_virtual/kernel ?= "linux-wandboard"
-
 UBOOT_MACHINE = "wandboard_dl_config"
 
 KERNEL_DEVICETREE = "imx6dl-wandboard.dtb"
 
-SERIAL_CONSOLE = "115200 ttymxc0"
-
-MACHINE_FEATURES += " pci wifi bluetooth"
+MACHINE_FEATURES += "bluetooth wifi"
 
 MACHINE_EXTRA_RRECOMMENDS += " broadcom-nvram-config"
diff --git a/conf/machine/wandboard-quad.conf b/conf/machine/wandboard-quad.conf
index 578dd0d..1523887 100644
--- a/conf/machine/wandboard-quad.conf
+++ b/conf/machine/wandboard-quad.conf
@@ -3,19 +3,14 @@
 #@SOC: i.MX6Q
 #@DESCRIPTION: Machine configuration for i.MX6 Wandboard Quad
 
-include conf/machine/include/imx-base.inc
-include conf/machine/include/tune-cortexa9.inc
+include include/wandboard.inc
 
 SOC_FAMILY = "mx6:mx6q:wandboard"
 
-PREFERRED_PROVIDER_virtual/kernel ?= "linux-wandboard"
-
 UBOOT_MACHINE = "wandboard_quad_config"
 
 KERNEL_DEVICETREE = "imx6q-wandboard.dtb"
 
-SERIAL_CONSOLE = "115200 ttymxc0"
-
-MACHINE_FEATURES += " pci wifi bluetooth"
+MACHINE_FEATURES += "bluetooth wifi"
 
 MACHINE_EXTRA_RRECOMMENDS += " broadcom-nvram-config"
diff --git a/conf/machine/wandboard-solo.conf b/conf/machine/wandboard-solo.conf
index aad7876..9696aeb 100644
--- a/conf/machine/wandboard-solo.conf
+++ b/conf/machine/wandboard-solo.conf
@@ -3,17 +3,10 @@
 #@SOC: i.MX6S
 #@DESCRIPTION: Machine configuration for i.MX6 Wandboard Solo
 
-include conf/machine/include/imx-base.inc
-include conf/machine/include/tune-cortexa9.inc
+include include/wandboard.inc
 
 SOC_FAMILY = "mx6:mx6s:wandboard"
 
-PREFERRED_PROVIDER_virtual/kernel ?= "linux-wandboard"
-
 UBOOT_MACHINE = "wandboard_solo_config"
 
 KERNEL_DEVICETREE = "imx6dl-wandboard.dtb"
-
-SERIAL_CONSOLE = "115200 ttymxc0"
-
-MACHINE_FEATURES += " pci wifi"
-- 
1.7.10.4

[meta-fsl-arm-extra][PATCH v3 2/2] wandboard.inc: add touchscreen support

[Mario Domenech Goulart]

Signed-off-by: Mario Domenech Goulart <mario@ossystems.com.br>
---
 conf/machine/include/wandboard.inc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/conf/machine/include/wandboard.inc b/conf/machine/include/wandboard.inc
index dc64d89..5e83ad5 100644
--- a/conf/machine/include/wandboard.inc
+++ b/conf/machine/include/wandboard.inc
@@ -7,4 +7,4 @@ PREFERRED_PROVIDER_virtual/kernel ?= "linux-wandboard"
 
 SERIAL_CONSOLE = "115200 ttymxc0"
 
-MACHINE_FEATURES += "pci"
+MACHINE_FEATURES += "pci touchscreen"
-- 
1.7.10.4

Re: [meta-fsl-arm-extra][PATCH v3 2/2] wandboard.inc: add touchscreen support

[John Weber]

Hi Mario,

On 12/9/13 11:26 AM, Mario Domenech Goulart wrote:
> Signed-off-by: Mario Domenech Goulart <mario@ossystems.com.br>
> ---
>   conf/machine/include/wandboard.inc |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/conf/machine/include/wandboard.inc b/conf/machine/include/wandboard.inc
> index dc64d89..5e83ad5 100644
> --- a/conf/machine/include/wandboard.inc
> +++ b/conf/machine/include/wandboard.inc
> @@ -7,4 +7,4 @@ PREFERRED_PROVIDER_virtual/kernel ?= "linux-wandboard"
>   
>   SERIAL_CONSOLE = "115200 ttymxc0"
>   
> -MACHINE_FEATURES += "pci"
> +MACHINE_FEATURES += "pci touchscreen"
What does the touchscreen feature add?  In the case of headless systems, how 
would a developer override this setting if they want to create an image without 
touch support?  Would something like MACHINE_FEATURES_remove = "touchscreen" work?

Re: [meta-fsl-arm-extra][PATCH v3 2/2] wandboard.inc: add touchscreen support

[Otavio Salvador]

Hello John,

On Mon, Dec 9, 2013 at 4:39 PM, John Weber <rjohnweber@gmail.com> wrote:
> On 12/9/13 11:26 AM, Mario Domenech Goulart wrote:
>> Signed-off-by: Mario Domenech Goulart <mario@ossystems.com.br>
>> diff --git a/conf/machine/include/wandboard.inc
>> b/conf/machine/include/wandboard.inc
>> index dc64d89..5e83ad5 100644
>> --- a/conf/machine/include/wandboard.inc
>> +++ b/conf/machine/include/wandboard.inc
>> @@ -7,4 +7,4 @@ PREFERRED_PROVIDER_virtual/kernel ?= "linux-wandboard"
>>     SERIAL_CONSOLE = "115200 ttymxc0"
>>   -MACHINE_FEATURES += "pci"
>> +MACHINE_FEATURES += "pci touchscreen"
>
> What does the touchscreen feature add?  In the case of headless systems, how
> would a developer override this setting if they want to create an image
> without touch support?  Would something like MACHINE_FEATURES_remove =
> "touchscreen" work?

It allows calibration for the images which supports it. This so
depends on the image it is uses.

The _remove is supported by bitbake so it does work.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-arm-extra][PATCH v3 2/2] wandboard.inc: add touchscreen support

[John Weber]

On 12/9/13 1:00 PM, Otavio Salvador wrote:
> Hello John,
>
> On Mon, Dec 9, 2013 at 4:39 PM, John Weber <rjohnweber@gmail.com> wrote:
>> On 12/9/13 11:26 AM, Mario Domenech Goulart wrote:
>>> Signed-off-by: Mario Domenech Goulart <mario@ossystems.com.br>
>>> diff --git a/conf/machine/include/wandboard.inc
>>> b/conf/machine/include/wandboard.inc
>>> index dc64d89..5e83ad5 100644
>>> --- a/conf/machine/include/wandboard.inc
>>> +++ b/conf/machine/include/wandboard.inc
>>> @@ -7,4 +7,4 @@ PREFERRED_PROVIDER_virtual/kernel ?= "linux-wandboard"
>>>      SERIAL_CONSOLE = "115200 ttymxc0"
>>>    -MACHINE_FEATURES += "pci"
>>> +MACHINE_FEATURES += "pci touchscreen"
>> What does the touchscreen feature add?  In the case of headless systems, how
>> would a developer override this setting if they want to create an image
>> without touch support?  Would something like MACHINE_FEATURES_remove =
>> "touchscreen" work?
> It allows calibration for the images which supports it. This so
> depends on the image it is uses.
>
> The _remove is supported by bitbake so it does work.
>
OK.  No problem.  Thanks.

Re: [meta-fsl-arm-extra][PATCH v3 2/2] wandboard.inc: add touchscreen support

[Eric Bénard]

Hi Mario,

Le Mon,  9 Dec 2013 15:26:16 -0200,
Mario Domenech Goulart <mario@ossystems.com.br> a écrit :

> Signed-off-by: Mario Domenech Goulart <mario@ossystems.com.br>
> ---
>  conf/machine/include/wandboard.inc |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/conf/machine/include/wandboard.inc b/conf/machine/include/wandboard.inc
> index dc64d89..5e83ad5 100644
> --- a/conf/machine/include/wandboard.inc
> +++ b/conf/machine/include/wandboard.inc
> @@ -7,4 +7,4 @@ PREFERRED_PROVIDER_virtual/kernel ?= "linux-wandboard"
>  
>  SERIAL_CONSOLE = "115200 ttymxc0"
>  
> -MACHINE_FEATURES += "pci"
> +MACHINE_FEATURES += "pci touchscreen"

where is the touchscreen interface on the wandboard ?

Eric

Re: [meta-fsl-arm-extra][PATCH v3 2/2] wandboard.inc: add touchscreen support

[Otavio Salvador]

Hello Eric,

On Wed, Dec 11, 2013 at 8:31 AM, Eric Bénard <eric@eukrea.com> wrote:
> Le Mon,  9 Dec 2013 15:26:16 -0200,
> Mario Domenech Goulart <mario@ossystems.com.br> a écrit :
>
>> Signed-off-by: Mario Domenech Goulart <mario@ossystems.com.br>
>> ---
>>  conf/machine/include/wandboard.inc |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/conf/machine/include/wandboard.inc b/conf/machine/include/wandboard.inc
>> index dc64d89..5e83ad5 100644
>> --- a/conf/machine/include/wandboard.inc
>> +++ b/conf/machine/include/wandboard.inc
>> @@ -7,4 +7,4 @@ PREFERRED_PROVIDER_virtual/kernel ?= "linux-wandboard"
>>
>>  SERIAL_CONSOLE = "115200 ttymxc0"
>>
>> -MACHINE_FEATURES += "pci"
>> +MACHINE_FEATURES += "pci touchscreen"
>
> where is the touchscreen interface on the wandboard ?

This allow used with the adapters which provide support for it.

For reference, Future Eletronics provide one:

http://www.futureelectronics.com/en/technologies/development-tools/development-tool-hardware/Pages/9032471-FWBADAPT-7WVGA-PCAP.aspx?IM=0

This is the one we used for testing.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-arm-extra][PATCH v3 2/2] wandboard.inc: add touchscreen support

[Eric Bénard]

Le Wed, 11 Dec 2013 08:44:35 -0200,
Otavio Salvador <otavio@ossystems.com.br> a écrit :

> Hello Eric,
> 
> On Wed, Dec 11, 2013 at 8:31 AM, Eric Bénard <eric@eukrea.com> wrote:
> > Le Mon,  9 Dec 2013 15:26:16 -0200,
> > Mario Domenech Goulart <mario@ossystems.com.br> a écrit :
> >
> >> Signed-off-by: Mario Domenech Goulart <mario@ossystems.com.br>
> >> ---
> >>  conf/machine/include/wandboard.inc |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/conf/machine/include/wandboard.inc b/conf/machine/include/wandboard.inc
> >> index dc64d89..5e83ad5 100644
> >> --- a/conf/machine/include/wandboard.inc
> >> +++ b/conf/machine/include/wandboard.inc
> >> @@ -7,4 +7,4 @@ PREFERRED_PROVIDER_virtual/kernel ?= "linux-wandboard"
> >>
> >>  SERIAL_CONSOLE = "115200 ttymxc0"
> >>
> >> -MACHINE_FEATURES += "pci"
> >> +MACHINE_FEATURES += "pci touchscreen"
> >
> > where is the touchscreen interface on the wandboard ?
> 
> This allow used with the adapters which provide support for it.
> 
> For reference, Future Eletronics provide one:
> 
> http://www.futureelectronics.com/en/technologies/development-tools/development-tool-hardware/Pages/9032471-FWBADAPT-7WVGA-PCAP.aspx?IM=0
> 
> This is the one we used for testing.
> 
OK not really a wandboard.inc MACHINE_FEATURE then ;-)

Eric