All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>, Rik van Riel <riel@redhat.com>,
	Mel Gorman <mgorman@suse.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Wanpeng Li <liwanp@linux.vnet.ibm.com>
Subject: [PATCH v6 1/6] sched/numa: fix set cpupid on page migration twice against thp
Date: Wed, 11 Dec 2013 18:15:56 +0800	[thread overview]
Message-ID: <1386756961-3887-2-git-send-email-liwanp@linux.vnet.ibm.com> (raw)
In-Reply-To: <1386756961-3887-1-git-send-email-liwanp@linux.vnet.ibm.com>

commit 7851a45cd3 (mm: numa: Copy cpupid on page migration) copy over
the cpupid at page migration time, there is unnecessary to set it again
in function migrate_misplaced_transhuge_page, this patch fix it.

Acked-by: Mel Gorman <mgorman@suse.de>
Reviewed-by: Rik van Riel <riel@redhat.com>
Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
---
 mm/migrate.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/mm/migrate.c b/mm/migrate.c
index bb94004..fdb70f7 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1736,8 +1736,6 @@ int migrate_misplaced_transhuge_page(struct mm_struct *mm,
 	if (!new_page)
 		goto out_fail;
 
-	page_cpupid_xchg_last(new_page, page_cpupid_last(page));
-
 	isolated = numamigrate_isolate_page(pgdat, page);
 	if (!isolated) {
 		put_page(new_page);
-- 
1.7.5.4


WARNING: multiple messages have this Message-ID (diff)
From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>, Rik van Riel <riel@redhat.com>,
	Mel Gorman <mgorman@suse.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Wanpeng Li <liwanp@linux.vnet.ibm.com>
Subject: [PATCH v6 1/6] sched/numa: fix set cpupid on page migration twice against thp
Date: Wed, 11 Dec 2013 18:15:56 +0800	[thread overview]
Message-ID: <1386756961-3887-2-git-send-email-liwanp@linux.vnet.ibm.com> (raw)
In-Reply-To: <1386756961-3887-1-git-send-email-liwanp@linux.vnet.ibm.com>

commit 7851a45cd3 (mm: numa: Copy cpupid on page migration) copy over
the cpupid at page migration time, there is unnecessary to set it again
in function migrate_misplaced_transhuge_page, this patch fix it.

Acked-by: Mel Gorman <mgorman@suse.de>
Reviewed-by: Rik van Riel <riel@redhat.com>
Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
---
 mm/migrate.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/mm/migrate.c b/mm/migrate.c
index bb94004..fdb70f7 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1736,8 +1736,6 @@ int migrate_misplaced_transhuge_page(struct mm_struct *mm,
 	if (!new_page)
 		goto out_fail;
 
-	page_cpupid_xchg_last(new_page, page_cpupid_last(page));
-
 	isolated = numamigrate_isolate_page(pgdat, page);
 	if (!isolated) {
 		put_page(new_page);
-- 
1.7.5.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-12-11 10:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-11 10:15 [PATCH v6 0/6] mm: sched: numa: several fixups Wanpeng Li
2013-12-11 10:15 ` Wanpeng Li
2013-12-11 10:15 ` Wanpeng Li [this message]
2013-12-11 10:15   ` [PATCH v6 1/6] sched/numa: fix set cpupid on page migration twice against thp Wanpeng Li
2013-12-11 10:15 ` [PATCH v6 2/6] sched/numa: drop sysctl_numa_balancing_settle_count sysctl Wanpeng Li
2013-12-11 10:15   ` Wanpeng Li
2013-12-11 10:15 ` [PATCH v6 3/6] sched/numa: use wrapper function task_node to get node which task is on Wanpeng Li
2013-12-11 10:15   ` Wanpeng Li
2013-12-11 10:15 ` [PATCH v6 4/6] sched/numa: fix set cpupid on page migration twice against normal page Wanpeng Li
2013-12-11 10:15   ` Wanpeng Li
2013-12-11 10:16 ` [PATCH v6 5/6] sched/numa: use wrapper function task_faults_idx to calculate index in group_faults Wanpeng Li
2013-12-11 10:16   ` Wanpeng Li
2013-12-11 10:16 ` [PATCH v6 6/6] sched/numa: fix period_slot recalculation Wanpeng Li
2013-12-11 10:16   ` Wanpeng Li
2013-12-11 10:24 ` [PATCH v6 0/6] mm: sched: numa: several fixups Peter Zijlstra
2013-12-11 10:24   ` Peter Zijlstra
2013-12-11 10:28   ` Wanpeng Li
2013-12-12  0:14   ` Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386756961-3887-2-git-send-email-liwanp@linux.vnet.ibm.com \
    --to=liwanp@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.