All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] kexec/x86: Do not map crash kernel area
@ 2013-12-11 10:26 Daniel Kiper
  0 siblings, 0 replies; only message in thread
From: Daniel Kiper @ 2013-12-11 10:26 UTC (permalink / raw)
  To: andrew.cooper3, david.vrabel, jbeulich, keir, xen-devel; +Cc: Daniel Kiper

It looks that crash kernel area was mapped deliberately. However,
there is no any references to that mapping in new and even old kexec
code. Additionally, commit messages does not explain why this mapping
was made. kexec and kdump tests (new and old version) show that they are
working without this mapping. Hence, if it is not used and everything
works with out it then remove relevant code and do not crate crash
kernel area mapping anymore.

Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
---
 xen/arch/x86/setup.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index f07ee2b..4833ca3 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -1097,9 +1097,7 @@ void __init __start_xen(unsigned long mbi_p)
                          mod[i].mod_start,
                          PFN_UP(mod[i].mod_end), PAGE_HYPERVISOR);
     }
-    map_pages_to_xen((unsigned long)__va(kexec_crash_area.start),
-                     kexec_crash_area.start >> PAGE_SHIFT,
-                     PFN_UP(kexec_crash_area.size), PAGE_HYPERVISOR);
+
     xen_virt_end = ((unsigned long)_end + (1UL << L2_PAGETABLE_SHIFT) - 1) &
                    ~((1UL << L2_PAGETABLE_SHIFT) - 1);
     destroy_xen_mappings(xen_virt_end, XEN_VIRT_START + BOOTSTRAP_MAP_BASE);
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2013-12-11 10:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-11 10:26 [PATCH v2] kexec/x86: Do not map crash kernel area Daniel Kiper

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.