All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Wanpeng Li <liwanp@linux.vnet.ibm.com>
Subject: [PATCH v8 4/4] sched/numa: fix period_slot recalculation
Date: Thu, 12 Dec 2013 15:23:26 +0800	[thread overview]
Message-ID: <1386833006-6600-4-git-send-email-liwanp@linux.vnet.ibm.com> (raw)
In-Reply-To: <1386833006-6600-1-git-send-email-liwanp@linux.vnet.ibm.com>

Changelog:
 v3 -> v4:
  * remove period_slot recalculation

The original code is as intended and was meant to scale the difference
between the NUMA_PERIOD_THRESHOLD and local/remote ratio when adjusting
the scan period. The period_slot recalculation can be dropped.

Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Acked-by: Mel Gorman <mgorman@suse.de>
Acked-by: David Rientjes <rientjes@google.com>
Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
---
 kernel/sched/fair.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 8a00879..e7ca79a 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1356,7 +1356,6 @@ static void update_task_scan_period(struct task_struct *p,
 		 * scanning faster if shared accesses dominate as it may
 		 * simply bounce migrations uselessly
 		 */
-		period_slot = DIV_ROUND_UP(diff, NUMA_PERIOD_SLOTS);
 		ratio = DIV_ROUND_UP(private * NUMA_PERIOD_SLOTS, (private + shared));
 		diff = (diff * ratio) / NUMA_PERIOD_SLOTS;
 	}
-- 
1.7.7.6


WARNING: multiple messages have this Message-ID (diff)
From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Wanpeng Li <liwanp@linux.vnet.ibm.com>
Subject: [PATCH v8 4/4] sched/numa: fix period_slot recalculation
Date: Thu, 12 Dec 2013 15:23:26 +0800	[thread overview]
Message-ID: <1386833006-6600-4-git-send-email-liwanp@linux.vnet.ibm.com> (raw)
In-Reply-To: <1386833006-6600-1-git-send-email-liwanp@linux.vnet.ibm.com>

Changelog:
 v3 -> v4:
  * remove period_slot recalculation

The original code is as intended and was meant to scale the difference
between the NUMA_PERIOD_THRESHOLD and local/remote ratio when adjusting
the scan period. The period_slot recalculation can be dropped.

Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Acked-by: Mel Gorman <mgorman@suse.de>
Acked-by: David Rientjes <rientjes@google.com>
Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
---
 kernel/sched/fair.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 8a00879..e7ca79a 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1356,7 +1356,6 @@ static void update_task_scan_period(struct task_struct *p,
 		 * scanning faster if shared accesses dominate as it may
 		 * simply bounce migrations uselessly
 		 */
-		period_slot = DIV_ROUND_UP(diff, NUMA_PERIOD_SLOTS);
 		ratio = DIV_ROUND_UP(private * NUMA_PERIOD_SLOTS, (private + shared));
 		diff = (diff * ratio) / NUMA_PERIOD_SLOTS;
 	}
-- 
1.7.7.6

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2013-12-12  7:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-12  7:23 [PATCH v8 1/4] sched/numa: drop sysctl_numa_balancing_settle_count sysctl Wanpeng Li
2013-12-12  7:23 ` Wanpeng Li
2013-12-12  7:23 ` [PATCH v8 2/4] sched/numa: use wrapper function task_node to get node which task is on Wanpeng Li
2013-12-12  7:23   ` Wanpeng Li
2013-12-18 10:32   ` [tip:sched/core] sched/numa: Use " tip-bot for Wanpeng Li
2013-12-12  7:23 ` [PATCH v8 3/4] sched/numa: use wrapper function task_faults_idx to calculate index in group_faults Wanpeng Li
2013-12-12  7:23   ` Wanpeng Li
2013-12-18 10:33   ` [tip:sched/core] sched/numa: Use " tip-bot for Wanpeng Li
2013-12-12  7:23 ` Wanpeng Li [this message]
2013-12-12  7:23   ` [PATCH v8 4/4] sched/numa: fix period_slot recalculation Wanpeng Li
2013-12-18 10:33   ` [tip:sched/core] sched/numa: Fix " tip-bot for Wanpeng Li
2013-12-13 18:09 ` [PATCH v8 1/4] sched/numa: drop sysctl_numa_balancing_settle_count sysctl Peter Zijlstra
2013-12-13 18:09   ` Peter Zijlstra
2013-12-15  8:41   ` Wanpeng Li
     [not found]   ` <20131215084110.GA4316@hacker.(null)>
2013-12-15 16:56     ` Peter Zijlstra
2013-12-15 16:56       ` Peter Zijlstra
2013-12-15 23:58       ` Wanpeng Li
2013-12-18 10:32 ` [tip:sched/core] sched/numa: Drop " tip-bot for Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386833006-6600-4-git-send-email-liwanp@linux.vnet.ibm.com \
    --to=liwanp@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.