* [PATCH] libffi: Copy headers to more common include path.
@ 2013-12-12 17:47 Fahad Arslan
2013-12-12 17:57 ` Richard Purdie
0 siblings, 1 reply; 5+ messages in thread
From: Fahad Arslan @ 2013-12-12 17:47 UTC (permalink / raw)
To: openembedded-core
Signed-off-by: Fahad Arslan <fahad_arslan@mentor.com>
---
meta/recipes-gnome/libffi/libffi_3.0.13.bb | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/meta/recipes-gnome/libffi/libffi_3.0.13.bb b/meta/recipes-gnome/libffi/libffi_3.0.13.bb
index db0841e..07dd7d1 100644
--- a/meta/recipes-gnome/libffi/libffi_3.0.13.bb
+++ b/meta/recipes-gnome/libffi/libffi_3.0.13.bb
@@ -22,3 +22,8 @@ inherit autotools
FILES_${PN}-dev += "${libdir}/libffi-${PV}"
BBCLASSEXTEND = "native nativesdk"
+
+do_install_append() {
+ install -d ${D}${includedir}
+ cp -r ${D}${libdir}/libffi-${PV}/include/* ${D}${includedir}/ || true
+}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] libffi: Copy headers to more common include path.
2013-12-12 17:47 [PATCH] libffi: Copy headers to more common include path Fahad Arslan
@ 2013-12-12 17:57 ` Richard Purdie
2013-12-12 18:04 ` Mark Hatle
2013-12-13 11:49 ` Arslan, Fahad
0 siblings, 2 replies; 5+ messages in thread
From: Richard Purdie @ 2013-12-12 17:57 UTC (permalink / raw)
To: Fahad Arslan; +Cc: openembedded-core
On Thu, 2013-12-12 at 22:47 +0500, Fahad Arslan wrote:
> Signed-off-by: Fahad Arslan <fahad_arslan@mentor.com>
> ---
> meta/recipes-gnome/libffi/libffi_3.0.13.bb | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/meta/recipes-gnome/libffi/libffi_3.0.13.bb b/meta/recipes-gnome/libffi/libffi_3.0.13.bb
> index db0841e..07dd7d1 100644
> --- a/meta/recipes-gnome/libffi/libffi_3.0.13.bb
> +++ b/meta/recipes-gnome/libffi/libffi_3.0.13.bb
> @@ -22,3 +22,8 @@ inherit autotools
> FILES_${PN}-dev += "${libdir}/libffi-${PV}"
>
> BBCLASSEXTEND = "native nativesdk"
> +
> +do_install_append() {
> + install -d ${D}${includedir}
> + cp -r ${D}${libdir}/libffi-${PV}/include/* ${D}${includedir}/ || true
> +}
Why? Shouldn't whatever is using them look for them in the correct
location?
Cheers,
Richard
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libffi: Copy headers to more common include path.
2013-12-12 17:57 ` Richard Purdie
@ 2013-12-12 18:04 ` Mark Hatle
2013-12-13 11:49 ` Arslan, Fahad
1 sibling, 0 replies; 5+ messages in thread
From: Mark Hatle @ 2013-12-12 18:04 UTC (permalink / raw)
To: openembedded-core
On 12/12/13, 11:57 AM, Richard Purdie wrote:
> On Thu, 2013-12-12 at 22:47 +0500, Fahad Arslan wrote:
>> Signed-off-by: Fahad Arslan <fahad_arslan@mentor.com>
>> ---
>> meta/recipes-gnome/libffi/libffi_3.0.13.bb | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/meta/recipes-gnome/libffi/libffi_3.0.13.bb b/meta/recipes-gnome/libffi/libffi_3.0.13.bb
>> index db0841e..07dd7d1 100644
>> --- a/meta/recipes-gnome/libffi/libffi_3.0.13.bb
>> +++ b/meta/recipes-gnome/libffi/libffi_3.0.13.bb
>> @@ -22,3 +22,8 @@ inherit autotools
>> FILES_${PN}-dev += "${libdir}/libffi-${PV}"
>>
>> BBCLASSEXTEND = "native nativesdk"
>> +
>> +do_install_append() {
>> + install -d ${D}${includedir}
>> + cp -r ${D}${libdir}/libffi-${PV}/include/* ${D}${includedir}/ || true
>> +}
>
> Why? Shouldn't whatever is using them look for them in the correct
> location?
Correct, I think this is wrong as well. Most of the time when versions are
included into the include path, the system may allow for multiple versions to be
installed and used at the same time.
--Mark
> Cheers,
>
> Richard
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libffi: Copy headers to more common include path.
2013-12-12 17:57 ` Richard Purdie
2013-12-12 18:04 ` Mark Hatle
@ 2013-12-13 11:49 ` Arslan, Fahad
2013-12-13 12:09 ` Burton, Ross
1 sibling, 1 reply; 5+ messages in thread
From: Arslan, Fahad @ 2013-12-13 11:49 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
My understanding was that headers should be placed under ${includedir} instead of
${libdir}. Isn't it the practice or am I missing something?
Thanks,
Fahad
________________________________________
From: Richard Purdie [richard.purdie@linuxfoundation.org]
Sent: Thursday, December 12, 2013 10:57 PM
To: Arslan, Fahad
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] libffi: Copy headers to more common include path.
On Thu, 2013-12-12 at 22:47 +0500, Fahad Arslan wrote:
> Signed-off-by: Fahad Arslan <fahad_arslan@mentor.com>
> ---
> meta/recipes-gnome/libffi/libffi_3.0.13.bb | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/meta/recipes-gnome/libffi/libffi_3.0.13.bb b/meta/recipes-gnome/libffi/libffi_3.0.13.bb
> index db0841e..07dd7d1 100644
> --- a/meta/recipes-gnome/libffi/libffi_3.0.13.bb
> +++ b/meta/recipes-gnome/libffi/libffi_3.0.13.bb
> @@ -22,3 +22,8 @@ inherit autotools
> FILES_${PN}-dev += "${libdir}/libffi-${PV}"
>
> BBCLASSEXTEND = "native nativesdk"
> +
> +do_install_append() {
> + install -d ${D}${includedir}
> + cp -r ${D}${libdir}/libffi-${PV}/include/* ${D}${includedir}/ || true
> +}
Why? Shouldn't whatever is using them look for them in the correct
location?
Cheers,
Richard
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libffi: Copy headers to more common include path.
2013-12-13 11:49 ` Arslan, Fahad
@ 2013-12-13 12:09 ` Burton, Ross
0 siblings, 0 replies; 5+ messages in thread
From: Burton, Ross @ 2013-12-13 12:09 UTC (permalink / raw)
To: Arslan, Fahad; +Cc: openembedded-core
On 13 December 2013 11:49, Arslan, Fahad <Fahad_Arslan@mentor.com> wrote:
> My understanding was that headers should be placed under ${includedir} instead of
> ${libdir}. Isn't it the practice or am I missing something?
If the headers are machine-specific then it's conventional to put a
user-visible include $includedir (arch-independent) which then
includes files from $libdir (arch-dependent).
Considering libffi needs to know details of the calling convention on
the machine, this is presumably what's happening. GLib does the same.
Ross
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-12-13 12:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-12 17:47 [PATCH] libffi: Copy headers to more common include path Fahad Arslan
2013-12-12 17:57 ` Richard Purdie
2013-12-12 18:04 ` Mark Hatle
2013-12-13 11:49 ` Arslan, Fahad
2013-12-13 12:09 ` Burton, Ross
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.