All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dario Faggioli <dario.faggioli@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, xen-devel@lists.xen.org
Subject: Re: [OSSTest PATCH [RFC] 2/4] ts-fedora-install: added for installing fedora guests
Date: Fri, 13 Dec 2013 18:36:11 +0100	[thread overview]
Message-ID: <1386956171.3980.27.camel@Solace> (raw)
In-Reply-To: <21163.14777.408700.773459@mariner.uk.xensource.com>


[-- Attachment #1.1: Type: text/plain, Size: 1216 bytes --]

On ven, 2013-12-13 at 16:45 +0000, Ian Jackson wrote:
> Dario Faggioli writes ("[OSSTest PATCH [RFC] 2/4] ts-fedora-install: added for installing fedora guests"):
> 
> > +    guest_await_reboot($ho, $gho, 2000);
> > +    guest_destroy($ho, $gho);
> > +
> > +    # Some fixups
> > +    store_runvar("$gho->{Guest}_tcpcheckport", 22);
> 
> The Debian guest installation is split into ts-debian-install and
> ts-debian-fixup, so that editing the fixup code doesn't involve
> rerunning the time-consuming installation step.
> 
> Would that be worth doing here as well ?
> 
Well, given the fact that Debian is installed with xen-tools, there's
probably more fixup to do there than here, and that's why it looked
sensible enough to keep the two together in this case.

Anyway, I think being able to change what we do during fixup without
necessarily having to reinstall is something valuable to have. I'll go
for it.

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2013-12-13 17:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-12 22:53 [OSSTest PATCH [RFC] 0/4] New test case: Fedora PV guests Dario Faggioli
2013-12-12 22:53 ` [OSSTest PATCH [RFC] 1/4] Introducing Osstest/Fedora.pm Dario Faggioli
2013-12-13 16:33   ` Ian Jackson
2013-12-13 17:47     ` Dario Faggioli
2013-12-12 22:53 ` [OSSTest PATCH [RFC] 2/4] ts-fedora-install: added for installing fedora guests Dario Faggioli
2013-12-13 16:44   ` Ian Jackson
2013-12-13 18:12     ` Dario Faggioli
2013-12-13 18:24       ` Ian Jackson
2013-12-13 16:45   ` Ian Jackson
2013-12-13 17:36     ` Dario Faggioli [this message]
2013-12-12 22:53 ` [OSSTest PATCH [RFC] 3/4] sg-run-job: Fedora guest job Dario Faggioli
2013-12-12 22:53 ` [OSSTest PATCH [RFC] 4/4] make-flight: Fedora guest tests Dario Faggioli
2013-12-13 16:49   ` Ian Jackson
2013-12-13 17:32     ` Dario Faggioli
2013-12-13 17:34       ` Ian Jackson
2013-12-13 18:03         ` Dario Faggioli
2013-12-13 18:20           ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386956171.3980.27.camel@Solace \
    --to=dario.faggioli@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.