All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, xen-devel@lists.xen.org
Subject: Re: [OSSTest PATCH [RFC] 4/4] make-flight: Fedora guest tests
Date: Fri, 13 Dec 2013 17:34:46 +0000	[thread overview]
Message-ID: <21163.17718.481738.503478@mariner.uk.xensource.com> (raw)
In-Reply-To: <1386955925.3980.23.camel@Solace>

Dario Faggioli writes ("Re: [OSSTest PATCH [RFC] 4/4] make-flight: Fedora guest tests"):
> On ven, 2013-12-13 at 16:49 +0000, Ian Jackson wrote:
> > This puts the Fedora arch name in the job name.  I think it would be
> > better if our job names used a consistent arch naming scheme (i.e.,
> > the Debian one).
> 
> You mean sticking with amd64 rather than x86_64? If yes, ok, I agree and
> that's easy enough.

Exactly, thanks.

> > According to your 0/4 message, this creates a large number of new test
> > jobs, but you're patching the ordinary make-flight.  So I think this
> > isn't really suitable as it is.
> > 
> So, the "lage number of new jobs" comes from the combination of Dom0
> arches and DomU arches, and from the fact that I'm testing two releases
> (19 and 20RC1, as per this series). I agree that all this variation is
> not necessary in regular flights, as I also tried to state myself in
> 0/4, so, yes, I think I can fall back to a less comprehensive set of
> test jobs, like only testing _one_ release, both amd64 and i386 for
> DomU, but only amd64 for dom0, like it is being done for the FreeBSD
> tests... Would this work?

Right.

> > Probably what we want is one or two extra jobs in the existing flights
> > (for testing new Xens still work with released Fedora) and a new more
> > comprehensive kind of flight for testing Fedora RCs.
> > 
> Ok, you mean (the final part) creating 'make-fedora-flight' with all and
> only the fedora jobs, right? Yes, I guess I can do that.

Perhaps.  I'm not sure whether it wants to be a different script or
not.  We already have some linux-specific flights which suppress most
of the jobs.  Maybe it would be better done with some ifs in the
existing script, or something.

If you do invent a make-fedora-flight you will have to factor out the
build parts of make-flight into a separate sub-script or a function in
a sourced file, or something.

Ian.

  reply	other threads:[~2013-12-13 17:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-12 22:53 [OSSTest PATCH [RFC] 0/4] New test case: Fedora PV guests Dario Faggioli
2013-12-12 22:53 ` [OSSTest PATCH [RFC] 1/4] Introducing Osstest/Fedora.pm Dario Faggioli
2013-12-13 16:33   ` Ian Jackson
2013-12-13 17:47     ` Dario Faggioli
2013-12-12 22:53 ` [OSSTest PATCH [RFC] 2/4] ts-fedora-install: added for installing fedora guests Dario Faggioli
2013-12-13 16:44   ` Ian Jackson
2013-12-13 18:12     ` Dario Faggioli
2013-12-13 18:24       ` Ian Jackson
2013-12-13 16:45   ` Ian Jackson
2013-12-13 17:36     ` Dario Faggioli
2013-12-12 22:53 ` [OSSTest PATCH [RFC] 3/4] sg-run-job: Fedora guest job Dario Faggioli
2013-12-12 22:53 ` [OSSTest PATCH [RFC] 4/4] make-flight: Fedora guest tests Dario Faggioli
2013-12-13 16:49   ` Ian Jackson
2013-12-13 17:32     ` Dario Faggioli
2013-12-13 17:34       ` Ian Jackson [this message]
2013-12-13 18:03         ` Dario Faggioli
2013-12-13 18:20           ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21163.17718.481738.503478@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=dario.faggioli@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.