All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Pedersen <twpedersen@gmail.com>
Cc: open80211s <devel@lists.open80211s.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Thomas Pedersen <thomas@cozybit.com>
Subject: Re: [PATCH 1/3] mac80211_hwsim: fix duplicate beacons on TSF adjust
Date: Mon, 16 Dec 2013 14:24:13 +0100	[thread overview]
Message-ID: <1387200253.4665.32.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1387198425.4665.28.camel@jlt4.sipsolutions.net> (sfid-20131216_135353_726110_E7D17A88)

On Mon, 2013-12-16 at 13:53 +0100, Johannes Berg wrote:
> On Sun, 2013-12-15 at 13:14 -0800, Thomas Pedersen wrote:
> > From: Thomas Pedersen <thomas@cozybit.com>
> > 
> > There was some bug when rescheduling the next beacon from
> > the beacon tasklet after adjusting TSF which would cause
> > the beacon timer to trigger twice. Beaconing at "old" TBT
> > (previously scheduled interface TBTT) with new timestamp
> > was incorrect anyway.
> > 
> > Instead, reschedule the beacon straight away when
> > adjusting TSF.
> 
> Applied.

Nope, never mind - this caused the wpa_s test cases to crash the kernel.

johannes


  reply	other threads:[~2013-12-16 13:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-15 21:14 [PATCH 1/3] mac80211_hwsim: fix duplicate beacons on TSF adjust Thomas Pedersen
2013-12-15 21:14 ` [PATCH 2/3] mac80211: reset TSF to 0 when joining a mesh Thomas Pedersen
2013-12-16 12:33   ` Sergey Ryazanov
2013-12-16 18:34     ` Thomas Pedersen
2013-12-16 21:55       ` Sergey Ryazanov
2013-12-17 17:59         ` Thomas Pedersen
2013-12-18  0:17           ` Sergey Ryazanov
2013-12-15 21:14 ` [PATCH 3/3] mac80211: update adjusting TBTT bit in beacon Thomas Pedersen
2013-12-16 12:55   ` Johannes Berg
2013-12-16 12:53 ` [PATCH 1/3] mac80211_hwsim: fix duplicate beacons on TSF adjust Johannes Berg
2013-12-16 13:24   ` Johannes Berg [this message]
2013-12-16 18:35     ` Thomas Pedersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387200253.4665.32.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=devel@lists.open80211s.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=thomas@cozybit.com \
    --cc=twpedersen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.