From: Thomas Pedersen <twpedersen@gmail.com>
To: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
open80211s <devel@lists.open80211s.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Thomas Pedersen <thomas@cozybit.com>
Subject: Re: [PATCH 2/3] mac80211: reset TSF to 0 when joining a mesh
Date: Mon, 16 Dec 2013 10:34:10 -0800 [thread overview]
Message-ID: <CAHmEv85q4c0FmvS+_kwQG9SfZgrokfYPNUvJmteKjdzxqnDvHw@mail.gmail.com> (raw)
In-Reply-To: <CAHNKnsTAJJBNT0nj8z-4mSAC_Gh1F6M7pdu3CGAMQ70+aALx4w@mail.gmail.com>
On Mon, Dec 16, 2013 at 4:33 AM, Sergey Ryazanov <ryazanov.s.a@gmail.com> wrote:
> Hello Thomas,
>
> 2013/12/16 Thomas Pedersen <twpedersen@gmail.com>:
>> diff --git a/net/mac80211/mesh.c b/net/mac80211/mesh.c
>> index 330d1f7..1174157 100644
>> --- a/net/mac80211/mesh.c
>> +++ b/net/mac80211/mesh.c
>> @@ -802,6 +802,8 @@ int ieee80211_start_mesh(struct ieee80211_sub_if_data *sdata)
>> return -ENOMEM;
>> }
>>
>> + /* next beacon will be DTIM-1, so TSF=0 was DTIM=0 */
>> + drv_set_tsf(local, sdata, 0);
>> ieee80211_bss_info_change_notify(sdata, changed);
>>
>> netif_carrier_on(sdata->dev);
>
> What happen with AP interface on the same radio if we configure mesh
> portal? Clients could be confused by such TSF jump.
Like Johannes said; either the driver supports per-vif TSF, or well,
it doesn't. Anyway wouldn't clients reset their own TSF when the new
beacon is received?
Thomas
next prev parent reply other threads:[~2013-12-16 18:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-15 21:14 [PATCH 1/3] mac80211_hwsim: fix duplicate beacons on TSF adjust Thomas Pedersen
2013-12-15 21:14 ` [PATCH 2/3] mac80211: reset TSF to 0 when joining a mesh Thomas Pedersen
2013-12-16 12:33 ` Sergey Ryazanov
2013-12-16 18:34 ` Thomas Pedersen [this message]
2013-12-16 21:55 ` Sergey Ryazanov
2013-12-17 17:59 ` Thomas Pedersen
2013-12-18 0:17 ` Sergey Ryazanov
2013-12-15 21:14 ` [PATCH 3/3] mac80211: update adjusting TBTT bit in beacon Thomas Pedersen
2013-12-16 12:55 ` Johannes Berg
2013-12-16 12:53 ` [PATCH 1/3] mac80211_hwsim: fix duplicate beacons on TSF adjust Johannes Berg
2013-12-16 13:24 ` Johannes Berg
2013-12-16 18:35 ` Thomas Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmEv85q4c0FmvS+_kwQG9SfZgrokfYPNUvJmteKjdzxqnDvHw@mail.gmail.com \
--to=twpedersen@gmail.com \
--cc=devel@lists.open80211s.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=ryazanov.s.a@gmail.com \
--cc=thomas@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.