[PATCH] ns16550: support ns16550a

[PATCH] ns16550: support ns16550a

[tsahee]

From: Tsahee Zidenberg <tsahee@gmx.com>

Ns16550a devices are Ns16550 devices with additional capabilities.
Decare XEN is compatible with this device, to be able to use unmodified
devicetrees.

Signed-off-by: Tsahee Zidenberg <tsahee@gmx.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
---
 xen/drivers/char/ns16550.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c
index 9c2cded..a947c68 100644
--- a/xen/drivers/char/ns16550.c
+++ b/xen/drivers/char/ns16550.c
@@ -817,6 +817,7 @@ static int __init ns16550_uart_dt_init(struct dt_device_node *dev,
 static const char const *ns16550_dt_compat[] __initconst =
 {
     "ns16550",
+    "ns16550a",
     "snps,dw-apb-uart",
     NULL
 };
-- 
1.8.1.2

Re: [PATCH] ns16550: support ns16550a

[Julien Grall]

On 12/22/2013 10:59 AM, tsahee@gmx.com wrote:
> From: Tsahee Zidenberg <tsahee@gmx.com>
>
> Ns16550a devices are Ns16550 devices with additional capabilities.
> Decare XEN is compatible with this device, to be able to use unmodified
> devicetrees.
>
> Signed-off-by: Tsahee Zidenberg <tsahee@gmx.com>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>

Acked-by: Julien Grall <julien.grall@linaro.org>

-- 
Julien Grall

misplaced const (was: Re: [PATCH] ns16550: support ns16550a)

[Jan Beulich]

>>> <tsahee@gmx.com> 12/22/13 3:52 PM >>>
>--- a/xen/drivers/char/ns16550.c
>+++ b/xen/drivers/char/ns16550.c
>@@ -817,6 +817,7 @@ static int __init ns16550_uart_dt_init(struct dt_device_node *dev,
>static const char const *ns16550_dt_compat[] __initconst =

This being ARM specific code, could someone please submit a patch to prevent
problems going forward with the duplicate const here (the second one really
belongs _after_ the *)?

Jan

Re: misplaced const

[Julien Grall]

On 12/23/2013 09:42 AM, Jan Beulich wrote:
>>>> <tsahee@gmx.com> 12/22/13 3:52 PM >>>
>> --- a/xen/drivers/char/ns16550.c
>> +++ b/xen/drivers/char/ns16550.c
>> @@ -817,6 +817,7 @@ static int __init ns16550_uart_dt_init(struct dt_device_node *dev,
>> static const char const *ns16550_dt_compat[] __initconst =
>
> This being ARM specific code, could someone please submit a patch to prevent
> problems going forward with the duplicate const here (the second one really
> belongs _after_ the *)?

Hi Jan,

Thanks for spotting the error. I noticed that every serial drivers which 
support Device Tree are affected by the duplicated const.

I have sent a patch on the ML: https://patches.linaro.org/22744/

Cheers,

-- 
Julien Grall

Re: [PATCH] ns16550: support ns16550a

[Ian Campbell]

On Sun, 2013-12-22 at 17:22 +0000, Julien Grall wrote:
> 
> On 12/22/2013 10:59 AM, tsahee@gmx.com wrote:
> > From: Tsahee Zidenberg <tsahee@gmx.com>
> >
> > Ns16550a devices are Ns16550 devices with additional capabilities.
> > Decare XEN is compatible with this device, to be able to use unmodified
> > devicetrees.
> >
> > Signed-off-by: Tsahee Zidenberg <tsahee@gmx.com>
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Acked-by: Julien Grall <julien.grall@linaro.org>

RM hat: There is basically no risk to existing systems since this just
adds a new compatible string. The benefit is that Xen will work on some
new set of hardware, if it turns out that things are buggy on that type
of hardware then we haven't lost anything vs. not trying to run on it at
all.

Applied, thanks.