From: Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org> To: balbi-l0cyMroinI0@public.gmane.org, shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org Cc: alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, marex-ynQEQJNshbs@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, frank.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org, peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: [PATCH v8 12/12] usb: phy-mxs: Add sync time after controller clear phcd Date: Tue, 24 Dec 2013 11:58:56 +0800 [thread overview] Message-ID: <1387857536-4996-13-git-send-email-peter.chen@freescale.com> (raw) In-Reply-To: <1387857536-4996-1-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org> After clear portsc.phcd, PHY needs 200us stable time for switch 32K clock to AHB clock. Signed-off-by: Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org> --- drivers/usb/phy/phy-mxs-usb.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c index 2722a86..ea41bb4 100644 --- a/drivers/usb/phy/phy-mxs-usb.c +++ b/drivers/usb/phy/phy-mxs-usb.c @@ -151,6 +151,15 @@ static inline bool is_imx6sl_phy(struct mxs_phy *mxs_phy) return mxs_phy->data == &imx6sl_phy_data; } +/* + * PHY needs some 32K cycles to switch from 32K clock to + * bus (such as AHB/AXI, etc) clock. + */ +static void mxs_phy_clock_switch_delay(void) +{ + usleep_range(300, 400); +} + static int mxs_phy_hw_init(struct mxs_phy *mxs_phy) { int ret; @@ -276,6 +285,7 @@ static int mxs_phy_init(struct usb_phy *phy) { struct mxs_phy *mxs_phy = to_mxs_phy(phy); + mxs_phy_clock_switch_delay(); clk_prepare_enable(mxs_phy->clk); return mxs_phy_hw_init(mxs_phy); } @@ -300,6 +310,7 @@ static int mxs_phy_suspend(struct usb_phy *x, int suspend) x->io_priv + HW_USBPHY_CTRL_SET); clk_disable_unprepare(mxs_phy->clk); } else { + mxs_phy_clock_switch_delay(); clk_prepare_enable(mxs_phy->clk); writel(BM_USBPHY_CTRL_CLKGATE, x->io_priv + HW_USBPHY_CTRL_CLR); -- 1.7.8 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: peter.chen@freescale.com (Peter Chen) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v8 12/12] usb: phy-mxs: Add sync time after controller clear phcd Date: Tue, 24 Dec 2013 11:58:56 +0800 [thread overview] Message-ID: <1387857536-4996-13-git-send-email-peter.chen@freescale.com> (raw) In-Reply-To: <1387857536-4996-1-git-send-email-peter.chen@freescale.com> After clear portsc.phcd, PHY needs 200us stable time for switch 32K clock to AHB clock. Signed-off-by: Peter Chen <peter.chen@freescale.com> --- drivers/usb/phy/phy-mxs-usb.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c index 2722a86..ea41bb4 100644 --- a/drivers/usb/phy/phy-mxs-usb.c +++ b/drivers/usb/phy/phy-mxs-usb.c @@ -151,6 +151,15 @@ static inline bool is_imx6sl_phy(struct mxs_phy *mxs_phy) return mxs_phy->data == &imx6sl_phy_data; } +/* + * PHY needs some 32K cycles to switch from 32K clock to + * bus (such as AHB/AXI, etc) clock. + */ +static void mxs_phy_clock_switch_delay(void) +{ + usleep_range(300, 400); +} + static int mxs_phy_hw_init(struct mxs_phy *mxs_phy) { int ret; @@ -276,6 +285,7 @@ static int mxs_phy_init(struct usb_phy *phy) { struct mxs_phy *mxs_phy = to_mxs_phy(phy); + mxs_phy_clock_switch_delay(); clk_prepare_enable(mxs_phy->clk); return mxs_phy_hw_init(mxs_phy); } @@ -300,6 +310,7 @@ static int mxs_phy_suspend(struct usb_phy *x, int suspend) x->io_priv + HW_USBPHY_CTRL_SET); clk_disable_unprepare(mxs_phy->clk); } else { + mxs_phy_clock_switch_delay(); clk_prepare_enable(mxs_phy->clk); writel(BM_USBPHY_CTRL_CLKGATE, x->io_priv + HW_USBPHY_CTRL_CLR); -- 1.7.8
next prev parent reply other threads:[~2013-12-24 3:58 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-12-24 3:58 [PATCH v8 00/12] Add power management support for mxs phy Peter Chen 2013-12-24 3:58 ` Peter Chen 2013-12-24 3:58 ` [PATCH v8 05/12] usb: phy-mxs: Add anatop regmap Peter Chen 2013-12-24 3:58 ` Peter Chen 2013-12-24 3:58 ` [PATCH v8 07/12] usb: phy-mxs: Enable IC fixes for related SoCs Peter Chen 2013-12-24 3:58 ` Peter Chen [not found] ` <1387857536-4996-1-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org> 2013-12-24 3:58 ` [PATCH v8 01/12] usb: doc: phy-mxs: Add more compatible strings Peter Chen 2013-12-24 3:58 ` Peter Chen 2013-12-24 3:58 ` [PATCH v8 02/12] usb: phy-mxs: Add platform judgement code Peter Chen 2013-12-24 3:58 ` Peter Chen 2013-12-24 3:58 ` [PATCH v8 03/12] usb: phy-mxs: Add auto clock and power setting Peter Chen 2013-12-24 3:58 ` Peter Chen 2013-12-24 3:58 ` [PATCH v8 04/12] usb: doc: phy-mxs: update binding for adding anatop phandle Peter Chen 2013-12-24 3:58 ` Peter Chen 2013-12-24 3:58 ` [PATCH v8 06/12] usb: phy-mxs: change description of usb device speed Peter Chen 2013-12-24 3:58 ` Peter Chen 2013-12-24 3:58 ` [PATCH v8 08/12] usb: phy-mxs: add controller id Peter Chen 2013-12-24 3:58 ` Peter Chen 2013-12-24 3:58 ` [PATCH v8 10/12] usb: phy-mxs: Add implementation of set_wakeup Peter Chen 2013-12-24 3:58 ` Peter Chen 2013-12-24 3:58 ` Peter Chen [this message] 2013-12-24 3:58 ` [PATCH v8 12/12] usb: phy-mxs: Add sync time after controller clear phcd Peter Chen 2013-12-24 3:58 ` [PATCH v8 09/12] usb: phy: Add set_wakeup API Peter Chen 2013-12-24 3:58 ` Peter Chen 2013-12-24 3:58 ` [PATCH v8 11/12] usb: phy-mxs: Add system suspend/resume API Peter Chen 2013-12-24 3:58 ` Peter Chen [not found] ` <1387857536-4996-12-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org> 2013-12-26 16:25 ` Felipe Balbi 2013-12-26 16:25 ` Felipe Balbi 2013-12-27 1:48 ` Peter Chen 2013-12-27 1:48 ` Peter Chen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1387857536-4996-13-git-send-email-peter.chen@freescale.com \ --to=peter.chen-kzfg59tc24xl57midrcfdg@public.gmane.org \ --cc=alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \ --cc=balbi-l0cyMroinI0@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=frank.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org \ --cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \ --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ --cc=marex-ynQEQJNshbs@public.gmane.org \ --cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \ --cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.