All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [PATCH] runtest/stress.part1: fix cmdline for nfsstress
@ 2013-12-24  9:00 Stanislav Kholmanskikh
  2014-02-05 10:44 ` Stanislav Kholmanskikh
  2014-02-05 11:48 ` chrubis
  0 siblings, 2 replies; 5+ messages in thread
From: Stanislav Kholmanskikh @ 2013-12-24  9:00 UTC (permalink / raw)
  To: ltp-list; +Cc: vasily.isaenko

TCbin is exported with an incorrect path therefore nfsstress
test cases fail.

Fixed with the correct path.

Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
---
 runtest/stress.part1 |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/runtest/stress.part1 b/runtest/stress.part1
index d879aaf..3b922f3 100644
--- a/runtest/stress.part1
+++ b/runtest/stress.part1
@@ -194,10 +194,10 @@ nfs03 export VERSION=2 SOCKET_TYPE=tcp; export TCbin=$LTPROOT/testcases/bin; nfs
 nfs03 export VERSION=3 SOCKET_TYPE=udp; export TCbin=$LTPROOT/testcases/bin; nfs04
 nfs03 export VERSION=3 SOCKET_TYPE=tcp; export TCbin=$LTPROOT/testcases/bin; nfs04
 
-nfsstress export VERSION=2 SOCKET_TYPE=udp; export TCbin=$LTPROOT/testcases/network/nfs/nfsstress; nfsstress 20 50 1
-nfsstress export VERSION=2 SOCKET_TYPE=tcp; export TCbin=$LTPROOT/testcases/network/nfs/nfsstress; nfsstress 20 50 1
-nfsstress export VERSION=3 SOCKET_TYPE=udp; export TCbin=$LTPROOT/testcases/network/nfs/nfsstress; nfsstress 20 50 1
-nfsstress export VERSION=3 SOCKET_TYPE=tcp; export TCbin=$LTPROOT/testcases/network/nfs/nfsstress; nfsstress 20 50 1
+nfsstress export VERSION=2 SOCKET_TYPE=udp; export TCbin=$LTPROOT/testcases/bin; nfsstress 20 50 1
+nfsstress export VERSION=2 SOCKET_TYPE=tcp; export TCbin=$LTPROOT/testcases/bin; nfsstress 20 50 1
+nfsstress export VERSION=3 SOCKET_TYPE=udp; export TCbin=$LTPROOT/testcases/bin; nfsstress 20 50 1
+nfsstress export VERSION=3 SOCKET_TYPE=tcp; export TCbin=$LTPROOT/testcases/bin; nfsstress 20 50 1
 
 nfsx-linux export VERSION=2 SOCKET_TYPE=udp; export TCbin=$LTPROOT/testcases/bin; fsx.sh
 nfsx-linux export VERSION=2 SOCKET_TYPE=tcp; export TCbin=$LTPROOT/testcases/bin; fsx.sh
-- 
1.7.1


------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH] runtest/stress.part1: fix cmdline for nfsstress
  2013-12-24  9:00 [LTP] [PATCH] runtest/stress.part1: fix cmdline for nfsstress Stanislav Kholmanskikh
@ 2014-02-05 10:44 ` Stanislav Kholmanskikh
  2014-02-05 11:48 ` chrubis
  1 sibling, 0 replies; 5+ messages in thread
From: Stanislav Kholmanskikh @ 2014-02-05 10:44 UTC (permalink / raw)
  To: ltp-list; +Cc: vasily.isaenko


On 12/24/2013 01:00 PM, Stanislav Kholmanskikh wrote:
> TCbin is exported with an incorrect path therefore nfsstress
> test cases fail.
>
> Fixed with the correct path.
>
> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
> ---

Hello!

Could anybody help to review this?

Thanks.

------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH] runtest/stress.part1: fix cmdline for nfsstress
  2013-12-24  9:00 [LTP] [PATCH] runtest/stress.part1: fix cmdline for nfsstress Stanislav Kholmanskikh
  2014-02-05 10:44 ` Stanislav Kholmanskikh
@ 2014-02-05 11:48 ` chrubis
  2014-02-06 12:44   ` [LTP] [PATCH] nfsstress: fix paths Stanislav Kholmanskikh
  1 sibling, 1 reply; 5+ messages in thread
From: chrubis @ 2014-02-05 11:48 UTC (permalink / raw)
  To: Stanislav Kholmanskikh; +Cc: vasily.isaenko, ltp-list

Hi!
> TCbin is exported with an incorrect path therefore nfsstress
> test cases fail.
> 
> Fixed with the correct path.
> 
> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>

I would rather see fix in the nfsstress to use $LTPROOT directly.

Also the TCtmp under TCbin directory is wrong, it should use use $TMPDIR
instead.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [LTP] [PATCH] nfsstress: fix paths
  2014-02-05 11:48 ` chrubis
@ 2014-02-06 12:44   ` Stanislav Kholmanskikh
  2014-02-06 13:35     ` chrubis
  0 siblings, 1 reply; 5+ messages in thread
From: Stanislav Kholmanskikh @ 2014-02-06 12:44 UTC (permalink / raw)
  To: ltp-list; +Cc: vasily.isaenko

Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
---
 runtest/stress.part1                      |    8 ++++----
 testcases/network/nfs/nfsstress/nfsstress |    6 ++----
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/runtest/stress.part1 b/runtest/stress.part1
index d879aaf..529716c 100644
--- a/runtest/stress.part1
+++ b/runtest/stress.part1
@@ -194,10 +194,10 @@ nfs03 export VERSION=2 SOCKET_TYPE=tcp; export TCbin=$LTPROOT/testcases/bin; nfs
 nfs03 export VERSION=3 SOCKET_TYPE=udp; export TCbin=$LTPROOT/testcases/bin; nfs04
 nfs03 export VERSION=3 SOCKET_TYPE=tcp; export TCbin=$LTPROOT/testcases/bin; nfs04
 
-nfsstress export VERSION=2 SOCKET_TYPE=udp; export TCbin=$LTPROOT/testcases/network/nfs/nfsstress; nfsstress 20 50 1
-nfsstress export VERSION=2 SOCKET_TYPE=tcp; export TCbin=$LTPROOT/testcases/network/nfs/nfsstress; nfsstress 20 50 1
-nfsstress export VERSION=3 SOCKET_TYPE=udp; export TCbin=$LTPROOT/testcases/network/nfs/nfsstress; nfsstress 20 50 1
-nfsstress export VERSION=3 SOCKET_TYPE=tcp; export TCbin=$LTPROOT/testcases/network/nfs/nfsstress; nfsstress 20 50 1
+nfsstress export VERSION=2 SOCKET_TYPE=udp; nfsstress 20 50 1
+nfsstress export VERSION=2 SOCKET_TYPE=tcp; nfsstress 20 50 1
+nfsstress export VERSION=3 SOCKET_TYPE=udp; nfsstress 20 50 1
+nfsstress export VERSION=3 SOCKET_TYPE=tcp; nfsstress 20 50 1
 
 nfsx-linux export VERSION=2 SOCKET_TYPE=udp; export TCbin=$LTPROOT/testcases/bin; fsx.sh
 nfsx-linux export VERSION=2 SOCKET_TYPE=tcp; export TCbin=$LTPROOT/testcases/bin; fsx.sh
diff --git a/testcases/network/nfs/nfsstress/nfsstress b/testcases/network/nfs/nfsstress/nfsstress
index 3e078d9..6e337d9 100755
--- a/testcases/network/nfs/nfsstress/nfsstress
+++ b/testcases/network/nfs/nfsstress/nfsstress
@@ -43,11 +43,9 @@ $trace_logic
 # Initialize local variables
 #-----------------------------------------------------------------------
 TC=${TC:=nfsstress}
-TCbin=${TCbin:=`pwd`}
-TCdat=${TCdat:=$TCbin}
+TCbin=${TCbin:=$LTPROOT/testcases/bin}
 TCsrc=${TCsrc:=$TCbin}
-TCtmp=${TCtmp:=$TCbin/$TC$$}
-TCdump=${TCdump:=$TCbin}
+TCtmp=${TCtmp:=$TMPDIR/$TC$$}
 RHOST=${RHOST:=`hostname|awk {'print $1'}`}
 export TCID=$TC
 export TST_TOTAL=1
-- 
1.7.1


------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH] nfsstress: fix paths
  2014-02-06 12:44   ` [LTP] [PATCH] nfsstress: fix paths Stanislav Kholmanskikh
@ 2014-02-06 13:35     ` chrubis
  0 siblings, 0 replies; 5+ messages in thread
From: chrubis @ 2014-02-06 13:35 UTC (permalink / raw)
  To: Stanislav Kholmanskikh; +Cc: vasily.isaenko, ltp-list

Hi!
> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
> ---
>  runtest/stress.part1                      |    8 ++++----
>  testcases/network/nfs/nfsstress/nfsstress |    6 ++----
>  2 files changed, 6 insertions(+), 8 deletions(-)

Pushed, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-02-06 13:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-24  9:00 [LTP] [PATCH] runtest/stress.part1: fix cmdline for nfsstress Stanislav Kholmanskikh
2014-02-05 10:44 ` Stanislav Kholmanskikh
2014-02-05 11:48 ` chrubis
2014-02-06 12:44   ` [LTP] [PATCH] nfsstress: fix paths Stanislav Kholmanskikh
2014-02-06 13:35     ` chrubis

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.