* [U-Boot] [PATCH v2 1/6] wandboard: Return from cpu_eth_init() directly
@ 2014-01-04 19:36 Fabio Estevam
2014-01-04 19:36 ` [U-Boot] [PATCH v2 2/6] titanium: " Fabio Estevam
` (5 more replies)
0 siblings, 6 replies; 8+ messages in thread
From: Fabio Estevam @ 2014-01-04 19:36 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
There is no need to print an error message when cpu_eth_init() fails because
net/eth.c already prints it.
In order to simplify the code, just return the value from cpu_eth_init(bis)
directly.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- None
board/wandboard/wandboard.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
index 0043bc6..72e9bb2 100644e
--- a/board/wandboard/wandboard.c
+++ b/board/wandboard/wandboard.c
@@ -257,15 +257,9 @@ static void setup_display(void)
int board_eth_init(bd_t *bis)
{
- int ret;
-
setup_iomux_enet();
- ret = cpu_eth_init(bis);
- if (ret)
- printf("FEC MXC: %s:failed\n", __func__);
-
- return ret;
+ return cpu_eth_init(bis);
}
int board_early_init_f(void)
--
1.8.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2 2/6] titanium: Return from cpu_eth_init() directly
2014-01-04 19:36 [U-Boot] [PATCH v2 1/6] wandboard: Return from cpu_eth_init() directly Fabio Estevam
@ 2014-01-04 19:36 ` Fabio Estevam
2014-01-06 6:45 ` Stefan Roese
2014-01-04 19:36 ` [U-Boot] [PATCH v2 3/6] mx6qarm2: Remove unneeded error message when cpu_eth_init() fails Fabio Estevam
` (4 subsequent siblings)
5 siblings, 1 reply; 8+ messages in thread
From: Fabio Estevam @ 2014-01-04 19:36 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
There is no need to print an error message when cpu_eth_init() fails because
net/eth.c already prints it.
In order to simplify the code, just return the value from cpu_eth_init(bis)
directly.
Cc: Stefan Roese <sr@denx.de>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
board/barco/titanium/titanium.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/board/barco/titanium/titanium.c b/board/barco/titanium/titanium.c
index 6db4488..84a7b84 100644
--- a/board/barco/titanium/titanium.c
+++ b/board/barco/titanium/titanium.c
@@ -264,15 +264,9 @@ int board_phy_config(struct phy_device *phydev)
int board_eth_init(bd_t *bis)
{
- int ret;
-
setup_iomux_enet();
- ret = cpu_eth_init(bis);
- if (ret)
- printf("FEC MXC: %s:failed\n", __func__);
-
- return ret;
+ return cpu_eth_init(bis);
}
int board_early_init_f(void)
--
1.8.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2 3/6] mx6qarm2: Remove unneeded error message when cpu_eth_init() fails
2014-01-04 19:36 [U-Boot] [PATCH v2 1/6] wandboard: Return from cpu_eth_init() directly Fabio Estevam
2014-01-04 19:36 ` [U-Boot] [PATCH v2 2/6] titanium: " Fabio Estevam
@ 2014-01-04 19:36 ` Fabio Estevam
2014-01-04 19:36 ` [U-Boot] [PATCH v2 4/6] mx6qsabreauto: Return from cpu_eth_init() directly Fabio Estevam
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2014-01-04 19:36 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
There is no need to print an error message when cpu_eth_init() fails because
net/eth.c already prints it.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- Separate declarations and code by a blank line
board/freescale/mx6qarm2/mx6qarm2.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/board/freescale/mx6qarm2/mx6qarm2.c b/board/freescale/mx6qarm2/mx6qarm2.c
index e063407..6c51f3a 100644
--- a/board/freescale/mx6qarm2/mx6qarm2.c
+++ b/board/freescale/mx6qarm2/mx6qarm2.c
@@ -186,13 +186,10 @@ int fecmxc_mii_postcall(int phy)
int board_eth_init(bd_t *bis)
{
struct eth_device *dev;
- int ret;
+ int ret = cpu_eth_init(bis);
- ret = cpu_eth_init(bis);
- if (ret) {
- printf("FEC MXC: %s:failed\n", __func__);
+ if (ret)
return ret;
- }
dev = eth_get_dev_by_name("FEC");
if (!dev) {
--
1.8.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2 4/6] mx6qsabreauto: Return from cpu_eth_init() directly
2014-01-04 19:36 [U-Boot] [PATCH v2 1/6] wandboard: Return from cpu_eth_init() directly Fabio Estevam
2014-01-04 19:36 ` [U-Boot] [PATCH v2 2/6] titanium: " Fabio Estevam
2014-01-04 19:36 ` [U-Boot] [PATCH v2 3/6] mx6qarm2: Remove unneeded error message when cpu_eth_init() fails Fabio Estevam
@ 2014-01-04 19:36 ` Fabio Estevam
2014-01-04 19:36 ` [U-Boot] [PATCH v2 5/6] mx6sabresd: " Fabio Estevam
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2014-01-04 19:36 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
There is no need to print an error message when cpu_eth_init() fails because
net/eth.c already prints it.
In order to simplify the code, just return the value from cpu_eth_init(bis)
directly.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
board/freescale/mx6qsabreauto/mx6qsabreauto.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/board/freescale/mx6qsabreauto/mx6qsabreauto.c b/board/freescale/mx6qsabreauto/mx6qsabreauto.c
index fc75eae..928dadf 100644
--- a/board/freescale/mx6qsabreauto/mx6qsabreauto.c
+++ b/board/freescale/mx6qsabreauto/mx6qsabreauto.c
@@ -192,15 +192,9 @@ int board_phy_config(struct phy_device *phydev)
int board_eth_init(bd_t *bis)
{
- int ret;
-
setup_iomux_enet();
- ret = cpu_eth_init(bis);
- if (ret)
- printf("FEC MXC: %s:failed\n", __func__);
-
- return ret;
+ return cpu_eth_init(bis);
}
#define BOARD_REV_B 0x200
--
1.8.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2 5/6] mx6sabresd: Return from cpu_eth_init() directly
2014-01-04 19:36 [U-Boot] [PATCH v2 1/6] wandboard: Return from cpu_eth_init() directly Fabio Estevam
` (2 preceding siblings ...)
2014-01-04 19:36 ` [U-Boot] [PATCH v2 4/6] mx6qsabreauto: Return from cpu_eth_init() directly Fabio Estevam
@ 2014-01-04 19:36 ` Fabio Estevam
2014-01-04 19:36 ` [U-Boot] [PATCH v2 6/6] mx6slevk: " Fabio Estevam
2014-01-13 10:56 ` [U-Boot] [PATCH v2 1/6] wandboard: " Stefano Babic
5 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2014-01-04 19:36 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
There is no need to print an error message when cpu_eth_init() fails because
net/eth.c already prints it.
In order to simplify the code, just return the value from cpu_eth_init(bis)
directly.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
board/freescale/mx6sabresd/mx6sabresd.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
index 2ffc3b8..12d8c56 100644
--- a/board/freescale/mx6sabresd/mx6sabresd.c
+++ b/board/freescale/mx6sabresd/mx6sabresd.c
@@ -453,15 +453,9 @@ int overwrite_console(void)
int board_eth_init(bd_t *bis)
{
- int ret;
-
setup_iomux_enet();
- ret = cpu_eth_init(bis);
- if (ret)
- printf("FEC MXC: %s:failed\n", __func__);
-
- return ret;
+ return cpu_eth_init(bis);
}
int board_early_init_f(void)
--
1.8.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2 6/6] mx6slevk: Return from cpu_eth_init() directly
2014-01-04 19:36 [U-Boot] [PATCH v2 1/6] wandboard: Return from cpu_eth_init() directly Fabio Estevam
` (3 preceding siblings ...)
2014-01-04 19:36 ` [U-Boot] [PATCH v2 5/6] mx6sabresd: " Fabio Estevam
@ 2014-01-04 19:36 ` Fabio Estevam
2014-01-13 10:56 ` [U-Boot] [PATCH v2 1/6] wandboard: " Stefano Babic
5 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2014-01-04 19:36 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
There is no need to print an error message when cpu_eth_init() fails because
net/eth.c already prints it.
In order to simplify the code, just return the value from cpu_eth_init(bis)
directly.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
board/freescale/mx6slevk/mx6slevk.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/board/freescale/mx6slevk/mx6slevk.c b/board/freescale/mx6slevk/mx6slevk.c
index 47c04ce..c496254 100644
--- a/board/freescale/mx6slevk/mx6slevk.c
+++ b/board/freescale/mx6slevk/mx6slevk.c
@@ -106,17 +106,9 @@ int board_mmc_init(bd_t *bis)
#ifdef CONFIG_FEC_MXC
int board_eth_init(bd_t *bis)
{
- int ret;
-
setup_iomux_fec();
- ret = cpu_eth_init(bis);
- if (ret) {
- printf("FEC MXC: %s:failed\n", __func__);
- return ret;
- }
-
- return 0;
+ return cpu_eth_init(bis);
}
static int setup_fec(void)
--
1.8.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2 2/6] titanium: Return from cpu_eth_init() directly
2014-01-04 19:36 ` [U-Boot] [PATCH v2 2/6] titanium: " Fabio Estevam
@ 2014-01-06 6:45 ` Stefan Roese
0 siblings, 0 replies; 8+ messages in thread
From: Stefan Roese @ 2014-01-06 6:45 UTC (permalink / raw)
To: u-boot
On 04.01.2014 20:36, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> There is no need to print an error message when cpu_eth_init() fails because
> net/eth.c already prints it.
>
> In order to simplify the code, just return the value from cpu_eth_init(bis)
> directly.
>
> Cc: Stefan Roese <sr@denx.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2 1/6] wandboard: Return from cpu_eth_init() directly
2014-01-04 19:36 [U-Boot] [PATCH v2 1/6] wandboard: Return from cpu_eth_init() directly Fabio Estevam
` (4 preceding siblings ...)
2014-01-04 19:36 ` [U-Boot] [PATCH v2 6/6] mx6slevk: " Fabio Estevam
@ 2014-01-13 10:56 ` Stefano Babic
5 siblings, 0 replies; 8+ messages in thread
From: Stefano Babic @ 2014-01-13 10:56 UTC (permalink / raw)
To: u-boot
On 04/01/2014 20:36, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> There is no need to print an error message when cpu_eth_init() fails because
> net/eth.c already prints it.
>
> In order to simplify the code, just return the value from cpu_eth_init(bis)
> directly.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied (whole series) to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-01-13 10:56 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-04 19:36 [U-Boot] [PATCH v2 1/6] wandboard: Return from cpu_eth_init() directly Fabio Estevam
2014-01-04 19:36 ` [U-Boot] [PATCH v2 2/6] titanium: " Fabio Estevam
2014-01-06 6:45 ` Stefan Roese
2014-01-04 19:36 ` [U-Boot] [PATCH v2 3/6] mx6qarm2: Remove unneeded error message when cpu_eth_init() fails Fabio Estevam
2014-01-04 19:36 ` [U-Boot] [PATCH v2 4/6] mx6qsabreauto: Return from cpu_eth_init() directly Fabio Estevam
2014-01-04 19:36 ` [U-Boot] [PATCH v2 5/6] mx6sabresd: " Fabio Estevam
2014-01-04 19:36 ` [U-Boot] [PATCH v2 6/6] mx6slevk: " Fabio Estevam
2014-01-13 10:56 ` [U-Boot] [PATCH v2 1/6] wandboard: " Stefano Babic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.