[PATCH] prefer vertical lists rather than horizontal

[PATCH] prefer vertical lists rather than horizontal

[Sami Kerola]

Hi Kay, et.al.,

This change is for libabc, and should not conflict when applied on top of
commit 3e633f4ad80eb6f222c7aa021a6f75762a31b405.


--->8----
From: Sami Kerola <kerolasa@iki.fi>
Date: Sun, 5 Jan 2014 12:05:45 +0000
Subject: [PATCH] prefer vertical lists rather than horizontal

Vertical lists, e.g., one string per line, can be version controlled
individually.  This commit also removes -Wpointer-arith duplicate from
my_CFLAGS variable.
---
 configure.ac | 42 +++++++++++++++++++++++++++++++++---------
 1 file changed, 33 insertions(+), 9 deletions(-)

diff --git a/configure.ac b/configure.ac
index 1926d18..e883619 100644
--- a/configure.ac
+++ b/configure.ac
@@ -6,13 +6,27 @@ AC_INIT([abc],
         [http://www.example.com/abc/])
 AC_CONFIG_SRCDIR([src/libabc.c])
 AC_CONFIG_AUX_DIR([build-aux])
-AM_INIT_AUTOMAKE([check-news foreign 1.11 -Wall -Wno-portability silent-rules tar-pax no-dist-gzip dist-xz subdir-objects])
+AM_INIT_AUTOMAKE([
+	check-news
+	foreign
+	1.11
+	-Wall
+	-Wno-portability
+	silent-rules
+	tar-pax
+	no-dist-gzip
+	dist-xz
+	subdir-objects
+])
 AC_PROG_CC_STDC
 AC_USE_SYSTEM_EXTENSIONS
 AC_SYS_LARGEFILE
 AC_CONFIG_MACRO_DIR([m4])
 AM_SILENT_RULES([yes])
-LT_INIT([disable-static pic-only])
+LT_INIT([
+	disable-static
+	pic-only
+])
 AC_PREFIX_DEFAULT([/usr])
 
 AC_PROG_SED
@@ -32,14 +46,24 @@ AS_IF([test "x$enable_debug" = "xyes"], [
         AC_DEFINE(ENABLE_DEBUG, [1], [Debug messages.])
 ])
 
-AC_CHECK_FUNCS([__secure_getenv secure_getenv])
+AC_CHECK_FUNCS([ \
+	__secure_getenv \
+	secure_getenv\
+])
 
-my_CFLAGS="-Wall \
--Wmissing-declarations -Wmissing-prototypes \
--Wnested-externs -Wpointer-arith \
--Wpointer-arith -Wsign-compare -Wchar-subscripts \
--Wstrict-prototypes -Wshadow \
--Wformat-security -Wtype-limits"
+my_CFLAGS="\
+-Wall \
+-Wchar-subscripts \
+-Wformat-security \
+-Wmissing-declarations \
+-Wmissing-prototypes \
+-Wnested-externs \
+-Wpointer-arith \
+-Wshadow \
+-Wsign-compare \
+-Wstrict-prototypes \
+-Wtype-limits \
+"
 AC_SUBST([my_CFLAGS])
 
 AC_CONFIG_HEADERS(config.h)
-- 
1.8.5.2

Re: [PATCH] prefer vertical lists rather than horizontal

[Kay Sievers]

On Sun, Jan 5, 2014 at 8:15 PM, Sami Kerola <kerolasa@iki.fi> wrote:
> This change is for libabc, and should not conflict when applied on top of
> commit 3e633f4ad80eb6f222c7aa021a6f75762a31b405.

Applied.

Thanks,
Kay