* [U-Boot] [PATCH] spi: sh_qspi: Add header file that defines the address of registers
@ 2014-01-08 1:16 Nobuhiro Iwamatsu
2014-01-08 17:57 ` Jagan Teki
2014-01-15 4:34 ` Jagan Teki
0 siblings, 2 replies; 10+ messages in thread
From: Nobuhiro Iwamatsu @ 2014-01-08 1:16 UTC (permalink / raw)
To: u-boot
Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
---
drivers/spi/sh_qspi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/sh_qspi.c b/drivers/spi/sh_qspi.c
index edeb42d..77ede6b 100644
--- a/drivers/spi/sh_qspi.c
+++ b/drivers/spi/sh_qspi.c
@@ -10,6 +10,7 @@
#include <common.h>
#include <malloc.h>
#include <spi.h>
+#include <asm/arch/rmobile.h>
#include <asm/io.h>
/* SH QSPI register bit masks <REG>_<BIT> */
@@ -170,7 +171,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs,
return NULL;
}
- ss->regs = (struct sh_qspi_regs *)CONFIG_SH_QSPI_BASE;
+ ss->regs = (struct sh_qspi_regs *)SH_QSPI_BASE;
/* Init SH QSPI */
sh_qspi_init(ss);
--
1.8.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] spi: sh_qspi: Add header file that defines the address of registers
2014-01-08 1:16 [U-Boot] [PATCH] spi: sh_qspi: Add header file that defines the address of registers Nobuhiro Iwamatsu
@ 2014-01-08 17:57 ` Jagan Teki
2014-01-09 4:19 ` Nobuhiro Iwamatsu
2014-01-15 4:34 ` Jagan Teki
1 sibling, 1 reply; 10+ messages in thread
From: Jagan Teki @ 2014-01-08 17:57 UTC (permalink / raw)
To: u-boot
Hi Nobuhiro Iwamatsu,
On Wed, Jan 8, 2014 at 6:46 AM, Nobuhiro Iwamatsu
<nobuhiro.iwamatsu.yj@renesas.com> wrote:
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> ---
> drivers/spi/sh_qspi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/sh_qspi.c b/drivers/spi/sh_qspi.c
> index edeb42d..77ede6b 100644
> --- a/drivers/spi/sh_qspi.c
> +++ b/drivers/spi/sh_qspi.c
> @@ -10,6 +10,7 @@
> #include <common.h>
> #include <malloc.h>
> #include <spi.h>
> +#include <asm/arch/rmobile.h>
> #include <asm/io.h>
>
> /* SH QSPI register bit masks <REG>_<BIT> */
> @@ -170,7 +171,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs,
> return NULL;
> }
>
> - ss->regs = (struct sh_qspi_regs *)CONFIG_SH_QSPI_BASE;
> + ss->regs = (struct sh_qspi_regs *)SH_QSPI_BASE;
I really don't understand where you define this macro.
--
Thanks,
Jagan.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] spi: sh_qspi: Add header file that defines the address of registers
2014-01-08 17:57 ` Jagan Teki
@ 2014-01-09 4:19 ` Nobuhiro Iwamatsu
2014-01-09 7:03 ` Jagan Teki
0 siblings, 1 reply; 10+ messages in thread
From: Nobuhiro Iwamatsu @ 2014-01-09 4:19 UTC (permalink / raw)
To: u-boot
Hi,
This macro was changed by following patch.
http://patchwork.ozlabs.org/patch/307934/
I should have been CC to you this.
Best regards,
Nobuhiro
2014/1/9 Jagan Teki <jagannadh.teki@gmail.com>:
> Hi Nobuhiro Iwamatsu,
>
> On Wed, Jan 8, 2014 at 6:46 AM, Nobuhiro Iwamatsu
> <nobuhiro.iwamatsu.yj@renesas.com> wrote:
>> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>> ---
>> drivers/spi/sh_qspi.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/spi/sh_qspi.c b/drivers/spi/sh_qspi.c
>> index edeb42d..77ede6b 100644
>> --- a/drivers/spi/sh_qspi.c
>> +++ b/drivers/spi/sh_qspi.c
>> @@ -10,6 +10,7 @@
>> #include <common.h>
>> #include <malloc.h>
>> #include <spi.h>
>> +#include <asm/arch/rmobile.h>
>> #include <asm/io.h>
>>
>> /* SH QSPI register bit masks <REG>_<BIT> */
>> @@ -170,7 +171,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs,
>> return NULL;
>> }
>>
>> - ss->regs = (struct sh_qspi_regs *)CONFIG_SH_QSPI_BASE;
>> + ss->regs = (struct sh_qspi_regs *)SH_QSPI_BASE;
>
> I really don't understand where you define this macro.
>
> --
> Thanks,
> Jagan.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
--
Nobuhiro Iwamatsu
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] spi: sh_qspi: Add header file that defines the address of registers
2014-01-09 4:19 ` Nobuhiro Iwamatsu
@ 2014-01-09 7:03 ` Jagan Teki
2014-01-14 0:01 ` Nobuhiro Iwamatsu
0 siblings, 1 reply; 10+ messages in thread
From: Jagan Teki @ 2014-01-09 7:03 UTC (permalink / raw)
To: u-boot
Hi Nobuhiro,
On Thu, Jan 9, 2014 at 9:49 AM, Nobuhiro Iwamatsu
<nobuhiro.iwamatsu.yj@renesas.com> wrote:
> Hi,
>
> This macro was changed by following patch.
> http://patchwork.ozlabs.org/patch/307934/
OK.
I will pick this once Albert pop your PR.
Any more spi patches?
>
> I should have been CC to you this.
>
> Best regards,
> Nobuhiro
>
> 2014/1/9 Jagan Teki <jagannadh.teki@gmail.com>:
>> Hi Nobuhiro Iwamatsu,
>>
>> On Wed, Jan 8, 2014 at 6:46 AM, Nobuhiro Iwamatsu
>> <nobuhiro.iwamatsu.yj@renesas.com> wrote:
>>> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>>> ---
>>> drivers/spi/sh_qspi.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/spi/sh_qspi.c b/drivers/spi/sh_qspi.c
>>> index edeb42d..77ede6b 100644
>>> --- a/drivers/spi/sh_qspi.c
>>> +++ b/drivers/spi/sh_qspi.c
>>> @@ -10,6 +10,7 @@
>>> #include <common.h>
>>> #include <malloc.h>
>>> #include <spi.h>
>>> +#include <asm/arch/rmobile.h>
>>> #include <asm/io.h>
>>>
>>> /* SH QSPI register bit masks <REG>_<BIT> */
>>> @@ -170,7 +171,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs,
>>> return NULL;
>>> }
>>>
>>> - ss->regs = (struct sh_qspi_regs *)CONFIG_SH_QSPI_BASE;
>>> + ss->regs = (struct sh_qspi_regs *)SH_QSPI_BASE;
>>
>> I really don't understand where you define this macro.
>>
--
Thanks,
Jagan.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] spi: sh_qspi: Add header file that defines the address of registers
2014-01-09 7:03 ` Jagan Teki
@ 2014-01-14 0:01 ` Nobuhiro Iwamatsu
2014-01-14 0:12 ` Nobuhiro Iwamatsu
0 siblings, 1 reply; 10+ messages in thread
From: Nobuhiro Iwamatsu @ 2014-01-14 0:01 UTC (permalink / raw)
To: u-boot
Hi, Jagan.
2014/1/9 Jagan Teki <jagannadh.teki@gmail.com>:
> Hi Nobuhiro,
>
> On Thu, Jan 9, 2014 at 9:49 AM, Nobuhiro Iwamatsu
> <nobuhiro.iwamatsu.yj@renesas.com> wrote:
>> Hi,
>>
>> This macro was changed by following patch.
>> http://patchwork.ozlabs.org/patch/307934/
> OK.
> I will pick this once Albert pop your PR.
>
> Any more spi patches?
>
I dont have SPI patches.
Thank you.
Best regards,
Nobuhiro
>>
>> I should have been CC to you this.
>>
>> Best regards,
>> Nobuhiro
>>
>> 2014/1/9 Jagan Teki <jagannadh.teki@gmail.com>:
>>> Hi Nobuhiro Iwamatsu,
>>>
>>> On Wed, Jan 8, 2014 at 6:46 AM, Nobuhiro Iwamatsu
>>> <nobuhiro.iwamatsu.yj@renesas.com> wrote:
>>>> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>>>> ---
>>>> drivers/spi/sh_qspi.c | 3 ++-
>>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/spi/sh_qspi.c b/drivers/spi/sh_qspi.c
>>>> index edeb42d..77ede6b 100644
>>>> --- a/drivers/spi/sh_qspi.c
>>>> +++ b/drivers/spi/sh_qspi.c
>>>> @@ -10,6 +10,7 @@
>>>> #include <common.h>
>>>> #include <malloc.h>
>>>> #include <spi.h>
>>>> +#include <asm/arch/rmobile.h>
>>>> #include <asm/io.h>
>>>>
>>>> /* SH QSPI register bit masks <REG>_<BIT> */
>>>> @@ -170,7 +171,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs,
>>>> return NULL;
>>>> }
>>>>
>>>> - ss->regs = (struct sh_qspi_regs *)CONFIG_SH_QSPI_BASE;
>>>> + ss->regs = (struct sh_qspi_regs *)SH_QSPI_BASE;
>>>
>>> I really don't understand where you define this macro.
>>>
>
> --
> Thanks,
> Jagan.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
--
Nobuhiro Iwamatsu
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] spi: sh_qspi: Add header file that defines the address of registers
2014-01-14 0:01 ` Nobuhiro Iwamatsu
@ 2014-01-14 0:12 ` Nobuhiro Iwamatsu
2014-01-14 6:25 ` Jagan Teki
0 siblings, 1 reply; 10+ messages in thread
From: Nobuhiro Iwamatsu @ 2014-01-14 0:12 UTC (permalink / raw)
To: u-boot
Hi,
2014/1/14 Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>:
> Hi, Jagan.
>
> 2014/1/9 Jagan Teki <jagannadh.teki@gmail.com>:
>> Hi Nobuhiro,
>>
>> On Thu, Jan 9, 2014 at 9:49 AM, Nobuhiro Iwamatsu
>> <nobuhiro.iwamatsu.yj@renesas.com> wrote:
>>> Hi,
>>>
>>> This macro was changed by following patch.
>>> http://patchwork.ozlabs.org/patch/307934/
>> OK.
>> I will pick this once Albert pop your PR.
Or there is also a path you take in this patch.
This patch is set. If you are not taken at the same time, this will
not be build.
Albert, do you think about this?
Best regards,
Nobuhiro
>>
>> Any more spi patches?
>>
>
> I dont have SPI patches.
> Thank you.
>
> Best regards,
> Nobuhiro
>
>>>
>>> I should have been CC to you this.
>>>
>>> Best regards,
>>> Nobuhiro
>>>
>>> 2014/1/9 Jagan Teki <jagannadh.teki@gmail.com>:
>>>> Hi Nobuhiro Iwamatsu,
>>>>
>>>> On Wed, Jan 8, 2014 at 6:46 AM, Nobuhiro Iwamatsu
>>>> <nobuhiro.iwamatsu.yj@renesas.com> wrote:
>>>>> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>>>>> ---
>>>>> drivers/spi/sh_qspi.c | 3 ++-
>>>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/spi/sh_qspi.c b/drivers/spi/sh_qspi.c
>>>>> index edeb42d..77ede6b 100644
>>>>> --- a/drivers/spi/sh_qspi.c
>>>>> +++ b/drivers/spi/sh_qspi.c
>>>>> @@ -10,6 +10,7 @@
>>>>> #include <common.h>
>>>>> #include <malloc.h>
>>>>> #include <spi.h>
>>>>> +#include <asm/arch/rmobile.h>
>>>>> #include <asm/io.h>
>>>>>
>>>>> /* SH QSPI register bit masks <REG>_<BIT> */
>>>>> @@ -170,7 +171,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs,
>>>>> return NULL;
>>>>> }
>>>>>
>>>>> - ss->regs = (struct sh_qspi_regs *)CONFIG_SH_QSPI_BASE;
>>>>> + ss->regs = (struct sh_qspi_regs *)SH_QSPI_BASE;
>>>>
>>>> I really don't understand where you define this macro.
>>>>
>>
>> --
>> Thanks,
>> Jagan.
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>
>
>
> --
> Nobuhiro Iwamatsu
--
Nobuhiro Iwamatsu
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] spi: sh_qspi: Add header file that defines the address of registers
2014-01-14 0:12 ` Nobuhiro Iwamatsu
@ 2014-01-14 6:25 ` Jagan Teki
2014-01-14 23:43 ` Nobuhiro Iwamatsu
0 siblings, 1 reply; 10+ messages in thread
From: Jagan Teki @ 2014-01-14 6:25 UTC (permalink / raw)
To: u-boot
Hi Nobuhiro,
On Tue, Jan 14, 2014 at 5:42 AM, Nobuhiro Iwamatsu
<nobuhiro.iwamatsu.yj@renesas.com> wrote:
> Hi,
>
> 2014/1/14 Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>:
>> Hi, Jagan.
>>
>> 2014/1/9 Jagan Teki <jagannadh.teki@gmail.com>:
>>> Hi Nobuhiro,
>>>
>>> On Thu, Jan 9, 2014 at 9:49 AM, Nobuhiro Iwamatsu
>>> <nobuhiro.iwamatsu.yj@renesas.com> wrote:
>>>> Hi,
>>>>
>>>> This macro was changed by following patch.
>>>> http://patchwork.ozlabs.org/patch/307934/
>>> OK.
>>> I will pick this once Albert pop your PR.
>
> Or there is also a path you take in this patch.
> This patch is set. If you are not taken at the same time, this will
> not be build.
OK. I will mark the reviewed-by tag on this patch so-that we can send
PR all together to Albert.
is it fine for you?
>
> Albert, do you think about this?
>
> Best regards,
> Nobuhiro
>>>
>>> Any more spi patches?
>>>
>>
>> I dont have SPI patches.
>> Thank you.
>>
>> Best regards,
>> Nobuhiro
>>
>>>>
>>>> I should have been CC to you this.
>>>>
>>>> Best regards,
>>>> Nobuhiro
>>>>
>>>> 2014/1/9 Jagan Teki <jagannadh.teki@gmail.com>:
>>>>> Hi Nobuhiro Iwamatsu,
>>>>>
>>>>> On Wed, Jan 8, 2014 at 6:46 AM, Nobuhiro Iwamatsu
>>>>> <nobuhiro.iwamatsu.yj@renesas.com> wrote:
>>>>>> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>>>>>> ---
>>>>>> drivers/spi/sh_qspi.c | 3 ++-
>>>>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/drivers/spi/sh_qspi.c b/drivers/spi/sh_qspi.c
>>>>>> index edeb42d..77ede6b 100644
>>>>>> --- a/drivers/spi/sh_qspi.c
>>>>>> +++ b/drivers/spi/sh_qspi.c
>>>>>> @@ -10,6 +10,7 @@
>>>>>> #include <common.h>
>>>>>> #include <malloc.h>
>>>>>> #include <spi.h>
>>>>>> +#include <asm/arch/rmobile.h>
>>>>>> #include <asm/io.h>
>>>>>>
>>>>>> /* SH QSPI register bit masks <REG>_<BIT> */
>>>>>> @@ -170,7 +171,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs,
>>>>>> return NULL;
>>>>>> }
>>>>>>
>>>>>> - ss->regs = (struct sh_qspi_regs *)CONFIG_SH_QSPI_BASE;
>>>>>> + ss->regs = (struct sh_qspi_regs *)SH_QSPI_BASE;
>>>>>
>>>>> I really don't understand where you define this macro.
>>>>>
--
Thanks,
Jagan.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] spi: sh_qspi: Add header file that defines the address of registers
2014-01-14 6:25 ` Jagan Teki
@ 2014-01-14 23:43 ` Nobuhiro Iwamatsu
0 siblings, 0 replies; 10+ messages in thread
From: Nobuhiro Iwamatsu @ 2014-01-14 23:43 UTC (permalink / raw)
To: u-boot
Hi, Jagan.
2014/1/14 Jagan Teki <jagannadh.teki@gmail.com>:
> Hi Nobuhiro,
>
> On Tue, Jan 14, 2014 at 5:42 AM, Nobuhiro Iwamatsu
> <nobuhiro.iwamatsu.yj@renesas.com> wrote:
>> Hi,
>>
>> 2014/1/14 Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>:
>>> Hi, Jagan.
>>>
>>> 2014/1/9 Jagan Teki <jagannadh.teki@gmail.com>:
>>>> Hi Nobuhiro,
>>>>
>>>> On Thu, Jan 9, 2014 at 9:49 AM, Nobuhiro Iwamatsu
>>>> <nobuhiro.iwamatsu.yj@renesas.com> wrote:
>>>>> Hi,
>>>>>
>>>>> This macro was changed by following patch.
>>>>> http://patchwork.ozlabs.org/patch/307934/
>>>> OK.
>>>> I will pick this once Albert pop your PR.
>>
>> Or there is also a path you take in this patch.
>> This patch is set. If you are not taken at the same time, this will
>> not be build.
>
> OK. I will mark the reviewed-by tag on this patch so-that we can send
> PR all together to Albert.
> is it fine for you?
Yes, it is fine to me. Thanks!
Best regards,
Nobuhiro
>
>>
>> Albert, do you think about this?
>>
>> Best regards,
>> Nobuhiro
>>>>
>>>> Any more spi patches?
>>>>
>>>
>>> I dont have SPI patches.
>>> Thank you.
>>>
>>> Best regards,
>>> Nobuhiro
>>>
>>>>>
>>>>> I should have been CC to you this.
>>>>>
>>>>> Best regards,
>>>>> Nobuhiro
>>>>>
>>>>> 2014/1/9 Jagan Teki <jagannadh.teki@gmail.com>:
>>>>>> Hi Nobuhiro Iwamatsu,
>>>>>>
>>>>>> On Wed, Jan 8, 2014 at 6:46 AM, Nobuhiro Iwamatsu
>>>>>> <nobuhiro.iwamatsu.yj@renesas.com> wrote:
>>>>>>> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>>>>>>> ---
>>>>>>> drivers/spi/sh_qspi.c | 3 ++-
>>>>>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>>>
>>>>>>> diff --git a/drivers/spi/sh_qspi.c b/drivers/spi/sh_qspi.c
>>>>>>> index edeb42d..77ede6b 100644
>>>>>>> --- a/drivers/spi/sh_qspi.c
>>>>>>> +++ b/drivers/spi/sh_qspi.c
>>>>>>> @@ -10,6 +10,7 @@
>>>>>>> #include <common.h>
>>>>>>> #include <malloc.h>
>>>>>>> #include <spi.h>
>>>>>>> +#include <asm/arch/rmobile.h>
>>>>>>> #include <asm/io.h>
>>>>>>>
>>>>>>> /* SH QSPI register bit masks <REG>_<BIT> */
>>>>>>> @@ -170,7 +171,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs,
>>>>>>> return NULL;
>>>>>>> }
>>>>>>>
>>>>>>> - ss->regs = (struct sh_qspi_regs *)CONFIG_SH_QSPI_BASE;
>>>>>>> + ss->regs = (struct sh_qspi_regs *)SH_QSPI_BASE;
>>>>>>
>>>>>> I really don't understand where you define this macro.
>>>>>>
>
> --
> Thanks,
> Jagan.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
--
Nobuhiro Iwamatsu
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] spi: sh_qspi: Add header file that defines the address of registers
2014-01-08 1:16 [U-Boot] [PATCH] spi: sh_qspi: Add header file that defines the address of registers Nobuhiro Iwamatsu
2014-01-08 17:57 ` Jagan Teki
@ 2014-01-15 4:34 ` Jagan Teki
2014-01-15 7:05 ` Nobuhiro Iwamatsu
1 sibling, 1 reply; 10+ messages in thread
From: Jagan Teki @ 2014-01-15 4:34 UTC (permalink / raw)
To: u-boot
On Wed, Jan 8, 2014 at 6:46 AM, Nobuhiro Iwamatsu
<nobuhiro.iwamatsu.yj@renesas.com> wrote:
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> ---
> drivers/spi/sh_qspi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/sh_qspi.c b/drivers/spi/sh_qspi.c
> index edeb42d..77ede6b 100644
> --- a/drivers/spi/sh_qspi.c
> +++ b/drivers/spi/sh_qspi.c
> @@ -10,6 +10,7 @@
> #include <common.h>
> #include <malloc.h>
> #include <spi.h>
> +#include <asm/arch/rmobile.h>
> #include <asm/io.h>
>
> /* SH QSPI register bit masks <REG>_<BIT> */
> @@ -170,7 +171,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs,
> return NULL;
> }
>
> - ss->regs = (struct sh_qspi_regs *)CONFIG_SH_QSPI_BASE;
> + ss->regs = (struct sh_qspi_regs *)SH_QSPI_BASE;
>
> /* Init SH QSPI */
> sh_qspi_init(ss);
> --
> 1.8.5
>
Reviewed-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
--
Thanks,
Jagan.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] spi: sh_qspi: Add header file that defines the address of registers
2014-01-15 4:34 ` Jagan Teki
@ 2014-01-15 7:05 ` Nobuhiro Iwamatsu
0 siblings, 0 replies; 10+ messages in thread
From: Nobuhiro Iwamatsu @ 2014-01-15 7:05 UTC (permalink / raw)
To: u-boot
2014/1/15 Jagan Teki <jagannadh.teki@gmail.com>:
> On Wed, Jan 8, 2014 at 6:46 AM, Nobuhiro Iwamatsu
> <nobuhiro.iwamatsu.yj@renesas.com> wrote:
>> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>> ---
>> drivers/spi/sh_qspi.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/spi/sh_qspi.c b/drivers/spi/sh_qspi.c
>> index edeb42d..77ede6b 100644
>> --- a/drivers/spi/sh_qspi.c
>> +++ b/drivers/spi/sh_qspi.c
>> @@ -10,6 +10,7 @@
>> #include <common.h>
>> #include <malloc.h>
>> #include <spi.h>
>> +#include <asm/arch/rmobile.h>
>> #include <asm/io.h>
>>
>> /* SH QSPI register bit masks <REG>_<BIT> */
>> @@ -170,7 +171,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs,
>> return NULL;
>> }
>>
>> - ss->regs = (struct sh_qspi_regs *)CONFIG_SH_QSPI_BASE;
>> + ss->regs = (struct sh_qspi_regs *)SH_QSPI_BASE;
>>
>> /* Init SH QSPI */
>> sh_qspi_init(ss);
>> --
>> 1.8.5
>>
>
> Reviewed-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
>
Thanks!
--
Nobuhiro Iwamatsu
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-01-15 7:05 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-08 1:16 [U-Boot] [PATCH] spi: sh_qspi: Add header file that defines the address of registers Nobuhiro Iwamatsu
2014-01-08 17:57 ` Jagan Teki
2014-01-09 4:19 ` Nobuhiro Iwamatsu
2014-01-09 7:03 ` Jagan Teki
2014-01-14 0:01 ` Nobuhiro Iwamatsu
2014-01-14 0:12 ` Nobuhiro Iwamatsu
2014-01-14 6:25 ` Jagan Teki
2014-01-14 23:43 ` Nobuhiro Iwamatsu
2014-01-15 4:34 ` Jagan Teki
2014-01-15 7:05 ` Nobuhiro Iwamatsu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.