All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH][meta-qt5][jansa/qt5-5.2.0]] qtbase: fix typo in PATH_EXTERNAL_HOST_BINS-patch
@ 2014-01-09 16:48 Andreas Müller
  2014-01-09 16:48 ` Andreas Müller
  0 siblings, 1 reply; 6+ messages in thread
From: Andreas Müller @ 2014-01-09 16:48 UTC (permalink / raw)
  To: openembedded-devel

I did not check if this error is in master branch - but hopefully 5.2 gets merged soon...

Andreas Müller (1):
  qtbase: fix typo in PATH_EXTERNAL_HOST_BINS-patch

 .../0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.8.3.1



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH][meta-qt5][jansa/qt5-5.2.0]] qtbase: fix typo in PATH_EXTERNAL_HOST_BINS-patch
  2014-01-09 16:48 [PATCH][meta-qt5][jansa/qt5-5.2.0]] qtbase: fix typo in PATH_EXTERNAL_HOST_BINS-patch Andreas Müller
@ 2014-01-09 16:48 ` Andreas Müller
  2014-01-09 23:29   ` Martin Jansa
  2014-02-10 11:47   ` Andreas Müller
  0 siblings, 2 replies; 6+ messages in thread
From: Andreas Müller @ 2014-01-09 16:48 UTC (permalink / raw)
  To: openembedded-devel

libraries based on cmake and depending on qt5qml failed to configure with:

|   The imported target "Qt5::DBus" references the file
|
|      "/home/a.mueller/tmp/oe-core-eglibc/sysroots/x86_64-linux/usr/bin/qt5/qdbusxml2xml"

Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
---
 .../0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-qt/qt5/qtbase/0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch b/recipes-qt/qt5/qtbase/0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch
index e3f1b72..ea3364e 100644
--- a/recipes-qt/qt5/qtbase/0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch
+++ b/recipes-qt/qt5/qtbase/0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch
@@ -54,7 +54,7 @@ index 1d94715..617efa8 100644
      set(imported_location \"${_qt5DBus_install_prefix}/$${CMAKE_BIN_DIR}qdbuscpp2xml$$CMAKE_BIN_SUFFIX\")
  !!ELSE
 -    set(imported_location \"$${CMAKE_BIN_DIR}qdbuscpp2xml$$CMAKE_BIN_SUFFIX\")
-+    set(imported_location \"${OE_QMAKE_PATH_EXTERNAL_HOST_BINS}/qdbusxml2xml$$CMAKE_BIN_SUFFIX\")
++    set(imported_location \"${OE_QMAKE_PATH_EXTERNAL_HOST_BINS}/qdbuscpp2xml$$CMAKE_BIN_SUFFIX\")
  !!ENDIF
      _qt5_DBus_check_file_exists(${imported_location})
  
-- 
1.8.3.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH][meta-qt5][jansa/qt5-5.2.0]] qtbase: fix typo in PATH_EXTERNAL_HOST_BINS-patch
  2014-01-09 16:48 ` Andreas Müller
@ 2014-01-09 23:29   ` Martin Jansa
  2014-01-13 10:14     ` Martin Jansa
  2014-02-10 11:47   ` Andreas Müller
  1 sibling, 1 reply; 6+ messages in thread
From: Martin Jansa @ 2014-01-09 23:29 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 2225 bytes --]

On Thu, Jan 09, 2014 at 05:48:26PM +0100, Andreas Müller wrote:
> libraries based on cmake and depending on qt5qml failed to configure with:
> 
> |   The imported target "Qt5::DBus" references the file
> |
> |      "/home/a.mueller/tmp/oe-core-eglibc/sysroots/x86_64-linux/usr/bin/qt5/qdbusxml2xml"

Thanks, it's typo only in 5.2.0, there was extra bindir in paths and
when I was fixing it I've noticed that OE_QMAKE_PATH_EXTERNAL_HOST_BINS
wasint used for qdbus*.

Last thing I want to fix in 5.2.0 before merge to master are wrong
(mostly empty) PRIVATE_INCLUDE_DIRS variables in cmake - that's what
prevents me to switch webos-ports to 5.2.0 now.

A bit longer description is now included in
https://github.com/meta-qt5/qtbase/blob/stable/oe-patches.txt
 
> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> ---
>  .../0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch     | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-qt/qt5/qtbase/0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch b/recipes-qt/qt5/qtbase/0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch
> index e3f1b72..ea3364e 100644
> --- a/recipes-qt/qt5/qtbase/0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch
> +++ b/recipes-qt/qt5/qtbase/0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch
> @@ -54,7 +54,7 @@ index 1d94715..617efa8 100644
>       set(imported_location \"${_qt5DBus_install_prefix}/$${CMAKE_BIN_DIR}qdbuscpp2xml$$CMAKE_BIN_SUFFIX\")
>   !!ELSE
>  -    set(imported_location \"$${CMAKE_BIN_DIR}qdbuscpp2xml$$CMAKE_BIN_SUFFIX\")
> -+    set(imported_location \"${OE_QMAKE_PATH_EXTERNAL_HOST_BINS}/qdbusxml2xml$$CMAKE_BIN_SUFFIX\")
> ++    set(imported_location \"${OE_QMAKE_PATH_EXTERNAL_HOST_BINS}/qdbuscpp2xml$$CMAKE_BIN_SUFFIX\")
>   !!ENDIF
>       _qt5_DBus_check_file_exists(${imported_location})
>   
> -- 
> 1.8.3.1
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH][meta-qt5][jansa/qt5-5.2.0]] qtbase: fix typo in PATH_EXTERNAL_HOST_BINS-patch
  2014-01-09 23:29   ` Martin Jansa
@ 2014-01-13 10:14     ` Martin Jansa
  0 siblings, 0 replies; 6+ messages in thread
From: Martin Jansa @ 2014-01-13 10:14 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 2896 bytes --]

On Fri, Jan 10, 2014 at 12:29:37AM +0100, Martin Jansa wrote:
> On Thu, Jan 09, 2014 at 05:48:26PM +0100, Andreas Müller wrote:
> > libraries based on cmake and depending on qt5qml failed to configure with:
> > 
> > |   The imported target "Qt5::DBus" references the file
> > |
> > |      "/home/a.mueller/tmp/oe-core-eglibc/sysroots/x86_64-linux/usr/bin/qt5/qdbusxml2xml"
> 
> Thanks, it's typo only in 5.2.0, there was extra bindir in paths and
> when I was fixing it I've noticed that OE_QMAKE_PATH_EXTERNAL_HOST_BINS
> wasint used for qdbus*.
> 
> Last thing I want to fix in 5.2.0 before merge to master are wrong
> (mostly empty) PRIVATE_INCLUDE_DIRS variables in cmake - that's what
> prevents me to switch webos-ports to 5.2.0 now.
> 
> A bit longer description is now included in
> https://github.com/meta-qt5/qtbase/blob/stable/oe-patches.txt

This is now fixed by last commit
https://github.com/meta-qt5/meta-qt5/tree/jansa/qt5-5.2.0

but I have found one new issue after this -
meta-webos-ports/recipes-qt/qt5/qt5-qpa-hwcomposer-plugin_git.bb
started to fail just after this header change, so I need to check if it
has some other bad side-effects.

and I would like to give Jacob a chance to debug
http://lists.openembedded.org/pipermail/openembedded-devel/2014-January/093688.html

> > Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> > ---
> >  .../0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch     | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/recipes-qt/qt5/qtbase/0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch b/recipes-qt/qt5/qtbase/0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch
> > index e3f1b72..ea3364e 100644
> > --- a/recipes-qt/qt5/qtbase/0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch
> > +++ b/recipes-qt/qt5/qtbase/0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch
> > @@ -54,7 +54,7 @@ index 1d94715..617efa8 100644
> >       set(imported_location \"${_qt5DBus_install_prefix}/$${CMAKE_BIN_DIR}qdbuscpp2xml$$CMAKE_BIN_SUFFIX\")
> >   !!ELSE
> >  -    set(imported_location \"$${CMAKE_BIN_DIR}qdbuscpp2xml$$CMAKE_BIN_SUFFIX\")
> > -+    set(imported_location \"${OE_QMAKE_PATH_EXTERNAL_HOST_BINS}/qdbusxml2xml$$CMAKE_BIN_SUFFIX\")
> > ++    set(imported_location \"${OE_QMAKE_PATH_EXTERNAL_HOST_BINS}/qdbuscpp2xml$$CMAKE_BIN_SUFFIX\")
> >   !!ENDIF
> >       _qt5_DBus_check_file_exists(${imported_location})
> >   
> > -- 
> > 1.8.3.1
> > 
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> 
> -- 
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com



-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH][meta-qt5][jansa/qt5-5.2.0]] qtbase: fix typo in PATH_EXTERNAL_HOST_BINS-patch
  2014-01-09 16:48 ` Andreas Müller
  2014-01-09 23:29   ` Martin Jansa
@ 2014-02-10 11:47   ` Andreas Müller
  2014-02-10 17:52     ` Martin Jansa
  1 sibling, 1 reply; 6+ messages in thread
From: Andreas Müller @ 2014-02-10 11:47 UTC (permalink / raw)
  To: openembedded-devel

On Thu, Jan 9, 2014 at 5:48 PM, Andreas Müller
<schnitzeltony@googlemail.com> wrote:
> libraries based on cmake and depending on qt5qml failed to configure with:
>
> |   The imported target "Qt5::DBus" references the file
> |
> |      "/home/a.mueller/tmp/oe-core-eglibc/sysroots/x86_64-linux/usr/bin/qt5/qdbusxml2xml"
>
> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> ---
>  .../0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch     | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-qt/qt5/qtbase/0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch b/recipes-qt/qt5/qtbase/0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch
> index e3f1b72..ea3364e 100644
> --- a/recipes-qt/qt5/qtbase/0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch
> +++ b/recipes-qt/qt5/qtbase/0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch
> @@ -54,7 +54,7 @@ index 1d94715..617efa8 100644
>       set(imported_location \"${_qt5DBus_install_prefix}/$${CMAKE_BIN_DIR}qdbuscpp2xml$$CMAKE_BIN_SUFFIX\")
>   !!ELSE
>  -    set(imported_location \"$${CMAKE_BIN_DIR}qdbuscpp2xml$$CMAKE_BIN_SUFFIX\")
> -+    set(imported_location \"${OE_QMAKE_PATH_EXTERNAL_HOST_BINS}/qdbusxml2xml$$CMAKE_BIN_SUFFIX\")
> ++    set(imported_location \"${OE_QMAKE_PATH_EXTERNAL_HOST_BINS}/qdbuscpp2xml$$CMAKE_BIN_SUFFIX\")
>   !!ENDIF
>       _qt5_DBus_check_file_exists(${imported_location})
>
> --
> 1.8.3.1
>
This one is back in 5.2.1. Shall I send a patch?

Andreas


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH][meta-qt5][jansa/qt5-5.2.0]] qtbase: fix typo in PATH_EXTERNAL_HOST_BINS-patch
  2014-02-10 11:47   ` Andreas Müller
@ 2014-02-10 17:52     ` Martin Jansa
  0 siblings, 0 replies; 6+ messages in thread
From: Martin Jansa @ 2014-02-10 17:52 UTC (permalink / raw)
  To: openembedded-devel

Ah sorry, it wasn't included in "stable" branch of meta-qt5/qtbase which I
used to rebase for 5.2.1, I've seen your patch already, I'll integrate it
in next few days.


On Mon, Feb 10, 2014 at 12:47 PM, Andreas Müller <
schnitzeltony@googlemail.com> wrote:

> On Thu, Jan 9, 2014 at 5:48 PM, Andreas Müller
> <schnitzeltony@googlemail.com> wrote:
> > libraries based on cmake and depending on qt5qml failed to configure
> with:
> >
> > |   The imported target "Qt5::DBus" references the file
> > |
> > |
>  "/home/a.mueller/tmp/oe-core-eglibc/sysroots/x86_64-linux/usr/bin/qt5/qdbusxml2xml"
> >
> > Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> > ---
> >  .../0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch
> | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> a/recipes-qt/qt5/qtbase/0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch
> b/recipes-qt/qt5/qtbase/0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch
> > index e3f1b72..ea3364e 100644
> > ---
> a/recipes-qt/qt5/qtbase/0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch
> > +++
> b/recipes-qt/qt5/qtbase/0014-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch
> > @@ -54,7 +54,7 @@ index 1d94715..617efa8 100644
> >       set(imported_location
> \"${_qt5DBus_install_prefix}/$${CMAKE_BIN_DIR}qdbuscpp2xml$$CMAKE_BIN_SUFFIX\")
> >   !!ELSE
> >  -    set(imported_location
> \"$${CMAKE_BIN_DIR}qdbuscpp2xml$$CMAKE_BIN_SUFFIX\")
> > -+    set(imported_location
> \"${OE_QMAKE_PATH_EXTERNAL_HOST_BINS}/qdbusxml2xml$$CMAKE_BIN_SUFFIX\")
> > ++    set(imported_location
> \"${OE_QMAKE_PATH_EXTERNAL_HOST_BINS}/qdbuscpp2xml$$CMAKE_BIN_SUFFIX\")
> >   !!ENDIF
> >       _qt5_DBus_check_file_exists(${imported_location})
> >
> > --
> > 1.8.3.1
> >
> This one is back in 5.2.1. Shall I send a patch?
>
> Andreas
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-02-10 17:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-09 16:48 [PATCH][meta-qt5][jansa/qt5-5.2.0]] qtbase: fix typo in PATH_EXTERNAL_HOST_BINS-patch Andreas Müller
2014-01-09 16:48 ` Andreas Müller
2014-01-09 23:29   ` Martin Jansa
2014-01-13 10:14     ` Martin Jansa
2014-02-10 11:47   ` Andreas Müller
2014-02-10 17:52     ` Martin Jansa

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.