From: Alan Jenkins <alan.christopher.jenkins@gmail.com>
To: Guido Trentalancia
<guido-D1bseh+SzQhuxeB9wqlrNw@public.gmane.org>,
selinux@tycho.nsa.gov
Subject: Re: [PATCH] libsemanage: remove lock files
Date: Mon, 24 Apr 2017 13:06:54 +0100 [thread overview]
Message-ID: <138cd2dc-f5c8-43ce-eb22-6f59c768623d@gmail.com> (raw)
In-Reply-To: <58517705.198270.1492699110308@pim.register.it>
On 20/04/17 15:38, Guido Trentalancia wrote:
> Remove semanage read and transaction lock files upon releasing
> them.
What prevents this sequence?
A release lock
B acquire lock
A unlink lock file
C create lock file
C acquire lock
> Signed-off-by: Guido Trentalancia <guido-D1bseh+SzQhuxeB9wqlrNw@public.gmane.org>
> ---
> src/semanage_store.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff -pruN a/src/semanage_store.c b/src/semanage_store.c
> --- a/src/semanage_store.c 2016-10-14 17:31:26.000000000 +0200
> +++ b/src/semanage_store.c 2017-04-03 09:32:24.093627962 +0200
> @@ -1904,6 +1904,7 @@ void semanage_release_trans_lock(semanag
> close(sh->u.direct.translock_file_fd);
> sh->u.direct.translock_file_fd = -1;
> }
> + unlink(semanage_files[SEMANAGE_TRANS_LOCK]);
> errno = errsv;
> }
>
> @@ -1917,6 +1918,7 @@ void semanage_release_active_lock(semana
> close(sh->u.direct.activelock_file_fd);
> sh->u.direct.activelock_file_fd = -1;
> }
> + unlink(semanage_files[SEMANAGE_READ_LOCK]);
> errno = errsv;
> }
next prev parent reply other threads:[~2017-04-24 12:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 14:38 [PATCH] libsemanage: remove lock files Guido Trentalancia
2017-04-20 15:44 ` Stephen Smalley
2017-04-20 15:45 ` Guido Trentalancia
2017-04-20 15:56 ` Stephen Smalley
2017-04-20 15:56 ` Guido Trentalancia
2017-04-20 16:08 ` Stephen Smalley
2017-04-20 16:09 ` Guido Trentalancia
2017-04-24 12:06 ` Alan Jenkins [this message]
2017-04-24 12:08 ` Alan Jenkins
2017-04-24 17:51 ` Guido Trentalancia
2017-04-24 18:38 ` Guido Trentalancia
2017-04-25 6:30 ` Russell Coker
2017-04-25 20:06 ` [PATCH v2] " Guido Trentalancia
2017-04-25 20:35 ` [PATCH v3] " Guido Trentalancia
2017-04-26 12:03 ` Jason Zaman
2017-04-26 12:56 ` Stephen Smalley
2017-04-26 18:13 ` Guido Trentalancia
2017-04-26 18:25 ` Stephen Smalley
2017-04-26 0:31 ` [PATCH v2] " Russell Coker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=138cd2dc-f5c8-43ce-eb22-6f59c768623d@gmail.com \
--to=alan.christopher.jenkins@gmail.com \
--cc=guido-D1bseh+SzQhuxeB9wqlrNw@public.gmane.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.