All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Smalley <sds@tycho.nsa.gov>
To: Guido Trentalancia <guido@trentalancia.net>, selinux@tycho.nsa.gov
Subject: Re: [PATCH] libsemanage: remove lock files
Date: Thu, 20 Apr 2017 11:56:36 -0400	[thread overview]
Message-ID: <1492703796.669.3.camel@tycho.nsa.gov> (raw)
In-Reply-To: <1967496203.202650.1492703110228@pim.register.it>

On Thu, 2017-04-20 at 17:45 +0200, Guido Trentalancia wrote:
> Hello Stephen.
> 
> Usually, when a lock file is released, the corresponding file is
> removed from the filesystem for keeping it clean and tidy.
> 
> I might be wrong... But why not ?
> 
> If nothing is handling the semanage store, then there shouldn't be a
> reason for keeping it locked. The presence of a lock file, usually
> means that the lock is active.

libsemanage doesn't use the lock files that way; it just uses them as
the object for flock() operations.  So the presence of the lock file
means nothing.  Removing it just means it will have to be re-created on
the next operation.  Not fundamentally opposed, but someone would need
to validate that it doesn't cause any issues.  It's been that way
forever.  Maybe the original Tresys authors of this code have an
opinion on it.

  reply	other threads:[~2017-04-20 15:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-20 14:38 [PATCH] libsemanage: remove lock files Guido Trentalancia
2017-04-20 15:44 ` Stephen Smalley
2017-04-20 15:45   ` Guido Trentalancia
2017-04-20 15:56     ` Stephen Smalley [this message]
2017-04-20 15:56       ` Guido Trentalancia
2017-04-20 16:08         ` Stephen Smalley
2017-04-20 16:09       ` Guido Trentalancia
2017-04-24 12:06 ` Alan Jenkins
2017-04-24 12:08   ` Alan Jenkins
2017-04-24 17:51     ` Guido Trentalancia
2017-04-24 18:38       ` Guido Trentalancia
2017-04-25  6:30         ` Russell Coker
2017-04-25 20:06           ` [PATCH v2] " Guido Trentalancia
2017-04-25 20:35             ` [PATCH v3] " Guido Trentalancia
2017-04-26 12:03               ` Jason Zaman
2017-04-26 12:56                 ` Stephen Smalley
2017-04-26 18:13                   ` Guido Trentalancia
2017-04-26 18:25                     ` Stephen Smalley
2017-04-26  0:31             ` [PATCH v2] " Russell Coker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492703796.669.3.camel@tycho.nsa.gov \
    --to=sds@tycho.nsa.gov \
    --cc=guido@trentalancia.net \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.