All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: multiplatform: remove reference to ARCH_MULTI_V4
@ 2013-07-13 20:09 ` Paul Bolle
  0 siblings, 0 replies; 6+ messages in thread
From: Paul Bolle @ 2013-07-13 20:09 UTC (permalink / raw)
  To: Russell King; +Cc: Arnd Bergmann, linux-arm-kernel, linux-kernel

The Kconfig symbol ARCH_MULTI_V4 was removed in commit 24e860fbfd
("ARM: multiplatform: always pick one CPU type"). Remove the last
reference to it too.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Untested.

1) Commit 24e860fbfd is silent on the reason to drop ARCH_MULTI_V4. And
the ARM section of the Kconfig files is rather complicated for people,
like me, that aren't familiar with the way the ARM universe is divided
in architectures, machines, platforms, etc. That makes it hard to say
whether ARCH_MULTI_V4 was dropped on purpose or by accident.

 arch/arm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 0ac9be6..0746bc8 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -912,7 +912,7 @@ config ARCH_MULTI_V6_V7
 	bool
 
 config ARCH_MULTI_CPU_AUTO
-	def_bool !(ARCH_MULTI_V4 || ARCH_MULTI_V4T || ARCH_MULTI_V6_V7)
+	def_bool !(ARCH_MULTI_V4T || ARCH_MULTI_V6_V7)
 	select ARCH_MULTI_V5
 
 endmenu
-- 
1.8.1.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] ARM: multiplatform: remove reference to ARCH_MULTI_V4
@ 2013-07-13 20:09 ` Paul Bolle
  0 siblings, 0 replies; 6+ messages in thread
From: Paul Bolle @ 2013-07-13 20:09 UTC (permalink / raw)
  To: linux-arm-kernel

The Kconfig symbol ARCH_MULTI_V4 was removed in commit 24e860fbfd
("ARM: multiplatform: always pick one CPU type"). Remove the last
reference to it too.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Untested.

1) Commit 24e860fbfd is silent on the reason to drop ARCH_MULTI_V4. And
the ARM section of the Kconfig files is rather complicated for people,
like me, that aren't familiar with the way the ARM universe is divided
in architectures, machines, platforms, etc. That makes it hard to say
whether ARCH_MULTI_V4 was dropped on purpose or by accident.

 arch/arm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 0ac9be6..0746bc8 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -912,7 +912,7 @@ config ARCH_MULTI_V6_V7
 	bool
 
 config ARCH_MULTI_CPU_AUTO
-	def_bool !(ARCH_MULTI_V4 || ARCH_MULTI_V4T || ARCH_MULTI_V6_V7)
+	def_bool !(ARCH_MULTI_V4T || ARCH_MULTI_V6_V7)
 	select ARCH_MULTI_V5
 
 endmenu
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: multiplatform: remove reference to ARCH_MULTI_V4
  2013-07-13 20:09 ` Paul Bolle
@ 2013-07-14  8:34   ` Arnd Bergmann
  -1 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2013-07-14  8:34 UTC (permalink / raw)
  To: Paul Bolle; +Cc: Russell King, linux-arm-kernel, linux-kernel

On Saturday 13 July 2013, Paul Bolle wrote:
> The Kconfig symbol ARCH_MULTI_V4 was removed in commit 24e860fbfd
> ("ARM: multiplatform: always pick one CPU type"). Remove the last
> reference to it too.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Untested.
> 
> 1) Commit 24e860fbfd is silent on the reason to drop ARCH_MULTI_V4. And
> the ARM section of the Kconfig files is rather complicated for people,
> like me, that aren't familiar with the way the ARM universe is divided
> in architectures, machines, platforms, etc. That makes it hard to say
> whether ARCH_MULTI_V4 was dropped on purpose or by accident.

It was dropped on purpose because it is unused in 3.11 but it will
be used again in 3.12, so I wouldn't bother with your patch.

Thanks anyway for looking into unused symbols, I think checking for
unused code like this is very useful in general.

	Arnd

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] ARM: multiplatform: remove reference to ARCH_MULTI_V4
@ 2013-07-14  8:34   ` Arnd Bergmann
  0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2013-07-14  8:34 UTC (permalink / raw)
  To: linux-arm-kernel

On Saturday 13 July 2013, Paul Bolle wrote:
> The Kconfig symbol ARCH_MULTI_V4 was removed in commit 24e860fbfd
> ("ARM: multiplatform: always pick one CPU type"). Remove the last
> reference to it too.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Untested.
> 
> 1) Commit 24e860fbfd is silent on the reason to drop ARCH_MULTI_V4. And
> the ARM section of the Kconfig files is rather complicated for people,
> like me, that aren't familiar with the way the ARM universe is divided
> in architectures, machines, platforms, etc. That makes it hard to say
> whether ARCH_MULTI_V4 was dropped on purpose or by accident.

It was dropped on purpose because it is unused in 3.11 but it will
be used again in 3.12, so I wouldn't bother with your patch.

Thanks anyway for looking into unused symbols, I think checking for
unused code like this is very useful in general.

	Arnd

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: multiplatform: remove reference to ARCH_MULTI_V4
  2013-07-14  8:34   ` Arnd Bergmann
@ 2014-02-10  1:20     ` Paul Bolle
  -1 siblings, 0 replies; 6+ messages in thread
From: Paul Bolle @ 2014-02-10  1:20 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Russell King, linux-arm-kernel, linux-kernel, Richard Weinberger

On Sun, 2013-07-14 at 10:34 +0200, Arnd Bergmann wrote:
> On Saturday 13 July 2013, Paul Bolle wrote:
> > The Kconfig symbol ARCH_MULTI_V4 was removed in commit 24e860fbfd
> > ("ARM: multiplatform: always pick one CPU type"). Remove the last
> > reference to it too.
> > 
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > ---
> > 0) Untested.
> > 
> > 1) Commit 24e860fbfd is silent on the reason to drop ARCH_MULTI_V4. And
> > the ARM section of the Kconfig files is rather complicated for people,
> > like me, that aren't familiar with the way the ARM universe is divided
> > in architectures, machines, platforms, etc. That makes it hard to say
> > whether ARCH_MULTI_V4 was dropped on purpose or by accident.
> 
> It was dropped on purpose because it is unused in 3.11 but it will
> be used again in 3.12, so I wouldn't bother with your patch.
> 
> Thanks anyway for looking into unused symbols, I think checking for
> unused code like this is very useful in general.

We're now at v3.14-rc1 and ARCH_MULTI_V4 is still unused. Are there still plans to
use it again?


Paul Bolle


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] ARM: multiplatform: remove reference to ARCH_MULTI_V4
@ 2014-02-10  1:20     ` Paul Bolle
  0 siblings, 0 replies; 6+ messages in thread
From: Paul Bolle @ 2014-02-10  1:20 UTC (permalink / raw)
  To: linux-arm-kernel

On Sun, 2013-07-14 at 10:34 +0200, Arnd Bergmann wrote:
> On Saturday 13 July 2013, Paul Bolle wrote:
> > The Kconfig symbol ARCH_MULTI_V4 was removed in commit 24e860fbfd
> > ("ARM: multiplatform: always pick one CPU type"). Remove the last
> > reference to it too.
> > 
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > ---
> > 0) Untested.
> > 
> > 1) Commit 24e860fbfd is silent on the reason to drop ARCH_MULTI_V4. And
> > the ARM section of the Kconfig files is rather complicated for people,
> > like me, that aren't familiar with the way the ARM universe is divided
> > in architectures, machines, platforms, etc. That makes it hard to say
> > whether ARCH_MULTI_V4 was dropped on purpose or by accident.
> 
> It was dropped on purpose because it is unused in 3.11 but it will
> be used again in 3.12, so I wouldn't bother with your patch.
> 
> Thanks anyway for looking into unused symbols, I think checking for
> unused code like this is very useful in general.

We're now at v3.14-rc1 and ARCH_MULTI_V4 is still unused. Are there still plans to
use it again?


Paul Bolle

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-02-10  1:20 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-13 20:09 [PATCH] ARM: multiplatform: remove reference to ARCH_MULTI_V4 Paul Bolle
2013-07-13 20:09 ` Paul Bolle
2013-07-14  8:34 ` Arnd Bergmann
2013-07-14  8:34   ` Arnd Bergmann
2014-02-10  1:20   ` Paul Bolle
2014-02-10  1:20     ` Paul Bolle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.