* [PATCH OSSTEST v2] cr-daily-branch: Make it possible to suppress the forcing of a baseline test
@ 2014-02-10 13:36 Ian Campbell
2014-02-10 18:14 ` Ian Jackson
0 siblings, 1 reply; 6+ messages in thread
From: Ian Campbell @ 2014-02-10 13:36 UTC (permalink / raw)
To: ian.jackson; +Cc: Ian Campbell, xen-devel
This is undesirable (most of the time) in a standalone environment, where you
are mostl ikely to be interested in the current version and not historical
comparissons.
Not sure there isn't a better way.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
v2: Remove spurious leading "i" from subject (damn you vi!)
Use safer test conditional/more obvious syntax
Remove unneeded call to check_tested as well.
---
cr-daily-branch | 26 ++++++++++++++------------
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/cr-daily-branch b/cr-daily-branch
index da6cf2f..c4a0872 100755
--- a/cr-daily-branch
+++ b/cr-daily-branch
@@ -85,18 +85,20 @@ check_tested () {
"$@"
}
-testedflight=`check_tested --revision-$tree="$OLD_REVISION"`
-
-if [ "x$testedflight" = x ]; then
- wantpush=false
- skipidentical=false
- force_baseline=true
- if [ "x$treeurl" != xnone: ]; then
- treearg=--tree-$tree=$treeurl
- fi
- tested_revision=`check_tested $treearg --print-revision=$tree`
- if [ "x$tested_revision" != x ]; then
- OLD_REVISION="$tested_revision"
+if [ "x$OSSTEST_NO_BASELINE" != xy ] ; then
+ testedflight=`check_tested --revision-$tree="$OLD_REVISION"`
+
+ if [ "x$testedflight" = x ]; then
+ wantpush=false
+ skipidentical=false
+ force_baseline=true
+ if [ "x$treeurl" != xnone: ]; then
+ treearg=--tree-$tree=$treeurl
+ fi
+ tested_revision=`check_tested $treearg --print-revision=$tree`
+ if [ "x$tested_revision" != x ]; then
+ OLD_REVISION="$tested_revision"
+ fi
fi
fi
--
1.8.5.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH OSSTEST v2] cr-daily-branch: Make it possible to suppress the forcing of a baseline test
2014-02-10 13:36 [PATCH OSSTEST v2] cr-daily-branch: Make it possible to suppress the forcing of a baseline test Ian Campbell
@ 2014-02-10 18:14 ` Ian Jackson
2014-02-11 9:35 ` Ian Campbell
0 siblings, 1 reply; 6+ messages in thread
From: Ian Jackson @ 2014-02-10 18:14 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel
Ian Campbell writes ("[PATCH OSSTEST v2] cr-daily-branch: Make it possible to suppress the forcing of a baseline test"):
> This is undesirable (most of the time) in a standalone environment, where you
> are mostl ikely to be interested in the current version and not historical
> comparissons.
>
> Not sure there isn't a better way.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
(But there's a lot of stuff in the queue so don't push it just yet...)
Ian.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH OSSTEST v2] cr-daily-branch: Make it possible to suppress the forcing of a baseline test
2014-02-10 18:14 ` Ian Jackson
@ 2014-02-11 9:35 ` Ian Campbell
2014-03-17 11:16 ` Ian Campbell
0 siblings, 1 reply; 6+ messages in thread
From: Ian Campbell @ 2014-02-11 9:35 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel
On Mon, 2014-02-10 at 18:14 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v2] cr-daily-branch: Make it possible to suppress the forcing of a baseline test"):
> > This is undesirable (most of the time) in a standalone environment, where you
> > are mostl ikely to be interested in the current version and not historical
> > comparissons.
> >
> > Not sure there isn't a better way.
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Thanks.
> (But there's a lot of stuff in the queue so don't push it just yet...)
Understood.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH OSSTEST v2] cr-daily-branch: Make it possible to suppress the forcing of a baseline test
2014-02-11 9:35 ` Ian Campbell
@ 2014-03-17 11:16 ` Ian Campbell
2014-03-17 11:30 ` Ian Jackson
0 siblings, 1 reply; 6+ messages in thread
From: Ian Campbell @ 2014-03-17 11:16 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel
On Tue, 2014-02-11 at 09:35 +0000, Ian Campbell wrote:
> On Mon, 2014-02-10 at 18:14 +0000, Ian Jackson wrote:
> > Ian Campbell writes ("[PATCH OSSTEST v2] cr-daily-branch: Make it possible to suppress the forcing of a baseline test"):
> > > This is undesirable (most of the time) in a standalone environment, where you
> > > are mostl ikely to be interested in the current version and not historical
> > > comparissons.
> > >
> > > Not sure there isn't a better way.
> >
> > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
> Thanks.
>
> > (But there's a lot of stuff in the queue so don't push it just yet...)
>
> Understood.
I think this wasn't in the wip.rebasing branch which you were keeping
and merged at a suitable point. Is it OK to go in now? Things seem
quiet.
Ian.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH OSSTEST v2] cr-daily-branch: Make it possible to suppress the forcing of a baseline test
2014-03-17 11:16 ` Ian Campbell
@ 2014-03-17 11:30 ` Ian Jackson
2014-03-17 11:57 ` Ian Campbell
0 siblings, 1 reply; 6+ messages in thread
From: Ian Jackson @ 2014-03-17 11:30 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel
Ian Campbell writes ("Re: [Xen-devel] [PATCH OSSTEST v2] cr-daily-branch: Make it possible to suppress the forcing of a baseline test"):
> I think this wasn't in the wip.rebasing branch which you were keeping
> and merged at a suitable point. Is it OK to go in now? Things seem
> quiet.
Yes, go ahead.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Ian.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH OSSTEST v2] cr-daily-branch: Make it possible to suppress the forcing of a baseline test
2014-03-17 11:30 ` Ian Jackson
@ 2014-03-17 11:57 ` Ian Campbell
0 siblings, 0 replies; 6+ messages in thread
From: Ian Campbell @ 2014-03-17 11:57 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel
On Mon, 2014-03-17 at 11:30 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH OSSTEST v2] cr-daily-branch: Make it possible to suppress the forcing of a baseline test"):
> > I think this wasn't in the wip.rebasing branch which you were keeping
> > and merged at a suitable point. Is it OK to go in now? Things seem
> > quiet.
>
> Yes, go ahead.
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Thanks. I have now pushed:
cf805fa Allow forcing the use of current osstest HEAD for branch=osstest
f836811 ts-hosts-allocate-Standalone: abort if the host to use has changed
fd271bd cs-adjust-flight: fix runvar-del
499bafb cr-daily-branch: Make it possible to suppress the forcing of a baseline test
to the pretest branch.
Ian.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-03-17 11:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-10 13:36 [PATCH OSSTEST v2] cr-daily-branch: Make it possible to suppress the forcing of a baseline test Ian Campbell
2014-02-10 18:14 ` Ian Jackson
2014-02-11 9:35 ` Ian Campbell
2014-03-17 11:16 ` Ian Campbell
2014-03-17 11:30 ` Ian Jackson
2014-03-17 11:57 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.