All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laura Abbott <lauraa@codeaurora.org>
To: Grant Likely <grant.likely@linaro.org>,
	Rob Herring <robh+dt@kernel.org>, Arnd Bergmann <arnd@arndb.de>
Cc: Laura Abbott <lauraa@codeaurora.org>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Kumar Gala <galak@codeaurora.org>,
	Kees Cook <keescook@chromium.org>
Subject: [RFC/PATCH 3/3] init: Move stack canary initialization after setup_arch
Date: Tue, 11 Feb 2014 17:33:25 -0800	[thread overview]
Message-ID: <1392168805-14200-4-git-send-email-lauraa@codeaurora.org> (raw)
In-Reply-To: <1392168805-14200-1-git-send-email-lauraa@codeaurora.org>

Stack canary intialization involves getting a random number.
Getting this random number may involve accessing caches or other
architectural specific features which are not available until
after the architecture is setup. Move the stack canary initialization
later to accomodate this.

Signed-off-by: Laura Abbott <lauraa@codeaurora.org>
---
 init/main.c |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/init/main.c b/init/main.c
index eb03090..63d0596 100644
--- a/init/main.c
+++ b/init/main.c
@@ -489,11 +489,6 @@ asmlinkage void __init start_kernel(void)
 	smp_setup_processor_id();
 	debug_objects_early_init();
 
-	/*
-	 * Set up the the initial canary ASAP:
-	 */
-	boot_init_stack_canary();
-
 	cgroup_init_early();
 
 	local_irq_disable();
@@ -507,6 +502,10 @@ asmlinkage void __init start_kernel(void)
 	page_address_init();
 	pr_notice("%s", linux_banner);
 	setup_arch(&command_line);
+	/*
+	 * Set up the the initial canary ASAP:
+	 */
+	boot_init_stack_canary();
 	mm_init_owner(&init_mm, &init_task);
 	mm_init_cpumask(&init_mm);
 	setup_command_line(command_line);
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation


WARNING: multiple messages have this Message-ID (diff)
From: lauraa@codeaurora.org (Laura Abbott)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC/PATCH 3/3] init: Move stack canary initialization after setup_arch
Date: Tue, 11 Feb 2014 17:33:25 -0800	[thread overview]
Message-ID: <1392168805-14200-4-git-send-email-lauraa@codeaurora.org> (raw)
In-Reply-To: <1392168805-14200-1-git-send-email-lauraa@codeaurora.org>

Stack canary intialization involves getting a random number.
Getting this random number may involve accessing caches or other
architectural specific features which are not available until
after the architecture is setup. Move the stack canary initialization
later to accomodate this.

Signed-off-by: Laura Abbott <lauraa@codeaurora.org>
---
 init/main.c |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/init/main.c b/init/main.c
index eb03090..63d0596 100644
--- a/init/main.c
+++ b/init/main.c
@@ -489,11 +489,6 @@ asmlinkage void __init start_kernel(void)
 	smp_setup_processor_id();
 	debug_objects_early_init();
 
-	/*
-	 * Set up the the initial canary ASAP:
-	 */
-	boot_init_stack_canary();
-
 	cgroup_init_early();
 
 	local_irq_disable();
@@ -507,6 +502,10 @@ asmlinkage void __init start_kernel(void)
 	page_address_init();
 	pr_notice("%s", linux_banner);
 	setup_arch(&command_line);
+	/*
+	 * Set up the the initial canary ASAP:
+	 */
+	boot_init_stack_canary();
 	mm_init_owner(&init_mm, &init_task);
 	mm_init_cpumask(&init_mm);
 	setup_command_line(command_line);
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

  parent reply	other threads:[~2014-02-12  1:34 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-12  1:33 [RFC/PATCH 0/3] Add devicetree scanning for randomness Laura Abbott
2014-02-12  1:33 ` Laura Abbott
     [not found] ` < 201402121251.06280.arnd@arndb.de>
2014-02-12  1:33 ` [RFC/PATCH 1/3] of: Add early randomness hooks Laura Abbott
2014-02-12  1:33   ` Laura Abbott
2014-02-12 16:47   ` Grant Likely
2014-02-12 16:47     ` Grant Likely
2014-02-12 16:47     ` Grant Likely
2014-02-12  1:33 ` [RFC/PATCH 2/3] arm: Add ARCH_WANT_OF_RANDOMNESS Laura Abbott
2014-02-12  1:33   ` Laura Abbott
2014-02-12 16:49   ` Grant Likely
2014-02-12 16:49     ` Grant Likely
2014-02-12 16:49     ` Grant Likely
2014-02-13  0:54     ` Laura Abbott
2014-02-13  0:54       ` Laura Abbott
2014-02-13  0:54       ` Laura Abbott
2014-02-12  1:33 ` Laura Abbott [this message]
2014-02-12  1:33   ` [RFC/PATCH 3/3] init: Move stack canary initialization after setup_arch Laura Abbott
2014-02-12 11:51 ` [RFC/PATCH 0/3] Add devicetree scanning for randomness Arnd Bergmann
2014-02-12 11:51   ` Arnd Bergmann
2014-02-12 11:51   ` Arnd Bergmann
2014-02-12 17:45   ` Jason Cooper
2014-02-12 17:45     ` Jason Cooper
2014-02-12 17:45     ` Jason Cooper
2014-02-12 18:13     ` Olof Johansson
2014-02-12 18:13       ` Olof Johansson
2014-02-12 18:13       ` Olof Johansson
2014-02-12 18:32       ` Jason Cooper
2014-02-12 18:32         ` Jason Cooper
2014-02-12 18:32         ` Jason Cooper
2014-02-12 18:17     ` Arnd Bergmann
2014-02-12 18:17       ` Arnd Bergmann
2014-02-12 18:17       ` Arnd Bergmann
2014-02-12 18:45       ` Jason Cooper
2014-02-12 18:45         ` Jason Cooper
2014-02-12 18:45         ` Jason Cooper
2014-02-12 19:12         ` Arnd Bergmann
2014-02-12 19:12           ` Arnd Bergmann
2014-02-12 19:43           ` Jason Cooper
2014-02-12 19:43             ` Jason Cooper
2014-02-12 23:55           ` Rob Herring
2014-02-12 23:55             ` Rob Herring
2014-02-12 23:55             ` Rob Herring
2014-02-12 18:20     ` Jason Gunthorpe
2014-02-12 18:20       ` Jason Gunthorpe
2014-02-12 18:20       ` Jason Gunthorpe
2014-02-12 18:51       ` Jason Cooper
2014-02-12 18:51         ` Jason Cooper
2014-02-12 18:51         ` Jason Cooper
2014-02-17 15:54       ` Grant Likely
2014-02-17 15:54         ` Grant Likely
2014-02-17 16:13         ` Arnd Bergmann
2014-02-17 16:13           ` Arnd Bergmann
2014-02-17 16:13           ` Arnd Bergmann
2014-02-17 18:23           ` Jason Cooper
2014-02-17 18:23             ` Jason Cooper
2014-02-17 21:07             ` Geert Uytterhoeven
2014-02-17 21:07               ` Geert Uytterhoeven
2014-02-17 21:07               ` Geert Uytterhoeven
2014-02-18 17:56               ` Jason Cooper
2014-02-18 17:56                 ` Jason Cooper
2014-02-18 17:56                 ` Jason Cooper
2014-02-18  9:39           ` Grant Likely
2014-02-18  9:39             ` Grant Likely
2014-02-18  9:39             ` Grant Likely
2014-02-18 18:19         ` Jason Gunthorpe
2014-02-18 18:19           ` Jason Gunthorpe
2014-02-12 21:35     ` Kees Cook
2014-02-12 21:35       ` Kees Cook
2014-02-12 21:35       ` Kees Cook
2014-02-13  0:06   ` Laura Abbott
2014-02-13  0:06     ` Laura Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392168805-14200-4-git-send-email-lauraa@codeaurora.org \
    --to=lauraa@codeaurora.org \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@linaro.org \
    --cc=keescook@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.