All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Benoît Canet" <benoit.canet@irqsave.net>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, "Benoît Canet" <benoit.canet@irqsave.net>,
	famz@redhat.com, "Benoit Canet" <benoit@irqsave.net>,
	jcody@redhat.com, armbru@redhat.com, mreitz@redhat.com,
	stefanha@redhat.com
Subject: [Qemu-devel] [FIX V2] block: Fix device snapshots broken by the block filter snapshots patchset.
Date: Thu, 13 Feb 2014 02:51:37 +0100	[thread overview]
Message-ID: <1392256297-21782-2-git-send-email-benoit.canet@irqsave.net> (raw)
In-Reply-To: <1392256297-21782-1-git-send-email-benoit.canet@irqsave.net>

Signed-off-by: Benoit Canet <benoit@irqsave.net>
---
 block.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/block.c b/block.c
index 70d7f35..d9553ba 100644
--- a/block.c
+++ b/block.c
@@ -5419,11 +5419,7 @@ bool bdrv_is_first_non_filter(BlockDriverState *candidate)
     QTAILQ_FOREACH(bs, &bdrv_states, device_list) {
         bool perm;
 
-        if (!bs->file) {
-            continue;
-        }
-
-        perm = bdrv_recurse_is_first_non_filter(bs->file, candidate);
+        perm = bdrv_recurse_is_first_non_filter(bs, candidate);
 
         /* candidate is the first non filter */
         if (perm) {
-- 
1.8.3.2

  reply	other threads:[~2014-02-13  1:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13  1:51 [Qemu-devel] [FIX V2] repair snapshots Benoît Canet
2014-02-13  1:51 ` Benoît Canet [this message]
2014-02-13  8:33   ` [Qemu-devel] [FIX V2] block: Fix device snapshots broken by the block filter snapshots patchset Kevin Wolf
2014-02-13  8:44     ` Benoît Canet
  -- strict thread matches above, loose matches on Subject: below --
2014-02-10 21:49 [Qemu-devel] [FIX V2] Fix broken external snapshots Benoît Canet
2014-02-10 21:49 ` [Qemu-devel] [FIX V2] block: Fix device snapshots broken by the block filter snapshots patchset Benoît Canet
2014-02-11  8:12   ` Fam Zheng
2014-02-12 19:49     ` Benoît Canet
2014-02-12 21:43       ` Benoît Canet
2014-02-13  1:42         ` Benoît Canet
2014-02-13  8:27       ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392256297-21782-2-git-send-email-benoit.canet@irqsave.net \
    --to=benoit.canet@irqsave.net \
    --cc=armbru@redhat.com \
    --cc=benoit@irqsave.net \
    --cc=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.