Re: [Qemu-devel] [FIX V2] block: Fix device snapshots broken by the block filter snapshots patchset.

From: Kevin Wolf <kwolf@redhat.com>
To: "Benoît Canet" <benoit.canet@irqsave.net>
Cc: famz@redhat.com, Benoit Canet <benoit@irqsave.net>,
	jcody@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org,
	stefanha@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [FIX V2] block: Fix device snapshots broken by the block filter snapshots patchset.
Date: Thu, 13 Feb 2014 09:33:52 +0100	[thread overview]
Message-ID: <20140213083352.GD32343@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1392256297-21782-2-git-send-email-benoit.canet@irqsave.net>

Am 13.02.2014 um 02:51 hat Benoît Canet geschrieben:
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> ---
>  block.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

Should be [PATCH v3] in the subject line.

> diff --git a/block.c b/block.c
> index 70d7f35..d9553ba 100644
> --- a/block.c
> +++ b/block.c
> @@ -5419,11 +5419,7 @@ bool bdrv_is_first_non_filter(BlockDriverState *candidate)
>      QTAILQ_FOREACH(bs, &bdrv_states, device_list) {
>          bool perm;
>  
> -        if (!bs->file) {
> -            continue;
> -        }
> -
> -        perm = bdrv_recurse_is_first_non_filter(bs->file, candidate);
> +        perm = bdrv_recurse_is_first_non_filter(bs, candidate);
>  
>          /* candidate is the first non filter */
>          if (perm) {

So we're back to my patch, just with different author? I thought you
said something was broken with it?

Kevin