* [PATCH Inte-gpu-tools 1/5] Assembler/bdw: Remove the unsupported cache agent for WRITE(...)
@ 2014-01-28 1:53 yakui.zhao
2014-02-13 3:10 ` Xiang, Haihao
0 siblings, 1 reply; 3+ messages in thread
From: yakui.zhao @ 2014-01-28 1:53 UTC (permalink / raw)
To: intel-gfx
From: Zhao Yakui <yakui.zhao@intel.com>
The Sampler/Constant cache is read-only. And it can't be used as
the target cache agent of WRITE message.
Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
---
assembler/gram.y | 4 ----
1 file changed, 4 deletions(-)
diff --git a/assembler/gram.y b/assembler/gram.y
index ad4cb29..589a0fe 100644
--- a/assembler/gram.y
+++ b/assembler/gram.y
@@ -1652,9 +1652,7 @@ msgtarget: NULL_TOKEN
{
if (IS_GENp(8)) {
if ($9 != 0 &&
- $9 != GEN6_SFID_DATAPORT_SAMPLER_CACHE &&
$9 != GEN6_SFID_DATAPORT_RENDER_CACHE &&
- $9 != GEN6_SFID_DATAPORT_CONSTANT_CACHE &&
$9 != GEN7_SFID_DATAPORT_DATA_CACHE &&
$9 != HSW_SFID_DATAPORT_DATA_CACHE1) {
error (&@9, "error: wrong cache type\n");
@@ -1715,9 +1713,7 @@ msgtarget: NULL_TOKEN
{
if (IS_GENp(8)) {
if ($9 != 0 &&
- $9 != GEN6_SFID_DATAPORT_SAMPLER_CACHE &&
$9 != GEN6_SFID_DATAPORT_RENDER_CACHE &&
- $9 != GEN6_SFID_DATAPORT_CONSTANT_CACHE &&
$9 != GEN7_SFID_DATAPORT_DATA_CACHE &&
$9 != HSW_SFID_DATAPORT_DATA_CACHE1) {
error (&@9, "error: wrong cache type\n");
--
1.8.2-rc2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH Inte-gpu-tools 1/5] Assembler/bdw: Remove the unsupported cache agent for WRITE(...)
2014-01-28 1:53 [PATCH Inte-gpu-tools 1/5] Assembler/bdw: Remove the unsupported cache agent for WRITE(...) yakui.zhao
@ 2014-02-13 3:10 ` Xiang, Haihao
2014-02-13 7:55 ` Damien Lespiau
0 siblings, 1 reply; 3+ messages in thread
From: Xiang, Haihao @ 2014-02-13 3:10 UTC (permalink / raw)
To: yakui.zhao; +Cc: intel-gfx
On Tue, 2014-01-28 at 09:53 +0800, yakui.zhao@intel.com wrote:
> From: Zhao Yakui <yakui.zhao@intel.com>
>
> The Sampler/Constant cache is read-only. And it can't be used as
> the target cache agent of WRITE message.
>
> Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
> ---
> assembler/gram.y | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/assembler/gram.y b/assembler/gram.y
> index ad4cb29..589a0fe 100644
> --- a/assembler/gram.y
> +++ b/assembler/gram.y
> @@ -1652,9 +1652,7 @@ msgtarget: NULL_TOKEN
> {
> if (IS_GENp(8)) {
> if ($9 != 0 &&
> - $9 != GEN6_SFID_DATAPORT_SAMPLER_CACHE &&
> $9 != GEN6_SFID_DATAPORT_RENDER_CACHE &&
> - $9 != GEN6_SFID_DATAPORT_CONSTANT_CACHE &&
> $9 != GEN7_SFID_DATAPORT_DATA_CACHE &&
> $9 != HSW_SFID_DATAPORT_DATA_CACHE1) {
> error (&@9, "error: wrong cache type\n");
> @@ -1715,9 +1713,7 @@ msgtarget: NULL_TOKEN
> {
> if (IS_GENp(8)) {
> if ($9 != 0 &&
> - $9 != GEN6_SFID_DATAPORT_SAMPLER_CACHE &&
> $9 != GEN6_SFID_DATAPORT_RENDER_CACHE &&
> - $9 != GEN6_SFID_DATAPORT_CONSTANT_CACHE &&
> $9 != GEN7_SFID_DATAPORT_DATA_CACHE &&
> $9 != HSW_SFID_DATAPORT_DATA_CACHE1) {
> error (&@9, "error: wrong cache type\n");
It is OK for me
Reviewed-by: Xiang, Haihao <haihao.xiang@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH Inte-gpu-tools 1/5] Assembler/bdw: Remove the unsupported cache agent for WRITE(...)
2014-02-13 3:10 ` Xiang, Haihao
@ 2014-02-13 7:55 ` Damien Lespiau
0 siblings, 0 replies; 3+ messages in thread
From: Damien Lespiau @ 2014-02-13 7:55 UTC (permalink / raw)
To: Xiang, Haihao; +Cc: intel-gfx
On Thu, Feb 13, 2014 at 11:10:00AM +0800, Xiang, Haihao wrote:
> On Tue, 2014-01-28 at 09:53 +0800, yakui.zhao@intel.com wrote:
> > From: Zhao Yakui <yakui.zhao@intel.com>
> >
> > The Sampler/Constant cache is read-only. And it can't be used as
> > the target cache agent of WRITE message.
> >
> > Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
>
> It is OK for me
>
> Reviewed-by: Xiang, Haihao <haihao.xiang@intel.com>
Pushed, thanks for the patch & review.
--
Damien
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-13 7:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-28 1:53 [PATCH Inte-gpu-tools 1/5] Assembler/bdw: Remove the unsupported cache agent for WRITE(...) yakui.zhao
2014-02-13 3:10 ` Xiang, Haihao
2014-02-13 7:55 ` Damien Lespiau
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.