All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gui Hecheng <guihc.fnst@cn.fujitsu.com>
To: linux-btrfs@vger.kernel.org
Cc: Gui Hecheng <guihc.fnst@cn.fujitsu.com>
Subject: [PATCH 2/4] btrfs-progs: remove a dead break before usage()
Date: Thu, 13 Feb 2014 11:16:36 +0800	[thread overview]
Message-ID: <1392261398-6197-2-git-send-email-guihc.fnst@cn.fujitsu.com> (raw)
In-Reply-To: <1392261398-6197-1-git-send-email-guihc.fnst@cn.fujitsu.com>

The usage() in help.c calls exit(1), so the break behind is nonsense
and should be removed.

Signed-off-by: Gui Hecheng <guihc.fnst@cn.fujitsu.com>
---
 cmds-property.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/cmds-property.c b/cmds-property.c
index 3d1f18c..df53f91 100644
--- a/cmds-property.c
+++ b/cmds-property.c
@@ -335,7 +335,6 @@ static void parse_args(int argc, char **argv,
 			break;
 		default:
 			usage(usage_str);
-			break;
 		}
 	}
 
-- 
1.8.1.4


  reply	other threads:[~2014-02-13  3:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13  3:16 [PATCH 1/4] btrfs-progs: use usage() to replace the warning msg on no-arg usage Gui Hecheng
2014-02-13  3:16 ` Gui Hecheng [this message]
2014-02-13  3:16 ` [PATCH 3/4] btrfs-progs: cleanup nonsense ret value assignment Gui Hecheng
2014-02-13  3:16 ` [PATCH 4/4] btrfs-progs: fix fsck leaks on error returns Gui Hecheng
2014-02-14 17:30   ` David Sterba
2014-02-17  1:16     ` Gui Hecheng
2014-02-14 17:57 ` [PATCH 1/4] btrfs-progs: use usage() to replace the warning msg on no-arg usage David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392261398-6197-2-git-send-email-guihc.fnst@cn.fujitsu.com \
    --to=guihc.fnst@cn.fujitsu.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.