From: David Sterba <dsterba@suse.cz>
To: Gui Hecheng <guihc.fnst@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/4] btrfs-progs: use usage() to replace the warning msg on no-arg usage
Date: Fri, 14 Feb 2014 18:57:37 +0100 [thread overview]
Message-ID: <20140214175737.GA16073@twin.jikos.cz> (raw)
In-Reply-To: <1392261398-6197-1-git-send-email-guihc.fnst@cn.fujitsu.com>
On Thu, Feb 13, 2014 at 11:16:35AM +0800, Gui Hecheng wrote:
> --- a/cmds-receive.c
> +++ b/cmds-receive.c
> @@ -951,10 +951,8 @@ int cmd_receive(int argc, char **argv)
> }
> }
>
> - if (optind + 1 != argc) {
> - fprintf(stderr, "ERROR: receive needs path to subvolume\n");
> - return 1;
> - }
> + if (optind + 1 != argc)
FYI, I've replaced this with check_argc_exact
> + usage(cmd_receive_usage);
>
> tomnt = argv[optind];
>
prev parent reply other threads:[~2014-02-14 17:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 3:16 [PATCH 1/4] btrfs-progs: use usage() to replace the warning msg on no-arg usage Gui Hecheng
2014-02-13 3:16 ` [PATCH 2/4] btrfs-progs: remove a dead break before usage() Gui Hecheng
2014-02-13 3:16 ` [PATCH 3/4] btrfs-progs: cleanup nonsense ret value assignment Gui Hecheng
2014-02-13 3:16 ` [PATCH 4/4] btrfs-progs: fix fsck leaks on error returns Gui Hecheng
2014-02-14 17:30 ` David Sterba
2014-02-17 1:16 ` Gui Hecheng
2014-02-14 17:57 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140214175737.GA16073@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=guihc.fnst@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.