From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "João Henrique Ferreira de Freitas" <joaohf@gmail.com>
Cc: dvhart@linux.intel.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] cml1.bbclass: Add fragmentconfig task to cml1
Date: Thu, 13 Feb 2014 11:33:58 +0000 [thread overview]
Message-ID: <1392291238.14081.10.camel@ted> (raw)
In-Reply-To: <1392250819-10123-3-git-send-email-joaohf@gmail.com>
On Wed, 2014-02-12 at 22:20 -0200, João Henrique Ferreira de Freitas
wrote:
> fragmentconfig() is a new task that makes a diff between the
> old and new config files and writes to the fragment.cfg result file.
> menuconfig() always copy the original config file, so the user
> doesn't need to copy it.
>
> Signed-off-by: João Henrique Ferreira de Freitas <joaohf@gmail.com>
> ---
> meta/classes/cml1.bbclass | 35 +++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
> index e292ecb..2053361 100644
> --- a/meta/classes/cml1.bbclass
> +++ b/meta/classes/cml1.bbclass
> @@ -16,8 +16,12 @@ HOST_LOADLIBES = "-lncurses"
> TERMINFO = "${STAGING_DATADIR_NATIVE}/terminfo"
>
> python do_menuconfig() {
> + import os
Don't import os please, this is always present so we don't need to.
> + import shutil
> +
> try:
> mtime = os.path.getmtime(".config")
> + shutil.copy(".config", ".config.orig")
> except OSError:
> mtime = 0
>
> @@ -38,3 +42,34 @@ do_menuconfig[depends] += "ncurses-native:do_populate_sysroot"
> do_menuconfig[nostamp] = "1"
> addtask menuconfig after do_configure
>
> +python do_fragmentconfig() {
> + import shutil
> + import subprocess
> +
> + workdir = d.getVar('WORKDIR', True)
> + fragment = workdir + '/fragment.cfg'
> + configorig = '.config.orig'
> + config = '.config'
> +
> + try:
> + md5newconfig = bb.utils.md5_file(configorig)
> + md5config = bb.utils.md5_file(config)
> + isdiff = md5newconfig != md5config
> + except OSError:
> + isdiff = 0
> +
> + if isdiff:
> + bb.note("Dumping config fragment into: '%s'." % fragment)
> + bb.note("new '%s' old '%s'" % (md5newconfig,md5config))
> +
> + statement = 'diff -Nurp ' + configorig + ' ' + config + '| sed -n "s/^\+//p" >' + fragment
> + subprocess.call(statement, shell=True)
> +
> + shutil.copy(configorig, config)
> + else:
> + if os.path.exists(fragment):
> + os.unlink(fragment)
> +}
> +
> +do_fragmentconfig[nostamp] = "1"
> +addtask fragmentconfig
next prev parent reply other threads:[~2014-02-13 11:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 0:20 [PATCH 0/2] Add task to create kernel config fragments João Henrique Ferreira de Freitas
2014-02-13 0:20 ` [PATCH 1/2] kernel-yocto: Add do_fragmentconfig task João Henrique Ferreira de Freitas
2014-02-13 0:20 ` [PATCH 2/2] cml1.bbclass: Add fragmentconfig task to cml1 João Henrique Ferreira de Freitas
2014-02-13 0:45 ` Darren Hart
2014-02-15 23:51 ` João Henrique Ferreira de Freitas
2014-02-13 11:33 ` Richard Purdie [this message]
2014-02-13 19:00 ` Darren Hart
2014-02-14 15:46 ` Richard Purdie
2014-02-14 16:15 ` Darren Hart
2014-02-14 16:44 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392291238.14081.10.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=dvhart@linux.intel.com \
--cc=joaohf@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.