From: Darren Hart <dvhart@linux.intel.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] cml1.bbclass: Add fragmentconfig task to cml1
Date: Fri, 14 Feb 2014 08:15:03 -0800 [thread overview]
Message-ID: <CF238059.6D5FB%dvhart@linux.intel.com> (raw)
In-Reply-To: <1392392807.14081.51.camel@ted>
On 2/14/14, 7:46, "Richard Purdie" <richard.purdie@linuxfoundation.org>
wrote:
>On Thu, 2014-02-13 at 11:00 -0800, Darren Hart wrote:
>> On 2/13/14, 3:33, "Richard Purdie" <richard.purdie@linuxfoundation.org>
>> wrote:
>>
>> >On Wed, 2014-02-12 at 22:20 -0200, João Henrique Ferreira de Freitas
>> >wrote:
>> >> fragmentconfig() is a new task that makes a diff between the
>> >> old and new config files and writes to the fragment.cfg result file.
>> >> menuconfig() always copy the original config file, so the user
>> >> doesn't need to copy it.
>> >>
>> >> Signed-off-by: João Henrique Ferreira de Freitas <joaohf@gmail.com>
>> >> ---
>> >> meta/classes/cml1.bbclass | 35 +++++++++++++++++++++++++++++++++++
>> >> 1 file changed, 35 insertions(+)
>> >>
>> >> diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
>> >> index e292ecb..2053361 100644
>> >> --- a/meta/classes/cml1.bbclass
>> >> +++ b/meta/classes/cml1.bbclass
>>
>> One more thought on this. As this is currently linux-yocto specific,
>>does
>> it belong in cml1.bbclass? It may make sense in busybox as well, so
>>maybe
>> this is the right place.
>>
>> RP, do you have a preference?
>
>Its starting to head in a direction we could probably use a
>kern-tools.bbclass to keep the code in a common place.
I wonder if something like kconfig.bbclass, rather than tying it to the
linux-yocto tooling (as it doesn't use any of the tooling to create the
fragment). Busybox could then use this, for example (not that it couldn't
include kern-tools.bbclass, it just seems a bit less natural to do so).
--
Darren Hart
Yocto Project - Linux Kernel
Intel Open Source Technology Center
next prev parent reply other threads:[~2014-02-14 16:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 0:20 [PATCH 0/2] Add task to create kernel config fragments João Henrique Ferreira de Freitas
2014-02-13 0:20 ` [PATCH 1/2] kernel-yocto: Add do_fragmentconfig task João Henrique Ferreira de Freitas
2014-02-13 0:20 ` [PATCH 2/2] cml1.bbclass: Add fragmentconfig task to cml1 João Henrique Ferreira de Freitas
2014-02-13 0:45 ` Darren Hart
2014-02-15 23:51 ` João Henrique Ferreira de Freitas
2014-02-13 11:33 ` Richard Purdie
2014-02-13 19:00 ` Darren Hart
2014-02-14 15:46 ` Richard Purdie
2014-02-14 16:15 ` Darren Hart [this message]
2014-02-14 16:44 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CF238059.6D5FB%dvhart@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.