* [RFC v3,2/3] controls.xml : add addtional Flash fault bits
@ 2014-02-14 9:45 Daniel Jeong
2014-02-17 9:41 ` Sakari Ailus
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Jeong @ 2014-02-14 9:45 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Rob Landley, Sakari Ailus, Andy Shevchenko
Cc: Hans Verkuil, Daniel Jeong, linux-media, linux-doc
Add addtional falult bits for FLASH
V4L2_FLASH_FAULT_UNDER_VOLTAGE : UVLO
V4L2_FLASH_FAULT_INPUT_VOLTAGE : input voltage is adjusted by IVFM
V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE : NTC Trip point is crossed.
Signed-off-by: Daniel Jeong <gshark.jeong@gmail.com>
---
Documentation/DocBook/media/v4l/controls.xml | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/Documentation/DocBook/media/v4l/controls.xml b/Documentation/DocBook/media/v4l/controls.xml
index a5a3188..8121f7e 100644
--- a/Documentation/DocBook/media/v4l/controls.xml
+++ b/Documentation/DocBook/media/v4l/controls.xml
@@ -4370,6 +4370,22 @@ interface and may change in the future.</para>
<entry>The flash controller has detected a short or open
circuit condition on the indicator LED.</entry>
</row>
+ <row>
+ <entry><constant>V4L2_FLASH_FAULT_UNDER_VOLTAGE</constant></entry>
+ <entry>Flash controller voltage to the flash LED
+ has been below the minimum limit specific to the flash
+ controller.</entry>
+ </row>
+ <row>
+ <entry><constant>V4L2_FLASH_FAULT_INPUT_VOLTAGE</constant></entry>
+ <entry>The flash controller has detected adjustment of input
+ voltage by Input Volage Flash Monitor(IVFM).</entry>
+ </row>
+ <row>
+ <entry><constant>V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE</constant></entry>
+ <entry>The flash controller has detected that TEMP input has
+ crossed NTC Trip Voltage.</entry>
+ </row>
</tbody>
</entrytbl>
</row>
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC v3,2/3] controls.xml : add addtional Flash fault bits
2014-02-14 9:45 [RFC v3,2/3] controls.xml : add addtional Flash fault bits Daniel Jeong
@ 2014-02-17 9:41 ` Sakari Ailus
2014-02-19 7:09 ` Daniel Jeong
0 siblings, 1 reply; 3+ messages in thread
From: Sakari Ailus @ 2014-02-17 9:41 UTC (permalink / raw)
To: Daniel Jeong, Mauro Carvalho Chehab, Rob Landley, Andy Shevchenko
Cc: Hans Verkuil, linux-media, linux-doc
Hi Daniel,
Thanks for the update.
Daniel Jeong wrote:
> Add addtional falult bits for FLASH
> V4L2_FLASH_FAULT_UNDER_VOLTAGE : UVLO
> V4L2_FLASH_FAULT_INPUT_VOLTAGE : input voltage is adjusted by IVFM
> V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE : NTC Trip point is crossed.
>
> Signed-off-by: Daniel Jeong <gshark.jeong@gmail.com>
> ---
> Documentation/DocBook/media/v4l/controls.xml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/DocBook/media/v4l/controls.xml b/Documentation/DocBook/media/v4l/controls.xml
> index a5a3188..8121f7e 100644
> --- a/Documentation/DocBook/media/v4l/controls.xml
> +++ b/Documentation/DocBook/media/v4l/controls.xml
> @@ -4370,6 +4370,22 @@ interface and may change in the future.</para>
> <entry>The flash controller has detected a short or open
> circuit condition on the indicator LED.</entry>
> </row>
> + <row>
> + <entry><constant>V4L2_FLASH_FAULT_UNDER_VOLTAGE</constant></entry>
> + <entry>Flash controller voltage to the flash LED
> + has been below the minimum limit specific to the flash
> + controller.</entry>
> + </row>
> + <row>
> + <entry><constant>V4L2_FLASH_FAULT_INPUT_VOLTAGE</constant></entry>
> + <entry>The flash controller has detected adjustment of input
> + voltage by Input Volage Flash Monitor(IVFM).</entry>
Volage -> Voltage; space before "(".
I still feel uncomfortable with the reference to the IVFM. That appears
clearely an implementation specific term.
You previously mentioned the flash current may be adjusted by the flash
controller. It should be mentioned here.
Is it possible to read the adjusted value from the chip?
> + </row>
> + <row>
> + <entry><constant>V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE</constant></entry>
> + <entry>The flash controller has detected that TEMP input has
> + crossed NTC Trip Voltage.</entry>
Even if the NTC resistor might be the actual implementation, I wouldn't
refer to it here. There could be a real temperature sensor, for instance.
> + </row>
> </tbody>
> </entrytbl>
> </row>
>
--
Kind regards,
Sakari Ailus
sakari.ailus@iki.fi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC v3,2/3] controls.xml : add addtional Flash fault bits
2014-02-17 9:41 ` Sakari Ailus
@ 2014-02-19 7:09 ` Daniel Jeong
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Jeong @ 2014-02-19 7:09 UTC (permalink / raw)
To: Sakari Ailus
Cc: Mauro Carvalho Chehab, Rob Landley, Andy Shevchenko,
Hans Verkuil, linux-media, linux-doc
Hi Sakari.
Thank you for you comments.
> Hi Daniel,
>
> Thanks for the update.
>
> Daniel Jeong wrote:
>> Add addtional falult bits for FLASH
>> V4L2_FLASH_FAULT_UNDER_VOLTAGE : UVLO
>> V4L2_FLASH_FAULT_INPUT_VOLTAGE : input voltage is adjusted by IVFM
>> V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE : NTC Trip point is crossed.
>>
>> Signed-off-by: Daniel Jeong <gshark.jeong@gmail.com>
>> ---
>> Documentation/DocBook/media/v4l/controls.xml | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>>
>> diff --git a/Documentation/DocBook/media/v4l/controls.xml b/Documentation/DocBook/media/v4l/controls.xml
>> index a5a3188..8121f7e 100644
>> --- a/Documentation/DocBook/media/v4l/controls.xml
>> +++ b/Documentation/DocBook/media/v4l/controls.xml
>> @@ -4370,6 +4370,22 @@ interface and may change in the future.</para>
>> <entry>The flash controller has detected a short or open
>> circuit condition on the indicator LED.</entry>
>> </row>
>> + <row>
>> + <entry><constant>V4L2_FLASH_FAULT_UNDER_VOLTAGE</constant></entry>
>> + <entry>Flash controller voltage to the flash LED
>> + has been below the minimum limit specific to the flash
>> + controller.</entry>
>> + </row>
>> + <row>
>> + <entry><constant>V4L2_FLASH_FAULT_INPUT_VOLTAGE</constant></entry>
>> + <entry>The flash controller has detected adjustment of input
>> + voltage by Input Volage Flash Monitor(IVFM).</entry>
> Volage -> Voltage; space before "(".
>
> I still feel uncomfortable with the reference to the IVFM. That appears
> clearely an implementation specific term.
>
> You previously mentioned the flash current may be adjusted by the flash
> controller. It should be mentioned here.
>
> Is it possible to read the adjusted value from the chip?
>
Unfornatley it is NOT possible.
Usually thresholds can be selected,for example 2.9V, 3.0V, 3.1V, and 3.2V.
Chip adjusts the current value if the input voltage cross the thresholds.
We just read this flault flag from chip. So we need this.
I will describe more next patch.
>> + </row>
>> + <row>
>> + <entry><constant>V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE</constant></entry>
>> + <entry>The flash controller has detected that TEMP input has
>> + crossed NTC Trip Voltage.</entry>
> Even if the NTC resistor might be the actual implementation, I wouldn't
> refer to it here. There could be a real temperature sensor, for instance.
I will fix it.
>> + </row>
>> </tbody>
>> </entrytbl>
>> </row>
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-19 7:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-14 9:45 [RFC v3,2/3] controls.xml : add addtional Flash fault bits Daniel Jeong
2014-02-17 9:41 ` Sakari Ailus
2014-02-19 7:09 ` Daniel Jeong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.