All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tar: fix a build error introduced by 1.27
@ 2014-02-14  3:30 Xudong.zhu
  2014-02-14  3:30 ` Xudong.zhu
  0 siblings, 1 reply; 4+ messages in thread
From: Xudong.zhu @ 2014-02-14  3:30 UTC (permalink / raw)
  To: openembedded-core

From: "Xudong.zhu" <xzhu@windriver.com>

--same-order option cannot be used with -c the latest
tar version 1.27.
To fix this, drop the -s from -ps if -c exists.

[YOCTO #5823]

Signed-off-by: Xudong.zhu <xzhu@windriver.com>
---
 meta/classes/libc-package.bbclass     |    8 ++++----
 meta/classes/package.bbclass          |    2 +-
 meta/classes/populate_sdk_deb.bbclass |    2 +-
 meta/classes/staging.bbclass          |    2 +-
 meta/lib/oe/path.py                   |    2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/meta/classes/libc-package.bbclass b/meta/classes/libc-package.bbclass
index 75e9b2a..1fc60d9 100644
--- a/meta/classes/libc-package.bbclass
+++ b/meta/classes/libc-package.bbclass
@@ -96,14 +96,14 @@ do_prep_locale_tree() {
 	treedir=${WORKDIR}/locale-tree
 	rm -rf $treedir
 	mkdir -p $treedir/${base_bindir} $treedir/${base_libdir} $treedir/${datadir} $treedir/${localedir}
-	tar -cf - -C ${LOCALETREESRC}${datadir} -ps i18n | tar -xf - -C $treedir/${datadir}
+	tar -cf - -C ${LOCALETREESRC}${datadir} -p i18n | tar -xf - -C $treedir/${datadir}
 	# unzip to avoid parsing errors
 	for i in $treedir/${datadir}/i18n/charmaps/*gz; do 
 		gunzip $i
 	done
-	tar -cf - -C ${LOCALETREESRC}${base_libdir} -ps . | tar -xf - -C $treedir/${base_libdir}
+	tar -cf - -C ${LOCALETREESRC}${base_libdir} -p . | tar -xf - -C $treedir/${base_libdir}
 	if [ -f ${STAGING_DIR_NATIVE}${prefix_native}/lib/libgcc_s.* ]; then
-		tar -cf - -C ${STAGING_DIR_NATIVE}/${prefix_native}/${base_libdir} -ps libgcc_s.* | tar -xf - -C $treedir/${base_libdir}
+		tar -cf - -C ${STAGING_DIR_NATIVE}/${prefix_native}/${base_libdir} -p libgcc_s.* | tar -xf - -C $treedir/${base_libdir}
 	fi
 	install -m 0755 ${LOCALETREESRC}${bindir}/localedef $treedir/${base_bindir}
 }
@@ -113,7 +113,7 @@ do_collect_bins_from_locale_tree() {
 
 	parent=$(dirname ${localedir})
 	mkdir -p ${PKGD}/$parent
-	tar -cf - -C $treedir/$parent -ps $(basename ${localedir}) | tar -xf - -C ${PKGD}$parent
+	tar -cf - -C $treedir/$parent -p $(basename ${localedir}) | tar -xf - -C ${PKGD}$parent
 }
 
 inherit qemu
diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index 59a27a2..847921d 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -437,7 +437,7 @@ python perform_packagecopy () {
     # files to operate on
     subprocess.call('rm -rf %s/*' % (dvar), shell=True)
     # Preserve sparse files and hard links
-    subprocess.call('tar -cf - -C %s -ps . | tar -xf - -C %s' % (dest, dvar), shell=True)
+    subprocess.call('tar -cf - -C %s -p . | tar -xf - -C %s' % (dest, dvar), shell=True)
 
     # replace RPATHs for the nativesdk binaries, to make them relocatable
     if bb.data.inherits_class('nativesdk', d) or bb.data.inherits_class('cross-canadian', d):
diff --git a/meta/classes/populate_sdk_deb.bbclass b/meta/classes/populate_sdk_deb.bbclass
index f2d0621..2d25149 100644
--- a/meta/classes/populate_sdk_deb.bbclass
+++ b/meta/classes/populate_sdk_deb.bbclass
@@ -13,7 +13,7 @@ populate_sdk_post_deb () {
 	local target_rootfs=$1
 
 	mkdir -p ${target_rootfs}/etc
-	tar -cf - -C ${STAGING_ETCDIR_NATIVE} -ps apt | tar -xf - -C ${target_rootfs}/etc
+	tar -cf - -C ${STAGING_ETCDIR_NATIVE} -p apt | tar -xf - -C ${target_rootfs}/etc
 }
 
 populate_sdk_deb () {
diff --git a/meta/classes/staging.bbclass b/meta/classes/staging.bbclass
index ee5a025..fb4eebd 100644
--- a/meta/classes/staging.bbclass
+++ b/meta/classes/staging.bbclass
@@ -17,7 +17,7 @@ sysroot_stage_dir() {
 	# However we always want to stage a $src itself, even if it's empty
 	mkdir -p "$dest"
 	if [ -d "$src" ]; then
-		tar -cf - -C "$src" -ps . | tar -xf - -C "$dest"
+		tar -cf - -C "$src" -p . | tar -xf - -C "$dest"
 	fi
 }
 
diff --git a/meta/lib/oe/path.py b/meta/lib/oe/path.py
index 1fdfa87..92a5910 100644
--- a/meta/lib/oe/path.py
+++ b/meta/lib/oe/path.py
@@ -82,7 +82,7 @@ def copytree(src, dst):
     # This way we also preserve hardlinks between files in the tree.
 
     bb.utils.mkdirhier(dst)
-    cmd = 'tar -cf - -C %s -ps . | tar -xf - -C %s' % (src, dst)
+    cmd = 'tar -cf - -C %s -p . | tar -xf - -C %s' % (src, dst)
     check_output(cmd, shell=True, stderr=subprocess.STDOUT)
 
 
-- 
1.7.9.5



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] tar: fix a build error introduced by 1.27
  2014-02-14  3:30 [PATCH] tar: fix a build error introduced by 1.27 Xudong.zhu
@ 2014-02-14  3:30 ` Xudong.zhu
  2014-02-14 12:29   ` Richard Purdie
  0 siblings, 1 reply; 4+ messages in thread
From: Xudong.zhu @ 2014-02-14  3:30 UTC (permalink / raw)
  To: openembedded-core

From: "Xudong.zhu" <xzhu@windriver.com>

--same-order option cannot be used with -c the latest
tar version 1.27.
To fix this, drop the -s from -ps if -c exists.

[YOCTO #5823]

Signed-off-by: Xudong.zhu <xzhu@windriver.com>
---
 meta/classes/libc-package.bbclass     |    8 ++++----
 meta/classes/package.bbclass          |    2 +-
 meta/classes/populate_sdk_deb.bbclass |    2 +-
 meta/classes/staging.bbclass          |    2 +-
 meta/lib/oe/path.py                   |    2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/meta/classes/libc-package.bbclass b/meta/classes/libc-package.bbclass
index 75e9b2a..1fc60d9 100644
--- a/meta/classes/libc-package.bbclass
+++ b/meta/classes/libc-package.bbclass
@@ -96,14 +96,14 @@ do_prep_locale_tree() {
 	treedir=${WORKDIR}/locale-tree
 	rm -rf $treedir
 	mkdir -p $treedir/${base_bindir} $treedir/${base_libdir} $treedir/${datadir} $treedir/${localedir}
-	tar -cf - -C ${LOCALETREESRC}${datadir} -ps i18n | tar -xf - -C $treedir/${datadir}
+	tar -cf - -C ${LOCALETREESRC}${datadir} -p i18n | tar -xf - -C $treedir/${datadir}
 	# unzip to avoid parsing errors
 	for i in $treedir/${datadir}/i18n/charmaps/*gz; do 
 		gunzip $i
 	done
-	tar -cf - -C ${LOCALETREESRC}${base_libdir} -ps . | tar -xf - -C $treedir/${base_libdir}
+	tar -cf - -C ${LOCALETREESRC}${base_libdir} -p . | tar -xf - -C $treedir/${base_libdir}
 	if [ -f ${STAGING_DIR_NATIVE}${prefix_native}/lib/libgcc_s.* ]; then
-		tar -cf - -C ${STAGING_DIR_NATIVE}/${prefix_native}/${base_libdir} -ps libgcc_s.* | tar -xf - -C $treedir/${base_libdir}
+		tar -cf - -C ${STAGING_DIR_NATIVE}/${prefix_native}/${base_libdir} -p libgcc_s.* | tar -xf - -C $treedir/${base_libdir}
 	fi
 	install -m 0755 ${LOCALETREESRC}${bindir}/localedef $treedir/${base_bindir}
 }
@@ -113,7 +113,7 @@ do_collect_bins_from_locale_tree() {
 
 	parent=$(dirname ${localedir})
 	mkdir -p ${PKGD}/$parent
-	tar -cf - -C $treedir/$parent -ps $(basename ${localedir}) | tar -xf - -C ${PKGD}$parent
+	tar -cf - -C $treedir/$parent -p $(basename ${localedir}) | tar -xf - -C ${PKGD}$parent
 }
 
 inherit qemu
diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index 59a27a2..847921d 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -437,7 +437,7 @@ python perform_packagecopy () {
     # files to operate on
     subprocess.call('rm -rf %s/*' % (dvar), shell=True)
     # Preserve sparse files and hard links
-    subprocess.call('tar -cf - -C %s -ps . | tar -xf - -C %s' % (dest, dvar), shell=True)
+    subprocess.call('tar -cf - -C %s -p . | tar -xf - -C %s' % (dest, dvar), shell=True)
 
     # replace RPATHs for the nativesdk binaries, to make them relocatable
     if bb.data.inherits_class('nativesdk', d) or bb.data.inherits_class('cross-canadian', d):
diff --git a/meta/classes/populate_sdk_deb.bbclass b/meta/classes/populate_sdk_deb.bbclass
index f2d0621..2d25149 100644
--- a/meta/classes/populate_sdk_deb.bbclass
+++ b/meta/classes/populate_sdk_deb.bbclass
@@ -13,7 +13,7 @@ populate_sdk_post_deb () {
 	local target_rootfs=$1
 
 	mkdir -p ${target_rootfs}/etc
-	tar -cf - -C ${STAGING_ETCDIR_NATIVE} -ps apt | tar -xf - -C ${target_rootfs}/etc
+	tar -cf - -C ${STAGING_ETCDIR_NATIVE} -p apt | tar -xf - -C ${target_rootfs}/etc
 }
 
 populate_sdk_deb () {
diff --git a/meta/classes/staging.bbclass b/meta/classes/staging.bbclass
index ee5a025..fb4eebd 100644
--- a/meta/classes/staging.bbclass
+++ b/meta/classes/staging.bbclass
@@ -17,7 +17,7 @@ sysroot_stage_dir() {
 	# However we always want to stage a $src itself, even if it's empty
 	mkdir -p "$dest"
 	if [ -d "$src" ]; then
-		tar -cf - -C "$src" -ps . | tar -xf - -C "$dest"
+		tar -cf - -C "$src" -p . | tar -xf - -C "$dest"
 	fi
 }
 
diff --git a/meta/lib/oe/path.py b/meta/lib/oe/path.py
index 1fdfa87..92a5910 100644
--- a/meta/lib/oe/path.py
+++ b/meta/lib/oe/path.py
@@ -82,7 +82,7 @@ def copytree(src, dst):
     # This way we also preserve hardlinks between files in the tree.
 
     bb.utils.mkdirhier(dst)
-    cmd = 'tar -cf - -C %s -ps . | tar -xf - -C %s' % (src, dst)
+    cmd = 'tar -cf - -C %s -p . | tar -xf - -C %s' % (src, dst)
     check_output(cmd, shell=True, stderr=subprocess.STDOUT)
 
 
-- 
1.7.9.5



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] tar: fix a build error introduced by 1.27
  2014-02-14  3:30 ` Xudong.zhu
@ 2014-02-14 12:29   ` Richard Purdie
  2014-02-17  2:44     ` Xudong.Zhu
  0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2014-02-14 12:29 UTC (permalink / raw)
  To: Xudong.zhu; +Cc: openembedded-core

On Fri, 2014-02-14 at 11:30 +0800, Xudong.zhu wrote:
> From: "Xudong.zhu" <xzhu@windriver.com>
> 
> --same-order option cannot be used with -c the latest
> tar version 1.27.
> To fix this, drop the -s from -ps if -c exists.
> 
> [YOCTO #5823]
> 
> Signed-off-by: Xudong.zhu <xzhu@windriver.com>
> ---
>  meta/classes/libc-package.bbclass     |    8 ++++----
>  meta/classes/package.bbclass          |    2 +-
>  meta/classes/populate_sdk_deb.bbclass |    2 +-
>  meta/classes/staging.bbclass          |    2 +-
>  meta/lib/oe/path.py                   |    2 +-
>  5 files changed, 8 insertions(+), 8 deletions(-)

This patch is not against master, this was fixed a while ago?

Cheers,

Richard



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] tar: fix a build error introduced by 1.27
  2014-02-14 12:29   ` Richard Purdie
@ 2014-02-17  2:44     ` Xudong.Zhu
  0 siblings, 0 replies; 4+ messages in thread
From: Xudong.Zhu @ 2014-02-17  2:44 UTC (permalink / raw)
  To: Richard Purdie; +Cc: openembedded-core

On 2014年02月14日 20:29, Richard Purdie wrote:
> On Fri, 2014-02-14 at 11:30 +0800, Xudong.zhu wrote:
>> From: "Xudong.zhu" <xzhu@windriver.com>
>>
>> --same-order option cannot be used with -c the latest
>> tar version 1.27.
>> To fix this, drop the -s from -ps if -c exists.
>>
>> [YOCTO #5823]
>>
>> Signed-off-by: Xudong.zhu <xzhu@windriver.com>
>> ---
>>   meta/classes/libc-package.bbclass     |    8 ++++----
>>   meta/classes/package.bbclass          |    2 +-
>>   meta/classes/populate_sdk_deb.bbclass |    2 +-
>>   meta/classes/staging.bbclass          |    2 +-
>>   meta/lib/oe/path.py                   |    2 +-
>>   5 files changed, 8 insertions(+), 8 deletions(-)
> This patch is not against master, this was fixed a while ago?
Sorry, I didn't notice that at the beginning, I just worked on my local 
branch, I will keep this in mind, thanks for your reminder, please 
ignore this patch.
> Cheers,
>
> Richard
>



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-02-17  2:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-14  3:30 [PATCH] tar: fix a build error introduced by 1.27 Xudong.zhu
2014-02-14  3:30 ` Xudong.zhu
2014-02-14 12:29   ` Richard Purdie
2014-02-17  2:44     ` Xudong.Zhu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.